Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 113354,
    "url": "http://patches.dpdk.org/api/patches/113354/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220623164245.561371-2-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220623164245.561371-2-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220623164245.561371-2-bruce.richardson@intel.com",
    "date": "2022-06-23T16:42:40",
    "name": "[RFC,1/6] test/telemetry_json: print success or failure per subtest",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "dcbe7952717caf1ffc053de28ff5358ad2187f91",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220623164245.561371-2-bruce.richardson@intel.com/mbox/",
    "series": [
        {
            "id": 23739,
            "url": "http://patches.dpdk.org/api/series/23739/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23739",
            "date": "2022-06-23T16:42:39",
            "name": "add json string escaping to telemetry",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/23739/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/113354/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/113354/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 25EA4A0093;\n\tThu, 23 Jun 2022 18:43:06 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 50202427F1;\n\tThu, 23 Jun 2022 18:43:01 +0200 (CEST)",
            "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 19D4E4067B\n for <dev@dpdk.org>; Thu, 23 Jun 2022 18:42:58 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Jun 2022 09:42:57 -0700",
            "from silpixa00401385.ir.intel.com (HELO\n silpixa00401385.ger.corp.intel.com.) ([10.237.223.125])\n by fmsmga005.fm.intel.com with ESMTP; 23 Jun 2022 09:42:56 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1656002579; x=1687538579;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=hJ0cmGTh9OsXMyI5rf+157EMkILCdCaBZf9lZ5yBuAM=;\n b=Ei6rl00SEPrrvASrYJFJH/E2Q6oQuocmyhnbAS+GduSZHfmHFZVNjO/k\n wIcOwH67Cz2dJPqyb9fBDE+OoE0r4iOFPH+/tkBg5KIumGY5s8w1G2lkx\n 6qcxNPWdLsFqkS8KOqelwxGD8wh48TJQPVwZruaawQ712Nyr3FZ5ZPSBX\n mD1WBYqC04VmexGMeqO27yrSTrW4WExK7E6smOQCM/+GRiOkINzZToMmu\n eznBpDEEfdFx1iVjKLHNi5WPIoxndvKPr2iwz8sIi1DvC6EhwgJ/DLCiP\n QWwnqChjDE+rVzO921emwUtzxZL0RzL5aVPjtO+XIh+UoXxXXq/OmLHHh Q==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6400,9594,10386\"; a=\"260589072\"",
            "E=Sophos;i=\"5.92,216,1650956400\"; d=\"scan'208\";a=\"260589072\"",
            "E=Sophos;i=\"5.92,216,1650956400\"; d=\"scan'208\";a=\"915267926\""
        ],
        "X-ExtLoop1": "1",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "ciara.power@intel.com, fengchengwen@huawei.com, mb@smartsharesystems.com,\n Bruce Richardson <bruce.richardson@intel.com>",
        "Subject": "[RFC PATCH 1/6] test/telemetry_json: print success or failure per\n subtest",
        "Date": "Thu, 23 Jun 2022 17:42:40 +0100",
        "Message-Id": "<20220623164245.561371-2-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.34.1",
        "In-Reply-To": "<20220623164245.561371-1-bruce.richardson@intel.com>",
        "References": "<20220623164245.561371-1-bruce.richardson@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "rather than just printing out success or failure at the end of the test\nonly, print out \"OK\" or \"ERROR\" for each individual test case within the\noverall test. As part of this, ensure each case returns 0 on success and\nany other value on failure.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test_telemetry_json.c | 33 ++++++++++++++++++++++++---------\n 1 file changed, 24 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/app/test/test_telemetry_json.c b/app/test/test_telemetry_json.c\nindex 790181d316..748b7cfe5a 100644\n--- a/app/test/test_telemetry_json.c\n+++ b/app/test/test_telemetry_json.c\n@@ -102,8 +102,10 @@ test_large_array_element(void)\n \n \tused = rte_tel_json_add_array_string(buf, sizeof(buf), used, str);\n \tprintf(\"%s: buf = '%s', expected = '%s'\\n\", __func__, buf, expected);\n+\tif (used != 0)\n+\t\treturn -1;\n \n-\treturn strlen(buf) != 0;\n+\treturn strncmp(expected, buf, sizeof(buf));\n }\n \n static int\n@@ -117,20 +119,33 @@ test_large_obj_element(void)\n \n \tused = rte_tel_json_add_obj_u64(buf, sizeof(buf), used, str, 0);\n \tprintf(\"%s: buf = '%s', expected = '%s'\\n\", __func__, buf, expected);\n+\tif (used != 0)\n+\t\treturn -1;\n \n-\treturn strlen(buf) != 0;\n+\treturn strncmp(expected, buf, sizeof(buf));\n }\n \n+typedef int (*test_fn)(void);\n+\n static int\n test_telemetry_json(void)\n {\n-\tif (test_basic_array() < 0 ||\n-\t\t\ttest_basic_obj() < 0 ||\n-\t\t\ttest_overflow_array() < 0 ||\n-\t\t\ttest_overflow_obj() < 0 ||\n-\t\t\ttest_large_array_element() < 0 ||\n-\t\t\ttest_large_obj_element() < 0)\n-\t\treturn -1;\n+\tunsigned int i;\n+\ttest_fn fns[] = {\n+\t\t\ttest_basic_array,\n+\t\t\ttest_basic_obj,\n+\t\t\ttest_overflow_array,\n+\t\t\ttest_overflow_obj,\n+\t\t\ttest_large_array_element,\n+\t\t\ttest_large_obj_element,\n+\t};\n+\tfor (i = 0; i < RTE_DIM(fns); i++)\n+\t\tif (fns[i]() == 0)\n+\t\t\tprintf(\"OK\\n\");\n+\t\telse {\n+\t\t\tprintf(\"ERROR\\n\");\n+\t\t\treturn -1;\n+\t\t}\n \treturn 0;\n }\n \n",
    "prefixes": [
        "RFC",
        "1/6"
    ]
}