Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112984/?format=api
{ "id": 112984, "url": "http://patches.dpdk.org/api/patches/112984/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220617093444.2004000-11-jin.liu@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220617093444.2004000-11-jin.liu@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220617093444.2004000-11-jin.liu@corigine.com", "date": "2022-06-17T09:34:41", "name": "[v3,10/13] net/nfp: add queue stop and close helper function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "de1d821b566d0361e6da754c7249205f3e8525ad", "submitter": { "id": 2670, "url": "http://patches.dpdk.org/api/people/2670/?format=api", "name": "Jin Liu", "email": "jin.liu@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220617093444.2004000-11-jin.liu@corigine.com/mbox/", "series": [ { "id": 23606, "url": "http://patches.dpdk.org/api/series/23606/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23606", "date": "2022-06-17T09:34:31", "name": "Add support of NFP3800 chip and firmware with NFDk", "version": 3, "mbox": "http://patches.dpdk.org/series/23606/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/112984/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/112984/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0A088A0093;\n\tFri, 17 Jun 2022 11:36:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A782442B88;\n\tFri, 17 Jun 2022 11:35:39 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2103.outbound.protection.outlook.com [40.107.94.103])\n by mails.dpdk.org (Postfix) with ESMTP id D891C42B7B\n for <dev@dpdk.org>; Fri, 17 Jun 2022 11:35:36 +0200 (CEST)", "from DM6PR13MB3004.namprd13.prod.outlook.com (2603:10b6:5:191::21)\n by CO3PR13MB5671.namprd13.prod.outlook.com (2603:10b6:303:17a::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.9; Fri, 17 Jun\n 2022 09:35:35 +0000", "from DM6PR13MB3004.namprd13.prod.outlook.com\n ([fe80::ac31:a36a:cc15:cd35]) by DM6PR13MB3004.namprd13.prod.outlook.com\n ([fe80::ac31:a36a:cc15:cd35%7]) with mapi id 15.20.5373.009; Fri, 17 Jun 2022\n 09:35:35 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=HrBRQ+04BUS6BrFV5aJe+EPWl0NtQ7xVCMZ9qUtjbR+8liCe6/GZ4Frbx6t2g4DPfTlfmF1tVkAA3CCEiK6n3uk2l6Zjt89mBTyrrE/PVgQ8f2s4g9IaQaK/jdceJsksYuhNj2yhXaPasLbJCqpN4qdt2srM4babYAsgdVLKcjUB+2LTuFDzItFes8OYbqKNCXieThY/ll3FBVP2qEXZpryonG1U/GQ9B//cU6dB1S2iVeSTKteo5G82OWki5PWImuEQw/dhVgqmVuILAXXxDKHRyRxPixRcLUTLGYQGlnT6HX5V6WQfjXRi2wP/FihewSw/CRQmNe9Pe4ED48hoCg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=jFZzr2930Vv2c4QQaVDS7/EwLKkvku48EhdYPEyXKfo=;\n b=Ro4UdGJgm9DzoIBWrAClZae66J7CZVhM0XFLvWispHlQ1nSDWFn53ow90fZ/whgXZPtnP7jDGgbO3P3aTUB7TT5wiZoa3MtulFYYvoqD2ro76V6Zdg55nTnZClgMX6hT1eTbDnOyyg2LbtpfgqKDaoVIVwtVMs2N+ru2WE5UXkRF0xqOWJj2zIsiZZIdebW4f0O296r0V0zwSmzCjoKYqIkV3YlRlV3PM+qTr4l+ctWKupj9/Dt0oe6SPkMuaPsc5RiisbEUomj9/C6o8+OHyilXlFv+JBv7O+h1muasm16K1wlblkTqVBkbJGE95Q4u0WNPyydRMY5/tBlFOakuRA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jFZzr2930Vv2c4QQaVDS7/EwLKkvku48EhdYPEyXKfo=;\n b=YpdeWNGsDs/o4u3QIzC0jxZJr6VjD7GKgWGfz0fUgUzmxT6F+pzV/xw73DpyE8iecTDhSTQqS2jvS9tZ23pHMynEN2vaW0OiLuvGA5MEt4TeCaJSTUASM5VL2WXrF3+I4NPVjK3uNJWqYwts702eQiG+aYLCMGfpi4iDSciDKjs=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Jin Liu <jin.liu@corigine.com>", "To": "dev@dpdk.org", "Cc": "niklas.soderlund@corigine.com, Jin Liu <jin.liu@corigine.com>,\n Diana Wang <na.wang@corigine.com>, Peng Zhang <peng.zhang@corigine.com>,\n Chaoyong He <chaoyong.he@corigine.com>", "Subject": "[PATCH v3 10/13] net/nfp: add queue stop and close helper function", "Date": "Fri, 17 Jun 2022 11:34:41 +0200", "Message-Id": "<20220617093444.2004000-11-jin.liu@corigine.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20220617093444.2004000-1-jin.liu@corigine.com>", "References": "<20220616023939.1798769-1-jin.liu@corigine.com>\n <20220617093444.2004000-1-jin.liu@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "LO4P123CA0192.GBRP123.PROD.OUTLOOK.COM\n (2603:10a6:600:1a4::17) To DM6PR13MB3004.namprd13.prod.outlook.com\n (2603:10b6:5:191::21)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "151cdce1-3a66-49d3-c0b6-08da5044bb08", "X-MS-TrafficTypeDiagnostic": "CO3PR13MB5671:EE_", "X-Microsoft-Antispam-PRVS": "\n <CO3PR13MB5671CE408D0A37C3D2F68A0194AF9@CO3PR13MB5671.namprd13.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n FIbfkBcOCOeuPV8WiHWjjdp3G5p7DCyGRJaQqAie0yuYL4uRsUHWWIlTnDPqyWnYJP/1zuIHvlJxIPnbPGG8YRVDUrcpObvRrZbsPoiapnJ5nD5dafOgC8Z3VuiVnhJPRzAFVD78YOll5z0chtupS3YTpsjY1a9Xb8/9QZ+77G1T5vcdc3nDawlMKLrG/k/dkpn08HBkMuI1a3dDipI9WDZ00KH78uMCr2vYpyUx1mSgT1miITCkRxjOHCFvCZ8DWgKTCyYDw4E2lGiSHfuA+y9JKrafq5YK7j3+/Njf+5xVDE7+198MvxR1WyPig/Jj+R5KCfOY+oxqC4rgOvkJkKXYt8oSsLQDa+ZtQxG0jFpji/svu1oi1UbCcnrsa7Ymtr7l3G+KVKRaHqHPPBhd5pOwdq1oRXpU7KcwgSm1LztbpRlGGpqjT0J99/DhmpJ5pnNLPApyXAz+TKODZxjx2Mz9kCVU1NTfmv6Dc4xoxenpxPRlAiQpRxI2n2dRXxB5CODYIjSF6Zd+rhbVZ5j+bY4PVS5amUhT+Cw2fkSnu44X0jCKTtdPIva+5sfSo/wzFftHl6UBvGyHGYgt3S2NqBU/Xq5QAZ5ymiEfylVlN1HgKSFqVV9PKEGLn61/eNVpSd4iwnNOr7t7oNlLGgJPjyDo8h0PE1LFHgAAJxXu5ge4tJkOAnmYMAdINb6C/cSjie/JecLUtXGz9o/wuNXIYBJ1cMNEPh9wCtP1AdZaJcwM9IoBTOf61FW30VDnTGIA", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DM6PR13MB3004.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230016)(4636009)(346002)(136003)(366004)(396003)(39840400004)(66476007)(66556008)(26005)(8676002)(66574015)(6666004)(107886003)(66946007)(6506007)(6916009)(44832011)(2906002)(316002)(4326008)(38350700002)(186003)(508600001)(54906003)(5660300002)(6486002)(6512007)(1076003)(8936002)(2616005)(36756003)(52116002)(83380400001)(86362001)(38100700002)(41300700001);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?ynf/kK3/C5WyxX94Uxu8/6bKXFx7?=\n\t=?utf-8?q?jAh9vnzbKbqNEewDMO52tAb+tA7HhRsCwbcXFKZb2aBI+NfGDnHLIgbLbZzBQWxMn?=\n\t=?utf-8?q?np0V5h93F4uAEIJjIF2fLegSPL4LqghXs48p1nZ64nKc1VQkxl0RprJNE1j25oUod?=\n\t=?utf-8?q?E8wrwHIbBpzKVQnZDGq2HO9DjOoOrAWYy6ADUwmFVMCc2+nOz4PNbhJJEsNZAJGHQ?=\n\t=?utf-8?q?yInffoKvn0W4rPJhcWYVj5FS4qm2R6n50j27ay5L6P/bB8QsRCmy5FR2rimxv2/V1?=\n\t=?utf-8?q?MUKIe3lKbvY8cvxYW3rKEZv/7kqk80+NvdGQN0Cn3opRAyUSxTHUHtbMyt58qa34v?=\n\t=?utf-8?q?+zzIKLv8v/A7playJQ9ou1S6icI0Aq5gwQKoqyecFTP3xSoxwbZJr2Sd6Dn9JXh3p?=\n\t=?utf-8?q?lsO5zZ1pGTilgMTgvQdpgZzyD9s8WZYFO2NvAnEwFDRKUsVfmEXFcj2GDRjzBf31F?=\n\t=?utf-8?q?k8dfWOcKjqW3LxvJ5/0JY/2nHiwFhDRlTsrmDi5nT7A0qbgITzbJi86chJhRD3JBC?=\n\t=?utf-8?q?/xJvLcSugY/t1fBUFVAcYzuVsVBn3rzP2LMX0vBIxy1TcexrE+FcP2j23qU/EBfQ4?=\n\t=?utf-8?q?RytiHr00fv50zC+tQTwFVseGicf112zMNk4UDAxC7S2oTmBd2oP0+HgSduPB3UiP8?=\n\t=?utf-8?q?9Jyr9Nu4EZYi8fOkC2XxCkiQzy48/FVufpW72eiouPZMWJ6ltLkI78cS7Od5hfo/9?=\n\t=?utf-8?q?WIgj4/xYPFIi1kYMJYE13+pczKwZe/3MgATqPYyBhKzvnIINpe5BRLVGzx6jl7PsG?=\n\t=?utf-8?q?B/+5/lB4PD96U5uVOCFeN0ZxfqWjVFaIgqxhDzqk0mFjdzuNEHfzs809UBzK4a7ha?=\n\t=?utf-8?q?tr9dHYJq2dFz8zlkhfMsNjY2z3GhTxLxL5iyVWId8M5FkwiTja47T3/S0mQSdl8yz?=\n\t=?utf-8?q?PTyu6opw0nv2N67grZ7LSNV8jMHpkar3UPXZ1BUjkrGXpDCpdw1mV4ukw+kRw7afO?=\n\t=?utf-8?q?5OGzK04XD70Q3zNmmrkkz1DXsKFBemOW7nB9G8R49JlYHv0a3a/H3rxEb9xFPAQg9?=\n\t=?utf-8?q?TAB7GS0eAHjaEhA73DPU0LfN1//SqHhusB1lEKfw3hF6iq9//zLqvrlfXkP5xzKNE?=\n\t=?utf-8?q?l8uFt6biepNDciSYETVypIlC7n1Q1IxgHTlnDztjtcAlNOK0ENWGvnQe5p2l33Ypk?=\n\t=?utf-8?q?Y9mnVg6swJ46yhgG1/mSrqtEO7ZeZsjetQ+610tiHSRYnSuFOSMFRcjksisBg0hZZ?=\n\t=?utf-8?q?OjbV4O1wVQMuZ/Bu4CT6TByqMd7/3Cx8PEsTAJ65Pc8on6/DYo8E9LxJdCXorJp7h?=\n\t=?utf-8?q?jKBaAx7JuhWnEFJDjFc829CrBqEdbTTlhpn3BCagMSVrOKGFWOBevNx45v7+jZSuO?=\n\t=?utf-8?q?icAEbZ3VGFkHVOJfTtHZbkqWEyjWB0YRqbHmG8OKrduuflnauREoJ2OXtYSQa+jRo?=\n\t=?utf-8?q?VeIrbGYRrFt2Edc811ddrVmbwhju+xZSz2Mn+evGUmgWO/N95bZkgIGrH6nu3mgvs?=\n\t=?utf-8?q?M4gA/BqKnxIOjWUV+6hAd4pCCwaBp7akbLYxsIccabYxiOfx2R03FUqKw2IKDJ3kX?=\n\t=?utf-8?q?Q1z1SaxiU3m2gxl1I1/g37AGF+AnOCl6vpfF+CGiFsjY7rrNuKSpGIwwlVz6Mi7Wn?=\n\t=?utf-8?q?T0cGqj8f+K7an+NNqsLbIrNrf4QE/JBPKzrIkApxzCbsGDMm0PrIYFvlrObRypGyl?=\n\t=?utf-8?q?5EWFV7ZrqsQpr4CpIKvLaDEWZrUQI1AA=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 151cdce1-3a66-49d3-c0b6-08da5044bb08", "X-MS-Exchange-CrossTenant-AuthSource": "DM6PR13MB3004.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Jun 2022 09:35:35.4913 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n vnlAdgNN+QWlNMolStJTmHmHYUxRqhJglxCzYU3sTlJzaAsezbeWyaBin+l/0frhf+RCSTNV2xJ4bj0rtdnoZg==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CO3PR13MB5671", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This commit does not introduce new features, just integrate some common\nlogic into helper functions to reduce the same logic and increase code\nreuse, include queue stop and queue close logic, will be used when NFP\nnet stop and close.\n\nqueue stop: reset queue\nqueue close: reset and release queue\n\nModify NFP net stop and close function, use helper function to stop\nand close queue instead of before logic.\n\nSigned-off-by: Jin Liu <jin.liu@corigine.com>\nSigned-off-by: Diana Wang <na.wang@corigine.com>\nSigned-off-by: Peng Zhang <peng.zhang@corigine.com>\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nSigned-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfp_common.c | 50 +++++++++++++++++++++++++++++++++\n drivers/net/nfp/nfp_common.h | 4 +++\n drivers/net/nfp/nfp_ethdev.c | 27 +++---------------\n drivers/net/nfp/nfp_ethdev_vf.c | 29 +++----------------\n 4 files changed, 62 insertions(+), 48 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c\nindex 9903a1bd5a..755c5ec4d9 100644\n--- a/drivers/net/nfp/nfp_common.c\n+++ b/drivers/net/nfp/nfp_common.c\n@@ -1320,6 +1320,56 @@ nfp_net_rss_config_default(struct rte_eth_dev *dev)\n \treturn ret;\n }\n \n+void\n+nfp_net_stop_rx_queue(struct rte_eth_dev *dev)\n+{\n+\tuint16_t i;\n+\tstruct nfp_net_rxq *this_rx_q;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tthis_rx_q = (struct nfp_net_rxq *)dev->data->rx_queues[i];\n+\t\tnfp_net_reset_rx_queue(this_rx_q);\n+\t}\n+}\n+\n+void\n+nfp_net_close_rx_queue(struct rte_eth_dev *dev)\n+{\n+\tuint16_t i;\n+\tstruct nfp_net_rxq *this_rx_q;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tthis_rx_q = (struct nfp_net_rxq *)dev->data->rx_queues[i];\n+\t\tnfp_net_reset_rx_queue(this_rx_q);\n+\t\tnfp_net_rx_queue_release(dev, i);\n+\t}\n+}\n+\n+void\n+nfp_net_stop_tx_queue(struct rte_eth_dev *dev)\n+{\n+\tuint16_t i;\n+\tstruct nfp_net_txq *this_tx_q;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tthis_tx_q = (struct nfp_net_txq *)dev->data->tx_queues[i];\n+\t\tnfp_net_reset_tx_queue(this_tx_q);\n+\t}\n+}\n+\n+void\n+nfp_net_close_tx_queue(struct rte_eth_dev *dev)\n+{\n+\tuint16_t i;\n+\tstruct nfp_net_txq *this_tx_q;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tthis_tx_q = (struct nfp_net_txq *)dev->data->tx_queues[i];\n+\t\tnfp_net_reset_tx_queue(this_tx_q);\n+\t\tnfp_net_tx_queue_release(dev, i);\n+\t}\n+}\n+\n RTE_LOG_REGISTER_SUFFIX(nfp_logtype_init, init, NOTICE);\n RTE_LOG_REGISTER_SUFFIX(nfp_logtype_driver, driver, NOTICE);\n /*\ndiff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h\nindex 19e96414e3..6d917e4b4a 100644\n--- a/drivers/net/nfp/nfp_common.h\n+++ b/drivers/net/nfp/nfp_common.h\n@@ -413,6 +413,10 @@ int nfp_net_rss_hash_update(struct rte_eth_dev *dev,\n int nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_rss_conf *rss_conf);\n int nfp_net_rss_config_default(struct rte_eth_dev *dev);\n+void nfp_net_stop_rx_queue(struct rte_eth_dev *dev);\n+void nfp_net_close_rx_queue(struct rte_eth_dev *dev);\n+void nfp_net_stop_tx_queue(struct rte_eth_dev *dev);\n+void nfp_net_close_tx_queue(struct rte_eth_dev *dev);\n \n #define NFP_NET_DEV_PRIVATE_TO_HW(adapter)\\\n \t(&((struct nfp_net_adapter *)adapter)->hw)\ndiff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex 0d650efd27..e8a8368d0f 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -181,10 +181,7 @@ nfp_net_start(struct rte_eth_dev *dev)\n static int\n nfp_net_stop(struct rte_eth_dev *dev)\n {\n-\tint i;\n \tstruct nfp_net_hw *hw;\n-\tstruct nfp_net_txq *this_tx_q;\n-\tstruct nfp_net_rxq *this_rx_q;\n \n \tPMD_INIT_LOG(DEBUG, \"Stop\");\n \n@@ -193,15 +190,9 @@ nfp_net_stop(struct rte_eth_dev *dev)\n \tnfp_net_disable_queues(dev);\n \n \t/* Clear queues */\n-\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n-\t\tthis_tx_q = (struct nfp_net_txq *)dev->data->tx_queues[i];\n-\t\tnfp_net_reset_tx_queue(this_tx_q);\n-\t}\n+\tnfp_net_stop_tx_queue(dev);\n \n-\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n-\t\tthis_rx_q = (struct nfp_net_rxq *)dev->data->rx_queues[i];\n-\t\tnfp_net_reset_rx_queue(this_rx_q);\n-\t}\n+\tnfp_net_stop_rx_queue(dev);\n \n \tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n \t\t/* Configure the physical port down */\n@@ -256,8 +247,6 @@ nfp_net_close(struct rte_eth_dev *dev)\n \tstruct nfp_net_hw *hw;\n \tstruct rte_pci_device *pci_dev;\n \tstruct nfp_pf_dev *pf_dev;\n-\tstruct nfp_net_txq *this_tx_q;\n-\tstruct nfp_net_rxq *this_rx_q;\n \tint i;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n@@ -277,17 +266,9 @@ nfp_net_close(struct rte_eth_dev *dev)\n \tnfp_net_disable_queues(dev);\n \n \t/* Clear queues */\n-\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n-\t\tthis_tx_q = (struct nfp_net_txq *)dev->data->tx_queues[i];\n-\t\tnfp_net_reset_tx_queue(this_tx_q);\n-\t\tnfp_net_tx_queue_release(dev, i);\n-\t}\n+\tnfp_net_close_tx_queue(dev);\n \n-\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n-\t\tthis_rx_q = (struct nfp_net_rxq *)dev->data->rx_queues[i];\n-\t\tnfp_net_reset_rx_queue(this_rx_q);\n-\t\tnfp_net_rx_queue_release(dev, i);\n-\t}\n+\tnfp_net_close_rx_queue(dev);\n \n \t/* Cancel possible impending LSC work here before releasing the port*/\n \trte_eal_alarm_cancel(nfp_net_dev_interrupt_delayed_handler,\ndiff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c\nindex 2342f44523..56428814b7 100644\n--- a/drivers/net/nfp/nfp_ethdev_vf.c\n+++ b/drivers/net/nfp/nfp_ethdev_vf.c\n@@ -145,24 +145,14 @@ nfp_netvf_start(struct rte_eth_dev *dev)\n static int\n nfp_netvf_stop(struct rte_eth_dev *dev)\n {\n-\tstruct nfp_net_txq *this_tx_q;\n-\tstruct nfp_net_rxq *this_rx_q;\n-\tint i;\n-\n \tPMD_INIT_LOG(DEBUG, \"Stop\");\n \n \tnfp_net_disable_queues(dev);\n \n \t/* Clear queues */\n-\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n-\t\tthis_tx_q = (struct nfp_net_txq *)dev->data->tx_queues[i];\n-\t\tnfp_net_reset_tx_queue(this_tx_q);\n-\t}\n+\tnfp_net_stop_tx_queue(dev);\n \n-\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n-\t\tthis_rx_q = (struct nfp_net_rxq *)dev->data->rx_queues[i];\n-\t\tnfp_net_reset_rx_queue(this_rx_q);\n-\t}\n+\tnfp_net_stop_rx_queue(dev);\n \n \treturn 0;\n }\n@@ -185,9 +175,6 @@ static int\n nfp_netvf_close(struct rte_eth_dev *dev)\n {\n \tstruct rte_pci_device *pci_dev;\n-\tstruct nfp_net_txq *this_tx_q;\n-\tstruct nfp_net_rxq *this_rx_q;\n-\tint i;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n@@ -204,17 +191,9 @@ nfp_netvf_close(struct rte_eth_dev *dev)\n \tnfp_net_disable_queues(dev);\n \n \t/* Clear queues */\n-\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n-\t\tthis_tx_q = (struct nfp_net_txq *)dev->data->tx_queues[i];\n-\t\tnfp_net_reset_tx_queue(this_tx_q);\n-\t\tnfp_net_tx_queue_release(dev, i);\n-\t}\n+\tnfp_net_close_tx_queue(dev);\n \n-\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n-\t\tthis_rx_q = (struct nfp_net_rxq *)dev->data->rx_queues[i];\n-\t\tnfp_net_reset_rx_queue(this_rx_q);\n-\t\tnfp_net_rx_queue_release(dev, i);\n-\t}\n+\tnfp_net_close_rx_queue(dev);\n \n \trte_intr_disable(pci_dev->intr_handle);\n \n", "prefixes": [ "v3", "10/13" ] }