Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 112835,
    "url": "http://patches.dpdk.org/api/patches/112835/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220616070743.30658-1-ndabilpuram@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220616070743.30658-1-ndabilpuram@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220616070743.30658-1-ndabilpuram@marvell.com",
    "date": "2022-06-16T07:07:32",
    "name": "[01/12] common/cnxk: use computed value for wqe skip",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "a76b153d8c828894b9f6a515db9869dd6b25e3a9",
    "submitter": {
        "id": 1202,
        "url": "http://patches.dpdk.org/api/people/1202/?format=api",
        "name": "Nithin Dabilpuram",
        "email": "ndabilpuram@marvell.com"
    },
    "delegate": {
        "id": 310,
        "url": "http://patches.dpdk.org/api/users/310/?format=api",
        "username": "jerin",
        "first_name": "Jerin",
        "last_name": "Jacob",
        "email": "jerinj@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220616070743.30658-1-ndabilpuram@marvell.com/mbox/",
    "series": [
        {
            "id": 23552,
            "url": "http://patches.dpdk.org/api/series/23552/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23552",
            "date": "2022-06-16T07:07:32",
            "name": "[01/12] common/cnxk: use computed value for wqe skip",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/23552/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/112835/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/112835/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8B1EDA00C3;\n\tThu, 16 Jun 2022 09:09:36 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 741494114F;\n\tThu, 16 Jun 2022 09:09:36 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 23844410D0\n for <dev@dpdk.org>; Thu, 16 Jun 2022 09:09:34 +0200 (CEST)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 25FN9p0S014305\n for <dev@dpdk.org>; Thu, 16 Jun 2022 00:09:34 -0700",
            "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3gqruu9kg7-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 16 Jun 2022 00:09:34 -0700",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Thu, 16 Jun 2022 00:09:32 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Thu, 16 Jun 2022 00:09:32 -0700",
            "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 0668A3F703F;\n Thu, 16 Jun 2022 00:09:29 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-type; s=pfpt0220;\n bh=eX/ZTxEHEMqWw455hppitCPlO7CRkRJtKgdUKYdrLtU=;\n b=JqkNvMPsBVaZv9FMxZM7oJZYmehL/Hu700fGuN4qGkZSCsuN9MYL7/wBCKIvVvibQKYs\n 1Zu51YFPhRHPEw+kBqby8y0v5lPOEDwUk7JMtYBJsnNtrGP3+vjQBbEZNoSxz1ct7jqx\n BZDQYTVeI3MsmOGGO5cjzo7cgasw8+QOox6uc9xJvkF/VlmUX5MMG08bzIz/NSFU9YY9\n IYjYpyzLXvceZKW5rdgMqZUhBSYuisj0tIhjeYLqBT7hw9Yi0W2XGT7YTLrif6ugTVhE\n OqdVIPbe7z3pJ0LsrodTz/rPDwd07e/kO75eMaTh5trqPpZEXe5axeC8KDwR4pudClg5 yw==",
        "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>",
        "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>, Pavan Nikhilesh\n <pbhagavatula@marvell.com>, Shijith Thotton <sthotton@marvell.com>",
        "CC": "<dev@dpdk.org>",
        "Subject": "[PATCH 01/12] common/cnxk: use computed value for wqe skip",
        "Date": "Thu, 16 Jun 2022 12:37:32 +0530",
        "Message-ID": "<20220616070743.30658-1-ndabilpuram@marvell.com>",
        "X-Mailer": "git-send-email 2.8.4",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Proofpoint-ORIG-GUID": "y1eLYfu2HeB8wm_feZo8AS8Npz2WpDsy",
        "X-Proofpoint-GUID": "y1eLYfu2HeB8wm_feZo8AS8Npz2WpDsy",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514\n definitions=2022-06-16_03,2022-06-15_01,2022-02-23_01",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Use computed value for WQE skip instead of a hardcoded value.\nWQE skip needs to be number of 128B lines to accommodate rte_mbuf.\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\nDepends-on: series=23500 (\"common/cnxk: add cnf10kb support\")\n\n drivers/common/cnxk/roc_nix_inl.h        | 2 +-\n drivers/common/cnxk/roc_nix_inl_priv.h   | 2 +-\n drivers/event/cnxk/cnxk_eventdev_adptr.c | 5 ++++-\n drivers/net/cnxk/cnxk_ethdev_sec.c       | 5 ++++-\n 4 files changed, 10 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/common/cnxk/roc_nix_inl.h b/drivers/common/cnxk/roc_nix_inl.h\nindex b1b4c5b..c7b1817 100644\n--- a/drivers/common/cnxk/roc_nix_inl.h\n+++ b/drivers/common/cnxk/roc_nix_inl.h\n@@ -131,7 +131,7 @@ struct roc_nix_inl_dev {\n \tuint16_t channel;\n \tuint16_t chan_mask;\n \tbool attach_cptlf;\n-\tbool wqe_skip;\n+\tuint16_t wqe_skip;\n \tuint8_t spb_drop_pc;\n \tuint8_t lpb_drop_pc;\n \tbool set_soft_exp_poll;\ndiff --git a/drivers/common/cnxk/roc_nix_inl_priv.h b/drivers/common/cnxk/roc_nix_inl_priv.h\nindex d61c7b2..a775efc 100644\n--- a/drivers/common/cnxk/roc_nix_inl_priv.h\n+++ b/drivers/common/cnxk/roc_nix_inl_priv.h\n@@ -84,7 +84,7 @@ struct nix_inl_dev {\n \tuint32_t ipsec_in_max_spi;\n \tuint32_t inb_spi_mask;\n \tbool attach_cptlf;\n-\tbool wqe_skip;\n+\tuint16_t wqe_skip;\n \tbool ts_ena;\n };\n \ndiff --git a/drivers/event/cnxk/cnxk_eventdev_adptr.c b/drivers/event/cnxk/cnxk_eventdev_adptr.c\nindex fa96090..cf5b1dd 100644\n--- a/drivers/event/cnxk/cnxk_eventdev_adptr.c\n+++ b/drivers/event/cnxk/cnxk_eventdev_adptr.c\n@@ -125,6 +125,7 @@ cnxk_sso_rxq_enable(struct cnxk_eth_dev *cnxk_eth_dev, uint16_t rq_id,\n {\n \tstruct roc_nix *nix = &cnxk_eth_dev->nix;\n \tstruct roc_nix_rq *rq;\n+\tuint16_t wqe_skip;\n \tint rc;\n \n \trq = &cnxk_eth_dev->rqs[rq_id];\n@@ -132,7 +133,9 @@ cnxk_sso_rxq_enable(struct cnxk_eth_dev *cnxk_eth_dev, uint16_t rq_id,\n \trq->tt = ev->sched_type;\n \trq->hwgrp = ev->queue_id;\n \trq->flow_tag_width = 20;\n-\trq->wqe_skip = 1;\n+\twqe_skip = RTE_ALIGN_CEIL(sizeof(struct rte_mbuf), ROC_CACHE_LINE_SZ);\n+\twqe_skip = wqe_skip / ROC_CACHE_LINE_SZ;\n+\trq->wqe_skip = wqe_skip;\n \trq->tag_mask = (port_id & 0xF) << 20;\n \trq->tag_mask |= (((port_id >> 4) & 0xF) | (RTE_EVENT_TYPE_ETHDEV << 4))\n \t\t\t<< 24;\ndiff --git a/drivers/net/cnxk/cnxk_ethdev_sec.c b/drivers/net/cnxk/cnxk_ethdev_sec.c\nindex d01ebb4..1de3454 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_sec.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_sec.c\n@@ -264,6 +264,7 @@ cnxk_nix_inl_dev_probe(struct rte_pci_driver *pci_drv,\n \tchar name[CNXK_NIX_INL_DEV_NAME_LEN];\n \tstruct roc_nix_inl_dev *inl_dev;\n \tconst struct rte_memzone *mz;\n+\tuint16_t wqe_skip;\n \tint rc = -ENOMEM;\n \n \tRTE_SET_USED(pci_drv);\n@@ -295,7 +296,9 @@ cnxk_nix_inl_dev_probe(struct rte_pci_driver *pci_drv,\n \n \tinl_dev->attach_cptlf = true;\n \t/* WQE skip is one for DPDK */\n-\tinl_dev->wqe_skip = true;\n+\twqe_skip = RTE_ALIGN_CEIL(sizeof(struct rte_mbuf), ROC_CACHE_LINE_SZ);\n+\twqe_skip = wqe_skip / ROC_CACHE_LINE_SZ;\n+\tinl_dev->wqe_skip = wqe_skip;\n \tinl_dev->set_soft_exp_poll = true;\n \trc = roc_nix_inl_dev_init(inl_dev);\n \tif (rc) {\n",
    "prefixes": [
        "01/12"
    ]
}