Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112619/?format=api
{ "id": 112619, "url": "http://patches.dpdk.org/api/patches/112619/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220609130129.210099-1-vfialko@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220609130129.210099-1-vfialko@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220609130129.210099-1-vfialko@marvell.com", "date": "2022-06-09T13:01:29", "name": "[1/1] examples/ipsec-secgw: add option for descriptors per QP", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b6061546347e65fbcab4b26124bcc57679f68ced", "submitter": { "id": 2390, "url": "http://patches.dpdk.org/api/people/2390/?format=api", "name": "Volodymyr Fialko", "email": "vfialko@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220609130129.210099-1-vfialko@marvell.com/mbox/", "series": [ { "id": 23450, "url": "http://patches.dpdk.org/api/series/23450/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23450", "date": "2022-06-09T13:01:29", "name": "[1/1] examples/ipsec-secgw: add option for descriptors per QP", "version": 1, "mbox": "http://patches.dpdk.org/series/23450/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/112619/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/112619/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 27723A0555;\n\tThu, 9 Jun 2022 15:01:39 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ED6BE40689;\n\tThu, 9 Jun 2022 15:01:38 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 6A7F140220\n for <dev@dpdk.org>; Thu, 9 Jun 2022 15:01:37 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 259Aesmq017914;\n Thu, 9 Jun 2022 06:01:36 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3gkfarrhbu-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 09 Jun 2022 06:01:36 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Thu, 9 Jun 2022 06:01:34 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Thu, 9 Jun 2022 06:01:34 -0700", "from localhost.localdomain (unknown [10.28.34.39])\n by maili.marvell.com (Postfix) with ESMTP id C700A3F7060;\n Thu, 9 Jun 2022 06:01:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=Y00oZr3iIfZyiUGItWtXiJNyqIXX/GD4sSwnZdvDRxs=;\n b=LqteqF26RtUBKStkDnRTnROjXwMeIBKjZZc3epbHy3vS8Qbozr6Yi3bWDNqPIC4lUATR\n v1o0DGDReJFRWZ6ZCcTsC8UyMuxJgh9k5bqhTm3STsZDeorWj3hzJWUZ0nUKjqjyTg2T\n SrSTiMEa5ALFHL2hKUICyUEwR6PWGpX8wchHDB3OVyAIq20U3EMotsSihRa3xRMibw4r\n skqBBEpQyGYxCLMtm8xdA+VGTImmngL+IBrJrmhUA51urK9BlSoAqIBzwqmxFLFPhn3H\n +YiTwv38l0JdNT7iTR9WPg5Tp+AOsPq2ns+5cJM1bHggRtRBvrkBoNXIwKSlQMlvwoxq cw==", "From": "Volodymyr Fialko <vfialko@marvell.com>", "To": "<dev@dpdk.org>, Radu Nicolau <radu.nicolau@intel.com>, Akhil Goyal\n <gakhil@marvell.com>", "CC": "<jerinj@marvell.com>, <anoobj@marvell.com>, Volodymyr Fialko\n <vfialko@marvell.com>", "Subject": "[PATCH 1/1] examples/ipsec-secgw: add option for descriptors per QP", "Date": "Thu, 9 Jun 2022 15:01:29 +0200", "Message-ID": "<20220609130129.210099-1-vfialko@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "UkcA0AUvtQpK_Dsnxn2Uilp5vj-a0sNn", "X-Proofpoint-ORIG-GUID": "UkcA0AUvtQpK_Dsnxn2Uilp5vj-a0sNn", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514\n definitions=2022-06-09_10,2022-06-09_01,2022-02-23_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Added option to configure number of queue pair descriptors via command\nline (--desc-nb NUMBER_OF_DESC).\n\nWhen the crypto processing takes longer durations, small queue pair size\nwould result in cryptodev enqueue failures. Larger queue pair size would\nallow more packets to stay in flight simultaneously and reduce enqueue\nfailures.\n\nSigned-off-by: Volodymyr Fialko <vfialko@marvell.com>\n---\n doc/guides/sample_app_ug/ipsec_secgw.rst | 4 ++++\n examples/ipsec-secgw/ipsec-secgw.c | 19 ++++++++++++++++---\n 2 files changed, 20 insertions(+), 3 deletions(-)", "diff": "diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides/sample_app_ug/ipsec_secgw.rst\nindex 94197a34f0..2529c95953 100644\n--- a/doc/guides/sample_app_ug/ipsec_secgw.rst\n+++ b/doc/guides/sample_app_ug/ipsec_secgw.rst\n@@ -151,6 +151,7 @@ The application has a number of command line options::\n --reassemble NUM\n --mtu MTU\n --frag-ttl FRAG_TTL_NS\n+ --desc-nb NUMBER_OF_DESC\n \n Where:\n \n@@ -258,6 +259,9 @@ Where:\n By default, vector pool size depeneds on packet pool size\n and size of each vector.\n \n+* ``--desc-nb NUMBER_OF_DESC``: Number of descriptors per queue pair.\n+ Default value: 2048.\n+\n The mapping of lcores to port/queues is similar to other l3fwd applications.\n \n For example, given the following command line to run application in poll mode::\ndiff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex 25255e053c..146222a1ec 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -62,7 +62,6 @@ volatile bool force_quit;\n \n #define MEMPOOL_CACHE_SIZE 256\n \n-#define CDEV_QUEUE_DESC 2048\n #define CDEV_MAP_ENTRIES 16384\n #define CDEV_MP_CACHE_SZ 64\n #define CDEV_MP_CACHE_MULTIPLIER 1.5 /* from rte_mempool.c */\n@@ -78,6 +77,11 @@ volatile bool force_quit;\n static uint16_t nb_rxd = IPSEC_SECGW_RX_DESC_DEFAULT;\n static uint16_t nb_txd = IPSEC_SECGW_TX_DESC_DEFAULT;\n \n+/*\n+ * Configurable number of descriptors per queue pair\n+ */\n+static uint32_t qp_desc_nb = 2048;\n+\n #define ETHADDR_TO_UINT64(addr) __BYTES_TO_UINT64( \\\n \t\t(addr)->addr_bytes[0], (addr)->addr_bytes[1], \\\n \t\t(addr)->addr_bytes[2], (addr)->addr_bytes[3], \\\n@@ -113,6 +117,7 @@ struct flow_info flow_info_tbl[RTE_MAX_ETHPORTS];\n #define CMD_LINE_OPT_VECTOR_TIMEOUT\t\"vector-tmo\"\n #define CMD_LINE_OPT_VECTOR_POOL_SZ\t\"vector-pool-sz\"\n #define CMD_LINE_OPT_PER_PORT_POOL\t\"per-port-pool\"\n+#define CMD_LINE_OPT_QP_DESC_NB\t\t\"desc-nb\"\n \n #define CMD_LINE_ARG_EVENT\t\"event\"\n #define CMD_LINE_ARG_POLL\t\"poll\"\n@@ -142,6 +147,7 @@ enum {\n \tCMD_LINE_OPT_VECTOR_TIMEOUT_NUM,\n \tCMD_LINE_OPT_VECTOR_POOL_SZ_NUM,\n \tCMD_LINE_OPT_PER_PORT_POOL_NUM,\n+\tCMD_LINE_OPT_QP_DESC_NB_NUM,\n };\n \n static const struct option lgopts[] = {\n@@ -160,6 +166,7 @@ static const struct option lgopts[] = {\n \t{CMD_LINE_OPT_VECTOR_TIMEOUT, 1, 0, CMD_LINE_OPT_VECTOR_TIMEOUT_NUM},\n \t{CMD_LINE_OPT_VECTOR_POOL_SZ, 1, 0, CMD_LINE_OPT_VECTOR_POOL_SZ_NUM},\n \t{CMD_LINE_OPT_PER_PORT_POOL, 0, 0, CMD_LINE_OPT_PER_PORT_POOL_NUM},\n+\t{CMD_LINE_OPT_QP_DESC_NB, 1, 0, CMD_LINE_OPT_QP_DESC_NB_NUM},\n \t{NULL, 0, 0, 0}\n };\n \n@@ -886,6 +893,7 @@ print_usage(const char *prgname)\n \t\t\" [--event-vector]\"\n \t\t\" [--vector-size SIZE]\"\n \t\t\" [--vector-tmo TIMEOUT in ns]\"\n+\t\t\" [--\" CMD_LINE_OPT_QP_DESC_NB \" NUMBER_OF_DESC]\"\n \t\t\"\\n\\n\"\n \t\t\" -p PORTMASK: Hexadecimal bitmask of ports to configure\\n\"\n \t\t\" -P : Enable promiscuous mode\\n\"\n@@ -948,6 +956,8 @@ print_usage(const char *prgname)\n \t\t\" --\" CMD_LINE_OPT_PER_PORT_POOL \" Enable per port mbuf pool\\n\"\n \t\t\" --\" CMD_LINE_OPT_VECTOR_POOL_SZ \" Vector pool size\\n\"\n \t\t\" (default value is based on mbuf count)\\n\"\n+\t\t\" --\" CMD_LINE_OPT_QP_DESC_NB \" DESC_NB\"\n+\t\t\": Number of descriptors per queue pair (default value: 2048)\\n\"\n \t\t\"\\n\",\n \t\tprgname);\n }\n@@ -1341,6 +1351,9 @@ parse_args(int32_t argc, char **argv, struct eh_conf *eh_conf)\n \t\tcase CMD_LINE_OPT_PER_PORT_POOL_NUM:\n \t\t\tper_port_pool = 1;\n \t\t\tbreak;\n+\t\tcase CMD_LINE_OPT_QP_DESC_NB_NUM:\n+\t\t\tqp_desc_nb = parse_decimal(optarg);\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\tprint_usage(prgname);\n \t\t\treturn -1;\n@@ -1658,7 +1671,7 @@ cryptodevs_init(uint16_t req_queue_num)\n \t\t\trte_panic(\"Failed to initialize cryptodev %u\\n\",\n \t\t\t\t\tcdev_id);\n \n-\t\tqp_conf.nb_descriptors = CDEV_QUEUE_DESC;\n+\t\tqp_conf.nb_descriptors = qp_desc_nb;\n \t\tqp_conf.mp_session =\n \t\t\tsocket_ctx[dev_conf.socket_id].session_pool;\n \t\tqp_conf.mp_session_private =\n@@ -2543,7 +2556,7 @@ calculate_nb_mbufs(uint16_t nb_ports, uint16_t nb_crypto_qp, uint32_t nb_rxq,\n \t\t\tnb_ports * nb_lcores * MAX_PKT_BURST +\n \t\t\tnb_ports * nb_txq * nb_txd +\n \t\t\tnb_lcores * MEMPOOL_CACHE_SIZE +\n-\t\t\tnb_crypto_qp * CDEV_QUEUE_DESC +\n+\t\t\tnb_crypto_qp * qp_desc_nb +\n \t\t\tnb_lcores * frag_tbl_sz *\n \t\t\tFRAG_TBL_BUCKET_ENTRIES),\n \t\t 8192U);\n", "prefixes": [ "1/1" ] }