Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112234/?format=api
{ "id": 112234, "url": "http://patches.dpdk.org/api/patches/112234/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220601135059.958882-2-wenxuanx.wu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220601135059.958882-2-wenxuanx.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220601135059.958882-2-wenxuanx.wu@intel.com", "date": "2022-06-01T13:50:56", "name": "[v8,1/3] ethdev: introduce protocol hdr based buffer split", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dbf8ce564026636c803910e352795b536081f0cf", "submitter": { "id": 2515, "url": "http://patches.dpdk.org/api/people/2515/?format=api", "name": "Wu, WenxuanX", "email": "wenxuanx.wu@intel.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220601135059.958882-2-wenxuanx.wu@intel.com/mbox/", "series": [ { "id": 23292, "url": "http://patches.dpdk.org/api/series/23292/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23292", "date": "2022-06-01T13:50:55", "name": "ethdev: introduce protocol type based header split", "version": 8, "mbox": "http://patches.dpdk.org/series/23292/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/112234/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/112234/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CE3F8A0548;\n\tWed, 1 Jun 2022 16:14:52 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A464142826;\n\tWed, 1 Jun 2022 16:14:49 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 828824113F\n for <dev@dpdk.org>; Wed, 1 Jun 2022 16:14:47 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Jun 2022 07:14:47 -0700", "from unknown (HELO localhost.localdomain) ([10.239.251.3])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Jun 2022 07:14:43 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1654092887; x=1685628887;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=JmEQKFpKTC9GLx6Jq04gS9TokPLsy6con4W6ZesFddQ=;\n b=dRX+yAUWqs9Po2T4v+4aJHFZt/TtP6kYCod7HqsnKBeAKJq8zgrhIlwS\n RMpDROoTe/UEfBYM9LhusV3VcQUqQyMIdJ079qMKFlQ0jpRzRTWTPCK3k\n Sr9AV+NxjkZLGH2PIgTRPV16Wq/o60vpo3biTGV0MCoJKbhVXY8O+Ogiz\n B8weR5Z/tSgRjzcbZENm1Kv3wvk7hjZ/z+8UgyklHdkuO8xJ4JNFC+PcC\n 2cnhCyu23Bf3kyzCBz2FKIIMt229hoUcKwHHdIclR/j8yVTVhcNGgjLa/\n 2CmZt7dSM1E+/s0P51CwWrSVIMnXEPVJa7ogTVKjZ5cOICySh6S31NSoS g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10365\"; a=\"338647457\"", "E=Sophos;i=\"5.91,268,1647327600\"; d=\"scan'208\";a=\"338647457\"", "E=Sophos;i=\"5.91,268,1647327600\"; d=\"scan'208\";a=\"606287126\"" ], "From": "wenxuanx.wu@intel.com", "To": "thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, xiaoyun.li@intel.com,\n ferruh.yigit@xilinx.com, aman.deep.singh@intel.com, dev@dpdk.org,\n yuying.zhang@intel.com, qi.z.zhang@intel.com, jerinjacobk@gmail.com", "Cc": "stephen@networkplumber.org, Wenxuan Wu <wenxuanx.wu@intel.com>,\n Xuan Ding <xuan.ding@intel.com>, Yuan Wang <yuanx.wang@intel.com>,\n Ray Kinsella <mdr@ashroe.eu>", "Subject": "[PATCH v8 1/3] ethdev: introduce protocol hdr based buffer split", "Date": "Wed, 1 Jun 2022 13:50:56 +0000", "Message-Id": "<20220601135059.958882-2-wenxuanx.wu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220601135059.958882-1-wenxuanx.wu@intel.com>", "References": "<20220303060136.36427-1-xuan.ding@intel.com>\n <20220601135059.958882-1-wenxuanx.wu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Wenxuan Wu <wenxuanx.wu@intel.com>\n\nCurrently, Rx buffer split supports length based split. With Rx queue\noffload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment\nconfigured, PMD will be able to split the received packets into\nmultiple segments.\n\nHowever, length based buffer split is not suitable for NICs that do split\nbased on protocol headers. Given a arbitrarily variable length in Rx packet\nsegment, it is almost impossible to pass a fixed protocol header to PMD.\nBesides, the existence of tunneling results in the composition of a packet\nis various, which makes the situation even worse.\n\nThis patch extends current buffer split to support protocol header based\nbuffer split. A new proto_hdr field is introduced in the reserved field\nof rte_eth_rxseg_split structure to specify protocol header. The proto_hdr\nfield defines the split position of packet, splitting will always happens\nafter the protocol header defined in the Rx packet segment. When Rx queue\noffload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT is enabled and corresponding\nprotocol header is configured, PMD will split the ingress packets into\nmultiple segments.\n\nstruct rte_eth_rxseg_split {\n\n struct rte_mempool *mp; /* memory pools to allocate segment from */\n uint16_t length; /* segment maximal data length,\n configures \"split point\" */\n uint16_t offset; /* data offset from beginning\n of mbuf data buffer */\n uint32_t proto_hdr; /* inner/outer L2/L3/L4 protocol header,\n\t\t\t configures \"split point\" */\n };\n\nBoth inner and outer L2/L3/L4 level protocol header split can be supported.\nCorresponding protocol header capability is RTE_PTYPE_L2_ETHER,\nRTE_PTYPE_L3_IPV4, RTE_PTYPE_L3_IPV6, RTE_PTYPE_L4_TCP, RTE_PTYPE_L4_UDP,\nRTE_PTYPE_L4_SCTP, RTE_PTYPE_INNER_L2_ETHER, RTE_PTYPE_INNER_L3_IPV4,\nRTE_PTYPE_INNER_L3_IPV6, RTE_PTYPE_INNER_L4_TCP, RTE_PTYPE_INNER_L4_UDP,\nRTE_PTYPE_INNER_L4_SCTP.\n\nFor example, let's suppose we configured the Rx queue with the\nfollowing segments:\n seg0 - pool0, proto_hdr0=RTE_PTYPE_L3_IPV4, off0=2B\n seg1 - pool1, proto_hdr1=RTE_PTYPE_L4_UDP, off1=128B\n seg2 - pool2, off1=0B\n\nThe packet consists of MAC_IPV4_UDP_PAYLOAD will be split like\nfollowing:\n seg0 - ipv4 header @ RTE_PKTMBUF_HEADROOM + 2 in mbuf from pool0\n seg1 - udp header @ 128 in mbuf from pool1\n seg2 - payload @ 0 in mbuf from pool2\n\nNow buffet split can be configured in two modes. For length based\nbuffer split, the mp, length, offset field in Rx packet segment should\nbe configured, while the proto_hdr field should not be configured.\nFor protocol header based buffer split, the mp, offset, proto_hdr field\nin Rx packet segment should be configured, while the length field should\nnot be configured.\n\nThe split limitations imposed by underlying PMD is reported in the\nrte_eth_dev_info->rx_seg_capa field. The memory attributes for the split\nparts may differ either, dpdk memory and external memory, respectively.\n\nSigned-off-by: Xuan Ding <xuan.ding@intel.com>\nSigned-off-by: Yuan Wang <yuanx.wang@intel.com>\nSigned-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>\nReviewed-by: Qi Zhang <qi.z.zhang@intel.com>\nAcked-by: Ray Kinsella <mdr@ashroe.eu>\n---\n lib/ethdev/rte_ethdev.c | 40 +++++++++++++++++++++++++++++++++-------\n lib/ethdev/rte_ethdev.h | 28 +++++++++++++++++++++++++++-\n 2 files changed, 60 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 29a3d80466..fbd55cdd9d 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -1661,6 +1661,7 @@ rte_eth_rx_queue_check_split(const struct rte_eth_rxseg_split *rx_seg,\n \t\tstruct rte_mempool *mpl = rx_seg[seg_idx].mp;\n \t\tuint32_t length = rx_seg[seg_idx].length;\n \t\tuint32_t offset = rx_seg[seg_idx].offset;\n+\t\tuint32_t proto_hdr = rx_seg[seg_idx].proto_hdr;\n \n \t\tif (mpl == NULL) {\n \t\t\tRTE_ETHDEV_LOG(ERR, \"null mempool pointer\\n\");\n@@ -1694,13 +1695,38 @@ rte_eth_rx_queue_check_split(const struct rte_eth_rxseg_split *rx_seg,\n \t\t}\n \t\toffset += seg_idx != 0 ? 0 : RTE_PKTMBUF_HEADROOM;\n \t\t*mbp_buf_size = rte_pktmbuf_data_room_size(mpl);\n-\t\tlength = length != 0 ? length : *mbp_buf_size;\n-\t\tif (*mbp_buf_size < length + offset) {\n-\t\t\tRTE_ETHDEV_LOG(ERR,\n-\t\t\t\t \"%s mbuf_data_room_size %u < %u (segment length=%u + segment offset=%u)\\n\",\n-\t\t\t\t mpl->name, *mbp_buf_size,\n-\t\t\t\t length + offset, length, offset);\n-\t\t\treturn -EINVAL;\n+\t\tif (proto_hdr == RTE_PTYPE_UNKNOWN) {\n+\t\t\t/* Split at fixed length. */\n+\t\t\tlength = length != 0 ? length : *mbp_buf_size;\n+\t\t\tif (*mbp_buf_size < length + offset) {\n+\t\t\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\t\t\"%s mbuf_data_room_size %u < %u (segment length=%u + segment offset=%u)\\n\",\n+\t\t\t\t\tmpl->name, *mbp_buf_size,\n+\t\t\t\t\tlength + offset, length, offset);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t} else {\n+\t\t\t/* Split after specified protocol header. */\n+\t\t\tif (!(proto_hdr & RTE_BUFFER_SPLIT_PROTO_HDR_MASK)) {\n+\t\t\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\t\t\"Protocol header %u not supported)\\n\",\n+\t\t\t\t\tproto_hdr);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\n+\t\t\tif (length != 0) {\n+\t\t\t\tRTE_ETHDEV_LOG(ERR, \"segment length should be set to zero in protocol header \"\n+\t\t\t\t\t \"based buffer split\\n\");\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\n+\t\t\tif (*mbp_buf_size < offset) {\n+\t\t\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\t\t\t\"%s mbuf_data_room_size %u < %u segment offset)\\n\",\n+\t\t\t\t\t\tmpl->name, *mbp_buf_size,\n+\t\t\t\t\t\toffset);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n \t\t}\n \t}\n \treturn 0;\ndiff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 04cff8ee10..0cd9dd6cc0 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -1187,6 +1187,9 @@ struct rte_eth_txmode {\n * mbuf) the following data will be pushed to the next segment\n * up to its own length, and so on.\n *\n+ * - The proto_hdrs in the elements define the split position of\n+ * received packets.\n+ *\n * - If the length in the segment description element is zero\n * the actual buffer size will be deduced from the appropriate\n * memory pool properties.\n@@ -1197,14 +1200,37 @@ struct rte_eth_txmode {\n * - pool from the last valid element\n * - the buffer size from this pool\n * - zero offset\n+ *\n+ * - Length based buffer split:\n+ * - mp, length, offset should be configured.\n+ * - The proto_hdr field should not be configured.\n+ *\n+ * - Protocol header based buffer split:\n+ * - mp, offset, proto_hdr should be configured.\n+ * - The length field should not be configured.\n */\n struct rte_eth_rxseg_split {\n \tstruct rte_mempool *mp; /**< Memory pool to allocate segment from. */\n \tuint16_t length; /**< Segment data length, configures split point. */\n \tuint16_t offset; /**< Data offset from beginning of mbuf data buffer. */\n-\tuint32_t reserved; /**< Reserved field. */\n+\tuint32_t proto_hdr; /**< Inner/outer L2/L3/L4 protocol header, configures split point. */\n };\n \n+/* Buffer split protocol header capability. */\n+#define RTE_BUFFER_SPLIT_PROTO_HDR_MASK ( \\\n+\tRTE_PTYPE_L2_ETHER | \\\n+\tRTE_PTYPE_L3_IPV4 | \\\n+\tRTE_PTYPE_L3_IPV6 | \\\n+\tRTE_PTYPE_L4_TCP | \\\n+\tRTE_PTYPE_L4_UDP | \\\n+\tRTE_PTYPE_L4_SCTP | \\\n+\tRTE_PTYPE_INNER_L2_ETHER | \\\n+\tRTE_PTYPE_INNER_L3_IPV4 | \\\n+\tRTE_PTYPE_INNER_L3_IPV6 | \\\n+\tRTE_PTYPE_INNER_L4_TCP | \\\n+\tRTE_PTYPE_INNER_L4_UDP | \\\n+\tRTE_PTYPE_INNER_L4_SCTP)\n+\n /**\n * @warning\n * @b EXPERIMENTAL: this structure may change without prior notice.\n", "prefixes": [ "v8", "1/3" ] }