Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112110/?format=api
{ "id": 112110, "url": "http://patches.dpdk.org/api/patches/112110/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220531092753.10825-1-romain.delhomel@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220531092753.10825-1-romain.delhomel@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220531092753.10825-1-romain.delhomel@6wind.com", "date": "2022-05-31T09:27:53", "name": "[RFC,v2] bus/fslmc: fix invalid use of default VFIO config", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "929d3db8e4107a12656a0b2973dc6e17c15c16eb", "submitter": { "id": 2705, "url": "http://patches.dpdk.org/api/people/2705/?format=api", "name": "Romain Delhomel", "email": "romain.delhomel@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220531092753.10825-1-romain.delhomel@6wind.com/mbox/", "series": [ { "id": 23258, "url": "http://patches.dpdk.org/api/series/23258/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23258", "date": "2022-05-31T09:27:53", "name": "[RFC,v2] bus/fslmc: fix invalid use of default VFIO config", "version": 2, "mbox": "http://patches.dpdk.org/series/23258/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/112110/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/112110/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4F3F4A0542;\n\tTue, 31 May 2022 11:28:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F2E2C400EF;\n\tTue, 31 May 2022 11:28:12 +0200 (CEST)", "from mail-wr1-f49.google.com (mail-wr1-f49.google.com\n [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 4497E400D6\n for <dev@dpdk.org>; Tue, 31 May 2022 11:28:12 +0200 (CEST)", "by mail-wr1-f49.google.com with SMTP id k19so9641371wrd.8\n for <dev@dpdk.org>; Tue, 31 May 2022 02:28:12 -0700 (PDT)", "from testament.dev.6wind.com ([185.13.181.2])\n by smtp.gmail.com with ESMTPSA id\n g6-20020a5d5546000000b002100aa69469sm11291654wrw.2.2022.05.31.02.28.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 31 May 2022 02:28:11 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=2SVmC4d+JMS+IyKR0M1T1oo+fnECR3bnVQrhlqg3VTM=;\n b=BB8Zv+9510JHj+tQgcSMduvxz39BJ/aiaOg+TurHIy+OoEBRr0YFIc/ej2Gje60zhK\n pkmesPmNBtaCtYr324MmhzMqDYZ1pLpoEsgqXMH7yYwgM0CYiO7Xr4fP+8zF/vntz1eF\n 5z9ujr2aMp8+4jf8Xju0vYVA3jmfG6rfOL/iQXlvxorCtP24e1AfHibQO7StI7fptdBr\n yX+4XaL+derXigdNlU3PKHahOn72jwL1UWcgvajNpgTLw9CGEqTUzhLcr5ALRhIeZa9e\n pmoMDKqGeSKpluosXTyF7k2jbVsCJks805+hBG2IVznNL+2AiTinZt9Yl+LznBFAgak/\n LhLg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=2SVmC4d+JMS+IyKR0M1T1oo+fnECR3bnVQrhlqg3VTM=;\n b=pxntHtRjLuLvyhBQfCssi1D193/kyMRAtqfDZFZypVS7n8YqxjAljV0Qye7NSarH2y\n 9ssbWQHoMBJ3LY+ZiOimscDlAgS4bJXJpiAhlNp/zDhJjSah1m3M419af4Ugh9ztzp4a\n HPTekC5yiuxZLidSlx/Q79SYTa9Wp5e6V73vOplwvbIalTooFsmTBNz83pzDTZSO8WL8\n nHfurp+9N6aqbcJVwcp259NlkjrbzhjAMnhpHlDHVZe7itkVvJAMzxIC3YsLHeqmwQr8\n gQyEpEHqHzSUHcqY87x113o+Md9htxBPN5vjui60nK4T06XpwQ8Ff5fl2fHTSt3cIG2I\n MaLg==", "X-Gm-Message-State": "AOAM530gOqsN+zS3QCBmlW4Jm8BMP/Hg6YJClb6EODr1dqJA/fxWkPQd\n YbIhF2QpS3o3sBHAgsDi44S92Q==", "X-Google-Smtp-Source": "\n ABdhPJx9mry5C88H6FGd2k8/OdRpEm4Yk06v32XNF6BUe89ap+U3vJbeAk88tQ0a1vdO2SH1yeIW/w==", "X-Received": "by 2002:adf:f2cd:0:b0:20e:5bf9:8e32 with SMTP id\n d13-20020adff2cd000000b0020e5bf98e32mr49551663wrp.161.1653989291955;\n Tue, 31 May 2022 02:28:11 -0700 (PDT)", "From": "Romain Delhomel <romain.delhomel@6wind.com>", "To": "hemant.agrawal@nxp.com,\n\tsachin.saxena@oss.nxp.com", "Cc": "dev@dpdk.org, olivier.matz@6wind.com, stephane.gonauer@6wind.com,\n guillaume.gaudonville@6wind.com, elias.boutaleb@6wind.com", "Subject": "[RFC v2] bus/fslmc: fix invalid use of default VFIO config", "Date": "Tue, 31 May 2022 11:27:53 +0200", "Message-Id": "<20220531092753.10825-1-romain.delhomel@6wind.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "\n <CAC9qv4BEL9c80k7s6SF6n53v_kXU=EvuOC2CHSNOZpqyPavfDw@mail.gmail.com>", "References": "\n <CAC9qv4BEL9c80k7s6SF6n53v_kXU=EvuOC2CHSNOZpqyPavfDw@mail.gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "At device probe, the fslmc bus driver calls rte_vfio_get_group_fd() to\nget a fd associated to a vfio group. This function first checks if the\ngroup is already opened, else it opens /dev/vfio/%u, and increases the\nnumber of active groups in default_vfio_cfg (which references the\ndefault vfio container).\n\nWhen adding the first group to a vfio_cfg, the caller is supposed to\npick an IOMMU type and set up DMA mappings for container, as it's done\nby pci bus, but it is not done here. Instead, a new container is created\nand used.\n\nThis prevents the pci bus driver, which uses the default_vfio_cfg\ncontainer, to configure the container because\ndefault_vfio_cfg->active_group > 1.\n\nThis patch fixes the issue by always creating a new container (and its\nassociated vfio_cfg) and binding the group to it.\n\nFixes: a69f79300262 (\"bus/fslmc: support multi VFIO group\")\nSigned-off-by: Romain Delhomel <romain.delhomel@6wind.com>\n---\nv2:\n* Fix wrong indentation\n\n drivers/bus/fslmc/fslmc_vfio.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c\nindex b4704eeae4e2..abe1cab2ee20 100644\n--- a/drivers/bus/fslmc/fslmc_vfio.c\n+++ b/drivers/bus/fslmc/fslmc_vfio.c\n@@ -979,6 +979,7 @@ fslmc_vfio_setup_group(void)\n {\n \tint groupid;\n \tint ret;\n+\tint vfio_container_fd;\n \tstruct vfio_group_status status = { .argsz = sizeof(status) };\n \n \t/* if already done once */\n@@ -997,8 +998,15 @@ fslmc_vfio_setup_group(void)\n \t\treturn 0;\n \t}\n \n+\tret = rte_vfio_container_create();\n+\tif (ret < 0) {\n+\t\tDPAA2_BUS_ERR(\"Failed to open VFIO container\");\n+\t\treturn ret;\n+\t}\n+\tvfio_container_fd = ret;\n+\n \t/* Get the actual group fd */\n-\tret = rte_vfio_get_group_fd(groupid);\n+\tret = rte_vfio_container_group_bind(vfio_container_fd, groupid);\n \tif (ret < 0)\n \t\treturn ret;\n \tvfio_group.fd = ret;\n", "prefixes": [ "RFC", "v2" ] }