Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112067/?format=api
{ "id": 112067, "url": "http://patches.dpdk.org/api/patches/112067/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220530143159.13672-3-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220530143159.13672-3-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220530143159.13672-3-arkadiuszx.kusztal@intel.com", "date": "2022-05-30T14:31:49", "name": "[v3,02/12] cryptodev: separate key exchange operation enum", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e850beaee6d5b55a1e0e5992916e4b79a59669b1", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220530143159.13672-3-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 23248, "url": "http://patches.dpdk.org/api/series/23248/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23248", "date": "2022-05-30T14:31:47", "name": "cryptodev: rsa, dh, ecdh changes", "version": 3, "mbox": "http://patches.dpdk.org/series/23248/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/112067/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/112067/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98529A0542;\n\tMon, 30 May 2022 17:39:52 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 351324281B;\n\tMon, 30 May 2022 17:39:43 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 0BAE9410E3\n for <dev@dpdk.org>; Mon, 30 May 2022 17:39:40 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 May 2022 08:39:40 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by orsmga005.jf.intel.com with ESMTP; 30 May 2022 08:39:39 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653925181; x=1685461181;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=Cg9jPXos+AFdPMEYjJ7VYR0CbyWDF5GiYMo6uO6hv/w=;\n b=mYd+fF6eZQ0hG3ViSHha7G/JrUVZ5Svs1aBLe7aq/cyYBqGybiMRRg0Z\n X3JjYRHU6o+Famlgz2CESp5gWY7LG+BZtHGDtnEsCePfaiSl2G8Gw7PJb\n uAJ+fCAvY0FrkME0TAFrfK3U+7seIadveGSqv1q/xKVm0e0L4A5aYAcWQ\n I7s25rcfuemV/H2GA9JD43yKtFZq7CzCWy+r0AAjgASLIg2v9EcvZRSJ7\n 2+vmip2enjB93oZa+eA49QorOmY57JCgnLr2033OuFuW+VZTAPQUnjivl\n 5D8t5ruDoo0JUediWBswmiSqbXUD+gzTasGniT19yKxd8Y7TVy7NAqq3V g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10363\"; a=\"338069424\"", "E=Sophos;i=\"5.91,263,1647327600\"; d=\"scan'208\";a=\"338069424\"", "E=Sophos;i=\"5.91,263,1647327600\"; d=\"scan'208\";a=\"751677993\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Subject": "[PATCH v3 02/12] cryptodev: separate key exchange operation enum", "Date": "Mon, 30 May 2022 15:31:49 +0100", "Message-Id": "<20220530143159.13672-3-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20220530143159.13672-1-arkadiuszx.kusztal@intel.com>", "References": "<20220530143159.13672-1-arkadiuszx.kusztal@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Separated key exchange enum from asym op type.\nKey exchange and asymmetric crypto operations like signatures,\nencryption/decryption should not share same operation enum as\nits use cases are unrelated and mutually exclusive.\nTherefore op_type was separate into:\n1) operation type\n2) key exchange operation type\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n app/test/test_cryptodev_asym.c | 52 +++++++++++++++-------------\n drivers/crypto/openssl/rte_openssl_pmd.c | 10 +++---\n drivers/crypto/openssl/rte_openssl_pmd_ops.c | 18 +++++-----\n lib/cryptodev/rte_crypto_asym.h | 45 +++++++++++++++---------\n lib/cryptodev/rte_cryptodev.c | 14 +++++---\n lib/cryptodev/rte_cryptodev.h | 4 ++-\n 6 files changed, 83 insertions(+), 60 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex 573af2a537..491ba2c1b9 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -976,27 +976,30 @@ static inline void print_asym_capa(\n \n \tfor (i = 0; i < RTE_CRYPTO_ASYM_OP_LIST_END; i++) {\n \t\t/* check supported operations */\n-\t\tif (rte_cryptodev_asym_xform_capability_check_optype(capa, i))\n-\t\t\tprintf(\" %s\",\n-\t\t\t\t\trte_crypto_asym_op_strings[i]);\n+\t\tif (rte_cryptodev_asym_xform_capability_check_optype(capa, i)) {\n+\t\t\tif (capa->xform_type == RTE_CRYPTO_ASYM_XFORM_DH)\n+\t\t\t\tprintf(\" %s\", rte_crypto_asym_ke_strings[i]);\n+\t\t\telse\n+\t\t\t\tprintf(\" %s\", rte_crypto_asym_op_strings[i]);\n \t\t}\n-\t\tswitch (capa->xform_type) {\n-\t\tcase RTE_CRYPTO_ASYM_XFORM_RSA:\n-\t\tcase RTE_CRYPTO_ASYM_XFORM_MODINV:\n-\t\tcase RTE_CRYPTO_ASYM_XFORM_MODEX:\n-\t\tcase RTE_CRYPTO_ASYM_XFORM_DH:\n-\t\tcase RTE_CRYPTO_ASYM_XFORM_DSA:\n-\t\t\tprintf(\" modlen: min %d max %d increment %d\",\n-\t\t\t\t\tcapa->modlen.min,\n-\t\t\t\t\tcapa->modlen.max,\n-\t\t\t\t\tcapa->modlen.increment);\n+\t}\n+\tswitch (capa->xform_type) {\n+\tcase RTE_CRYPTO_ASYM_XFORM_RSA:\n+\tcase RTE_CRYPTO_ASYM_XFORM_MODINV:\n+\tcase RTE_CRYPTO_ASYM_XFORM_MODEX:\n+\tcase RTE_CRYPTO_ASYM_XFORM_DH:\n+\tcase RTE_CRYPTO_ASYM_XFORM_DSA:\n+\t\tprintf(\" modlen: min %d max %d increment %d\",\n+\t\t\t\tcapa->modlen.min,\n+\t\t\t\tcapa->modlen.max,\n+\t\t\t\tcapa->modlen.increment);\n+\tbreak;\n+\tcase RTE_CRYPTO_ASYM_XFORM_ECDSA:\n+\tcase RTE_CRYPTO_ASYM_XFORM_ECPM:\n+\tdefault:\n \t\tbreak;\n-\t\tcase RTE_CRYPTO_ASYM_XFORM_ECDSA:\n-\t\tcase RTE_CRYPTO_ASYM_XFORM_ECPM:\n-\t\tdefault:\n-\t\t\tbreak;\n-\t\t}\n-\t\tprintf(\"\\n\");\n+\t}\n+\tprintf(\"\\n\");\n }\n \n static int\n@@ -1064,7 +1067,7 @@ test_dh_gen_shared_sec(struct rte_crypto_asym_xform *xfrm)\n \tasym_op = op->asym;\n \n \t/* Setup a xform and op to generate private key only */\n-\txform.dh.type = RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE;\n+\txform.dh.ke_type = RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE;\n \txform.next = NULL;\n \tasym_op->dh.priv_key.data = dh_test_params.priv_key.data;\n \tasym_op->dh.priv_key.length = dh_test_params.priv_key.length;\n@@ -1146,7 +1149,7 @@ test_dh_gen_priv_key(struct rte_crypto_asym_xform *xfrm)\n \tasym_op = op->asym;\n \n \t/* Setup a xform and op to generate private key only */\n-\txform.dh.type = RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE;\n+\txform.dh.ke_type = RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE;\n \txform.next = NULL;\n \tasym_op->dh.priv_key.data = output;\n \tasym_op->dh.priv_key.length = sizeof(output);\n@@ -1229,7 +1232,7 @@ test_dh_gen_pub_key(struct rte_crypto_asym_xform *xfrm)\n \t * using test private key\n \t *\n \t */\n-\txform.dh.type = RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE;\n+\txform.dh.ke_type = RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE;\n \txform.next = NULL;\n \n \tasym_op->dh.pub_key.data = output;\n@@ -1319,9 +1322,10 @@ test_dh_gen_kp(struct rte_crypto_asym_xform *xfrm)\n \t/* Setup a xform chain to generate\n \t * private key first followed by\n \t * public key\n-\t */xform.dh.type = RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE;\n+\t */\n+\txform.dh.ke_type = RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE;\n \tpub_key_xform.xform_type = RTE_CRYPTO_ASYM_XFORM_DH;\n-\tpub_key_xform.dh.type = RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE;\n+\tpub_key_xform.dh.ke_type = RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE;\n \txform.next = &pub_key_xform;\n \n \tasym_op->dh.pub_key.data = out_pub_key;\ndiff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c\nindex d80e1052e2..86f285ef79 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd.c\n@@ -1697,7 +1697,7 @@ process_openssl_dh_op(struct rte_crypto_op *cop,\n \tint ret = 0;\n \n \tif (sess->u.dh.key_op &\n-\t\t\t(1 << RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE)) {\n+\t\t\t(1 << RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE)) {\n \t\t/* compute shared secret using peer public key\n \t\t * and current private key\n \t\t * shared secret = peer_key ^ priv_key mod p\n@@ -1754,9 +1754,9 @@ process_openssl_dh_op(struct rte_crypto_op *cop,\n \t * then first set DH with user provided private key\n \t */\n \tif ((sess->u.dh.key_op &\n-\t\t\t(1 << RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE)) &&\n+\t\t\t(1 << RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE)) &&\n \t\t\t!(sess->u.dh.key_op &\n-\t\t\t(1 << RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE))) {\n+\t\t\t(1 << RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE))) {\n \t\t/* generate public key using user-provided private key\n \t\t * pub_key = g ^ priv_key mod p\n \t\t */\n@@ -1790,7 +1790,7 @@ process_openssl_dh_op(struct rte_crypto_op *cop,\n \t\treturn 0;\n \t}\n \n-\tif (sess->u.dh.key_op & (1 << RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE)) {\n+\tif (sess->u.dh.key_op & (1 << RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE)) {\n \t\tconst BIGNUM *pub_key = NULL;\n \n \t\tOPENSSL_LOG(DEBUG, \"%s:%d update public key\\n\",\n@@ -1805,7 +1805,7 @@ process_openssl_dh_op(struct rte_crypto_op *cop,\n \t}\n \n \tif (sess->u.dh.key_op &\n-\t\t\t(1 << RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE)) {\n+\t\t\t(1 << RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE)) {\n \t\tconst BIGNUM *priv_key = NULL;\n \n \t\tOPENSSL_LOG(DEBUG, \"%s:%d updated priv key\\n\",\ndiff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\nindex 1cb07794bd..724492c7cb 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c\n@@ -533,10 +533,10 @@ static const struct rte_cryptodev_capabilities openssl_pmd_capabilities[] = {\n \t\t\t.xform_capa = {\n \t\t\t\t.xform_type = RTE_CRYPTO_ASYM_XFORM_DH,\n \t\t\t\t.op_types =\n-\t\t\t\t((1<<RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE) |\n-\t\t\t\t(1 << RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE |\n+\t\t\t\t((1<<RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE) |\n+\t\t\t\t(1 << RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE |\n \t\t\t\t(1 <<\n-\t\t\t\tRTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE))),\n+\t\t\t\tRTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE))),\n \t\t\t\t{\n \t\t\t\t.modlen = {\n \t\t\t\t/* value 0 symbolizes no limit on min length */\n@@ -1006,16 +1006,16 @@ static int openssl_set_asym_session_parameters(\n \t\t * DH Priv key generate, or both\n \t\t * public and private key generate\n \t\t */\n-\t\tasym_session->u.dh.key_op = (1 << xform->dh.type);\n+\t\tasym_session->u.dh.key_op = (1 << xform->dh.ke_type);\n \n-\t\tif (xform->dh.type ==\n-\t\t\tRTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE) {\n+\t\tif (xform->dh.ke_type ==\n+\t\t\tRTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE) {\n \t\t\t/* check if next is pubkey */\n \t\t\tif ((xform->next != NULL) &&\n \t\t\t\t(xform->next->xform_type ==\n \t\t\t\tRTE_CRYPTO_ASYM_XFORM_DH) &&\n-\t\t\t\t(xform->next->dh.type ==\n-\t\t\t\tRTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE)\n+\t\t\t\t(xform->next->dh.ke_type ==\n+\t\t\t\tRTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE)\n \t\t\t\t) {\n \t\t\t\t/*\n \t\t\t\t * setup op as pub/priv key\n@@ -1023,7 +1023,7 @@ static int openssl_set_asym_session_parameters(\n \t\t\t\t */\n \t\t\t\tasym_session->u.dh.key_op |=\n \t\t\t\t(1 <<\n-\t\t\t\tRTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE);\n+\t\t\t\tRTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE);\n \t\t\t}\n \t\t}\n \t\tasym_session->u.dh.dh_key = dh;\ndiff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h\nindex 87df9b2ce3..e496588c7a 100644\n--- a/lib/cryptodev/rte_crypto_asym.h\n+++ b/lib/cryptodev/rte_crypto_asym.h\n@@ -33,6 +33,10 @@ struct rte_cryptodev_asym_session;\n extern const char *\n rte_crypto_asym_xform_strings[];\n \n+/** asym key exchange operation type name strings */\n+extern const char *\n+rte_crypto_asym_ke_strings[];\n+\n /** asym operations type name strings */\n extern const char *\n rte_crypto_asym_op_strings[];\n@@ -113,16 +117,22 @@ enum rte_crypto_asym_op_type {\n \t/**< Signature Generation operation */\n \tRTE_CRYPTO_ASYM_OP_VERIFY,\n \t/**< Signature Verification operation */\n-\tRTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE,\n-\t/**< DH Private Key generation operation */\n-\tRTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE,\n-\t/**< DH Public Key generation operation */\n-\tRTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE,\n-\t/**< DH Shared Secret compute operation */\n \tRTE_CRYPTO_ASYM_OP_LIST_END\n };\n \n /**\n+ * Asymmetric crypto key exchange operation type\n+ */\n+enum rte_crypto_asym_ke_type {\n+\tRTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE,\n+\t/**< Private Key generation operation */\n+\tRTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE,\n+\t/**< Public Key generation operation */\n+\tRTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE\n+\t/**< Shared Secret compute operation */\n+};\n+\n+/**\n * Padding types for RSA signature.\n */\n enum rte_crypto_rsa_padding_type {\n@@ -260,7 +270,7 @@ struct rte_crypto_modinv_xform {\n *\n */\n struct rte_crypto_dh_xform {\n-\tenum rte_crypto_asym_op_type type;\n+\tenum rte_crypto_asym_ke_type ke_type;\n \t/**< Setup xform for key generate or shared secret compute */\n \trte_crypto_uint p;\n \t/**< Prime modulus data */\n@@ -397,26 +407,27 @@ struct rte_crypto_rsa_op_param {\n struct rte_crypto_dh_op_param {\n \trte_crypto_uint pub_key;\n \t/**<\n-\t * Output generated public key when xform type is\n-\t * DH PUB_KEY_GENERATION.\n-\t * Input peer public key when xform type is DH\n-\t * SHARED_SECRET_COMPUTATION\n+\t * Output - generated public key, when dh xform ke_type is\n+\t * RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE.\n \t *\n+\t * Input - peer's public key, when dh xform ke_type is\n+\t * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE.\n \t */\n \n \trte_crypto_uint priv_key;\n \t/**<\n-\t * Output generated private key if xform type is\n-\t * DH PRIVATE_KEY_GENERATION\n-\t * Input when xform type is DH SHARED_SECRET_COMPUTATION.\n+\t * Output - generated private key, when dh xform ke_type is\n+\t * RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE.\n \t *\n+\t * Input - private key, when dh xform ke_type is one of:\n+\t * RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE,\n+\t * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE.\n \t */\n \n \trte_crypto_uint shared_secret;\n \t/**<\n-\t * Output with calculated shared secret\n-\t * when dh xform set up with op type = SHARED_SECRET_COMPUTATION.\n-\t *\n+\t * Output - calculated shared secret when dh xform ke_type is\n+\t * RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE.\n \t */\n };\n \ndiff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c\nindex e16e6802aa..cc614b0f72 100644\n--- a/lib/cryptodev/rte_cryptodev.c\n+++ b/lib/cryptodev/rte_cryptodev.c\n@@ -177,10 +177,16 @@ const char *rte_crypto_asym_op_strings[] = {\n \t[RTE_CRYPTO_ASYM_OP_ENCRYPT]\t= \"encrypt\",\n \t[RTE_CRYPTO_ASYM_OP_DECRYPT]\t= \"decrypt\",\n \t[RTE_CRYPTO_ASYM_OP_SIGN]\t= \"sign\",\n-\t[RTE_CRYPTO_ASYM_OP_VERIFY]\t= \"verify\",\n-\t[RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE]\t= \"priv_key_generate\",\n-\t[RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE] = \"pub_key_generate\",\n-\t[RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE] = \"sharedsecret_compute\",\n+\t[RTE_CRYPTO_ASYM_OP_VERIFY]\t= \"verify\"\n+};\n+\n+/**\n+ * Asymmetric crypto key exchange operation strings identifiers.\n+ */\n+const char *rte_crypto_asym_ke_strings[] = {\n+\t[RTE_CRYPTO_ASYM_KE_PRIV_KEY_GENERATE] = \"priv_key_generate\",\n+\t[RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE] = \"pub_key_generate\",\n+\t[RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE] = \"sharedsecret_compute\"\n };\n \n /**\ndiff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h\nindex 2c2c2edeb7..7d683fd728 100644\n--- a/lib/cryptodev/rte_cryptodev.h\n+++ b/lib/cryptodev/rte_cryptodev.h\n@@ -168,7 +168,9 @@ struct rte_cryptodev_asymmetric_xform_capability {\n \t/**< Transform type: RSA/MODEXP/DH/DSA/MODINV */\n \n \tuint32_t op_types;\n-\t/**< bitmask for supported rte_crypto_asym_op_type */\n+\t/**< bitmask for supported rte_crypto_asym_op_type or\n+\t * rte_crypto_asym_ke_type\n+\t */\n \n \t__extension__\n \tunion {\n", "prefixes": [ "v3", "02/12" ] }