Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111826/?format=api
{ "id": 111826, "url": "http://patches.dpdk.org/api/patches/111826/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220525155324.9288-3-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220525155324.9288-3-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220525155324.9288-3-arkadiuszx.kusztal@intel.com", "date": "2022-05-25T15:53:12", "name": "[v2,02/14] cryptodev: reduce number of comments in asym xform", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "869e83fc1bbe5916442ffef5872af8bff1967d36", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220525155324.9288-3-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 23159, "url": "http://patches.dpdk.org/api/series/23159/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23159", "date": "2022-05-25T15:53:10", "name": "cryptodev: rsa, dh, ecdh changes", "version": 2, "mbox": "http://patches.dpdk.org/series/23159/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111826/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/111826/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 06B14A0555;\n\tWed, 25 May 2022 19:03:25 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EC5D04113D;\n\tWed, 25 May 2022 19:03:24 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 03E4B40151\n for <dev@dpdk.org>; Wed, 25 May 2022 19:03:22 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 May 2022 10:01:11 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by FMSMGA003.fm.intel.com with ESMTP; 25 May 2022 10:01:10 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653498203; x=1685034203;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=dRbeVbZCaL2GZ9592KVyoaIZMqgImOEZwwrRGEa1As4=;\n b=ZnFVuMKtfhYIfhGyZFrDSpmzFUP8bV1Sn91nf88ZhKRb5XPXMhInJ4xf\n 5ARqxrXS36ECF/16ChcLhfWWV5yeYzryihZMy6QDovIc7Em1eNCm5qgAY\n EoQ6KErVVJdo6Xp2k1pLsnh+QbTIJXJolWSUvNBRoEAjsWWKqAvmX/KN9\n HdqmkjIeGl69f9F4mYTtjh5UF6AqNsDh/Z1R5jog8/auk1Z2KfC9+9prp\n Sk7cCyPX3xQpEjGdZUxgodW6/g5zOGSxvDk6bOrRP8xbP5i9CafBfrm/Y\n tDsV3ZGHHolZaBqjPlp1Wq5bKQjnDIm+d3H2x5OLyUM5eNYiGgOUfmG0E Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10358\"; a=\"273596088\"", "E=Sophos;i=\"5.91,250,1647327600\"; d=\"scan'208\";a=\"273596088\"", "E=Sophos;i=\"5.91,250,1647327600\"; d=\"scan'208\";a=\"664502294\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Subject": "[PATCH v2 02/14] cryptodev: reduce number of comments in asym xform", "Date": "Wed, 25 May 2022 16:53:12 +0100", "Message-Id": "<20220525155324.9288-3-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20220525155324.9288-1-arkadiuszx.kusztal@intel.com>", "References": "<20220525155324.9288-1-arkadiuszx.kusztal@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Reduced number of comments in asymmetric xform.\nInformation describing basic functionality of well known\nalgorithms are unnecessary.\n- Removed NONE asymetric xform.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n app/test/test_cryptodev_asym.c | 2 -\n lib/cryptodev/rte_crypto_asym.h | 114 ++++++++++++++++------------------------\n lib/cryptodev/rte_cryptodev.c | 1 -\n 3 files changed, 46 insertions(+), 71 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex 573af2a537..5aa9d65395 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -288,7 +288,6 @@ test_cryptodev_asym_ver(struct rte_crypto_op *op,\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_XFORM_DH:\n \tcase RTE_CRYPTO_ASYM_XFORM_DSA:\n-\tcase RTE_CRYPTO_ASYM_XFORM_NONE:\n \tcase RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED:\n \tdefault:\n \t\tbreak;\n@@ -440,7 +439,6 @@ test_cryptodev_asym_op(struct crypto_testsuite_params_asym *ts_params,\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_XFORM_DH:\n \tcase RTE_CRYPTO_ASYM_XFORM_DSA:\n-\tcase RTE_CRYPTO_ASYM_XFORM_NONE:\n \tcase RTE_CRYPTO_ASYM_XFORM_UNSPECIFIED:\n \tdefault:\n \t\tsnprintf(test_msg, ASYM_TEST_MSG_LEN,\ndiff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h\nindex 7206652458..66ffb29743 100644\n--- a/lib/cryptodev/rte_crypto_asym.h\n+++ b/lib/cryptodev/rte_crypto_asym.h\n@@ -38,6 +38,40 @@ extern const char *\n rte_crypto_asym_op_strings[];\n \n /**\n+ * Buffer to hold crypto params required for asym operations.\n+ *\n+ * These buffers can be used for both input to PMD and output from PMD. When\n+ * used for output from PMD, application has to ensure the buffer is large\n+ * enough to hold the target data.\n+ *\n+ * If an operation requires the PMD to generate a random number,\n+ * and the device supports CSRNG, 'data' should be set to NULL.\n+ * The crypto parameter in question will not be used by the PMD,\n+ * as it is internally generated.\n+ */\n+typedef struct rte_crypto_param_t {\n+\tuint8_t *data;\n+\t/**< pointer to buffer holding data */\n+\trte_iova_t iova;\n+\t/**< IO address of data buffer */\n+\tsize_t length;\n+\t/**< length of data in bytes */\n+} rte_crypto_param;\n+\n+/** Unsigned big-integer in big-endian format */\n+typedef rte_crypto_param rte_crypto_uint;\n+\n+/**\n+ * Structure for elliptic curve point\n+ */\n+struct rte_crypto_ec_point {\n+\trte_crypto_param x;\n+\t/**< X coordinate */\n+\trte_crypto_param y;\n+\t/**< Y coordinate */\n+};\n+\n+/**\n * List of elliptic curves. This enum aligns with\n * TLS \"Supported Groups\" registry (previously known as\n * NamedCurve registry). FFDH groups are not, and will not\n@@ -55,46 +89,23 @@ enum rte_crypto_curve_id {\n };\n \n /**\n- * Asymmetric crypto transformation types.\n- * Each xform type maps to one asymmetric algorithm\n- * performing specific operation\n- *\n+ * Asymmetric crypto algorithms\n */\n enum rte_crypto_asym_xform_type {\n-\tRTE_CRYPTO_ASYM_XFORM_UNSPECIFIED = 0,\n+\tRTE_CRYPTO_ASYM_XFORM_UNSPECIFIED,\n \t/**< Invalid xform. */\n-\tRTE_CRYPTO_ASYM_XFORM_NONE,\n-\t/**< Xform type None.\n-\t * May be supported by PMD to support\n-\t * passthrough op for debugging purpose.\n-\t * if xform_type none , op_type is disregarded.\n-\t */\n \tRTE_CRYPTO_ASYM_XFORM_RSA,\n-\t/**< RSA. Performs Encrypt, Decrypt, Sign and Verify.\n-\t * Refer to rte_crypto_asym_op_type\n-\t */\n+\t/**< RSA */\n \tRTE_CRYPTO_ASYM_XFORM_DH,\n-\t/**< Diffie-Hellman.\n-\t * Performs Key Generate and Shared Secret Compute.\n-\t * Refer to rte_crypto_asym_op_type\n-\t */\n+\t/**< Diffie-Hellman */\n \tRTE_CRYPTO_ASYM_XFORM_DSA,\n-\t/**< Digital Signature Algorithm\n-\t * Performs Signature Generation and Verification.\n-\t * Refer to rte_crypto_asym_op_type\n-\t */\n+\t/**< Digital Signature Algorithm */\n \tRTE_CRYPTO_ASYM_XFORM_MODINV,\n-\t/**< Modular Multiplicative Inverse\n-\t * Perform Modular Multiplicative Inverse b^(-1) mod n\n-\t */\n+\t/**< Modular Multiplicative Inverse */\n \tRTE_CRYPTO_ASYM_XFORM_MODEX,\n-\t/**< Modular Exponentiation\n-\t * Perform Modular Exponentiation b^e mod n\n-\t */\n+\t/**< Modular Exponentiation */\n \tRTE_CRYPTO_ASYM_XFORM_ECDSA,\n-\t/**< Elliptic Curve Digital Signature Algorithm\n-\t * Perform Signature Generation and Verification.\n-\t */\n+\t/**< Elliptic Curve Digital Signature Algorithm */\n \tRTE_CRYPTO_ASYM_XFORM_ECPM,\n \t/**< Elliptic Curve Point Multiplication */\n \tRTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END\n@@ -126,11 +137,12 @@ enum rte_crypto_asym_op_type {\n * Padding types for RSA signature.\n */\n enum rte_crypto_rsa_padding_type {\n-\tRTE_CRYPTO_RSA_PADDING_NONE = 0,\n+\tRTE_CRYPTO_RSA_PADDING_NONE,\n \t/**< RSA no padding scheme */\n \tRTE_CRYPTO_RSA_PADDING_PKCS1_5,\n-\t/**< RSA PKCS#1 PKCS1-v1_5 padding scheme. For signatures block type 01,\n-\t * for encryption block type 02 are used.\n+\t/**< RSA PKCS#1 PKCS1-v1_5 padding scheme.\n+\t * For signatures block type 01, for encryption\n+\t * block type 02 are used.\n \t */\n \tRTE_CRYPTO_RSA_PADDING_OAEP,\n \t/**< RSA PKCS#1 OAEP padding scheme */\n@@ -156,40 +168,6 @@ enum rte_crypto_rsa_priv_key_type {\n };\n \n /**\n- * Buffer to hold crypto params required for asym operations.\n- *\n- * These buffers can be used for both input to PMD and output from PMD. When\n- * used for output from PMD, application has to ensure the buffer is large\n- * enough to hold the target data.\n- *\n- * If an operation requires the PMD to generate a random number,\n- * and the device supports CSRNG, 'data' should be set to NULL.\n- * The crypto parameter in question will not be used by the PMD,\n- * as it is internally generated.\n- */\n-typedef struct rte_crypto_param_t {\n-\tuint8_t *data;\n-\t/**< pointer to buffer holding data */\n-\trte_iova_t iova;\n-\t/**< IO address of data buffer */\n-\tsize_t length;\n-\t/**< length of data in bytes */\n-} rte_crypto_param;\n-\n-/** Unsigned big-integer in big-endian format */\n-typedef rte_crypto_param rte_crypto_uint;\n-\n-/**\n- * Structure for elliptic curve point\n- */\n-struct rte_crypto_ec_point {\n-\trte_crypto_param x;\n-\t/**< X coordinate */\n-\trte_crypto_param y;\n-\t/**< Y coordinate */\n-};\n-\n-/**\n * Structure describing RSA private key in quintuple format.\n * See PKCS V1.5 RSA Cryptography Standard.\n */\ndiff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c\nindex e16e6802aa..691625bd04 100644\n--- a/lib/cryptodev/rte_cryptodev.c\n+++ b/lib/cryptodev/rte_cryptodev.c\n@@ -160,7 +160,6 @@ rte_crypto_aead_operation_strings[] = {\n * Asymmetric crypto transform operation strings identifiers.\n */\n const char *rte_crypto_asym_xform_strings[] = {\n-\t[RTE_CRYPTO_ASYM_XFORM_NONE]\t= \"none\",\n \t[RTE_CRYPTO_ASYM_XFORM_RSA]\t= \"rsa\",\n \t[RTE_CRYPTO_ASYM_XFORM_MODEX]\t= \"modexp\",\n \t[RTE_CRYPTO_ASYM_XFORM_MODINV]\t= \"modinv\",\n", "prefixes": [ "v2", "02/14" ] }