Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111825/?format=api
{ "id": 111825, "url": "http://patches.dpdk.org/api/patches/111825/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220525155324.9288-2-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220525155324.9288-2-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220525155324.9288-2-arkadiuszx.kusztal@intel.com", "date": "2022-05-25T15:53:11", "name": "[v2,01/14] cryptodev: redefine ec group enum", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d1b280b7e0f4ebcfd4f74460a13b33386585c2b1", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220525155324.9288-2-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 23159, "url": "http://patches.dpdk.org/api/series/23159/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23159", "date": "2022-05-25T15:53:10", "name": "cryptodev: rsa, dh, ecdh changes", "version": 2, "mbox": "http://patches.dpdk.org/series/23159/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111825/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/111825/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 19013A0555;\n\tWed, 25 May 2022 19:03:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 087D040C35;\n\tWed, 25 May 2022 19:03:13 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id CA6A64067B\n for <dev@dpdk.org>; Wed, 25 May 2022 19:03:11 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 May 2022 10:01:09 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by FMSMGA003.fm.intel.com with ESMTP; 25 May 2022 10:01:08 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653498192; x=1685034192;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=fOFPYWUQAp8oRmzJKvjqAEOhn0i6PCNKINyWaBYnjhg=;\n b=MJ9gx78/U6kSbazl+3o2QHQMFP4IzAAcvEi/PXLHHZ/bFGjKnQO8Bdob\n 7r280Y9eBBl8FzG/fS9UlBoUiTFY+EV8LH9LBC0NPCeDG7mJTwHRmlry5\n tWep+PXYEJzyDnQFmVdvMkLSLz8GPL50OGF+3eX6dOGlHgrIp8aGySE4c\n iTiG5/5F9xchrdvmzLo2ZeARSHu0/ZLqXOsSAgT0DNhTwYVbsrF7/M2Ga\n P72HKhd1fIHzP+5DDG1T0axC+xWKy3Cyv1gnusFqesf8AXUXhWraTno64\n r6iULaFB/aDf5vOlG2qJKxuusjtzN3LTq8n4/a62LKEbhKA7kBau0jfEW w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10358\"; a=\"273596028\"", "E=Sophos;i=\"5.91,250,1647327600\"; d=\"scan'208\";a=\"273596028\"", "E=Sophos;i=\"5.91,250,1647327600\"; d=\"scan'208\";a=\"664502271\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Subject": "[PATCH v2 01/14] cryptodev: redefine ec group enum", "Date": "Wed, 25 May 2022 16:53:11 +0100", "Message-Id": "<20220525155324.9288-2-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20220525155324.9288-1-arkadiuszx.kusztal@intel.com>", "References": "<20220525155324.9288-1-arkadiuszx.kusztal@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- EC enum was renamed to rte_crypto_curve_id.\nElliptic curve enum name was incorrectly associated\nwith group (it comes from current tls registry name).\n- Clarified comments about TLS deprecation.\nSome curves included are deprecated with TLS 1.3.\nComments to address it were added.\n- Clarified FFDH groups usage.\nElliptic curves IDs in TLS are placed in the same registry\nas FFDH. Cryptodev does not assign specific groups, and\nif specific groups would be assigned by DPDK, it cannot be\nTLS SupportedGroups registry, as it would conflict with\nother protocols like IPSec.\n- Added IANA reference.\nOnly few selected curves are included in previously\nreferenced rfc8422. IANA reference is added instead.\n- Removed UNKNOWN ec group.\nThere is no default value, and there is no UNKNOWN\nelliptic curve.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n lib/cryptodev/rte_crypto_asym.h | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h\nindex cd24d4b07b..7206652458 100644\n--- a/lib/cryptodev/rte_crypto_asym.h\n+++ b/lib/cryptodev/rte_crypto_asym.h\n@@ -38,16 +38,20 @@ extern const char *\n rte_crypto_asym_op_strings[];\n \n /**\n- * TLS named curves\n- * https://tools.ietf.org/html/rfc8422\n+ * List of elliptic curves. This enum aligns with\n+ * TLS \"Supported Groups\" registry (previously known as\n+ * NamedCurve registry). FFDH groups are not, and will not\n+ * be included in this list.\n+ * Deprecation for selected curve in tls does not deprecate\n+ * the selected curve in Cryptodev.\n+ * https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml\n */\n-enum rte_crypto_ec_group {\n-\tRTE_CRYPTO_EC_GROUP_UNKNOWN = 0,\n+enum rte_crypto_curve_id {\n \tRTE_CRYPTO_EC_GROUP_SECP192R1 = 19,\n \tRTE_CRYPTO_EC_GROUP_SECP224R1 = 21,\n \tRTE_CRYPTO_EC_GROUP_SECP256R1 = 23,\n \tRTE_CRYPTO_EC_GROUP_SECP384R1 = 24,\n-\tRTE_CRYPTO_EC_GROUP_SECP521R1 = 25,\n+\tRTE_CRYPTO_EC_GROUP_SECP521R1 = 25\n };\n \n /**\n@@ -294,7 +298,7 @@ struct rte_crypto_dsa_xform {\n *\n */\n struct rte_crypto_ec_xform {\n-\tenum rte_crypto_ec_group curve_id;\n+\tenum rte_crypto_curve_id curve_id;\n \t/**< Pre-defined ec groups */\n };\n \n", "prefixes": [ "v2", "01/14" ] }