Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/11171/?format=api
{ "id": 11171, "url": "http://patches.dpdk.org/api/patches/11171/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1457424877-26234-7-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1457424877-26234-7-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1457424877-26234-7-git-send-email-helin.zhang@intel.com", "date": "2016-03-08T08:14:14", "name": "[dpdk-dev,v5,06/29] i40e/base: fix missing check for stopped admin queue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c362e849c2ff476b4e815b66c85db9076de26567", "submitter": { "id": 14, "url": "http://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": { "id": 10, "url": "http://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1457424877-26234-7-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/11171/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/11171/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id BA771475D;\n\tTue, 8 Mar 2016 09:15:04 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id E23482C6B\n\tfor <dev@dpdk.org>; Tue, 8 Mar 2016 09:15:01 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP; 08 Mar 2016 00:15:01 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga004.fm.intel.com with ESMTP; 08 Mar 2016 00:14:59 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u288EtwH008366;\n\tTue, 8 Mar 2016 16:14:55 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u288EqMN026524; Tue, 8 Mar 2016 16:14:54 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u288EqLK026520; \n\tTue, 8 Mar 2016 16:14:52 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.22,556,1449561600\"; d=\"scan'208\";a=\"61904414\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 8 Mar 2016 16:14:14 +0800", "Message-Id": "<1457424877-26234-7-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1457424877-26234-1-git-send-email-helin.zhang@intel.com>", "References": "<1457278919-30800-1-git-send-email-helin.zhang@intel.com>\n\t<1457424877-26234-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 06/29] i40e/base: fix missing check for\n\tstopped admin queue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It's possible that while waiting for the spinlock, another\nentity (that owns the spinlock) has shut down the admin queue.\nIf it then attempts to use the queue, it will panic.\nIt adds a check for this condition on the receive side. This\nmatches an existing check on the send queue side.\n\nFixes: 8db9e2a1b232 (\"i40e: base driver\")\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\nAcked-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n drivers/net/i40e/base/i40e_adminq.c | 8 ++++++++\n 1 file changed, 8 insertions(+)\n\nv4:\n - Reworded the commit logs.", "diff": "diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c\nindex 998582c..e1a162e 100644\n--- a/drivers/net/i40e/base/i40e_adminq.c\n+++ b/drivers/net/i40e/base/i40e_adminq.c\n@@ -1035,6 +1035,13 @@ enum i40e_status_code i40e_clean_arq_element(struct i40e_hw *hw,\n \t/* take the lock before we start messing with the ring */\n \ti40e_acquire_spinlock(&hw->aq.arq_spinlock);\n \n+\tif (hw->aq.arq.count == 0) {\n+\t\ti40e_debug(hw, I40E_DEBUG_AQ_MESSAGE,\n+\t\t\t \"AQRX: Admin queue not initialized.\\n\");\n+\t\tret_code = I40E_ERR_QUEUE_EMPTY;\n+\t\tgoto clean_arq_element_err;\n+\t}\n+\n \t/* set next_to_use to head */\n #ifdef PF_DRIVER\n #ifdef INTEGRATED_VF\n@@ -1113,6 +1120,7 @@ clean_arq_element_out:\n \t/* Set pending if needed, unlock and return */\n \tif (pending != NULL)\n \t\t*pending = (ntc > ntu ? hw->aq.arq.count : 0) + (ntu - ntc);\n+clean_arq_element_err:\n \ti40e_release_spinlock(&hw->aq.arq_spinlock);\n \n #ifdef PF_DRIVER\n", "prefixes": [ "dpdk-dev", "v5", "06/29" ] }