Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111620/?format=api
{ "id": 111620, "url": "http://patches.dpdk.org/api/patches/111620/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1653298524-232138-14-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1653298524-232138-14-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1653298524-232138-14-git-send-email-andy.pei@intel.com", "date": "2022-05-23T09:35:24", "name": "[v9,13/13] vdpa/ifc/base: access correct register for blk device", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b8989c7321b205a6b92f77125ba47e6c1357bd0a", "submitter": { "id": 1185, "url": "http://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1653298524-232138-14-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 23091, "url": "http://patches.dpdk.org/api/series/23091/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23091", "date": "2022-05-23T09:35:11", "name": "add virtio_blk device support to vdpa/ifc", "version": 9, "mbox": "http://patches.dpdk.org/series/23091/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111620/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/111620/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B5BFEA04FD;\n\tMon, 23 May 2022 12:23:51 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B731F42B94;\n\tMon, 23 May 2022 12:23:05 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id A30F242B93\n for <dev@dpdk.org>; Mon, 23 May 2022 12:23:04 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 May 2022 03:23:04 -0700", "from dpdk-dipei.sh.intel.com ([10.67.110.238])\n by orsmga006.jf.intel.com with ESMTP; 23 May 2022 03:23:02 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653301384; x=1684837384;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=7XyHxRdg3k3dWPi/bG+6PK7dnWbMDBPcqJF3TqK7BFY=;\n b=kJR4poR+C8owDNIPxvPA0LFcaLi8WIshO47bkjKgIROvaQxxfVPvR+vj\n w/MsRJkgvveBnA2rCsakpqNEMcO6NuF7XEW/4/1AEzxk40yEKPUDuo9Cq\n ezNDSabaN2zYpdoz3Q6X6cDyI7sAlrRHT7wkHbVWRrRG9xQ11b5u774tv\n 6fCPTuc/IhsKnV27le2NDfFJZY+yeA0QFMv2asD7JxOj2ieZu6FV6AD/3\n sX5Ok1xgThlDv6GamBTx4L+ko9O7gws0mHQy1McU+yPRmngp/Ib2Vvviw\n wcBKU2SA1HnHcGRIHSr8fn3VixOUm2sjBPDYAmKkMEs3pRZNjk7gEN3RT w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10355\"; a=\"255239410\"", "E=Sophos;i=\"5.91,246,1647327600\"; d=\"scan'208\";a=\"255239410\"", "E=Sophos;i=\"5.91,246,1647327600\"; d=\"scan'208\";a=\"547889566\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, maxime.coquelin@redhat.com, gang.cao@intel.com,\n changpeng.liu@intel.com, rosen.xu@intel.com, qimaix.xiao@intel.com", "Subject": "[PATCH v9 13/13] vdpa/ifc/base: access correct register for blk\n device", "Date": "Mon, 23 May 2022 17:35:24 +0800", "Message-Id": "<1653298524-232138-14-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1653298524-232138-1-git-send-email-andy.pei@intel.com>", "References": "<1643093258-47258-2-git-send-email-andy.pei@intel.com>\n <1653298524-232138-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Register address is different between net and blk device.\nWe are re-useing most of the code, when register address is\ndifferent, we have to check net and blk device go through\ndifferent code.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n drivers/vdpa/ifc/base/ifcvf.c | 34 +++++++++++++++++++++++++++-------\n 1 file changed, 27 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c\nindex d10c1fd..dd475a7 100644\n--- a/drivers/vdpa/ifc/base/ifcvf.c\n+++ b/drivers/vdpa/ifc/base/ifcvf.c\n@@ -218,10 +218,17 @@\n \t\t\t\t&cfg->queue_used_hi);\n \t\tIFCVF_WRITE_REG16(hw->vring[i].size, &cfg->queue_size);\n \n-\t\t*(u32 *)(lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n-\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE + (i % 2) * 4) =\n-\t\t\t(u32)hw->vring[i].last_avail_idx |\n-\t\t\t((u32)hw->vring[i].last_used_idx << 16);\n+\t\tif (hw->device_type == IFCVF_BLK)\n+\t\t\t*(u32 *)(lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\ti * IFCVF_LM_CFG_SIZE) =\n+\t\t\t\t(u32)hw->vring[i].last_avail_idx |\n+\t\t\t\t((u32)hw->vring[i].last_used_idx << 16);\n+\t\telse\n+\t\t\t*(u32 *)(lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE +\n+\t\t\t\t(i % 2) * 4) =\n+\t\t\t\t(u32)hw->vring[i].last_avail_idx |\n+\t\t\t\t((u32)hw->vring[i].last_used_idx << 16);\n \n \t\tIFCVF_WRITE_REG16(i + 1, &cfg->queue_msix_vector);\n \t\tif (IFCVF_READ_REG16(&cfg->queue_msix_vector) ==\n@@ -254,9 +261,22 @@\n \t\tIFCVF_WRITE_REG16(i, &cfg->queue_select);\n \t\tIFCVF_WRITE_REG16(0, &cfg->queue_enable);\n \t\tIFCVF_WRITE_REG16(IFCVF_MSI_NO_VECTOR, &cfg->queue_msix_vector);\n-\t\tring_state = *(u32 *)(hw->lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n-\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE + (i % 2) * 4);\n-\t\thw->vring[i].last_avail_idx = (u16)(ring_state >> 16);\n+\n+\t\tif (hw->device_type == IFCVF_BLK)\n+\t\t\tring_state = *(u32 *)(hw->lm_cfg +\n+\t\t\t\t\tIFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\t\ti * IFCVF_LM_CFG_SIZE);\n+\t\telse\n+\t\t\tring_state = *(u32 *)(hw->lm_cfg +\n+\t\t\t\t\tIFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE +\n+\t\t\t\t\t(i % 2) * 4);\n+\n+\t\tif (hw->device_type == IFCVF_BLK)\n+\t\t\thw->vring[i].last_avail_idx =\n+\t\t\t\t(u16)(ring_state & IFCVF_16_BIT_MASK);\n+\t\telse\n+\t\t\thw->vring[i].last_avail_idx = (u16)(ring_state >> 16);\n \t\thw->vring[i].last_used_idx = (u16)(ring_state >> 16);\n \t}\n }\n", "prefixes": [ "v9", "13/13" ] }