Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 111520,
    "url": "http://patches.dpdk.org/api/patches/111520/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-37-arkadiuszx.kusztal@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220520055445.40063-37-arkadiuszx.kusztal@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220520055445.40063-37-arkadiuszx.kusztal@intel.com",
    "date": "2022-05-20T05:54:41",
    "name": "[36/40] test/crypto: reduce rsa struct to only necessary fields",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "a70a19db1ee724aa334343f16f2797a95bc0b12f",
    "submitter": {
        "id": 452,
        "url": "http://patches.dpdk.org/api/people/452/?format=api",
        "name": "Arkadiusz Kusztal",
        "email": "arkadiuszx.kusztal@intel.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-37-arkadiuszx.kusztal@intel.com/mbox/",
    "series": [
        {
            "id": 23057,
            "url": "http://patches.dpdk.org/api/series/23057/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23057",
            "date": "2022-05-20T05:54:05",
            "name": "cryptodev: rsa, dh, ecdh changes",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/23057/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/111520/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/111520/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EDB79A0503;\n\tFri, 20 May 2022 09:06:14 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4708842C02;\n\tFri, 20 May 2022 09:04:04 +0200 (CEST)",
            "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 03F7F42BD8\n for <dev@dpdk.org>; Fri, 20 May 2022 09:04:01 +0200 (CEST)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 May 2022 00:04:01 -0700",
            "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by orsmga008.jf.intel.com with ESMTP; 20 May 2022 00:04:00 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653030242; x=1684566242;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=BWMQDclO1xYjo/t5brVu+JLOaPGxEGjs5n+xhQwz9cQ=;\n b=QEnYRv0gjO8y9S54zLFhlF0SnszsXL+7uItdafv2PaPhh79RjOqnWv6V\n F9IgK3jyGNKWy/2irNiiqeDJiSWNB5Whn0fmS1elXURTZ2GGhYdQ/cmhE\n nlbnCTcn3nMmpcWF/W3N+to5PWv3ajz817ADaTzASOGitQOjS/uB6MCli\n VGEYnEDlZiR5yOiAappj3chmKqEJpnR1DKnRrxy/W2LcQ9NbABflMmDfv\n jRtjJ6mn2mjv05/UDVDoRdS157CAdLbyxZMc/bbL1S9KiSiuybUIVsvxZ\n i77tAf5yUF2YkjfZSMpQGAHam2XKzxiOdS9ZTZApi4FX7KWkBB+rgqLP1 Q==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6400,9594,10352\"; a=\"333140505\"",
            "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"333140505\"",
            "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"599058638\""
        ],
        "X-ExtLoop1": "1",
        "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "gakhil@marvell.com, anoobj@marvell.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>",
        "Subject": "[PATCH 36/40] test/crypto: reduce rsa struct to only necessary fields",
        "Date": "Fri, 20 May 2022 06:54:41 +0100",
        "Message-Id": "<20220520055445.40063-37-arkadiuszx.kusztal@intel.com>",
        "X-Mailer": "git-send-email 2.13.6",
        "In-Reply-To": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>",
        "References": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "- reduced rsa struct to only necessary fields.\nThis commit reflects changes to the asymmetric crypto API.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n app/test/test_cryptodev_asym.c | 80 +++++++++++++++++++++++-------------------\n 1 file changed, 43 insertions(+), 37 deletions(-)",
    "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex eca0612815..ed86eaf8ba 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -90,14 +90,14 @@ queue_ops_rsa_sign_verify(void *sess)\n \t/* Compute sign on the test vector */\n \tasym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_SIGN;\n \n-\tasym_op->rsa.message.data = rsaplaintext.data;\n-\tasym_op->rsa.message.length = rsaplaintext.len;\n-\tasym_op->rsa.sign.length = 0;\n-\tasym_op->rsa.sign.data = output_buf;\n+\tasym_op->rsa.input.data = rsaplaintext.data;\n+\tasym_op->rsa.input.length = rsaplaintext.len;\n+\tasym_op->rsa.output.length = 0;\n+\tasym_op->rsa.output.data = output_buf;\n \tasym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;\n \n-\tdebug_hexdump(stdout, \"message\", asym_op->rsa.message.data,\n-\t\t      asym_op->rsa.message.length);\n+\tdebug_hexdump(stdout, \"message\", asym_op->rsa.input.data,\n+\t\t      asym_op->rsa.input.length);\n \n \t/* Attach asymmetric crypto session to crypto operations */\n \trte_crypto_op_attach_asym_session(op, sess);\n@@ -120,13 +120,17 @@ queue_ops_rsa_sign_verify(void *sess)\n \t\tgoto error_exit;\n \t}\n \n-\tdebug_hexdump(stdout, \"signed message\", asym_op->rsa.sign.data,\n-\t\t      asym_op->rsa.sign.length);\n+\tdebug_hexdump(stdout, \"signed message\", asym_op->rsa.output.data,\n+\t\t      asym_op->rsa.output.length);\n \tasym_op = result_op->asym;\n \n \t/* Verify sign */\n \tasym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_VERIFY;\n \tasym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;\n+\tasym_op->rsa.input.data = output_buf;\n+\tasym_op->rsa.input.length = asym_op->rsa.output.length;\n+\tasym_op->rsa.message.data = rsaplaintext.data;\n+\tasym_op->rsa.message.length = rsaplaintext.len;\n \n \t/* Process crypto operation */\n \tif (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) != 1) {\n@@ -181,14 +185,14 @@ queue_ops_rsa_enc_dec(void *sess)\n \t/* Compute encryption on the test vector */\n \tasym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_ENCRYPT;\n \n-\tasym_op->rsa.message.data = rsaplaintext.data;\n-\tasym_op->rsa.cipher.data = cipher_buf;\n-\tasym_op->rsa.cipher.length = 0;\n-\tasym_op->rsa.message.length = rsaplaintext.len;\n+\tasym_op->rsa.input.data = rsaplaintext.data;\n+\tasym_op->rsa.output.data = cipher_buf;\n+\tasym_op->rsa.output.length = 0;\n+\tasym_op->rsa.input.length = rsaplaintext.len;\n \tasym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;\n \n-\tdebug_hexdump(stdout, \"message\", asym_op->rsa.message.data,\n-\t\t      asym_op->rsa.message.length);\n+\tdebug_hexdump(stdout, \"message\", asym_op->rsa.input.data,\n+\t\t      asym_op->rsa.input.length);\n \n \t/* Attach asymmetric crypto session to crypto operations */\n \trte_crypto_op_attach_asym_session(op, sess);\n@@ -210,14 +214,16 @@ queue_ops_rsa_enc_dec(void *sess)\n \t\tstatus = TEST_FAILED;\n \t\tgoto error_exit;\n \t}\n-\tdebug_hexdump(stdout, \"encrypted message\", asym_op->rsa.message.data,\n-\t\t      asym_op->rsa.message.length);\n+\tdebug_hexdump(stdout, \"encrypted message\", asym_op->rsa.output.data,\n+\t\t      asym_op->rsa.output.length);\n \n \t/* Use the resulted output as decryption Input vector*/\n \tasym_op = result_op->asym;\n-\tasym_op->rsa.message.length = 0;\n+\tasym_op->rsa.output.length = 0;\n \tasym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_DECRYPT;\n \tasym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;\n+\trte_memcpy(asym_op->rsa.input.data, asym_op->rsa.output.data,\n+\t\tasym_op->rsa.input.length);\n \n \t/* Process crypto operation */\n \tif (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) != 1) {\n@@ -270,20 +276,20 @@ test_cryptodev_asym_ver(struct rte_crypto_op *op,\n \tcase RTE_CRYPTO_ASYM_XFORM_RSA:\n \t\tif (op->asym->rsa.op_type == RTE_CRYPTO_ASYM_OP_ENCRYPT) {\n \t\t\tdata_size = xform_tc->rsa.n.length;\n-\t\t\tdata_received = result_op->asym->rsa.cipher.data;\n+\t\t\tdata_received = result_op->asym->rsa.output.data;\n \t\t\tdata_expected = data_tc->rsa_data.ct.data;\n \t\t} else if (op->asym->rsa.op_type == RTE_CRYPTO_ASYM_OP_DECRYPT) {\n \t\t\tdata_size = xform_tc->rsa.n.length;\n \t\t\tdata_expected = data_tc->rsa_data.pt.data;\n-\t\t\tdata_received = result_op->asym->rsa.message.data;\n+\t\t\tdata_received = result_op->asym->rsa.output.data;\n \t\t} else if (op->asym->rsa.op_type == RTE_CRYPTO_ASYM_OP_SIGN) {\n \t\t\tdata_size = xform_tc->rsa.n.length;\n \t\t\tdata_expected = data_tc->rsa_data.sign.data;\n-\t\t\tdata_received = result_op->asym->rsa.sign.data;\n+\t\t\tdata_received = result_op->asym->rsa.output.data;\n \t\t} else if (op->asym->rsa.op_type == RTE_CRYPTO_ASYM_OP_VERIFY) {\n \t\t\tdata_size = xform_tc->rsa.n.length;\n \t\t\tdata_expected = data_tc->rsa_data.pt.data;\n-\t\t\tdata_received = result_op->asym->rsa.cipher.data;\n+\t\t\tdata_received = result_op->asym->rsa.output.data;\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_XFORM_DH:\n@@ -415,25 +421,25 @@ test_cryptodev_asym_op(struct crypto_testsuite_params_asym *ts_params,\n \t\top->asym->rsa.padding.type = data_tc->rsa_data.padding;\n \n \t\tif (op->asym->rsa.op_type == RTE_CRYPTO_ASYM_OP_ENCRYPT) {\n-\t\t\tasym_op->rsa.message.data = data_tc->rsa_data.pt.data;\n-\t\t\tasym_op->rsa.message.length = data_tc->rsa_data.pt.len;\n-\t\t\tasym_op->rsa.cipher.data = result;\n-\t\t\tasym_op->rsa.cipher.length = data_tc->rsa_data.n.len;\n+\t\t\tasym_op->rsa.input.data = data_tc->rsa_data.pt.data;\n+\t\t\tasym_op->rsa.input.length = data_tc->rsa_data.pt.len;\n+\t\t\tasym_op->rsa.output.data = result;\n+\t\t\tasym_op->rsa.output.length = data_tc->rsa_data.n.len;\n \t\t} else if (op->asym->rsa.op_type == RTE_CRYPTO_ASYM_OP_DECRYPT) {\n-\t\t\tasym_op->rsa.message.data = result;\n-\t\t\tasym_op->rsa.message.length = data_tc->rsa_data.n.len;\n-\t\t\tasym_op->rsa.cipher.data = data_tc->rsa_data.ct.data;\n-\t\t\tasym_op->rsa.cipher.length = data_tc->rsa_data.ct.len;\n+\t\t\tasym_op->rsa.output.data = result;\n+\t\t\tasym_op->rsa.output.length = data_tc->rsa_data.n.len;\n+\t\t\tasym_op->rsa.input.data = data_tc->rsa_data.ct.data;\n+\t\t\tasym_op->rsa.input.length = data_tc->rsa_data.ct.len;\n \t\t} else if (op->asym->rsa.op_type == RTE_CRYPTO_ASYM_OP_SIGN) {\n-\t\t\tasym_op->rsa.sign.data = result;\n-\t\t\tasym_op->rsa.sign.length = data_tc->rsa_data.n.len;\n-\t\t\tasym_op->rsa.message.data = data_tc->rsa_data.pt.data;\n-\t\t\tasym_op->rsa.message.length = data_tc->rsa_data.pt.len;\n+\t\t\tasym_op->rsa.output.data = result;\n+\t\t\tasym_op->rsa.output.length = data_tc->rsa_data.n.len;\n+\t\t\tasym_op->rsa.input.data = data_tc->rsa_data.pt.data;\n+\t\t\tasym_op->rsa.input.length = data_tc->rsa_data.pt.len;\n \t\t} else if (op->asym->rsa.op_type == RTE_CRYPTO_ASYM_OP_VERIFY) {\n-\t\t\tasym_op->rsa.cipher.data = result;\n-\t\t\tasym_op->rsa.cipher.length = data_tc->rsa_data.n.len;\n-\t\t\tasym_op->rsa.sign.data = data_tc->rsa_data.sign.data;\n-\t\t\tasym_op->rsa.sign.length = data_tc->rsa_data.sign.len;\n+\t\t\tasym_op->rsa.message.data = result;\n+\t\t\tasym_op->rsa.message.length = data_tc->rsa_data.n.len;\n+\t\t\tasym_op->rsa.input.data = data_tc->rsa_data.sign.data;\n+\t\t\tasym_op->rsa.input.length = data_tc->rsa_data.sign.len;\n \t\t}\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_XFORM_DH:\n",
    "prefixes": [
        "36/40"
    ]
}