Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111500/?format=api
{ "id": 111500, "url": "http://patches.dpdk.org/api/patches/111500/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-17-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220520055445.40063-17-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220520055445.40063-17-arkadiuszx.kusztal@intel.com", "date": "2022-05-20T05:54:21", "name": "[16/40] cryptodev: move dh type from xform to dh op", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "246c3fa96afcfded295b2f0e2c09aeac9774598b", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220520055445.40063-17-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 23057, "url": "http://patches.dpdk.org/api/series/23057/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=23057", "date": "2022-05-20T05:54:05", "name": "cryptodev: rsa, dh, ecdh changes", "version": 1, "mbox": "http://patches.dpdk.org/series/23057/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111500/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/111500/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D6E3A0503;\n\tFri, 20 May 2022 09:04:14 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ECC8F42BC0;\n\tFri, 20 May 2022 09:03:13 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 7EFAA42BB9\n for <dev@dpdk.org>; Fri, 20 May 2022 09:03:12 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 May 2022 00:03:11 -0700", "from silpixa00399302.ir.intel.com ([10.237.214.136])\n by orsmga008.jf.intel.com with ESMTP; 20 May 2022 00:03:10 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653030192; x=1684566192;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=cTIbmLoX/Wzg1mra/WLVKXThIVmpz3P4IKpEw5glTVs=;\n b=YHfYUux6IEAUIQijY8RazBfKVryCkmdFRkmehFJsnMO9/ccRWbr7g7Pg\n y2lRBTpxIVhHLsY7AAG6ptjp71OVHmHQVhyhqWSJuppmsdcySWHbfexAK\n kfcCsbKn9GWrtp6SHBaRqgFp0dFdqcgVQHqKrMm/F+kufJ2OioiJwRwaF\n NuyXkaa+9hHa/xGPmpmwB+DoWnYUIzCuTmI7dRrEhKfhTHNeyoK4JrnMu\n fcs5CLrXXeHdd1Yd6H7EJKnD2w7OBhzkkXGI55EFBb5TPz7FDbdhfEJB6\n ymbCCfFeJ+VEUeIqUcqoz/F2bimoPgoAAxK5Tfxf1P6oNK7MRcaBzep/d Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10352\"; a=\"333140349\"", "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"333140349\"", "E=Sophos;i=\"5.91,238,1647327600\"; d=\"scan'208\";a=\"599058306\"" ], "X-ExtLoop1": "1", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "gakhil@marvell.com, anoobj@marvell.com, roy.fan.zhang@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Subject": "[PATCH 16/40] cryptodev: move dh type from xform to dh op", "Date": "Fri, 20 May 2022 06:54:21 +0100", "Message-Id": "<20220520055445.40063-17-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>", "References": "<20220520055445.40063-1-arkadiuszx.kusztal@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Moved dh operation type to dh operation struct.\nOperation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should\nbe free to choose for any operation. One xform/session should\nbe enough to perform both DH operations, if op_type would be xform\nmember, session would have to be to be created twice for the same\ngroup. Similar problem would be observed in sessionless case.\nAdditionally, it will help extend DH to support Elliptic Curves.\n\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n lib/cryptodev/rte_crypto_asym.h | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h\nindex b355cbe5fa..728a98f02e 100644\n--- a/lib/cryptodev/rte_crypto_asym.h\n+++ b/lib/cryptodev/rte_crypto_asym.h\n@@ -250,8 +250,6 @@ struct rte_crypto_modinv_xform {\n *\n */\n struct rte_crypto_dh_xform {\n-\tenum rte_crypto_asym_ke_type type;\n-\t/**< Setup xform for key generate or shared secret compute */\n \trte_crypto_uint p;\n \t/**< Prime modulus data */\n \trte_crypto_uint g;\n@@ -379,27 +377,29 @@ struct rte_crypto_rsa_op_param {\n * @note:\n */\n struct rte_crypto_dh_op_param {\n+\tenum rte_crypto_asym_ke_type op_type;\n+\t/**< Key exchange operation type */\n \trte_crypto_uint pub_key;\n \t/**<\n-\t * Output generated public key when xform type is\n+\t * Output generated public key when op_type is\n \t * DH PUB_KEY_GENERATION.\n-\t * Input peer public key when xform type is DH\n+\t * Input peer public key when op_type is DH\n \t * SHARED_SECRET_COMPUTATION\n \t *\n \t */\n \n \trte_crypto_uint priv_key;\n \t/**<\n-\t * Output generated private key if xform type is\n+\t * Output generated private key when op_type is\n \t * DH PRIVATE_KEY_GENERATION\n-\t * Input when xform type is DH SHARED_SECRET_COMPUTATION.\n+\t * Input when op_type is DH SHARED_SECRET_COMPUTATION.\n \t *\n \t */\n \n \trte_crypto_uint shared_secret;\n \t/**<\n \t * Output with calculated shared secret\n-\t * when dh xform set up with op type = SHARED_SECRET_COMPUTATION.\n+\t * when op type is SHARED_SECRET_COMPUTATION.\n \t *\n \t */\n };\n", "prefixes": [ "16/40" ] }