Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111097/?format=api
{ "id": 111097, "url": "http://patches.dpdk.org/api/patches/111097/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220513025357.52275-5-fengchengwen@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220513025357.52275-5-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220513025357.52275-5-fengchengwen@huawei.com", "date": "2022-05-13T02:53:52", "name": "[v4,4/9] net/ipn3ke: adjust return value of xstats-get ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "03d579b9ed74bd6816d9923f14029c015f3a2f3a", "submitter": { "id": 2146, "url": "http://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220513025357.52275-5-fengchengwen@huawei.com/mbox/", "series": [ { "id": 22920, "url": "http://patches.dpdk.org/api/series/22920/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22920", "date": "2022-05-13T02:53:48", "name": "bugfix for ethdev telemetry", "version": 4, "mbox": "http://patches.dpdk.org/series/22920/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111097/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/111097/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 42CB9A00C3;\n\tFri, 13 May 2022 05:00:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 596554283F;\n\tFri, 13 May 2022 04:59:58 +0200 (CEST)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id E05DD42830\n for <dev@dpdk.org>; Fri, 13 May 2022 04:59:53 +0200 (CEST)", "from dggpeml500024.china.huawei.com (unknown [172.30.72.55])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KztY30ZZBzCsW2;\n Fri, 13 May 2022 10:55:03 +0800 (CST)", "from localhost.localdomain (10.67.165.24) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.24; Fri, 13 May 2022 10:59:52 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@xilinx.com>,\n <andrew.rybchenko@oktetlabs.ru>, <ndabilpuram@marvell.com>,\n <kirankumark@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>", "CC": "<mb@smartsharesystems.com>, <stephen@networkplumber.org>, <dev@dpdk.org>", "Subject": "[PATCH v4 4/9] net/ipn3ke: adjust return value of xstats-get ops", "Date": "Fri, 13 May 2022 10:53:52 +0800", "Message-ID": "<20220513025357.52275-5-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20220513025357.52275-1-fengchengwen@huawei.com>", "References": "<20220416010747.40714-1-fengchengwen@huawei.com>\n <20220513025357.52275-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.24]", "X-ClientProxiedBy": "dggems702-chm.china.huawei.com (10.3.19.179) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Many user (e.g. telemetry) invokes rte_eth_xstats_get(port_id, NULL, 0)\nto retrieve the required number of elements, but currently ipn3ke PMD\nreturns zero when xstats is NULL.\n\nIn the previous patch, the framework defines that the required number\nof entries should be returned when xstats is NULL and n is zero. And\nxstats is NULL if and only if n is zero.\n\nBased on the preceding constraints, this patch removes the logic of\n\"return zero when xstats is NULL\".\n\nFixes: 5a6d883878db (\"net/ipn3ke: implement statistics\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/ipn3ke/ipn3ke_representor.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c\nindex c9dde1d82e..abbecfdf2e 100644\n--- a/drivers/net/ipn3ke/ipn3ke_representor.c\n+++ b/drivers/net/ipn3ke/ipn3ke_representor.c\n@@ -2218,9 +2218,6 @@ ipn3ke_rpst_xstats_get\n \tstruct ipn3ke_rpst_hw_port_stats hw_stats;\n \tstruct rte_eth_stats stats;\n \n-\tif (!xstats)\n-\t\treturn 0;\n-\n \tif (!ethdev) {\n \t\tIPN3KE_AFU_PMD_ERR(\"ethernet device to get statistics is NULL\");\n \t\treturn -EINVAL;\n", "prefixes": [ "v4", "4/9" ] }