Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111035/?format=api
{ "id": 111035, "url": "http://patches.dpdk.org/api/patches/111035/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220511163310.50892-1-heinrich.schuchardt@canonical.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220511163310.50892-1-heinrich.schuchardt@canonical.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220511163310.50892-1-heinrich.schuchardt@canonical.com", "date": "2022-05-11T16:33:10", "name": "[1/1] test/pmd_perf: handling of unknown connection speed", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "92bf83c60ebc76c8c1390baa6b7e576ac8ee67b0", "submitter": { "id": 2687, "url": "http://patches.dpdk.org/api/people/2687/?format=api", "name": "Heinrich Schuchardt", "email": "heinrich.schuchardt@canonical.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220511163310.50892-1-heinrich.schuchardt@canonical.com/mbox/", "series": [ { "id": 22897, "url": "http://patches.dpdk.org/api/series/22897/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22897", "date": "2022-05-11T16:33:10", "name": "[1/1] test/pmd_perf: handling of unknown connection speed", "version": 1, "mbox": "http://patches.dpdk.org/series/22897/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/111035/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/111035/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A35D2A0032;\n\tWed, 11 May 2022 18:33:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 46EE8406B4;\n\tWed, 11 May 2022 18:33:16 +0200 (CEST)", "from smtp-relay-canonical-1.canonical.com\n (smtp-relay-canonical-1.canonical.com [185.125.188.121])\n by mails.dpdk.org (Postfix) with ESMTP id 01E7440042\n for <dev@dpdk.org>; Wed, 11 May 2022 18:33:14 +0200 (CEST)", "from workstation5.fritz.box\n (ip-062-143-094-109.um16.pools.vodafone-ip.de [62.143.94.109])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 5BE5B3FF5F;\n Wed, 11 May 2022 16:33:14 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com;\n s=20210705; t=1652286794;\n bh=BmfufhKaKUHeGYHdWiaXlUCuFwVcAGPMX1Yw6/3LIkM=;\n h=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=Im2LvoGA7eZclrqX9/sdy8egAawZz8ZImuCxsCYfCt9lgf32C2g1CduRafVM+7uQP\n CeywTC/lD7jpolzcSECjVUgC+0zzeAU7PNs82ctotWGouHk0oyeH7D1LXZWm3qlix2\n Q8dRwVk16Z0elZTk33tpdJwoeEJu/FjmJgsuP5CaBg/NHvXi08yY2bacQW6YP2UY4a\n FHaHccxaTSawpRX3qK5B9o64j9+CNVcQV8Rw4Famj4/G6Drr+Kkw4cB3IJzqRa5SLC\n ElbaGEtPh0LrX0ZKXqxKMINuJ6g7UL3s5Lni0Ll88yTQqCMon6jJ4RNNVHS70xLBD8\n lZe2zdlq/3nIA==", "From": "Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "To": "Thomas Monjalon <thomas@monjalon.net>,\n David Marchand <david.marchand@redhat.com>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, Chenbo Xia <chenbo.xia@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>, Rosen Xu <rosen.xu@intel.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Joyce Kong <joyce.kong@arm.com>, Jie Zhou <jizh@linux.microsoft.com>,\n dev@dpdk.org, Heinrich Schuchardt <heinrich.schuchardt@canonical.com>", "Subject": "[PATCH 1/1] test/pmd_perf: handling of unknown connection speed", "Date": "Wed, 11 May 2022 18:33:10 +0200", "Message-Id": "<20220511163310.50892-1-heinrich.schuchardt@canonical.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When running DPDK in QEMU it cannot determine the connection speed.\npmd_perf_autotest treats this as if the connection speed where\nUNIT32_MAX Mbps:\n\n RTE>>pmd_perf_autotest\n Start PMD RXTX cycles cost test.\n Allocated mbuf pool on socket 0\n CONFIG RXD=1024 TXD=1024\n Performance test runs on lcore 1 socket 0\n Port 0 Address:52:54:00:12:34:57\n Port 1 Address:52:54:00:12:34:58\n Checking link statuses...\n Port 0 Link up at Unknown FDX Autoneg\n Port 1 Link up at Unknown FDX Autoneg\n IPv4 pktlen 46\n UDP pktlen 26\n Generate 4096 packets @socket 0\n inject 2048 packet to port 0\n inject 2048 packet to port 1\n Total packets inject to prime ports = 4096\n Each port will do 6391320379464 packets per second\n Test will stop after at least 25565281517856 packets received\n\nThis will not allow the test to terminate in a reasonable timespan.\nJust assume 10 Gbps in this case instead:\n\n ...\n Test will stop after at least 59523808 packets received\n\nSigned-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>\n---\n app/test/test_pmd_perf.c | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c\nindex 25611bfe9b..ee08c8aade 100644\n--- a/app/test/test_pmd_perf.c\n+++ b/app/test/test_pmd_perf.c\n@@ -486,10 +486,17 @@ main_loop(__rte_unused void *args)\n \t}\n \tprintf(\"Total packets inject to prime ports = %u\\n\", idx);\n \n-\tpackets_per_second = (link_mbps * 1000 * 1000) /\n-\t\t((PACKET_SIZE + FRAME_GAP + MAC_PREAMBLE) * CHAR_BIT);\n-\tprintf(\"Each port will do %\"PRIu64\" packets per second\\n\",\n-\t packets_per_second);\n+\tif (link_mbps != RTE_ETH_SPEED_NUM_UNKNOWN) {\n+\t\tpackets_per_second = (link_mbps * 1000 * 1000) /\n+\t\t\t((PACKET_SIZE + FRAME_GAP + MAC_PREAMBLE) * CHAR_BIT);\n+\t\tprintf(\"Each port will do %\"PRIu64\" packets per second\\n\",\n+\t\t packets_per_second);\n+\t\ttotal_packets = RTE_TEST_DURATION * conf->nb_ports * packets_per_second;\n+\t} else {\n+\t\t/* We don't know the speed. Pretend it is 10G */\n+\t\tpackets_per_second = ((uint64_t)RTE_ETH_SPEED_NUM_10G * 1000 * 1000) /\n+\t\t\t((PACKET_SIZE + FRAME_GAP + MAC_PREAMBLE) * CHAR_BIT);\n+\t}\n \n \ttotal_packets = RTE_TEST_DURATION * conf->nb_ports * packets_per_second;\n \tprintf(\"Test will stop after at least %\"PRIu64\" packets received\\n\",\n", "prefixes": [ "1/1" ] }