Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110587/?format=api
{ "id": 110587, "url": "http://patches.dpdk.org/api/patches/110587/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220503042257.15626-3-pagupta@vmware.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220503042257.15626-3-pagupta@vmware.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220503042257.15626-3-pagupta@vmware.com", "date": "2022-05-03T04:22:51", "name": "[2/8] vmxnet3: implement reta query and reta update", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5bfc4b82a074e72266a407abc07dbd6c44130fc4", "submitter": { "id": 2677, "url": "http://patches.dpdk.org/api/people/2677/?format=api", "name": "Pankaj Gupta", "email": "pagupta@vmware.com" }, "delegate": { "id": 3961, "url": "http://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220503042257.15626-3-pagupta@vmware.com/mbox/", "series": [ { "id": 22766, "url": "http://patches.dpdk.org/api/series/22766/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22766", "date": "2022-05-03T04:22:49", "name": "vmxnet3 version V5 and V6", "version": 1, "mbox": "http://patches.dpdk.org/series/22766/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/110587/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/110587/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9DAB0A0093;\n\tTue, 3 May 2022 06:23:28 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 16FC842833;\n\tTue, 3 May 2022 06:23:15 +0200 (CEST)", "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12on2086.outbound.protection.outlook.com [40.107.244.86])\n by mails.dpdk.org (Postfix) with ESMTP id BE6A14282A\n for <dev@dpdk.org>; Tue, 3 May 2022 06:23:13 +0200 (CEST)", "from BYAPR05MB5624.namprd05.prod.outlook.com (2603:10b6:a03:1d::13)\n by BL0PR05MB5523.namprd05.prod.outlook.com (2603:10b6:208:68::26)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Tue, 3 May\n 2022 04:23:11 +0000", "from BYAPR05MB5624.namprd05.prod.outlook.com\n ([fe80::5161:a7c5:8c7d:f3b2]) by BYAPR05MB5624.namprd05.prod.outlook.com\n ([fe80::5161:a7c5:8c7d:f3b2%7]) with mapi id 15.20.5206.024; Tue, 3 May 2022\n 04:23:11 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ghzuHhXIO7UbKs7eCUmcEsBnFfvtpMCGrnLOPjsdQfnl72yOcrYbT5K7G6O+ZmYQyz0Pqbn0AHPyy3lH7ZS8SPyQHpoUCKuazzoX/iXabB5vHi8TdzNEh7ryNdZ9jfFv2XQY34CIEBJIrAaSeVcwym93a430k7h8Yps8Zz6Ly9/i04XxPCGf0jkiPC69IoQKKXtEItexdizr6blaC+/nkI9/hLX+BtXa2/LgUgTefaQOiwNvZVMmsS0R2FT0cJ0ffwzWuUyYkpZuJW4rApxG+S/2JeUOlygWQpieFarz+vTskklA9Imyzxeh+C1Mr4jG2FpJ89uNALBcPYk7QSBRjw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=VLKdXX7LVo/ME6ffKsMZcNJhgBvNt+qk8I73YQZHNsY=;\n b=TSpnstwDPcqxHgtSjZ7G5BotzaZEhBGscCRazt0yOblNuzXzv9adlEcSLjaQ3mhKSq8Fv7Q2Cop7iuuzEbkNSRcuR4NTdh/Alb6tViMW4WOB+g6TI0GfjcDyHFKUYkDrgqBo0TFCh2Jusy6j9Gwgp4FvuU34kfQwW4oMMYm3LgIwsKpUb7/4K5Or/SomlDDA+YRvFJF71YbDwMVURSHz/TfVPo2qsr7t4+4nCCzO+5xwtOqWde+DIcDwJ+tF+ztcWi6JGs+TbpT02xpVidpvTuAk+BAlQdzMKDEEdoy9cjqyVQn7DqQK+SG6oGLoLmHDBQRTMgP6NY0SWKCPhOn14w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com;\n dkim=pass header.d=vmware.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=VLKdXX7LVo/ME6ffKsMZcNJhgBvNt+qk8I73YQZHNsY=;\n b=i9e2Wz0nQEbxenzpL63XpO7p6tridO+VXu3ENFNXUdnH8UpsgYcKmq1VhA4maJPDndS+QNnE56Ug5RMP0XhefgaQ5rxduHZsVyje1PADbgY9prBU0iudn/5swZ2LSmFpCtwLyIRPEj5qAGclzu0a4eUqxLiC3xDhyh7uQiIG5pc=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=vmware.com;", "From": "Pankaj Gupta <pagupta@vmware.com>", "To": "jbehrens@vmware.com,\n\tyongwang@vmware.com", "Cc": "dev@dpdk.org,\n\tpagupta@vmware.com", "Subject": "[PATCH 2/8] vmxnet3: implement reta query and reta update", "Date": "Tue, 3 May 2022 00:22:51 -0400", "Message-Id": "<20220503042257.15626-3-pagupta@vmware.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20220503042257.15626-1-pagupta@vmware.com>", "References": "<20220503042257.15626-1-pagupta@vmware.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "SJ0PR03CA0059.namprd03.prod.outlook.com\n (2603:10b6:a03:33e::34) To BYAPR05MB5624.namprd05.prod.outlook.com\n (2603:10b6:a03:1d::13)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "9f07d0e7-f511-4ac3-0a82-08da2cbca1f5", "X-MS-TrafficTypeDiagnostic": "BL0PR05MB5523:EE_", "X-Microsoft-Antispam-PRVS": "\n <BL0PR05MB55238A336B1E2F4F234ED202C9C09@BL0PR05MB5523.namprd05.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ml+UFJ/jKRTp0jbVkmdymJOKZYDwIfIF076n0KVWZ1VRS/AfRh8VSko2h5oIYCDmGGF0jOX+efxtx7HMtGyG1IYYBDsjcjwtNJFgI66fOe8VrrKZ5Jp5LOYbagtMmYA0yFlV81OFPB6zax86Y+TxgXHqdxAq+/OZSxhia/zKlgsBTOsv+8a1Gh+G2f4krxpnjDdfRZ8142bAt5Y06d6EDcQcuDb4HVUw40bYrHNZKPh7YgbCcZrf4wz/YqqzqoZpOicHJgvkEA7m4Z7IcjQHLS5GuBrgvG4Tsp8u5ouN6MF+/UeUO/zcxUxRXLLTd8JtZuvr3l+MYSHjSY2LxKKgsv/xtcNVarVwzWRe8AwPD9FLL0xGYzp2TgGUwLC/quITZSZiEVSs75P+9Wbk6i2lvuREfmJ0dfTZBNwDt6hX/T8ZYrpWhBTpQ6S6F477PIHsZnWbrmd+g3LBG7Ls3DhCilJWoIfDLdqB/d4VBQYmWxqedVapHG7KEPfFyAQr9htzEtwKYxTqAq3IpWAfEKr+HEgI0QXkH+DQEhscAfEAsA+PCPQYDUBx2yeJq/nkXL/qGwmN+Az8eRrqKZ0NPW1eBGPOskhHfgDsj5cUadP3A2qNKNu/sCY0AnwpqznQ9SDA1xu6UL/tvPgwfAYpLNtPB3jOxmKHhgCRqnBtzzSqEJvI76uVro3cAw3xSlpo1siK+r3fayCACNMIkk62JviywQ==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BYAPR05MB5624.namprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230001)(4636009)(366004)(6636002)(38350700002)(26005)(107886003)(83380400001)(36756003)(1076003)(8676002)(6506007)(86362001)(2616005)(66476007)(66946007)(66556008)(38100700002)(4326008)(6486002)(508600001)(186003)(316002)(2906002)(8936002)(6666004)(6512007)(52116002)(15650500001)(5660300002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n JJ1tL03Jsq34pyBg6X1SsSa3CnzEF9KfVJZ/VGuKXrmEEkkBRQhtt7mTNSVEqD+MUxm25CGsFZXan7N7q1/4ViuT4UlUIW06eNizNQCT7BN/xxnYSH/20mUOsdRBnPv9lYuR/ZUH7xz9sxp3tUbKtH5g8P8jHmKmv3HATgrK/Rs3aPXc/70+sbsRAfzHr++NcXsY9B1QtXWGDeTdZcXTSAt/nPavZViIh1nxg2dq2DaECHtpMwdE9FD/j2PaVRq9lLcjOCgTISm30Uw0Ol7wPlNPpD/znpDnqD8NADEzRbY4R414iOgBUI2M07mSWzMwyFlw9vV4wNqwUGT9ocHVpk2uCwAGXGiFN9v70sSuSIXB/TVpykl/EX+enlErh5k09sQDwGW5sPPDjlSJFVsd9QBjZujzb5KTBTF9GkaUoQaJcY5PV1qfQ5dJngxeJDoMpCxDpHNPQ/NVHDvvq7LO6GdKxacOBb9gHt6nisPz1ir1gIFnNSCopZpRzdgh9x46uxakne2FoCHCLZ5q8iJQ/x2f6w8Xw6kgcCjaFr5nGMvzY5ZdLhVN0+McaAe+YGIP7PBMc4WsTaN+J3/3FXsauUvcGvJ6KxlVgIZ3tyF+hE9YLITc2TK557RYJX6KKkLuENu/NAkdzkzdevQY6rcCSrivGvalbKFI6Nlg1K0o6EBF3vy2JQOdITMlKISNBGjIKXRrdha4FHQ3GGE2nL+nn3CHAnmlurIkP+ZfB5ET5+XjhtAtbkwEBReu3TI47kesWWq59DxDSETsCmhzaqLZZEIzJNGxmLn10GWadVsTVU/EedI3tFZf8UV/wx+TABu5R8OfbDG4tBxkHda9SsYr6qzAm9xJyNHNZ1KJBaGKeztOz2L1kA1uvDdqMW4Y4dH+908YDY24BOOn25YQAI3F+X3/hccmcaGYSQKXEF6yM3iiZAfX2nZdD/QUz+Lr+xPhEGnhbufvjCM44inQfNkT3Y+I4d+0tUODKRotFv1Uij4a1DM8HcHhXzgRLx+GTwEb+BWJhp5dYIhEM9L2mqammmBUuOWyehNuTNZwqftQDUe5+4RQ6Fjd8wcwNIJZ4xMG+IXkYBcMTK+NneL+Na3Fl/LS2J8skKmQ0vXKlMA3rc+OmgMPwpRIb6bq55d+MZC1oWfx2AAoKwClXavToF+V15YA5zHqw3Mvu76QShe762H04FWz+KDbc2MgyjAvxIKi0kDhozbB130CcYMsgTKIj8LWwSsixyLfqM+xwQ8henrc6hQtZEf5jJMxqzwwHvYds9frh2AC/9jfBu57oVKRjbmkXkCalISv+sw3Jvy1jj2LCIHf17O8mVbzRQT36BOXuJOEQeXzi6Vi3VGgW99WvaajlZTPQxRzYOgepEU3oX+Bibn0dhDHwgMHlhNbsmHabTlZLyqTJfpGKLIG8vkbi5PYgrGxopVtF2A33Mq29uIuSKUIX/XBAoB/3wf6AAO7f01ZvFErXyz7hrMddIDXhH2aCHJdSBldD0k8scpi49fxzhZCJYFGMgPU6Dg6o8Mpdol+xSYw+5jQukXQALnPR90BMyELPTVgYNOEZYyyEsZOJEUARwU5+kQt4SXzrMbwGmIJXx7MTgKnMOnb+meYzvvbnGmedlOSROSknsrPHl+jc+vIwUH07r52KNzXTEWr7H13deevjfByU5sc0scJPXlUh5kDWa+k1rJTTdqf5z+aIzf0/cZiGxQPYfbFmE/R8UbjkO+sHkQxtmOHXqyqqw==", "X-OriginatorOrg": "vmware.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9f07d0e7-f511-4ac3-0a82-08da2cbca1f5", "X-MS-Exchange-CrossTenant-AuthSource": "BYAPR05MB5624.namprd05.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 May 2022 04:23:11.0885 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 4OkfNI0o8ENycbKpr5Av1tHyLQRkDd8i4GMFL/XnTYR516lD197ZXe1Q1kZFmRYrO/yA4DUjgwokzML87AIBNA==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BL0PR05MB5523", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Added reta query and reta update support for VMXNET3\n\nTested, using testpmd, for different hardware version on ESXi 7.0 Update 2.\n\nSigned-off-by: Pankaj Gupta <pagupta@vmware.com>\n---\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 67 ++++++++++++++++++++++++++++\n 1 file changed, 67 insertions(+)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c\nindex a7e1e5fef5..eb65499cf2 100644\n--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c\n+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c\n@@ -95,6 +95,14 @@ static int vmxnet3_mac_addr_set(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_ether_addr *mac_addr);\n static void vmxnet3_process_events(struct rte_eth_dev *dev);\n static void vmxnet3_interrupt_handler(void *param);\n+static int\n+vmxnet3_rss_reta_update(struct rte_eth_dev *dev,\n+\t\t\tstruct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t\tuint16_t reta_size);\n+static int\n+vmxnet3_rss_reta_query(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t uint16_t reta_size);\n static int vmxnet3_dev_rx_queue_intr_enable(struct rte_eth_dev *dev,\n \t\t\t\t\t\tuint16_t queue_id);\n static int vmxnet3_dev_rx_queue_intr_disable(struct rte_eth_dev *dev,\n@@ -137,6 +145,8 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = {\n \t.tx_queue_release = vmxnet3_dev_tx_queue_release,\n \t.rx_queue_intr_enable = vmxnet3_dev_rx_queue_intr_enable,\n \t.rx_queue_intr_disable = vmxnet3_dev_rx_queue_intr_disable,\n+\t.reta_update = vmxnet3_rss_reta_update,\n+\t.reta_query = vmxnet3_rss_reta_query,\n };\n \n struct vmxnet3_xstats_name_off {\n@@ -1696,3 +1706,60 @@ RTE_PMD_REGISTER_PCI_TABLE(net_vmxnet3, pci_id_vmxnet3_map);\n RTE_PMD_REGISTER_KMOD_DEP(net_vmxnet3, \"* igb_uio | uio_pci_generic | vfio-pci\");\n RTE_LOG_REGISTER_SUFFIX(vmxnet3_logtype_init, init, NOTICE);\n RTE_LOG_REGISTER_SUFFIX(vmxnet3_logtype_driver, driver, NOTICE);\n+\n+static int\n+vmxnet3_rss_reta_update(struct rte_eth_dev *dev,\n+\t\t\tstruct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t\tuint16_t reta_size)\n+{\n+\tint i, idx, shift;\n+\tstruct vmxnet3_hw *hw = dev->data->dev_private;\n+\tstruct VMXNET3_RSSConf *dev_rss_conf = hw->rss_conf;\n+\n+\tif (reta_size != dev_rss_conf->indTableSize) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"The size of hash lookup table configured (%d) doesn't match \"\n+\t\t\t\"the supported number (%d)\",\n+\t\t\treta_size, dev_rss_conf->indTableSize);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (i = 0; i < reta_size; i++) {\n+\t\tidx = i / RTE_ETH_RETA_GROUP_SIZE;\n+\t\tshift = i % RTE_ETH_RETA_GROUP_SIZE;\n+\t\tif (reta_conf[idx].mask & (1ULL << shift))\n+\t\t\tdev_rss_conf->indTable[i] = (uint8_t)reta_conf[idx].reta[shift];\n+\t}\n+\n+\tVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,\n+\t\t\t\tVMXNET3_CMD_UPDATE_RSSIDT);\n+\n+\treturn 0;\n+}\n+\n+static int\n+vmxnet3_rss_reta_query(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t uint16_t reta_size)\n+{\n+\tint i, idx, shift;\n+\tstruct vmxnet3_hw *hw = dev->data->dev_private;\n+\tstruct VMXNET3_RSSConf *dev_rss_conf = hw->rss_conf;\n+\n+\tif (reta_size != dev_rss_conf->indTableSize) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Size of requested hash lookup table (%d) doesn't \"\n+\t\t\t\"match the configured size (%d)\",\n+\t\t\treta_size, dev_rss_conf->indTableSize);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (i = 0; i < reta_size; i++) {\n+\t\tidx = i / RTE_ETH_RETA_GROUP_SIZE;\n+\t\tshift = i % RTE_ETH_RETA_GROUP_SIZE;\n+\t\tif (reta_conf[idx].mask & (1ULL << shift))\n+\t\t\treta_conf[idx].reta[shift] = dev_rss_conf->indTable[i];\n+\t}\n+\n+\treturn 0;\n+}\n", "prefixes": [ "2/8" ] }