Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108923/?format=api
{ "id": 108923, "url": "http://patches.dpdk.org/api/patches/108923/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1648451862-123318-17-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1648451862-123318-17-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1648451862-123318-17-git-send-email-andy.pei@intel.com", "date": "2022-03-28T07:17:42", "name": "[v5,16/16] vhost: make sure each queue callfd is configured", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a52092b22df2570aaf3e810b2b3c14353bc2319b", "submitter": { "id": 1185, "url": "http://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1648451862-123318-17-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 22260, "url": "http://patches.dpdk.org/api/series/22260/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=22260", "date": "2022-03-28T07:17:26", "name": "add virtio_blk device support to vdpa/ifc", "version": 5, "mbox": "http://patches.dpdk.org/series/22260/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/108923/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/108923/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49149A034C;\n\tMon, 28 Mar 2022 10:03:40 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D314F428CF;\n\tMon, 28 Mar 2022 10:02:15 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 9F480428CE\n for <dev@dpdk.org>; Mon, 28 Mar 2022 10:02:13 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Mar 2022 01:02:13 -0700", "from dpdk-dipei.sh.intel.com ([10.67.110.238])\n by orsmga008.jf.intel.com with ESMTP; 28 Mar 2022 01:02:11 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1648454533; x=1679990533;\n h=from:to:cc:subject:date:message-id:in-reply-to: references;\n bh=0LUUAg0BjZY4nCoILL6MvUAVDXEP8UNje30DYtnOsfA=;\n b=RVr8KGnlye7RTaaWLnVWT2mRPWZOmVCOBmtZ8HrZ7pPRodZ8CjjqAmaO\n MJ/fxl6PuCH/xoIOCOy3VHUHYhvWbGeZPUl+zw5XhBdTusZd+yjmoM2GS\n reu76nHT4n9KmL+zDn2gPIUw/7FGxwzvMw+nPAYw13n3gJaqeKoMbsyA3\n yzkNZAB9EQ+eJ45wRMUdzAcc6LBbA30HTXjHzMz2lhq1g2X94ejPJk1+M\n UL6VWtUdKfxktPJGJkK6NWZGnxG+K8McQGX+IQs4jDNgVI8xG58gx9m+S\n 9yYAuviMTAGOL+SzTV+wbsmf8N46nYD5Vl9L8rlBP5wDLtLAqEXDhULzH A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10299\"; a=\"256515805\"", "E=Sophos;i=\"5.90,216,1643702400\"; d=\"scan'208\";a=\"256515805\"", "E=Sophos;i=\"5.90,216,1643702400\"; d=\"scan'208\";a=\"563421956\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, maxime.coquelin@redhat.com, gang.cao@intel.com,\n changpeng.liu@intel.com", "Subject": "[PATCH v5 16/16] vhost: make sure each queue callfd is configured", "Date": "Mon, 28 Mar 2022 15:17:42 +0800", "Message-Id": "<1648451862-123318-17-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1648451862-123318-1-git-send-email-andy.pei@intel.com>", "References": "<1643093258-47258-2-git-send-email-andy.pei@intel.com>\n <1648451862-123318-1-git-send-email-andy.pei@intel.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "During the vhost data path building process, qemu will create\na call fd at first, and create another call fd in the end.\nThe final call fd will be used to relay notify.\nIn the original code, after kick fd is set, dev_conf will\nset the first call fd. Even though the actual call fd will set,\nthe data path will not work correctly.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n lib/vhost/vhost_user.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 55e8bd0..43154c0 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -3197,12 +3197,26 @@ typedef int (*vhost_message_handler_t)(struct virtio_net **pdev,\n \tif (!vdpa_dev)\n \t\tgoto out;\n \n+\tif (request != VHOST_USER_SET_VRING_CALL)\n+\t\tgoto out;\n+\n \tif (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) {\n \t\tif (vdpa_dev->ops->dev_conf(dev->vid))\n \t\t\tVHOST_LOG_CONFIG(ERR, \"(%s) failed to configure vDPA device\\n\",\n \t\t\t\t\tdev->ifname);\n \t\telse\n \t\t\tdev->flags |= VIRTIO_DEV_VDPA_CONFIGURED;\n+\t} else {\n+\t\t/* when VIRTIO_DEV_VDPA_CONFIGURED already configured\n+\t\t * close the device and config the device again,\n+\t\t * make sure the call fd of each queue is configured correctly.\n+\t\t */\n+\t\tif (vdpa_dev->ops->dev_close(dev->vid))\n+\t\t\tVHOST_LOG_CONFIG(ERR,\n+\t\t\t\t\t \"Failed to close vDPA device\\n\");\n+\t\tif (vdpa_dev->ops->dev_conf(dev->vid))\n+\t\t\tVHOST_LOG_CONFIG(ERR,\n+\t\t\t\t\t \"Failed to re-config vDPA device\\n\");\n \t}\n \n out:\n", "prefixes": [ "v5", "16/16" ] }