Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108347/?format=api
{ "id": 108347, "url": "http://patches.dpdk.org/api/patches/108347/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220225065445.1551062-1-vattunuru@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220225065445.1551062-1-vattunuru@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220225065445.1551062-1-vattunuru@marvell.com", "date": "2022-02-25T06:54:45", "name": "[1/1] net/cnxk: make inline inbound device usage default", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8d300c4b4fc8a9d2e916031809b3ea0706ac3e6a", "submitter": { "id": 1277, "url": "http://patches.dpdk.org/api/people/1277/?format=api", "name": "Vamsi Krishna Attunuru", "email": "vattunuru@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220225065445.1551062-1-vattunuru@marvell.com/mbox/", "series": [ { "id": 21887, "url": "http://patches.dpdk.org/api/series/21887/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21887", "date": "2022-02-25T06:54:45", "name": "[1/1] net/cnxk: make inline inbound device usage default", "version": 1, "mbox": "http://patches.dpdk.org/series/21887/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/108347/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/108347/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2BEA2A034C;\n\tFri, 25 Feb 2022 07:54:55 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F0D834115C;\n\tFri, 25 Feb 2022 07:54:54 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id F212B4068B\n for <dev@dpdk.org>; Fri, 25 Feb 2022 07:54:52 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 21ONdpas012858\n for <dev@dpdk.org>; Thu, 24 Feb 2022 22:54:52 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3eekfw9p71-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 24 Feb 2022 22:54:52 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Thu, 24 Feb 2022 22:54:50 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Thu, 24 Feb 2022 22:54:50 -0800", "from localhost.localdomain (unknown [10.28.48.51])\n by maili.marvell.com (Postfix) with ESMTP id 17D453F7052;\n Thu, 24 Feb 2022 22:54:48 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=tZuyp0wyt+MVGg0ltckpCPtNQvoQsX5WzlA3NAk0gQs=;\n b=Hn4JJWatPEKyDPQs7qYdWaREw3g0V++wwoBET0DxNd/mfoDPwa3FZqtO0ZfHsZgPNkuh\n j7y+IiUI9H+GMTZaDmnbTcy5u6MhO/V1mJMPU9GU7w55xePJpQAGUIJWvjcZw/Mcd2M0\n tfUUAnylCuCMxnIQ7ygpzKUM9iIgvzJkOiaWi2q5ozIChTEpJns2x2Z2yHY7NCfRrwI0\n zMTkHzH1zXx4lEDQMv+tHtHSghcPHgWy6oilUl7eyi8ef2JKPqR+OMMkVlxzfnpW4hk8\n jElVZbsYEIYQWMIB5TH0HBki5QEBMrs1SF8Esl2bJA9JNeDx6dCUdJqRpOO1H+F9KLvm OA==", "From": "Vamsi Attunuru <vattunuru@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<jerinj@marvell.com>, <vattunuru@marvell.com>, <ndabilpuram@marvell.com>", "Subject": "[PATCH 1/1] net/cnxk: make inline inbound device usage default", "Date": "Fri, 25 Feb 2022 12:24:45 +0530", "Message-ID": "<20220225065445.1551062-1-vattunuru@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "LzGsjFlpovpqz4QCmhOXwpMCoI0jrbOl", "X-Proofpoint-ORIG-GUID": "LzGsjFlpovpqz4QCmhOXwpMCoI0jrbOl", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514\n definitions=2022-02-25_05,2022-02-24_01,2022-02-23_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently inline inbound device usage is not default for eventdev,\npatch renames force_inl_dev dev arg to no_inl_dev and enables inline\ninbound device by default.\n\nSigned-off-by: Vamsi Attunuru <vattunuru@marvell.com>\n---\n doc/guides/nics/cnxk.rst | 10 +++++-----\n drivers/event/cnxk/cnxk_eventdev_adptr.c | 4 ++--\n drivers/net/cnxk/cn9k_ethdev.c | 1 +\n drivers/net/cnxk/cnxk_ethdev.h | 4 ++--\n drivers/net/cnxk/cnxk_ethdev_devargs.c | 11 +++++------\n 5 files changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/doc/guides/nics/cnxk.rst b/doc/guides/nics/cnxk.rst\nindex be51ca2146..31c801fa04 100644\n--- a/doc/guides/nics/cnxk.rst\n+++ b/doc/guides/nics/cnxk.rst\n@@ -275,7 +275,7 @@ Runtime Config Options\n With the above configuration, two CPT LF's are setup and distributed among\n all the Tx queues for outbound processing.\n \n-- ``Force using inline ipsec device for inbound`` (default ``0``)\n+- ``Disable using inline ipsec device for inbound`` (default ``0``)\n \n In CN10K, in event mode, driver can work in two modes,\n \n@@ -285,13 +285,13 @@ Runtime Config Options\n 2. Both Inbound encrypted traffic and plain traffic post decryption are\n received by ethdev.\n \n- By default event mode works without using inline device i.e mode ``2``.\n- This behaviour can be changed to pick mode ``1`` by using\n- ``force_inb_inl_dev`` ``devargs`` parameter.\n+ By default event mode works using inline device i.e mode ``1``.\n+ This behaviour can be changed to pick mode ``2`` by using\n+ ``no_inl_dev`` ``devargs`` parameter.\n \n For example::\n \n- -a 0002:02:00.0,force_inb_inl_dev=1 -a 0002:03:00.0,force_inb_inl_dev=1\n+ -a 0002:02:00.0,no_inl_dev=1 -a 0002:03:00.0,no_inl_dev=1\n \n With the above configuration, inbound encrypted traffic from both the ports\n is received by ipsec inline device.\ndiff --git a/drivers/event/cnxk/cnxk_eventdev_adptr.c b/drivers/event/cnxk/cnxk_eventdev_adptr.c\nindex 5ebd3340e7..42ac14064d 100644\n--- a/drivers/event/cnxk/cnxk_eventdev_adptr.c\n+++ b/drivers/event/cnxk/cnxk_eventdev_adptr.c\n@@ -263,9 +263,9 @@ cnxk_sso_rx_adapter_queue_add(\n \n \t/* Switch to use PF/VF's NIX LF instead of inline device for inbound\n \t * when all the RQ's are switched to event dev mode. We do this only\n-\t * when using inline device is not forced by dev args.\n+\t * when dev arg no_inl_dev=1 is selected.\n \t */\n-\tif (!cnxk_eth_dev->inb.force_inl_dev &&\n+\tif (cnxk_eth_dev->inb.no_inl_dev &&\n \t cnxk_eth_dev->nb_rxq_sso == cnxk_eth_dev->nb_rxq)\n \t\tcnxk_nix_inb_mode_set(cnxk_eth_dev, false);\n \ndiff --git a/drivers/net/cnxk/cn9k_ethdev.c b/drivers/net/cnxk/cn9k_ethdev.c\nindex 6b049b2897..ae42d76d6d 100644\n--- a/drivers/net/cnxk/cn9k_ethdev.c\n+++ b/drivers/net/cnxk/cn9k_ethdev.c\n@@ -594,6 +594,7 @@ cn9k_nix_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)\n \t}\n \n \tdev->hwcap = 0;\n+\tdev->inb.no_inl_dev = 1;\n \n \t/* Register up msg callbacks for PTP information */\n \troc_nix_ptp_info_cb_register(&dev->nix, cn9k_nix_ptp_info_update_cb);\ndiff --git a/drivers/net/cnxk/cnxk_ethdev.h b/drivers/net/cnxk/cnxk_ethdev.h\nindex 445b7abf69..9a9d3baf25 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.h\n+++ b/drivers/net/cnxk/cnxk_ethdev.h\n@@ -272,8 +272,8 @@ struct cnxk_eth_dev_sec_inb {\n \t/* Using inbound with inline device */\n \tbool inl_dev;\n \n-\t/* Device argument to force inline device for inb */\n-\tbool force_inl_dev;\n+\t/* Device argument to disable inline device usage for inb */\n+\tbool no_inl_dev;\n \n \t/* Active sessions */\n \tuint16_t nb_sess;\ndiff --git a/drivers/net/cnxk/cnxk_ethdev_devargs.c b/drivers/net/cnxk/cnxk_ethdev_devargs.c\nindex 8a71644899..9b2beb6743 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_devargs.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_devargs.c\n@@ -241,7 +241,7 @@ parse_sdp_channel_mask(const char *key, const char *value, void *extra_args)\n #define CNXK_IPSEC_IN_MAX_SPI\t\"ipsec_in_max_spi\"\n #define CNXK_IPSEC_OUT_MAX_SA\t\"ipsec_out_max_sa\"\n #define CNXK_OUTB_NB_DESC\t\"outb_nb_desc\"\n-#define CNXK_FORCE_INB_INL_DEV\t\"force_inb_inl_dev\"\n+#define CNXK_NO_INL_DEV\t\t\"no_inl_dev\"\n #define CNXK_OUTB_NB_CRYPTO_QS\t\"outb_nb_crypto_qs\"\n #define CNXK_SDP_CHANNEL_MASK\t\"sdp_channel_mask\"\n #define CNXK_FLOW_PRE_L2_INFO\t\"flow_pre_l2_info\"\n@@ -257,7 +257,6 @@ cnxk_ethdev_parse_devargs(struct rte_devargs *devargs, struct cnxk_eth_dev *dev)\n \tuint16_t flow_prealloc_size = 1;\n \tuint16_t switch_header_type = 0;\n \tuint16_t flow_max_priority = 3;\n-\tuint16_t force_inb_inl_dev = 0;\n \tuint16_t outb_nb_crypto_qs = 1;\n \tuint32_t ipsec_in_min_spi = 0;\n \tuint16_t outb_nb_desc = 8200;\n@@ -266,6 +265,7 @@ cnxk_ethdev_parse_devargs(struct rte_devargs *devargs, struct cnxk_eth_dev *dev)\n \tuint16_t scalar_enable = 0;\n \tuint8_t lock_rx_ctx = 0;\n \tstruct rte_kvargs *kvlist;\n+\tuint16_t no_inl_dev = 0;\n \n \tmemset(&sdp_chan, 0, sizeof(sdp_chan));\n \tmemset(&pre_l2_info, 0, sizeof(struct flow_pre_l2_size_info));\n@@ -302,8 +302,7 @@ cnxk_ethdev_parse_devargs(struct rte_devargs *devargs, struct cnxk_eth_dev *dev)\n \t\t\t &outb_nb_desc);\n \trte_kvargs_process(kvlist, CNXK_OUTB_NB_CRYPTO_QS,\n \t\t\t &parse_outb_nb_crypto_qs, &outb_nb_crypto_qs);\n-\trte_kvargs_process(kvlist, CNXK_FORCE_INB_INL_DEV, &parse_flag,\n-\t\t\t &force_inb_inl_dev);\n+\trte_kvargs_process(kvlist, CNXK_NO_INL_DEV, &parse_flag, &no_inl_dev);\n \trte_kvargs_process(kvlist, CNXK_SDP_CHANNEL_MASK,\n \t\t\t &parse_sdp_channel_mask, &sdp_chan);\n \trte_kvargs_process(kvlist, CNXK_FLOW_PRE_L2_INFO,\n@@ -312,7 +311,7 @@ cnxk_ethdev_parse_devargs(struct rte_devargs *devargs, struct cnxk_eth_dev *dev)\n \n null_devargs:\n \tdev->scalar_ena = !!scalar_enable;\n-\tdev->inb.force_inl_dev = !!force_inb_inl_dev;\n+\tdev->inb.no_inl_dev = !!no_inl_dev;\n \tdev->inb.max_spi = ipsec_in_max_spi;\n \tdev->outb.max_sa = ipsec_out_max_sa;\n \tdev->outb.nb_desc = outb_nb_desc;\n@@ -350,5 +349,5 @@ RTE_PMD_REGISTER_PARAM_STRING(net_cnxk,\n \t\t\t CNXK_OUTB_NB_DESC \"=<1-65535>\"\n \t\t\t CNXK_FLOW_PRE_L2_INFO \"=<0-255>/<1-255>/<0-1>\"\n \t\t\t CNXK_OUTB_NB_CRYPTO_QS \"=<1-64>\"\n-\t\t\t CNXK_FORCE_INB_INL_DEV \"=1\"\n+\t\t\t CNXK_NO_INL_DEV \"=0\"\n \t\t\t CNXK_SDP_CHANNEL_MASK \"=<1-4095>/<1-4095>\");\n", "prefixes": [ "1/1" ] }