Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107922/?format=api
{ "id": 107922, "url": "http://patches.dpdk.org/api/patches/107922/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220221230240.2409665-11-akozyrev@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220221230240.2409665-11-akozyrev@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220221230240.2409665-11-akozyrev@nvidia.com", "date": "2022-02-21T23:02:39", "name": "[v9,10/11] app/testpmd: add flow queue pull operation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "49f2786217a3fae7743b185ce0a7fb3062c2a936", "submitter": { "id": 1873, "url": "http://patches.dpdk.org/api/people/1873/?format=api", "name": "Alexander Kozyrev", "email": "akozyrev@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220221230240.2409665-11-akozyrev@nvidia.com/mbox/", "series": [ { "id": 21774, "url": "http://patches.dpdk.org/api/series/21774/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21774", "date": "2022-02-21T23:02:29", "name": "ethdev: datapath-focused flow rules management", "version": 9, "mbox": "http://patches.dpdk.org/series/21774/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107922/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/107922/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5F15CA034F;\n\tTue, 22 Feb 2022 00:04:19 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5475740E64;\n\tTue, 22 Feb 2022 00:03:34 +0100 (CET)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2078.outbound.protection.outlook.com [40.107.237.78])\n by mails.dpdk.org (Postfix) with ESMTP id C35AC411B2\n for <dev@dpdk.org>; Tue, 22 Feb 2022 00:03:31 +0100 (CET)", "from LV2PR12MB5992.namprd12.prod.outlook.com (2603:10b6:408:14e::17)\n by BN7PR12MB2803.namprd12.prod.outlook.com (2603:10b6:408:32::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Mon, 21 Feb\n 2022 23:03:30 +0000", "from MW4P222CA0012.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::17)\n by LV2PR12MB5992.namprd12.prod.outlook.com (2603:10b6:408:14e::17)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Mon, 21 Feb\n 2022 23:03:29 +0000", "from CO1NAM11FT018.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:114:cafe::54) by MW4P222CA0012.outlook.office365.com\n (2603:10b6:303:114::17) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16 via Frontend\n Transport; Mon, 21 Feb 2022 23:03:29 +0000", "from mail.nvidia.com (12.22.5.236) by\n CO1NAM11FT018.mail.protection.outlook.com (10.13.175.16) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4995.15 via Frontend Transport; Mon, 21 Feb 2022 23:03:28 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL109.nvidia.com\n (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 21 Feb 2022 23:03:28 +0000", "from pegasus01.mtr.labs.mlnx (10.126.230.35) by\n rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.9;\n Mon, 21 Feb 2022 15:03:25 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=S4AM7cPxBZVLFljsGsYTUf5SKpIdShaVwKCOKTIn8CB5pTzxjMvUg1kz6if49fmE/0EFxrG/lVnwCn7gIGxcGrJwoxOUkJZfWah7xz62jmktHilY3nNSsn1MdS8V6rPxPw7VpbvXEVshjumdlljoaaSjVUx6XAOt9BqJbs4+zHmuve+iLg3xnMvmrbg3S3uAy3Lb8emy+seDjf/LuI6cs1ob9nFNHi04WFST5AnRpuvYZaTbs5Jy8De4BX/DOtydkvC7SqMyuk3EZ6ny2fTogGmfiBepXVoLJMA9SlyxALBxaNECRzXT7rYk766EbrInNmkMnmvXFnpscAbqoQ8slQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=qtsVJTt46DiE1L7aJlShc0x3CLUto2WyGT60cJf4858=;\n b=MoBMMdZFEJ6F0toLJWdkOQqAq2ukBaaXwkoKGUCIr/ssTQQyllOydPrecGvj0ZFQ+qJXlJLnv/zX5Z8Ff9dQXlJZzrtwe/9PM05S7sBsqgo27lCUxup4WVqz3cQIx1KkX8JSg1Pv5rkrJV5fQlNXMOfkKOrtlglPsqTfZ1/UhrF6FZ/LcejDtU0l+Fh1T+kHRhaFBLcGJH4QTadnBwOJRio+zlJ772naMNAbLHeqcJkHINbu9R3so4nM5F/HUrZbVWz8MEWWZuaBEY4ppPYYY1mbUR52CeNtLc0KT+kHV4TLByL8l09lBX3+huOWu8Pi+9d5t3sDAg2RChWJR99Chg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 12.22.5.236) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass\n (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none\n (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=qtsVJTt46DiE1L7aJlShc0x3CLUto2WyGT60cJf4858=;\n b=oTP+QDEl1iBcbFwhd9NhfDQIM2E8CNTgWh7KoMD7VV/IjQ1lTHQnnJMxJlQm8f+wmMXJ0fAKHVkcHAa2grIrcjJPKUJdYRgr9rn3ZY+pehc8ZnUTc1Que9XYtlxM26iY/lIiJkXhs4VpQQ/kek+sCIwexYhXhEW33HxL5DZXaN2AM8oHMlbCurCc3E04bk8CEuelfk7Q9roHMrUalif88zFXlwh6G5n44jRCuM41PZgKwcT13H+DF+3uw/GP3cGjYjnf7KqYCWCVZdMJlu6vopjAZGhtG4jd5ERxT7WhIVyLuFZs+XJv3QvAZfWME0ABkqN4x08MRcE1Jg3CUpv7gA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 12.22.5.236)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 12.22.5.236 as permitted sender) receiver=protection.outlook.com;\n client-ip=12.22.5.236; helo=mail.nvidia.com;", "From": "Alexander Kozyrev <akozyrev@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<orika@nvidia.com>, <thomas@monjalon.net>, <ivan.malov@oktetlabs.ru>,\n <andrew.rybchenko@oktetlabs.ru>, <ferruh.yigit@intel.com>,\n <mohammad.abdul.awal@intel.com>, <qi.z.zhang@intel.com>,\n <jerinj@marvell.com>, <ajit.khaparde@broadcom.com>,\n <bruce.richardson@intel.com>", "Subject": "[PATCH v9 10/11] app/testpmd: add flow queue pull operation", "Date": "Tue, 22 Feb 2022 01:02:39 +0200", "Message-ID": "<20220221230240.2409665-11-akozyrev@nvidia.com>", "X-Mailer": "git-send-email 2.18.2", "In-Reply-To": "<20220221230240.2409665-1-akozyrev@nvidia.com>", "References": "<20220220034409.2226860-1-akozyrev@nvidia.com>\n <20220221230240.2409665-1-akozyrev@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "6dd3a408-2af9-4a9d-61f1-08d9f58e5fac", "X-MS-TrafficTypeDiagnostic": "LV2PR12MB5992:EE_|BN7PR12MB2803:EE_", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <LV2PR12MB5992DC97BDE06B1CCF207583AF3A9@LV2PR12MB5992.namprd12.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n zeEFMjBbWSLiLfpM4+iR5DMpU1N0sr5v3tfCTtvqDNxW1eDZoO5lnFheS6cGHmtktoUtalmJtUmqE6CgdI/RoFUm1cf/vLQbMTO4GKph4kWb+bqOJw8f8wYuesc/G1yxw+wQpkKXmFufziIgVI+Fj9uSICUiosFgdQyfSxGlN0eM0Z8yzNiw8xuAePcDWfRmUEFqDimzHL9vduXWdJJR2rg9WPYsVZ/XJHYYWEf49nCGTK8bHvfwIUzL2fZURL/rD+umi3tGX0uy5TGN4LdHyj3L+PvpTDhw1S6+hPsOLVcM+qP1ougCa6Ftu+1MKWirl7QFfOR/m+lt75UFF/WNTKV39fKVn1siPbph79ywm5jSbIGZcSwHRDhPkHudRwA5NLU2jRWdQKr3D3q+f/A4R/kl+QyjnGF9m72gkCvb0kgt50lve5tzIePzHsUjy7Iz3Nn78+v1S6u5YN1S7lFbNCwBxDxinw0bxOpy2iknG/cHOtOh2COYvuFrlMjCy6l0hRwN6fMY3fsLP19iRZ8+XL0TupKnyXjzB9UHikOuOZM80NmMlHV/dr5avMljsq+i1PWuxfHuFdjwXLUae/w3OaisbquD2I/9B9bCjnarQSBtSrIGomhWPv330jZTSdbvwQxJYqUhG48G0Qg0+VRstdO4N3IDuhh6TshgSrv8jcoaSgq4etUh9TQdIhuRHE5Xpf+BwCq5u6O67vorUy1+Wg==", "X-Forefront-Antispam-Report": "CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE;\n SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(54906003)(8676002)(6916009)(7416002)(26005)(1076003)(16526019)(5660300002)(8936002)(70586007)(70206006)(83380400001)(4326008)(186003)(356005)(82310400004)(316002)(336012)(426003)(81166007)(86362001)(40460700003)(47076005)(36756003)(6666004)(2906002)(36860700001)(508600001)(2616005)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Feb 2022 23:03:28.7679 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6dd3a408-2af9-4a9d-61f1-08d9f58e5fac", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT018.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN7PR12MB2803", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add testpmd support for the rte_flow_pull API.\nProvide the command line interface for pulling operations results.\nUsage example: flow pull 0 queue 0\n\nSigned-off-by: Alexander Kozyrev <akozyrev@nvidia.com>\nAcked-by: Ori Kam <orika@nvidia.com>\n---\n app/test-pmd/cmdline_flow.c | 56 +++++++++++++++-\n app/test-pmd/config.c | 74 +++++++++++++--------\n app/test-pmd/testpmd.h | 1 +\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 25 +++++++\n 4 files changed, 127 insertions(+), 29 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex af36975cdf..d4b72724e6 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -95,6 +95,7 @@ enum index {\n \tFLEX,\n \tQUEUE,\n \tPUSH,\n+\tPULL,\n \n \t/* Flex arguments */\n \tFLEX_ITEM_INIT,\n@@ -142,6 +143,9 @@ enum index {\n \t/* Push arguments. */\n \tPUSH_QUEUE,\n \n+\t/* Pull arguments. */\n+\tPULL_QUEUE,\n+\n \t/* Table arguments. */\n \tTABLE_CREATE,\n \tTABLE_DESTROY,\n@@ -2259,6 +2263,9 @@ static int parse_qo_destroy(struct context *, const struct token *,\n static int parse_push(struct context *, const struct token *,\n \t\t const char *, unsigned int,\n \t\t void *, unsigned int);\n+static int parse_pull(struct context *, const struct token *,\n+\t\t const char *, unsigned int,\n+\t\t void *, unsigned int);\n static int parse_tunnel(struct context *, const struct token *,\n \t\t\tconst char *, unsigned int,\n \t\t\tvoid *, unsigned int);\n@@ -2538,7 +2545,8 @@ static const struct token token_list[] = {\n \t\t\t TUNNEL,\n \t\t\t FLEX,\n \t\t\t QUEUE,\n-\t\t\t PUSH)),\n+\t\t\t PUSH,\n+\t\t\t PULL)),\n \t\t.call = parse_init,\n \t},\n \t/* Top-level command. */\n@@ -2934,6 +2942,21 @@ static const struct token token_list[] = {\n \t\t.args = ARGS(ARGS_ENTRY(struct buffer, queue)),\n \t},\n \t/* Top-level command. */\n+\t[PULL] = {\n+\t\t.name = \"pull\",\n+\t\t.help = \"pull flow operations results\",\n+\t\t.next = NEXT(NEXT_ENTRY(PULL_QUEUE), NEXT_ENTRY(COMMON_PORT_ID)),\n+\t\t.args = ARGS(ARGS_ENTRY(struct buffer, port)),\n+\t\t.call = parse_pull,\n+\t},\n+\t/* Sub-level commands. */\n+\t[PULL_QUEUE] = {\n+\t\t.name = \"queue\",\n+\t\t.help = \"specify queue id\",\n+\t\t.next = NEXT(NEXT_ENTRY(END), NEXT_ENTRY(COMMON_QUEUE_ID)),\n+\t\t.args = ARGS(ARGS_ENTRY(struct buffer, queue)),\n+\t},\n+\t/* Top-level command. */\n \t[INDIRECT_ACTION] = {\n \t\t.name = \"indirect_action\",\n \t\t.type = \"{command} {port_id} [{arg} [...]]\",\n@@ -8786,6 +8809,34 @@ parse_push(struct context *ctx, const struct token *token,\n \treturn len;\n }\n \n+/** Parse tokens for pull command. */\n+static int\n+parse_pull(struct context *ctx, const struct token *token,\n+\t const char *str, unsigned int len,\n+\t void *buf, unsigned int size)\n+{\n+\tstruct buffer *out = buf;\n+\n+\t/* Token name must match. */\n+\tif (parse_default(ctx, token, str, len, NULL, 0) < 0)\n+\t\treturn -1;\n+\t/* Nothing else to do if there is no buffer. */\n+\tif (!out)\n+\t\treturn len;\n+\tif (!out->command) {\n+\t\tif (ctx->curr != PULL)\n+\t\t\treturn -1;\n+\t\tif (sizeof(*out) > size)\n+\t\t\treturn -1;\n+\t\tout->command = ctx->curr;\n+\t\tctx->objdata = 0;\n+\t\tctx->object = out;\n+\t\tctx->objmask = NULL;\n+\t\tout->args.vc.data = (uint8_t *)out + size;\n+\t}\n+\treturn len;\n+}\n+\n static int\n parse_flex(struct context *ctx, const struct token *token,\n \t const char *str, unsigned int len,\n@@ -10174,6 +10225,9 @@ cmd_flow_parsed(const struct buffer *in)\n \tcase PUSH:\n \t\tport_queue_flow_push(in->port, in->queue);\n \t\tbreak;\n+\tcase PULL:\n+\t\tport_queue_flow_pull(in->port, in->queue);\n+\t\tbreak;\n \tcase INDIRECT_ACTION_CREATE:\n \t\tport_action_handle_create(\n \t\t\t\tin->port, in->args.vc.attr.group,\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 9ffb7d88dc..158d1b38a8 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -2469,14 +2469,12 @@ port_queue_flow_create(portid_t port_id, queueid_t queue_id,\n \t\t const struct rte_flow_action *actions)\n {\n \tstruct rte_flow_op_attr op_attr = { .postpone = postpone };\n-\tstruct rte_flow_op_result comp = { 0 };\n \tstruct rte_flow *flow;\n \tstruct rte_port *port;\n \tstruct port_flow *pf;\n \tstruct port_table *pt;\n \tuint32_t id = 0;\n \tbool found;\n-\tint ret = 0;\n \tstruct rte_flow_error error = { RTE_FLOW_ERROR_TYPE_NONE, NULL, NULL };\n \tstruct rte_flow_action_age *age = age_action_get(actions);\n \n@@ -2539,16 +2537,6 @@ port_queue_flow_create(portid_t port_id, queueid_t queue_id,\n \t\treturn port_flow_complain(&error);\n \t}\n \n-\twhile (ret == 0) {\n-\t\t/* Poisoning to make sure PMDs update it in case of error. */\n-\t\tmemset(&error, 0x22, sizeof(error));\n-\t\tret = rte_flow_pull(port_id, queue_id, &comp, 1, &error);\n-\t\tif (ret < 0) {\n-\t\t\tprintf(\"Failed to pull queue\\n\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\t}\n-\n \tpf->next = port->flow_list;\n \tpf->id = id;\n \tpf->flow = flow;\n@@ -2563,7 +2551,6 @@ port_queue_flow_destroy(portid_t port_id, queueid_t queue_id,\n \t\t\tbool postpone, uint32_t n, const uint32_t *rule)\n {\n \tstruct rte_flow_op_attr op_attr = { .postpone = postpone };\n-\tstruct rte_flow_op_result comp = { 0 };\n \tstruct rte_port *port;\n \tstruct port_flow **tmp;\n \tuint32_t c = 0;\n@@ -2599,21 +2586,6 @@ port_queue_flow_destroy(portid_t port_id, queueid_t queue_id,\n \t\t\t\tret = port_flow_complain(&error);\n \t\t\t\tcontinue;\n \t\t\t}\n-\n-\t\t\twhile (ret == 0) {\n-\t\t\t\t/*\n-\t\t\t\t * Poisoning to make sure PMD\n-\t\t\t\t * update it in case of error.\n-\t\t\t\t */\n-\t\t\t\tmemset(&error, 0x44, sizeof(error));\n-\t\t\t\tret = rte_flow_pull(port_id, queue_id,\n-\t\t\t\t\t\t &comp, 1, &error);\n-\t\t\t\tif (ret < 0) {\n-\t\t\t\t\tprintf(\"Failed to pull queue\\n\");\n-\t\t\t\t\treturn -EINVAL;\n-\t\t\t\t}\n-\t\t\t}\n-\n \t\t\tprintf(\"Flow rule #%u destruction enqueued\\n\", pf->id);\n \t\t\t*tmp = pf->next;\n \t\t\tfree(pf);\n@@ -2654,6 +2626,52 @@ port_queue_flow_push(portid_t port_id, queueid_t queue_id)\n \treturn ret;\n }\n \n+/** Pull queue operation results from the queue. */\n+int\n+port_queue_flow_pull(portid_t port_id, queueid_t queue_id)\n+{\n+\tstruct rte_port *port;\n+\tstruct rte_flow_op_result *res;\n+\tstruct rte_flow_error error;\n+\tint ret = 0;\n+\tint success = 0;\n+\tint i;\n+\n+\tif (port_id_is_invalid(port_id, ENABLED_WARN) ||\n+\t port_id == (portid_t)RTE_PORT_ALL)\n+\t\treturn -EINVAL;\n+\tport = &ports[port_id];\n+\n+\tif (queue_id >= port->queue_nb) {\n+\t\tprintf(\"Queue #%u is invalid\\n\", queue_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tres = calloc(port->queue_sz, sizeof(struct rte_flow_op_result));\n+\tif (!res) {\n+\t\tprintf(\"Failed to allocate memory for pulled results\\n\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tmemset(&error, 0x66, sizeof(error));\n+\tret = rte_flow_pull(port_id, queue_id, res,\n+\t\t\t\t port->queue_sz, &error);\n+\tif (ret < 0) {\n+\t\tprintf(\"Failed to pull a operation results\\n\");\n+\t\tfree(res);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (i = 0; i < ret; i++) {\n+\t\tif (res[i].status == RTE_FLOW_OP_SUCCESS)\n+\t\t\tsuccess++;\n+\t}\n+\tprintf(\"Queue #%u pulled %u operations (%u failed, %u succeeded)\\n\",\n+\t queue_id, ret, ret - success, success);\n+\tfree(res);\n+\treturn ret;\n+}\n+\n /** Create flow rule. */\n int\n port_flow_create(portid_t port_id,\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 24a43fd82c..5ea2408a0b 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -941,6 +941,7 @@ int port_queue_flow_create(portid_t port_id, queueid_t queue_id,\n int port_queue_flow_destroy(portid_t port_id, queueid_t queue_id,\n \t\t\t bool postpone, uint32_t n, const uint32_t *rule);\n int port_queue_flow_push(portid_t port_id, queueid_t queue_id);\n+int port_queue_flow_pull(portid_t port_id, queueid_t queue_id);\n int port_flow_validate(portid_t port_id,\n \t\t const struct rte_flow_attr *attr,\n \t\t const struct rte_flow_item *pattern,\ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex 4f1f908d4a..5080ddb256 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -3402,6 +3402,10 @@ following sections.\n \n flow push {port_id} queue {queue_id}\n \n+- Pull all operations results from a queue::\n+\n+ flow pull {port_id} queue {queue_id}\n+\n - Create a flow rule::\n \n flow create {port_id}\n@@ -3637,6 +3641,23 @@ The usual error message is shown when operations cannot be pushed::\n \n Caught error type [...] ([...]): [...]\n \n+Pulling flow operations results\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+``flow pull`` asks the underlying device about flow queue operations\n+results and return all the processed (successfully or not) operations.\n+It is bound to ``rte_flow_pull()``::\n+\n+ flow pull {port_id} queue {queue_id}\n+\n+If successful, it will show::\n+\n+ Queue #[...] pulled #[...] operations (#[...] failed, #[...] succeeded)\n+\n+The usual error message is shown when operations results cannot be pulled::\n+\n+ Caught error type [...] ([...]): [...]\n+\n Creating a tunnel stub for offload\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n \n@@ -3767,6 +3788,8 @@ Otherwise it will show an error message of the form::\n This command uses the same pattern items and actions as ``flow create``,\n their format is described in `Creating flow rules`_.\n \n+``flow queue pull`` must be called to retrieve the operation status.\n+\n Attributes\n ^^^^^^^^^^\n \n@@ -4508,6 +4531,8 @@ message is shown when a rule cannot be destroyed::\n \n Caught error type [...] ([...]): [...]\n \n+``flow queue pull`` must be called to retrieve the operation status.\n+\n Querying flow rules\n ~~~~~~~~~~~~~~~~~~~\n \n", "prefixes": [ "v9", "10/11" ] }