Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107696/?format=api
{ "id": 107696, "url": "http://patches.dpdk.org/api/patches/107696/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220216160610.475242-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220216160610.475242-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220216160610.475242-2-bruce.richardson@intel.com", "date": "2022-02-16T16:06:07", "name": "[1/3] app/test: fix missing checks for DMA device capacity", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "559a1f06fdb49bae20364b9de24141f34c95b9ae", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220216160610.475242-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 21696, "url": "http://patches.dpdk.org/api/series/21696/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21696", "date": "2022-02-16T16:06:09", "name": "idxd driver update fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/21696/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/107696/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/107696/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F3554A00C5;\n\tWed, 16 Feb 2022 17:09:32 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E53FC410FF;\n\tWed, 16 Feb 2022 17:09:32 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id E079940150;\n Wed, 16 Feb 2022 17:09:30 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Feb 2022 08:06:32 -0800", "from silpixa00401026.ir.intel.com ([10.243.22.62])\n by orsmga005.jf.intel.com with ESMTP; 16 Feb 2022 08:06:30 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1645027771; x=1676563771;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=uSBsEdJ227f5pPe3zyuctcmrVBvM0pd0xy3gNXYg12Q=;\n b=KSEtns9xn10mUGn1IsNEbVBcYQJKXimcqovt2os/kbZEnlsV8doUESfD\n CsIwDrRWR9jPUxoIIhtJN0oCNP0m1hSOXdDB+gpi5Mz2N3dNVQE31JVNX\n 1ezAHYnmo9BWJMMjDlSuXyDQuECelGl8MZl8ot9tomibuXi1sILgGpr1/\n CMEWMvmed9USqmvPChMOIs0O1bUxuxl5D0fNtQwTSiJv6GMU0iuDLWbhO\n 9uuInpXi7+XNJFZlh0BAqLmgKaicO2CMzYko9rjFl4dRYAo5b0TUcaVtn\n nvhOqrCKoHj1ha8qas9d+a9RtDYqrQfdMF6NJupYiL1vfz++834/BKnHC A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10260\"; a=\"275236466\"", "E=Sophos;i=\"5.88,374,1635231600\"; d=\"scan'208\";a=\"275236466\"", "E=Sophos;i=\"5.88,374,1635231600\"; d=\"scan'208\";a=\"704363183\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, kevin.laatz@intel.com,\n stable@dpdk.org, Chengwen Feng <fengchengwen@huawei.com>,\n Conor Walsh <conor.walsh@intel.com>", "Subject": "[PATCH 1/3] app/test: fix missing checks for DMA device capacity", "Date": "Wed, 16 Feb 2022 16:06:07 +0000", "Message-Id": "<20220216160610.475242-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220216160610.475242-1-bruce.richardson@intel.com>", "References": "<20220216160610.475242-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For some DMA HW devices, e.g. those using the idxd driver, the maximum\nburst size is configurable, which can lead to test failures if the value\nis set too small. Add explicit check for this to give reasonable error\nmessages for devices which need their config adjusted.\n\nFixes: 1b86a66a30c2 (\"test/dma: add more comprehensive copy tests\")\nFixes: 8fa5d2683940 (\"test/dma: add burst capacity test\")\nCc: kevin.laatz@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test_dmadev.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c\nindex db5aff701c..2b097e0f47 100644\n--- a/app/test/test_dmadev.c\n+++ b/app/test/test_dmadev.c\n@@ -775,6 +775,9 @@ test_dmadev_instance(int16_t dev_id)\n \tif (rte_dma_stats_get(dev_id, vchan, &stats) != 0)\n \t\tERR_RETURN(\"Error with rte_dma_stats_get()\\n\");\n \n+\tif (rte_dma_burst_capacity(dev_id, vchan) < 32)\n+\t\tERR_RETURN(\"Error: Device does not have sufficient burst capacity to run tests\");\n+\n \tif (stats.completed != 0 || stats.submitted != 0 || stats.errors != 0)\n \t\tERR_RETURN(\"Error device stats are not all zero: completed = %\"PRIu64\", \"\n \t\t\t\t\"submitted = %\"PRIu64\", errors = %\"PRIu64\"\\n\",\n@@ -796,7 +799,10 @@ test_dmadev_instance(int16_t dev_id)\n \t\tgoto err;\n \n \t/* run some burst capacity tests */\n-\tif (runtest(\"burst capacity\", test_burst_capacity, 1, dev_id, vchan, CHECK_ERRS) < 0)\n+\tif (rte_dma_burst_capacity(dev_id, vchan) < 64)\n+\t\tprintf(\"DMA Dev %u: insufficient burst capacity (64 required), skipping tests\\n\",\n+\t\t\t\tdev_id);\n+\telse if (runtest(\"burst capacity\", test_burst_capacity, 1, dev_id, vchan, CHECK_ERRS) < 0)\n \t\tgoto err;\n \n \t/* to test error handling we can provide null pointers for source or dest in copies. This\n", "prefixes": [ "1/3" ] }