Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105998/?format=api
{ "id": 105998, "url": "http://patches.dpdk.org/api/patches/105998/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220118050802.3915187-10-akozyrev@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220118050802.3915187-10-akozyrev@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220118050802.3915187-10-akozyrev@nvidia.com", "date": "2022-01-18T05:08:01", "name": "[09/10] app/testpmd: implement rte flow queue dequeue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fa86dd3abd137312584e9a45bf285b0d1dbcfd0c", "submitter": { "id": 1873, "url": "http://patches.dpdk.org/api/people/1873/?format=api", "name": "Alexander Kozyrev", "email": "akozyrev@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220118050802.3915187-10-akozyrev@nvidia.com/mbox/", "series": [ { "id": 21222, "url": "http://patches.dpdk.org/api/series/21222/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21222", "date": "2022-01-18T05:02:11", "name": "ethdev: datapath-focused flow rules management", "version": 1, "mbox": "http://patches.dpdk.org/series/21222/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105998/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105998/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 72448A00C3;\n\tTue, 18 Jan 2022 06:09:38 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E887F426F1;\n\tTue, 18 Jan 2022 06:09:30 +0100 (CET)", "from NAM02-SN1-obe.outbound.protection.outlook.com\n (mail-sn1anam02on2067.outbound.protection.outlook.com [40.107.96.67])\n by mails.dpdk.org (Postfix) with ESMTP id 23622426E2\n for <dev@dpdk.org>; Tue, 18 Jan 2022 06:09:29 +0100 (CET)", "from PH0PR12MB5418.namprd12.prod.outlook.com (2603:10b6:510:e5::19)\n by BY5PR12MB4082.namprd12.prod.outlook.com (2603:10b6:a03:212::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.10; Tue, 18 Jan\n 2022 05:09:27 +0000", "from MW4PR03CA0316.namprd03.prod.outlook.com (2603:10b6:303:dd::21)\n by PH0PR12MB5418.namprd12.prod.outlook.com (2603:10b6:510:e5::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Tue, 18 Jan\n 2022 05:09:26 +0000", "from CO1NAM11FT013.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:dd:cafe::14) by MW4PR03CA0316.outlook.office365.com\n (2603:10b6:303:dd::21) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11 via Frontend\n Transport; Tue, 18 Jan 2022 05:09:26 +0000", "from mail.nvidia.com (12.22.5.238) by\n CO1NAM11FT013.mail.protection.outlook.com (10.13.174.227) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4888.9 via Frontend Transport; Tue, 18 Jan 2022 05:09:25 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL105.nvidia.com\n (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 18 Jan 2022 05:09:25 +0000", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.9; Mon, 17 Jan 2022\n 21:09:22 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=JtUlvrsFRmnkgYRFdXCIdtqyluiYcHbleSECDgXMA2VDTp6KW8PbPbK+no1zFJ8RZ4ZBtAk0tIPWkZ1KQzNRpm1iPgw9W13qpFDV8T0FqqXzWUiDk/GxmhMk3+ll3f8FiPF2559CwteYi71cP9/vs3UNCosGc8YGACBbLtEm2edfIviWy0StdirING0XL428Mz4glgTvAXcPwc70IXEfsYkUMIoWfBo5o8MOwsJ+wi7cr4Pf5LK/V/Uikuc9Ud8v70DXrDDy3+CX5MjWgJI+NFWpoeJXu8HT8RJjvbo05DcOsggLVc2HNWHqruKmv0z0f+iY278pV9q+tJMtz/YI/Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=MbCwJtq/8ubFYUL3cGU7m5AUbPSn8iwvEFjHojPUYWQ=;\n b=AZasQplfBdNEYtLIup7lJj3m3W9OhgQ/pD8YoiWQ+Gvp4ftOJgQizugwNEvfbREcdBlL8FU4eMa/2LDttqSvujvabAi5So2afbdI8q6pOBCNlS0EuNYR04fo4f54JQq1cfIKHMwAc2exjVALfFiPMu0MpYSMVSpN8Y3+6cK/9Ed3oT4h0ANNdtJvEEjRvjAHhZxOFNzxQVyV0j9+kYdctKkgwbDAJr9Z7ugB/+vptRPVIC3mODxpoXWxI5UUDmQoIUoMq9jt9CgnCPgkIxY6WsFkOpBavWDe0DOHwVfTS+hNrDYiLUk57yhYtzK0dTZsbRZnxNMFbvDJzH+pW9dZGQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 12.22.5.238) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass\n (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none\n (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=MbCwJtq/8ubFYUL3cGU7m5AUbPSn8iwvEFjHojPUYWQ=;\n b=pL2wa4nFw+PwwVsMnt9/pnquDL4O72CnQMkFC0bgS/7blyVs67efTguvG1Dva0ljv2x+xg7eqU2U1aIPoJ0F/kUDR0CHmKTHiqngnpjxKzjgAfkdbePQoix4aLcXtt5hPgbb/QKZ7nUv2bqo6+PEQ6JFrTQ+b7sqLmhnpRvvtXRup4MC9Ezm8IdJItbBWwsb9ExejRkNagia8HKto2AWgU0yxyqP0De+RxKGhkoc4NbSHRLCLbw34nJ+f6LV9/cNTJqQ9ABExgKK7HIwCIv8EFixb0pBtWgW549aa/Cbbe5On38MKsRif4XJFiY9mlwiIc0uLZe0MsHC8VyrDXESTg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 12.22.5.238)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 12.22.5.238 as permitted sender) receiver=protection.outlook.com;\n client-ip=12.22.5.238; helo=mail.nvidia.com;", "From": "Alexander Kozyrev <akozyrev@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<orika@nvidia.com>, <thomas@monjalon.net>, <ivan.malov@oktetlabs.ru>,\n <andrew.rybchenko@oktetlabs.ru>, <ferruh.yigit@intel.com>,\n <mohammad.abdul.awal@intel.com>, <qi.z.zhang@intel.com>,\n <jerinj@marvell.com>, <ajit.khaparde@broadcom.com>", "Subject": "[PATCH 09/10] app/testpmd: implement rte flow queue dequeue", "Date": "Tue, 18 Jan 2022 07:08:01 +0200", "Message-ID": "<20220118050802.3915187-10-akozyrev@nvidia.com>", "X-Mailer": "git-send-email 2.18.2", "In-Reply-To": "<20220118050802.3915187-6-akozyrev@nvidia.com>", "References": "<20220118050802.3915187-6-akozyrev@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "57e9a0d8-1cc1-43bc-4b58-08d9da40b2bf", "X-MS-TrafficTypeDiagnostic": "PH0PR12MB5418:EE_|BY5PR12MB4082:EE_", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <PH0PR12MB5418385C5989EE5F530BF2A9AF589@PH0PR12MB5418.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:2803;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n mHefEXX8fIFRGRRp1hzIQAQXY4/sj6mL2Y3L2yNVdHKWRFmbNqrsUCiyChUJJuyr+LLHfMCEoWd9JFCxn3PUp0lcdVh2wMdd2ejpOTUGYfbJ8SsTYSEO4HnOyHL2adpGMWPb68/Pf56f/ezt4DiRXjr0cR5fSXWv5n3xzVlIx0bp2eohoiX7TsZqcUDBzhKVam6vt+1yd31329r9oj53gYY7Q9O5xPxU7vYKMq34s/oFiJZnlKFcFsWPB6YLzzo7E6UOwEDvHYgzXLWuwjPyCd1lzg+N0IgiAyPuq9LOte84vKPHAIRIsVeZvzoLxXZSTzU53V5KXsL13WNMZwWlQcfUmetF+qPa4wU6tTaxSawrm/pmhCoCp2KIEnrD9bz/ljTFd90hfUnNE2Nf/vpX3MYJD/O8sUmROx6SrrGYmo5zvTObXQmvSsAH1Og6rvmyjhOYtpbgQmUJqQJSYlTNf2IBJ9qDc8ICdQN2BXuyJevVukGaAdA1/Co5fTtKJiB4Q+Z5krPmr5MCLTx8Mi/A1Uqfa8KI7xXMYKM3ACCoNkfuMFrVb4S98BVpK3SsYVUoHAkGsHCgYsCZuOWOq9TFXLJE6JcYnou7AIMLPIaSk7C0sEwncCU1uN+6JZ/OFZ9PnPAcACxkEZMblR/ZFQqH1Cx+Z2wTYs29hrOwOj/coR0BoPQ55rw4nd1EI/II5w46lBG5k6GjgvD1MEit5uoUkAcoZcUgAlxKv0kSEBqQGGqrtgTSyhgxXBwdbkQoZQFiS9cqEyHW6gllZ96tUPGEaP587QKdRX2Qt8/4324bEAE=", "X-Forefront-Antispam-Report": "CIP:12.22.5.238; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE;\n SFS:(4636009)(46966006)(40470700002)(36840700001)(316002)(70586007)(70206006)(6666004)(36756003)(16526019)(2616005)(81166007)(186003)(7696005)(26005)(36860700001)(426003)(336012)(6916009)(55016003)(83380400001)(54906003)(8676002)(356005)(4326008)(82310400004)(8936002)(508600001)(5660300002)(40460700001)(47076005)(1076003)(6286002)(2906002)(86362001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 Jan 2022 05:09:25.9872 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 57e9a0d8-1cc1-43bc-4b58-08d9da40b2bf", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.238];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT013.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR12MB4082", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add testpmd support for the rte_flow_q_dequeue API.\nProvide the command line interface for operations dequeue.\nUsage example: flow dequeue 0 queue 0\n\nSigned-off-by: Alexander Kozyrev <akozyrev@nvidia.com>\n---\n app/test-pmd/cmdline_flow.c | 54 +++++++++++++++\n app/test-pmd/config.c | 74 +++++++++++++--------\n app/test-pmd/testpmd.h | 1 +\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 25 +++++++\n 4 files changed, 126 insertions(+), 28 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex e94c01cf75..507eb87984 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -93,6 +93,7 @@ enum index {\n \tTUNNEL,\n \tFLEX,\n \tQUEUE,\n+\tDEQUEUE,\n \tDRAIN,\n \n \t/* Flex arguments */\n@@ -132,6 +133,9 @@ enum index {\n \tQUEUE_DESTROY_ID,\n \tQUEUE_DESTROY_DRAIN,\n \n+\t/* Dequeue arguments. */\n+\tDEQUEUE_QUEUE,\n+\n \t/* Drain arguments. */\n \tDRAIN_QUEUE,\n \n@@ -2159,6 +2163,9 @@ static int parse_qo(struct context *, const struct token *,\n static int parse_qo_destroy(struct context *, const struct token *,\n \t\t\t const char *, unsigned int,\n \t\t\t void *, unsigned int);\n+static int parse_dequeue(struct context *, const struct token *,\n+\t\t\t const char *, unsigned int,\n+\t\t\t void *, unsigned int);\n static int parse_drain(struct context *, const struct token *,\n \t\t const char *, unsigned int,\n \t\t void *, unsigned int);\n@@ -2440,6 +2447,7 @@ static const struct token token_list[] = {\n \t\t\t TUNNEL,\n \t\t\t FLEX,\n \t\t\t QUEUE,\n+\t\t\t DEQUEUE,\n \t\t\t DRAIN)),\n \t\t.call = parse_init,\n \t},\n@@ -2775,6 +2783,21 @@ static const struct token token_list[] = {\n \t\t.call = parse_qo_destroy,\n \t},\n \t/* Top-level command. */\n+\t[DEQUEUE] = {\n+\t\t.name = \"dequeue\",\n+\t\t.help = \"dequeue flow operations\",\n+\t\t.next = NEXT(NEXT_ENTRY(DEQUEUE_QUEUE), NEXT_ENTRY(COMMON_PORT_ID)),\n+\t\t.args = ARGS(ARGS_ENTRY(struct buffer, port)),\n+\t\t.call = parse_dequeue,\n+\t},\n+\t/* Sub-level commands. */\n+\t[DEQUEUE_QUEUE] = {\n+\t\t.name = \"queue\",\n+\t\t.help = \"specify queue id\",\n+\t\t.next = NEXT(NEXT_ENTRY(END), NEXT_ENTRY(COMMON_QUEUE_ID)),\n+\t\t.args = ARGS(ARGS_ENTRY(struct buffer, queue)),\n+\t},\n+\t/* Top-level command. */\n \t[DRAIN] = {\n \t\t.name = \"drain\",\n \t\t.help = \"drain a flow queue\",\n@@ -8408,6 +8431,34 @@ parse_qo_destroy(struct context *ctx, const struct token *token,\n \t}\n }\n \n+/** Parse tokens for dequeue command. */\n+static int\n+parse_dequeue(struct context *ctx, const struct token *token,\n+\t const char *str, unsigned int len,\n+\t void *buf, unsigned int size)\n+{\n+\tstruct buffer *out = buf;\n+\n+\t/* Token name must match. */\n+\tif (parse_default(ctx, token, str, len, NULL, 0) < 0)\n+\t\treturn -1;\n+\t/* Nothing else to do if there is no buffer. */\n+\tif (!out)\n+\t\treturn len;\n+\tif (!out->command) {\n+\t\tif (ctx->curr != DEQUEUE)\n+\t\t\treturn -1;\n+\t\tif (sizeof(*out) > size)\n+\t\t\treturn -1;\n+\t\tout->command = ctx->curr;\n+\t\tctx->objdata = 0;\n+\t\tctx->object = out;\n+\t\tctx->objmask = NULL;\n+\t\tout->args.vc.data = (uint8_t *)out + size;\n+\t}\n+\treturn len;\n+}\n+\n /** Parse tokens for drain queue command. */\n static int\n parse_drain(struct context *ctx, const struct token *token,\n@@ -9800,6 +9851,9 @@ cmd_flow_parsed(const struct buffer *in)\n \t\t\t\t\tin->args.destroy.rule_n,\n \t\t\t\t\tin->args.destroy.rule);\n \t\tbreak;\n+\tcase DEQUEUE:\n+\t\tport_queue_flow_dequeue(in->port, in->queue);\n+\t\tbreak;\n \tcase DRAIN:\n \t\tport_queue_flow_drain(in->port, in->queue);\n \t\tbreak;\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex c6469dd06f..5d23edf562 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -2420,14 +2420,12 @@ port_queue_flow_create(portid_t port_id, queueid_t queue_id,\n \t\t const struct rte_flow_action *actions)\n {\n \tstruct rte_flow_q_ops_attr ops_attr = { .drain = drain };\n-\tstruct rte_flow_q_op_res comp = { 0 };\n \tstruct rte_flow *flow;\n \tstruct rte_port *port;\n \tstruct port_flow *pf;\n \tstruct port_table *pt;\n \tuint32_t id = 0;\n \tbool found;\n-\tint ret = 0;\n \tstruct rte_flow_error error;\n \tstruct rte_flow_action_age *age = age_action_get(actions);\n \n@@ -2477,16 +2475,6 @@ port_queue_flow_create(portid_t port_id, queueid_t queue_id,\n \t\treturn port_flow_complain(&error);\n \t}\n \n-\twhile (ret == 0) {\n-\t\t/* Poisoning to make sure PMDs update it in case of error. */\n-\t\tmemset(&error, 0x22, sizeof(error));\n-\t\tret = rte_flow_q_dequeue(port_id, queue_id, &comp, 1, &error);\n-\t\tif (ret < 0) {\n-\t\t\tprintf(\"Failed to poll queue\\n\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\t}\n-\n \tpf->next = port->flow_list;\n \tpf->id = id;\n \tpf->flow = flow;\n@@ -2501,7 +2489,6 @@ port_queue_flow_destroy(portid_t port_id, queueid_t queue_id,\n \t\t\tbool drain, uint32_t n, const uint32_t *rule)\n {\n \tstruct rte_flow_q_ops_attr op_attr = { .drain = drain };\n-\tstruct rte_flow_q_op_res comp = { 0 };\n \tstruct rte_port *port;\n \tstruct port_flow **tmp;\n \tuint32_t c = 0;\n@@ -2537,21 +2524,6 @@ port_queue_flow_destroy(portid_t port_id, queueid_t queue_id,\n \t\t\t\tret = port_flow_complain(&error);\n \t\t\t\tcontinue;\n \t\t\t}\n-\n-\t\t\twhile (ret == 0) {\n-\t\t\t\t/*\n-\t\t\t\t * Poisoning to make sure PMD\n-\t\t\t\t * update it in case of error.\n-\t\t\t\t */\n-\t\t\t\tmemset(&error, 0x44, sizeof(error));\n-\t\t\t\tret = rte_flow_q_dequeue(port_id, queue_id,\n-\t\t\t\t\t\t\t &comp, 1, &error);\n-\t\t\t\tif (ret < 0) {\n-\t\t\t\t\tprintf(\"Failed to poll queue\\n\");\n-\t\t\t\t\treturn -EINVAL;\n-\t\t\t\t}\n-\t\t\t}\n-\n \t\t\tprintf(\"Flow rule #%u destruction enqueued\\n\", pf->id);\n \t\t\t*tmp = pf->next;\n \t\t\tfree(pf);\n@@ -2592,6 +2564,52 @@ port_queue_flow_drain(portid_t port_id, queueid_t queue_id)\n \treturn ret;\n }\n \n+/** Dequeue a queue operation from the queue. */\n+int\n+port_queue_flow_dequeue(portid_t port_id, queueid_t queue_id)\n+{\n+\tstruct rte_port *port;\n+\tstruct rte_flow_q_op_res *res;\n+\tstruct rte_flow_error error;\n+\tint ret = 0;\n+\tint success = 0;\n+\tint i;\n+\n+\tif (port_id_is_invalid(port_id, ENABLED_WARN) ||\n+\t port_id == (portid_t)RTE_PORT_ALL)\n+\t\treturn -EINVAL;\n+\tport = &ports[port_id];\n+\n+\tif (queue_id >= port->queue_nb) {\n+\t\tprintf(\"Queue #%u is invalid\\n\", queue_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tres = malloc(sizeof(struct rte_flow_q_op_res) * port->queue_sz);\n+\tif (!res) {\n+\t\tprintf(\"Failed to allocate memory for dequeue results\\n\");\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tmemset(&error, 0x66, sizeof(error));\n+\tret = rte_flow_q_dequeue(port_id, queue_id, res,\n+\t\t\t\t port->queue_sz, &error);\n+\tif (ret < 0) {\n+\t\tprintf(\"Failed to dequeue a queue\\n\");\n+\t\tfree(res);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (i = 0; i < ret; i++) {\n+\t\tif (res[i].status == RTE_FLOW_Q_OP_SUCCESS)\n+\t\t\tsuccess++;\n+\t}\n+\tprintf(\"Queue #%u dequeued %u operations (%u failed, %u succeeded)\\n\",\n+\t queue_id, ret, ret - success, success);\n+\tfree(res);\n+\treturn ret;\n+}\n+\n /** Create flow rule. */\n int\n port_flow_create(portid_t port_id,\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex bf4597e7ba..3cf336dbae 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -935,6 +935,7 @@ int port_queue_flow_create(portid_t port_id, queueid_t queue_id,\n int port_queue_flow_destroy(portid_t port_id, queueid_t queue_id,\n \t\t\t bool drain, uint32_t n, const uint32_t *rule);\n int port_queue_flow_drain(portid_t port_id, queueid_t queue_id);\n+int port_queue_flow_dequeue(portid_t port_id, queueid_t queue_id);\n int port_flow_validate(portid_t port_id,\n \t\t const struct rte_flow_attr *attr,\n \t\t const struct rte_flow_item *pattern,\ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex 2ff4e4aef1..fff4de8f00 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -3372,6 +3372,10 @@ following sections.\n \n flow drain {port_id} queue {queue_id}\n \n+- Dequeue all operations from a queue::\n+\n+ flow dequeue {port_id} queue {queue_id}\n+\n - Create a flow rule::\n \n flow create {port_id}\n@@ -3582,6 +3586,23 @@ The usual error message is shown when a queue cannot be drained::\n \n Caught error type [...] ([...]): [...]\n \n+Dequeueing flow operations\n+~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+``flow dequeue`` asks the underlying device about flow queue operations\n+results and return all the processed (successfully or not) operations.\n+It is bound to ``rte_flow_q_dequeue()``::\n+\n+ flow dequeue {port_id} queue {queue_id}\n+\n+If successful, it will show::\n+\n+ Queue #[...] dequeued #[...] operations (#[...] failed, #[...] succeeded)\n+\n+The usual error message is shown when a queue cannot be drained::\n+\n+ Caught error type [...] ([...]): [...]\n+\n Creating a tunnel stub for offload\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n \n@@ -3711,6 +3732,8 @@ Otherwise it will show an error message of the form::\n This command uses the same pattern items and actions as ``flow create``,\n their format is described in `Creating flow rules`_.\n \n+``flow queue dequeue`` must be called to retrieve the operation status.\n+\n Attributes\n ^^^^^^^^^^\n \n@@ -4444,6 +4467,8 @@ message is shown when a rule cannot be destroyed::\n \n Caught error type [...] ([...]): [...]\n \n+``flow queue dequeue`` must be called to retrieve the operation status.\n+\n Querying flow rules\n ~~~~~~~~~~~~~~~~~~~\n \n", "prefixes": [ "09/10" ] }