Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105736/?format=api
{ "id": 105736, "url": "http://patches.dpdk.org/api/patches/105736/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220111134105.1007191-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220111134105.1007191-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220111134105.1007191-2-bruce.richardson@intel.com", "date": "2022-01-11T13:41:02", "name": "[v2,1/4] dma/idxd: fix burst capacity calculation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0533b5ad3b18d9a57b2e3038a98465b454da291b", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220111134105.1007191-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 21125, "url": "http://patches.dpdk.org/api/series/21125/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21125", "date": "2022-01-11T13:41:01", "name": "fixes for dma/idxd", "version": 2, "mbox": "http://patches.dpdk.org/series/21125/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105736/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105736/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 34DC0A034F;\n\tTue, 11 Jan 2022 14:41:41 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2343B42708;\n\tTue, 11 Jan 2022 14:41:41 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 0111441143;\n Tue, 11 Jan 2022 14:41:38 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Jan 2022 05:41:38 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.86])\n by orsmga005.jf.intel.com with ESMTP; 11 Jan 2022 05:41:36 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1641908499; x=1673444499;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=z0N9Bxnw3A4KEGlkTED7T3U6YuuleNducmrX5TimkxI=;\n b=YCtpYMNfs9B4E84hAA4Cj88IlnDup1706fefhSuLLnZ1bW903U6OExAo\n X/qfH9CUQsqAfDiZLjVrBDTs0P369nxb+DOCBYJP2tPuxRrxU3wl/e9oY\n /4ABXyKtFZiM0bW4FSHgs7p6T3nmSEQC0c1xKQrBcG11yr3bqZNLyPZ/C\n wlUaKpiQTZqSd8GvpxCYa5UC8ji8T3pDV442dfCFg9+wABHjaGazK5PkR\n OnHFYjl1fq46TiGcsU1xwecWEYWGGwLalDBnowwLN4djiVE6Q8Df9sEHh\n l8wJAo3qLzSz5XzxrzvcM3KfgpDb5vlgnT1VOSJN6rdaRfgrQ2fmFLjDC Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10223\"; a=\"306836000\"", "E=Sophos;i=\"5.88,279,1635231600\"; d=\"scan'208\";a=\"306836000\"", "E=Sophos;i=\"5.88,279,1635231600\"; d=\"scan'208\";a=\"690997103\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, kevin.laatz@intel.com,\n stable@dpdk.org, Jiayu Hu <jiayu.hu@intel.com>,\n Conor Walsh <conor.walsh@intel.com>,\n Chengwen Feng <fengchengwen@huawei.com>", "Subject": "[PATCH v2 1/4] dma/idxd: fix burst capacity calculation", "Date": "Tue, 11 Jan 2022 13:41:02 +0000", "Message-Id": "<20220111134105.1007191-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20220111134105.1007191-1-bruce.richardson@intel.com>", "References": "<20211220170514.736732-1-bruce.richardson@intel.com>\n <20220111134105.1007191-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the maximum burst size supported by HW is less than the available\nring space, incorrect capacity was returned when there was already some\njobs queued up for submission. This was because the capacity calculation\nfailed to subtract the number of already-enqueued jobs from the max\nburst size. After subtraction is done, ensure that any negative values\n(which should never occur if the user respects the reported limits), are\nclamped to zero.\n\nFixes: 9459de4edc99 (\"dma/idxd: add burst capacity\")\nCc: kevin.laatz@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Kevin Laatz <kevin.laatz@intel.com>\nTested-by: Jiayu Hu <jiayu.hu@intel.com>\n---\n drivers/dma/idxd/idxd_common.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/dma/idxd/idxd_common.c b/drivers/dma/idxd/idxd_common.c\nindex fc11b11337..4442d1cbbd 100644\n--- a/drivers/dma/idxd/idxd_common.c\n+++ b/drivers/dma/idxd/idxd_common.c\n@@ -485,7 +485,9 @@ idxd_burst_capacity(const void *dev_private, uint16_t vchan __rte_unused)\n \t\twrite_idx += idxd->desc_ring_mask + 1;\n \tused_space = write_idx - idxd->ids_returned;\n \n-\treturn RTE_MIN((idxd->desc_ring_mask - used_space), idxd->max_batch_size);\n+\tconst int ret = RTE_MIN((idxd->desc_ring_mask - used_space),\n+\t\t\t(idxd->max_batch_size - idxd->batch_size));\n+\treturn ret < 0 ? 0 : (uint16_t)ret;\n }\n \n int\n", "prefixes": [ "v2", "1/4" ] }