Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 105573,
    "url": "http://patches.dpdk.org/api/patches/105573/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20220103142201.475552-2-amo@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220103142201.475552-2-amo@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220103142201.475552-2-amo@semihalf.com",
    "date": "2022-01-03T14:22:01",
    "name": "[1/1] ring: fix off by 1 mistake",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "51560f69eec256ee3e879bbedff08fc40eac5d72",
    "submitter": {
        "id": 1112,
        "url": "http://patches.dpdk.org/api/people/1112/?format=api",
        "name": "Andrzej Ostruszka",
        "email": "amo@semihalf.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20220103142201.475552-2-amo@semihalf.com/mbox/",
    "series": [
        {
            "id": 21050,
            "url": "http://patches.dpdk.org/api/series/21050/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21050",
            "date": "2022-01-03T14:22:00",
            "name": "Minor mistake in ring (en|de)queueing",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/21050/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/105573/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/105573/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DC36DA04A3;\n\tMon,  3 Jan 2022 15:23:19 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C93FF41141;\n\tMon,  3 Jan 2022 15:23:19 +0100 (CET)",
            "from mail-lj1-f173.google.com (mail-lj1-f173.google.com\n [209.85.208.173])\n by mails.dpdk.org (Postfix) with ESMTP id B982C410E0\n for <dev@dpdk.org>; Mon,  3 Jan 2022 15:23:18 +0100 (CET)",
            "by mail-lj1-f173.google.com with SMTP id t2so4346988ljo.6\n for <dev@dpdk.org>; Mon, 03 Jan 2022 06:23:18 -0800 (PST)",
            "from andrzejo-l.semihalf.net ([83.142.187.84])\n by smtp.googlemail.com with ESMTPSA id p19sm3420800ljj.17.2022.01.03.06.23.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 03 Jan 2022 06:23:18 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=kKD5oJ9I3HjP3Kul2CGaiVsddV3DusCGzMiY/on0koI=;\n b=5sRsvX88CRdl1A3dOrALFG5YQZrZ9e9sh7BOFAnfgQZSx588woIvbGsLEsmzbQ/d5c\n IIXvUnCDgcN4KJvM8fUxtfObmkjRWUp1CM5Ug0CZ+gS9AIdTt+DbGYOv4T0KWXNFDdQa\n BnjCy1fpdANuf8TS+uLuYHYuV2kQzWdTogIdwgJpjHmzr1pwezA+B1x2jcPHa8qHXCsq\n qrvkzb+1f3vwYq55k6Libvrx3jPYMYAN47bulWPYzKJTP+vPxJZRaPZW9a9Xz6nXEjzr\n fVBMn44eKzyD/HVv52fgUf4UbnXdHmwOLVZh3VANrHrOatKD0MTknFEOWCW2dt43jad8\n kG+Q==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=kKD5oJ9I3HjP3Kul2CGaiVsddV3DusCGzMiY/on0koI=;\n b=XNNfRwswCMT+djXW5ppeGMVa7IS8bURHF0AqEzOoyHgsnyWp8gjzrA7muWyUARgex9\n TeLDnyasJq09LJRlnY+KyB4FxEszN4Jomq7CNKP5AXPfvVZez+Ka5qMmPvRcZ1Wmf8tr\n WwSu1lE9Tju2d4MtKJFJ7udDmqaWyt6jtEgzvTKlJuli/827/Q4ATafzvjG4bsSjc3el\n Q46mycgATYQBnPram6K6uLEyaEXCSQbRy12gxtfVivLrR+nbb/ohWzJ6wyU288cGYlJr\n AMgqYRvXBkiA7lEhNk69bT6tetxfVp6XKH4HaaiG8RhxAyg52RbmGr3Ygk2sQLordmcg\n CB2Q==",
        "X-Gm-Message-State": "AOAM532t9MzTXV+g1ryvzDAeUfrgEH4JKGuwqJ4C27gqGu8yA5XvdrIe\n 6jnRu5Oy5s1rtcAVyL9DX5uHEt41za+qJg==",
        "X-Google-Smtp-Source": "\n ABdhPJwDYkInDR66Xlab2lljIT0GOau5LZH1BHtv1ZKye+9ppfOuV4JhCa79H6hXLPARNPZCP5RSMA==",
        "X-Received": "by 2002:a05:651c:114b:: with SMTP id\n h11mr38277649ljo.439.1641219798348;\n Mon, 03 Jan 2022 06:23:18 -0800 (PST)",
        "From": "Andrzej Ostruszka <amo@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "upstream@semihalf.com,\n\tAndrzej Ostruszka <amo@semihalf.com>",
        "Subject": "[PATCH 1/1] ring: fix off by 1 mistake",
        "Date": "Mon,  3 Jan 2022 15:22:01 +0100",
        "Message-Id": "<20220103142201.475552-2-amo@semihalf.com>",
        "X-Mailer": "git-send-email 2.34.1.448.ga2b2bfdf31-goog",
        "In-Reply-To": "<20220103142201.475552-1-amo@semihalf.com>",
        "References": "<20220103142201.475552-1-amo@semihalf.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "When enqueueing/dequeueing to/from the ring we try to optimize by manual\nloop unrolling.  The check for this optimization looks like:\n\n\tif (likely(idx + n < size)) {\n\nwhere 'idx' points to the first usable element (empty slot for enqueue,\ndata for dequeue).  The correct comparison here should be '<=' instead\nof '<'.\n\nThis is not a functional error since we fall back to the loop with\ncorrect checks on indexes.  Just a minor suboptimal behaviour for the\ncase when we want to enqueue/dequeue exactly the number of elements that\nwe have in the ring before wrapping to its beginning.\n\nSigned-off-by: Andrzej Ostruszka <amo@semihalf.com>\n---\n lib/ring/rte_ring_elem_pvt.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/lib/ring/rte_ring_elem_pvt.h b/lib/ring/rte_ring_elem_pvt.h\nindex 275ec55393..83788c56e6 100644\n--- a/lib/ring/rte_ring_elem_pvt.h\n+++ b/lib/ring/rte_ring_elem_pvt.h\n@@ -17,7 +17,7 @@ __rte_ring_enqueue_elems_32(struct rte_ring *r, const uint32_t size,\n \tunsigned int i;\n \tuint32_t *ring = (uint32_t *)&r[1];\n \tconst uint32_t *obj = (const uint32_t *)obj_table;\n-\tif (likely(idx + n < size)) {\n+\tif (likely(idx + n <= size)) {\n \t\tfor (i = 0; i < (n & ~0x7); i += 8, idx += 8) {\n \t\t\tring[idx] = obj[i];\n \t\t\tring[idx + 1] = obj[i + 1];\n@@ -62,7 +62,7 @@ __rte_ring_enqueue_elems_64(struct rte_ring *r, uint32_t prod_head,\n \tuint32_t idx = prod_head & r->mask;\n \tuint64_t *ring = (uint64_t *)&r[1];\n \tconst unaligned_uint64_t *obj = (const unaligned_uint64_t *)obj_table;\n-\tif (likely(idx + n < size)) {\n+\tif (likely(idx + n <= size)) {\n \t\tfor (i = 0; i < (n & ~0x3); i += 4, idx += 4) {\n \t\t\tring[idx] = obj[i];\n \t\t\tring[idx + 1] = obj[i + 1];\n@@ -95,7 +95,7 @@ __rte_ring_enqueue_elems_128(struct rte_ring *r, uint32_t prod_head,\n \tuint32_t idx = prod_head & r->mask;\n \trte_int128_t *ring = (rte_int128_t *)&r[1];\n \tconst rte_int128_t *obj = (const rte_int128_t *)obj_table;\n-\tif (likely(idx + n < size)) {\n+\tif (likely(idx + n <= size)) {\n \t\tfor (i = 0; i < (n & ~0x1); i += 2, idx += 2)\n \t\t\tmemcpy((void *)(ring + idx),\n \t\t\t\t(const void *)(obj + i), 32);\n@@ -151,7 +151,7 @@ __rte_ring_dequeue_elems_32(struct rte_ring *r, const uint32_t size,\n \tunsigned int i;\n \tuint32_t *ring = (uint32_t *)&r[1];\n \tuint32_t *obj = (uint32_t *)obj_table;\n-\tif (likely(idx + n < size)) {\n+\tif (likely(idx + n <= size)) {\n \t\tfor (i = 0; i < (n & ~0x7); i += 8, idx += 8) {\n \t\t\tobj[i] = ring[idx];\n \t\t\tobj[i + 1] = ring[idx + 1];\n@@ -196,7 +196,7 @@ __rte_ring_dequeue_elems_64(struct rte_ring *r, uint32_t prod_head,\n \tuint32_t idx = prod_head & r->mask;\n \tuint64_t *ring = (uint64_t *)&r[1];\n \tunaligned_uint64_t *obj = (unaligned_uint64_t *)obj_table;\n-\tif (likely(idx + n < size)) {\n+\tif (likely(idx + n <= size)) {\n \t\tfor (i = 0; i < (n & ~0x3); i += 4, idx += 4) {\n \t\t\tobj[i] = ring[idx];\n \t\t\tobj[i + 1] = ring[idx + 1];\n@@ -229,7 +229,7 @@ __rte_ring_dequeue_elems_128(struct rte_ring *r, uint32_t prod_head,\n \tuint32_t idx = prod_head & r->mask;\n \trte_int128_t *ring = (rte_int128_t *)&r[1];\n \trte_int128_t *obj = (rte_int128_t *)obj_table;\n-\tif (likely(idx + n < size)) {\n+\tif (likely(idx + n <= size)) {\n \t\tfor (i = 0; i < (n & ~0x1); i += 2, idx += 2)\n \t\t\tmemcpy((void *)(obj + i), (void *)(ring + idx), 32);\n \t\tswitch (n & 0x1) {\n",
    "prefixes": [
        "1/1"
    ]
}