Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 105328,
    "url": "http://patches.dpdk.org/api/patches/105328/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211223044237.52037-1-baymaxhuang@gmail.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20211223044237.52037-1-baymaxhuang@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20211223044237.52037-1-baymaxhuang@gmail.com",
    "date": "2021-12-23T04:42:37",
    "name": "net/virtio: fix unreleased resource when creating virtio user dev is failed",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "79a891400258fb5e0bebf570887452cc5b6a5bb4",
    "submitter": {
        "id": 2435,
        "url": "http://patches.dpdk.org/api/people/2435/?format=api",
        "name": "Harold Huang",
        "email": "baymaxhuang@gmail.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211223044237.52037-1-baymaxhuang@gmail.com/mbox/",
    "series": [
        {
            "id": 21010,
            "url": "http://patches.dpdk.org/api/series/21010/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=21010",
            "date": "2021-12-23T04:42:37",
            "name": "net/virtio: fix unreleased resource when creating virtio user dev is failed",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/21010/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/105328/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/105328/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 585F8A00BE;\n\tThu, 23 Dec 2021 05:43:29 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D60864068C;\n\tThu, 23 Dec 2021 05:43:28 +0100 (CET)",
            "from mail-pj1-f46.google.com (mail-pj1-f46.google.com\n [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 7A5404067B\n for <dev@dpdk.org>; Thu, 23 Dec 2021 05:43:27 +0100 (CET)",
            "by mail-pj1-f46.google.com with SMTP id gj24so4063526pjb.0\n for <dev@dpdk.org>; Wed, 22 Dec 2021 20:43:27 -0800 (PST)",
            "from localhost.localdomain ([157.255.44.216])\n by smtp.gmail.com with ESMTPSA id b9sm4178685pfm.127.2021.12.22.20.43.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Dec 2021 20:43:26 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=KOYC9PwSa78RKnLum7gnGNRYtq13aL0cWyXmlQObJTE=;\n b=P0FYa06oAETDoPrC82cLe0580sCwSjTQNhYcuffe1sNME4q2AE5mSoLTs7rR6QQQBK\n pDyJf+fLDsXgGNIwPjw5gg1t/R4qmKwkheNwNDpGnbLRFaWeJvv11jGJ7L10v28SP80V\n DUwqkfsiVS3qISKS4Qaqm5jNubcHzxV78M3DdNfrzhkuwaJ0Ip0Md0dVryXfWLP6EVyO\n cbduTmfbFbklM2eUfVjwyd7DR6estraLr8gkNThtdvmLsoHwpkLzW85PtVD9Hr1QaQsT\n BXKGF9tKHGot8y4Ckqjis6YfwFBWtUb+uFqDiKhluGz/tOXrNp/ELUeSbCSW4Efak964\n O2OQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=KOYC9PwSa78RKnLum7gnGNRYtq13aL0cWyXmlQObJTE=;\n b=lX2n2Mw2k8KpuDK4F8GPHKQVIJPusCgX4pk4DXl1xTbmkkFd10PgYnrIcNgnJcwIQ/\n qG9EoAKjlNUHd98tMkuCYrq/12lR7zkNQI5nKytp3V03XWNVsDCmn2VZkJ8UFE92dECS\n aPWiRhqQF9yDVM/FvC4tFN78Bkc0bu85Z+1MdbiPYxa7Ef4lWtt+zLBfY10Wb1YdLg4w\n RnYf9QxSmANFHYgAjWGLtkzVZj6YfKnq6UwHVfrEAk1L9OOyU3fHT0oY9wFVXLoutNxZ\n 8TnjrCe7SGTd25Dr8Y8L7K+objrpnnGDHBHgdhNeQD+WlN6QIbRzLkTTWldKYiGiLK5w\n XCbA==",
        "X-Gm-Message-State": "AOAM530bJG8HDDMx2xGve7H5MEiIsL8LoIz5dEI48QlUllrgsPQyx4T9\n dRTpMv49biLZAVmiFCzhxObv1PlVg0IEkg==",
        "X-Google-Smtp-Source": "\n ABdhPJwR6ibiEcoLoFGPVHt44RIZHWilYjBRvRp7T+amup1FWolm7lx4x1nBMy25lZIVw7/OW4NRPQ==",
        "X-Received": "by 2002:a17:902:d2c6:b0:149:b75:b5d6 with SMTP id\n n6-20020a170902d2c600b001490b75b5d6mr774919plc.99.1640234606371;\n Wed, 22 Dec 2021 20:43:26 -0800 (PST)",
        "From": "Harold Huang <baymaxhuang@gmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>",
        "Subject": "[PATCH] net/virtio: fix unreleased resource when creating virtio user\n dev is failed",
        "Date": "Thu, 23 Dec 2021 12:42:37 +0800",
        "Message-Id": "<20211223044237.52037-1-baymaxhuang@gmail.com>",
        "X-Mailer": "git-send-email 2.27.0",
        "In-Reply-To": "<20211220124100.1307675-1-baymaxhuang@gmail.com>",
        "References": "<20211220124100.1307675-1-baymaxhuang@gmail.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "When eth_virtio_dev_init is failed, the registered virtio user memory event\ncb is not released and the backend created tap device is not destroyed.\nIt would cause some residual tap device existed in the host and creating\na new vdev could be failed because the new virtio_user_dev could use the\nsame address pointer and register memory event cb to the same address is\nnot allowed.\n\nSigned-off-by: Harold Huang <baymaxhuang@gmail.com>\n---\nCompared to patch v3, commit log is changed because this bug could\ncause residual tap device in the host.\n drivers/net/virtio/virtio_user_ethdev.c | 1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c\nindex 0271098f0d..16eca2f940 100644\n--- a/drivers/net/virtio/virtio_user_ethdev.c\n+++ b/drivers/net/virtio/virtio_user_ethdev.c\n@@ -666,6 +666,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *vdev)\n \t/* previously called by pci probing for physical dev */\n \tif (eth_virtio_dev_init(eth_dev) < 0) {\n \t\tPMD_INIT_LOG(ERR, \"eth_virtio_dev_init fails\");\n+\t\tvirtio_user_dev_uninit(dev);\n \t\tvirtio_user_eth_dev_free(eth_dev);\n \t\tgoto end;\n \t}\n",
    "prefixes": []
}