Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105271/?format=api
{ "id": 105271, "url": "http://patches.dpdk.org/api/patches/105271/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211220055039.4035627-2-feifei.wang2@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211220055039.4035627-2-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211220055039.4035627-2-feifei.wang2@arm.com", "date": "2021-12-20T05:50:37", "name": "[1/3] net/i40e: reduce redundant store operation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "28bf5c0441fb8ed45a93353d559a96c5b0ee64cc", "submitter": { "id": 1771, "url": "http://patches.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211220055039.4035627-2-feifei.wang2@arm.com/mbox/", "series": [ { "id": 20979, "url": "http://patches.dpdk.org/api/series/20979/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20979", "date": "2021-12-20T05:50:36", "name": "reduce redundant store operation for Tx free", "version": 1, "mbox": "http://patches.dpdk.org/series/20979/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105271/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105271/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B5703A034C;\n\tMon, 20 Dec 2021 06:50:55 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F231241154;\n\tMon, 20 Dec 2021 06:50:52 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 9A72341151\n for <dev@dpdk.org>; Mon, 20 Dec 2021 06:50:51 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 13D8D1042;\n Sun, 19 Dec 2021 21:50:51 -0800 (PST)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.123])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3FA173F5A1;\n Sun, 19 Dec 2021 21:50:49 -0800 (PST)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Beilei Xing <beilei.xing@intel.com>", "Cc": "dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>", "Subject": "[PATCH 1/3] net/i40e: reduce redundant store operation", "Date": "Mon, 20 Dec 2021 13:50:37 +0800", "Message-Id": "<20211220055039.4035627-2-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211220055039.4035627-1-feifei.wang2@arm.com>", "References": "<20211220055039.4035627-1-feifei.wang2@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For free buffer operation in i40e driver, it is unnecessary to store\n'NULL' into txep.mbuf. This is because when putting mbuf into Tx queue,\ntx_tail is the sentinel. And when doing tx_free, tx_next_dd is the\nsentinel. In all processes, mbuf==NULL is not a condition in check.\nThus reset of mbuf is unnecessary and can be omitted.\n\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/i40e/i40e_rxtx.c | 3 ---\n drivers/net/i40e/i40e_rxtx_vec_common.h | 1 -\n 2 files changed, 4 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex e4cb33dc3c..4de2be53e6 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -1344,7 +1344,6 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)\n \t\t\tfor (j = 0; j != k; j += RTE_I40E_TX_MAX_FREE_BUF_SZ) {\n \t\t\t\tfor (i = 0; i < RTE_I40E_TX_MAX_FREE_BUF_SZ; ++i, ++txep) {\n \t\t\t\t\tfree[i] = txep->mbuf;\n-\t\t\t\t\ttxep->mbuf = NULL;\n \t\t\t\t}\n \t\t\t\trte_mempool_put_bulk(free[0]->pool, (void **)free,\n \t\t\t\t\t\tRTE_I40E_TX_MAX_FREE_BUF_SZ);\n@@ -1354,14 +1353,12 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)\n \t\tif (m) {\n \t\t\tfor (i = 0; i < m; ++i, ++txep) {\n \t\t\t\tfree[i] = txep->mbuf;\n-\t\t\t\ttxep->mbuf = NULL;\n \t\t\t}\n \t\t\trte_mempool_put_bulk(free[0]->pool, (void **)free, m);\n \t\t}\n \t} else {\n \t\tfor (i = 0; i < txq->tx_rs_thresh; ++i, ++txep) {\n \t\t\trte_pktmbuf_free_seg(txep->mbuf);\n-\t\t\ttxep->mbuf = NULL;\n \t\t}\n \t}\n \ndiff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h\nindex f9a7f46550..26deb59fc4 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_common.h\n+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h\n@@ -103,7 +103,6 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)\n \tif (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {\n \t\tfor (i = 0; i < n; i++) {\n \t\t\tfree[i] = txep[i].mbuf;\n-\t\t\ttxep[i].mbuf = NULL;\n \t\t}\n \t\trte_mempool_put_bulk(free[0]->pool, (void **)free, n);\n \t\tgoto done;\n", "prefixes": [ "1/3" ] }