Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105258/?format=api
{ "id": 105258, "url": "http://patches.dpdk.org/api/patches/105258/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/3507a733eb704a80a3c13718957d2ab1bc1b39bb.1639636621.git.songyl@ramaxel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<3507a733eb704a80a3c13718957d2ab1bc1b39bb.1639636621.git.songyl@ramaxel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3507a733eb704a80a3c13718957d2ab1bc1b39bb.1639636621.git.songyl@ramaxel.com", "date": "2021-12-18T02:51:44", "name": "[v1,17/25] net/spnic: support RSS configuration update and get", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cef50217ea5eed6860e988363e4bebb34696657c", "submitter": { "id": 2455, "url": "http://patches.dpdk.org/api/people/2455/?format=api", "name": "Yanling Song", "email": "songyl@ramaxel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/3507a733eb704a80a3c13718957d2ab1bc1b39bb.1639636621.git.songyl@ramaxel.com/mbox/", "series": [ { "id": 20973, "url": "http://patches.dpdk.org/api/series/20973/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20973", "date": "2021-12-18T02:51:28", "name": "Net/SPNIC: support SPNIC into DPDK 22.03", "version": 1, "mbox": "http://patches.dpdk.org/series/20973/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105258/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105258/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98572A04A4;\n\tSat, 18 Dec 2021 03:54:52 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 34695426F5;\n\tSat, 18 Dec 2021 03:52:46 +0100 (CET)", "from VLXDG1SPAM1.ramaxel.com (email.ramaxel.com [221.4.138.186])\n by mails.dpdk.org (Postfix) with ESMTP id 0E67B426EE\n for <dev@dpdk.org>; Sat, 18 Dec 2021 03:52:43 +0100 (CET)", "from V12DG1MBS01.ramaxel.local (v12dg1mbs01.ramaxel.local\n [172.26.18.31])\n by VLXDG1SPAM1.ramaxel.com with ESMTPS id 1BI2q27P010347\n (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);\n Sat, 18 Dec 2021 10:52:02 +0800 (GMT-8)\n (envelope-from songyl@ramaxel.com)", "from localhost.localdomain (10.64.9.47) by V12DG1MBS01.ramaxel.local\n (172.26.18.31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Sat, 18\n Dec 2021 10:52:01 +0800" ], "From": "Yanling Song <songyl@ramaxel.com>", "To": "<dev@dpdk.org>", "CC": "<songyl@ramaxel.com>, <yanling.song@linux.dev>, <yanggan@ramaxel.com>,\n <ferruh.yigit@intel.com>", "Subject": "[PATCH v1 17/25] net/spnic: support RSS configuration update and get", "Date": "Sat, 18 Dec 2021 10:51:44 +0800", "Message-ID": "\n <3507a733eb704a80a3c13718957d2ab1bc1b39bb.1639636621.git.songyl@ramaxel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<cover.1639636621.git.songyl@ramaxel.com>", "References": "<cover.1639636621.git.songyl@ramaxel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.64.9.47]", "X-ClientProxiedBy": "V12DG1MBS01.ramaxel.local (172.26.18.31) To\n V12DG1MBS01.ramaxel.local (172.26.18.31)", "X-DNSRBL": "", "X-MAIL": "VLXDG1SPAM1.ramaxel.com 1BI2q27P010347", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This commit implements rss_hash_update and rss_hash_conf_get.\n\nSigned-off-by: Yanling Song <songyl@ramaxel.com>\n---\n drivers/net/spnic/spnic_ethdev.c | 235 +++++++++++++++++++++++++++++++\n 1 file changed, 235 insertions(+)", "diff": "diff --git a/drivers/net/spnic/spnic_ethdev.c b/drivers/net/spnic/spnic_ethdev.c\nindex c97f15e871..61342db497 100644\n--- a/drivers/net/spnic/spnic_ethdev.c\n+++ b/drivers/net/spnic/spnic_ethdev.c\n@@ -1277,6 +1277,233 @@ static int spnic_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)\n \treturn err;\n }\n \n+\n+/**\n+ * Update the RSS hash key and RSS hash type.\n+ *\n+ * @param[in] dev\n+ * Pointer to ethernet device structure.\n+ * @param[in] rss_conf\n+ * RSS configuration data.\n+ *\n+ * @retval zero: Success\n+ * @retval non-zero: Failure\n+ */\n+static int spnic_rss_hash_update(struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_rss_conf *rss_conf)\n+{\n+\tstruct spnic_nic_dev *nic_dev = SPNIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\tstruct spnic_rss_type rss_type = {0};\n+\tu64 rss_hf = rss_conf->rss_hf;\n+\tint err = 0;\n+\n+\tif (nic_dev->rss_state == SPNIC_RSS_DISABLE) {\n+\t\tif (rss_hf != 0)\n+\t\t\treturn -EINVAL;\n+\n+\t\tPMD_DRV_LOG(INFO, \"RSS is not enabled\");\n+\t\treturn 0;\n+\t}\n+\n+\tif (rss_conf->rss_key_len > SPNIC_RSS_KEY_SIZE) {\n+\t\tPMD_DRV_LOG(ERR, \"Invalid RSS key, rss_key_len: %d\",\n+\t\t\t rss_conf->rss_key_len);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (rss_conf->rss_key) {\n+\t\terr = spnic_rss_set_hash_key(nic_dev->hwdev, nic_dev->rss_key);\n+\t\tif (err) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Set RSS hash key failed\");\n+\t\t\treturn err;\n+\t\t}\n+\t\tmemcpy(nic_dev->rss_key, rss_conf->rss_key,\n+\t\t rss_conf->rss_key_len);\n+\t}\n+\n+\trss_type.ipv4 = (rss_hf & (ETH_RSS_IPV4 | ETH_RSS_FRAG_IPV4 |\n+\t\tETH_RSS_NONFRAG_IPV4_OTHER)) ? 1 : 0;\n+\trss_type.tcp_ipv4 = (rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) ? 1 : 0;\n+\trss_type.ipv6 = (rss_hf & (ETH_RSS_IPV6 | ETH_RSS_FRAG_IPV6 |\n+\t\tETH_RSS_NONFRAG_IPV6_OTHER)) ? 1 : 0;\n+\trss_type.ipv6_ext = (rss_hf & ETH_RSS_IPV6_EX) ? 1 : 0;\n+\trss_type.tcp_ipv6 = (rss_hf & ETH_RSS_NONFRAG_IPV6_TCP) ? 1 : 0;\n+\trss_type.tcp_ipv6_ext = (rss_hf & ETH_RSS_IPV6_TCP_EX) ? 1 : 0;\n+\trss_type.udp_ipv4 = (rss_hf & ETH_RSS_NONFRAG_IPV4_UDP) ? 1 : 0;\n+\trss_type.udp_ipv6 = (rss_hf & ETH_RSS_NONFRAG_IPV6_UDP) ? 1 : 0;\n+\n+\terr = spnic_set_rss_type(nic_dev->hwdev, rss_type);\n+\tif (err)\n+\t\tPMD_DRV_LOG(ERR, \"Set RSS type failed\");\n+\n+\treturn err;\n+}\n+\n+/**\n+ * Get the RSS hash configuration.\n+ *\n+ * @param[in] dev\n+ * Pointer to ethernet device structure.\n+ * @param[out] rss_conf\n+ * RSS configuration data.\n+ *\n+ * @retval zero: Success\n+ * @retval non-zero: Failure\n+ */\n+static int spnic_rss_conf_get(struct rte_eth_dev *dev,\n+\t\t\t struct rte_eth_rss_conf *rss_conf)\n+{\n+\tstruct spnic_nic_dev *nic_dev = SPNIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\tstruct spnic_rss_type rss_type = {0};\n+\tint err;\n+\n+\tif (!rss_conf)\n+\t\treturn -EINVAL;\n+\n+\tif (nic_dev->rss_state == SPNIC_RSS_DISABLE) {\n+\t\trss_conf->rss_hf = 0;\n+\t\tPMD_DRV_LOG(INFO, \"RSS is not enabled\");\n+\t\treturn 0;\n+\t}\n+\n+\tif (rss_conf->rss_key &&\n+\t rss_conf->rss_key_len >= SPNIC_RSS_KEY_SIZE) {\n+\t\t/*\n+\t\t * Get RSS key from driver to reduce the frequency of the MPU\n+\t\t * accessing the RSS memory.\n+\t\t */\n+\t\trss_conf->rss_key_len = sizeof(nic_dev->rss_key);\n+\t\tmemcpy(rss_conf->rss_key, nic_dev->rss_key,\n+\t\t rss_conf->rss_key_len);\n+\t}\n+\n+\terr = spnic_get_rss_type(nic_dev->hwdev, &rss_type);\n+\tif (err)\n+\t\treturn err;\n+\n+\trss_conf->rss_hf = 0;\n+\trss_conf->rss_hf |= rss_type.ipv4 ? (ETH_RSS_IPV4 |\n+\t\tETH_RSS_FRAG_IPV4 | ETH_RSS_NONFRAG_IPV4_OTHER) : 0;\n+\trss_conf->rss_hf |= rss_type.tcp_ipv4 ? ETH_RSS_NONFRAG_IPV4_TCP : 0;\n+\trss_conf->rss_hf |= rss_type.ipv6 ? (ETH_RSS_IPV6 |\n+\t\tETH_RSS_FRAG_IPV6 | ETH_RSS_NONFRAG_IPV6_OTHER) : 0;\n+\trss_conf->rss_hf |= rss_type.ipv6_ext ? ETH_RSS_IPV6_EX : 0;\n+\trss_conf->rss_hf |= rss_type.tcp_ipv6 ? ETH_RSS_NONFRAG_IPV6_TCP : 0;\n+\trss_conf->rss_hf |= rss_type.tcp_ipv6_ext ? ETH_RSS_IPV6_TCP_EX : 0;\n+\trss_conf->rss_hf |= rss_type.udp_ipv4 ? ETH_RSS_NONFRAG_IPV4_UDP : 0;\n+\trss_conf->rss_hf |= rss_type.udp_ipv6 ? ETH_RSS_NONFRAG_IPV6_UDP : 0;\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * Get the RETA indirection table.\n+ *\n+ * @param[in] dev\n+ * Pointer to ethernet device structure.\n+ * @param[out] reta_conf\n+ * Pointer to RETA configuration structure array.\n+ * @param[in] reta_size\n+ * Size of the RETA table.\n+ *\n+ * @retval zero: Success\n+ * @retval non-zero: Failure\n+ */\n+static int spnic_rss_reta_query(struct rte_eth_dev *dev,\n+\t\t\t\tstruct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t\t\tuint16_t reta_size)\n+{\n+\tstruct spnic_nic_dev *nic_dev = SPNIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\tu32 indirtbl[SPNIC_RSS_INDIR_SIZE] = {0};\n+\tu16 idx, shift;\n+\tu16 i;\n+\tint err;\n+\n+\tif (nic_dev->rss_state == SPNIC_RSS_DISABLE) {\n+\t\tPMD_DRV_LOG(INFO, \"RSS is not enabled\");\n+\t\treturn 0;\n+\t}\n+\n+\tif (reta_size != SPNIC_RSS_INDIR_SIZE) {\n+\t\tPMD_DRV_LOG(ERR, \"Invalid reta size, reta_size: %d\", reta_size);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\terr = spnic_rss_get_indir_tbl(nic_dev->hwdev, indirtbl);\n+\tif (err) {\n+\t\tPMD_DRV_LOG(ERR, \"Get RSS retas table failed, error: %d\",\n+\t\t\t err);\n+\t\treturn err;\n+\t}\n+\n+\tfor (i = 0; i < reta_size; i++) {\n+\t\tidx = i / RTE_RETA_GROUP_SIZE;\n+\t\tshift = i % RTE_RETA_GROUP_SIZE;\n+\t\tif (reta_conf[idx].mask & (1ULL << shift))\n+\t\t\treta_conf[idx].reta[shift] = (uint16_t)indirtbl[i];\n+\t}\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * Update the RETA indirection table.\n+ *\n+ * @param[in] dev\n+ * Pointer to ethernet device structure.\n+ * @param[in] reta_conf\n+ * Pointer to RETA configuration structure array.\n+ * @param[in] reta_size\n+ * Size of the RETA table.\n+ *\n+ * @retval zero: Success\n+ * @retval non-zero: Failure\n+ */\n+static int spnic_rss_reta_update(struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t\t\t uint16_t reta_size)\n+{\n+\tstruct spnic_nic_dev *nic_dev = SPNIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev);\n+\tu32 indirtbl[SPNIC_RSS_INDIR_SIZE] = {0};\n+\tu16 idx, shift;\n+\tu16 i;\n+\tint err;\n+\n+\tif (nic_dev->rss_state == SPNIC_RSS_DISABLE)\n+\t\treturn 0;\n+\n+\tif (reta_size != SPNIC_RSS_INDIR_SIZE) {\n+\t\tPMD_DRV_LOG(ERR, \"Invalid reta size, reta_size: %d\", reta_size);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\terr = spnic_rss_get_indir_tbl(nic_dev->hwdev, indirtbl);\n+\tif (err)\n+\t\treturn err;\n+\n+\t/* Update RSS reta table */\n+\tfor (i = 0; i < reta_size; i++) {\n+\t\tidx = i / RTE_RETA_GROUP_SIZE;\n+\t\tshift = i % RTE_RETA_GROUP_SIZE;\n+\t\tif (reta_conf[idx].mask & (1ULL << shift))\n+\t\t\tindirtbl[i] = reta_conf[idx].reta[shift];\n+\t}\n+\n+\tfor (i = 0 ; i < reta_size; i++) {\n+\t\tif (indirtbl[i] >= nic_dev->num_rqs) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Invalid reta entry, index: %d, num_rqs: %d\",\n+\t\t\t\t indirtbl[i], nic_dev->num_rqs);\n+\t\t\treturn -EFAULT;\n+\t\t}\n+\t}\n+\n+\terr = spnic_rss_set_indir_tbl(nic_dev->hwdev, indirtbl);\n+\tif (err)\n+\t\tPMD_DRV_LOG(ERR, \"Set RSS reta table failed\");\n+\n+\treturn err;\n+}\n+\n /**\n * Update MAC address\n *\n@@ -1484,6 +1711,10 @@ static const struct eth_dev_ops spnic_pmd_ops = {\n \t.dev_stop = spnic_dev_stop,\n \t.dev_close = spnic_dev_close,\n \t.mtu_set = spnic_dev_set_mtu,\n+\t.rss_hash_update = spnic_rss_hash_update,\n+\t.rss_hash_conf_get = spnic_rss_conf_get,\n+\t.reta_update = spnic_rss_reta_update,\n+\t.reta_query = spnic_rss_reta_query,\n \t.mac_addr_set = spnic_set_mac_addr,\n \t.mac_addr_remove = spnic_mac_addr_remove,\n \t.mac_addr_add = spnic_mac_addr_add,\n@@ -1503,6 +1734,10 @@ static const struct eth_dev_ops spnic_pmd_vf_ops = {\n \t.dev_stop = spnic_dev_stop,\n \t.dev_close = spnic_dev_close,\n \t.mtu_set = spnic_dev_set_mtu,\n+\t.rss_hash_update = spnic_rss_hash_update,\n+\t.rss_hash_conf_get = spnic_rss_conf_get,\n+\t.reta_update = spnic_rss_reta_update,\n+\t.reta_query = spnic_rss_reta_query,\n \t.mac_addr_set = spnic_set_mac_addr,\n \t.mac_addr_remove = spnic_mac_addr_remove,\n \t.mac_addr_add = spnic_mac_addr_add,\n", "prefixes": [ "v1", "17/25" ] }