Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105158/?format=api
{ "id": 105158, "url": "http://patches.dpdk.org/api/patches/105158/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211216111430.699717-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211216111430.699717-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211216111430.699717-1-bruce.richardson@intel.com", "date": "2021-12-16T11:14:30", "name": "config: remove explicit undef of unset values", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "33312d1ef6233f3d646d05b8b9303869e2fe573d", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211216111430.699717-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 20952, "url": "http://patches.dpdk.org/api/series/20952/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20952", "date": "2021-12-16T11:14:30", "name": "config: remove explicit undef of unset values", "version": 1, "mbox": "http://patches.dpdk.org/series/20952/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105158/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/105158/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DEEF6A00C3;\n\tThu, 16 Dec 2021 12:15:01 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B3CCE40696;\n\tThu, 16 Dec 2021 12:15:01 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 3C5CF40143\n for <dev@dpdk.org>; Thu, 16 Dec 2021 12:15:00 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Dec 2021 03:14:59 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.86])\n by orsmga008.jf.intel.com with ESMTP; 16 Dec 2021 03:14:57 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1639653300; x=1671189300;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=MJFLwNGDna9js03LayJvgsgQMe64bXCoEkmsGDBxnGo=;\n b=cqIE7WjAFGvFdqauBPYDnyu6m2RKvo19u1pBYy8ffXRk0lfXNNmlj6w9\n OO8m92VF6U/Xwduj32/hNo4VaO6WzUWvz5mOPOV/OMXXiBGRu8v+ahH/r\n nU+KHXFPg1P3850Ez714u4izEFUqzFJOKEiliE3O/RGvdTix9eiBCfD1s\n EFspInsZdaYW3LPWMf5W+E9kY6tF7h6UrE/TGQX+Bj996A/3QU+Q0FDge\n mAaPLvhXWiup78zKcB4QF1WBq4ExVcUYk2kE4w8aK433G3zFQZrX5dsDO\n RxO2aBstjn+GqX2ktZO+Odjxpp5Ov52mdmmiyNdH2tlT2fviLKrj1zuHA g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10199\"; a=\"238203538\"", "E=Sophos;i=\"5.88,211,1635231600\"; d=\"scan'208\";a=\"238203538\"", "E=Sophos;i=\"5.88,211,1635231600\"; d=\"scan'208\";a=\"519207074\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, junx.dong@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH] config: remove explicit undef of unset values", "Date": "Thu, 16 Dec 2021 11:14:30 +0000", "Message-Id": "<20211216111430.699717-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Rather than explicitly clearing any setting of undefined values in our\nrte_config.h file, it's better to instead just add a comment that the\nvalue is not set. Using a comment allows the user to set the value using\nCFLAGS or similar mechanism without the config file clearing the value\nagain.\n\nThe text used \"<VALUE> is not set\" is modelled after the kernel approach\nof doing the same thing.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n\nAlthough DPDK coding convention forbids use of \"//\" for comments, using\nregular C comment style makes the config settings less clear, as they can\nbe confused with regular comments in the file. Using \"//\" makes them stand\nout better, so I prefer it. However, if others feel strongly, they can be\nchanged to standard.\n\nNote: this is a resubmission of patch [1] which was part of a rejected\nseries. However, the reasons for rejection - values in config being out\nof sync with those used for building apps - are less relevant for\nmany, if not all, of these setting, so I believe the benefits for\ntesting outweigh the potential downsides. If any setting is likely\nproblematic, I can keep the explicit undef for that case in a new patch\nversion.\n\n[1] http://patches.dpdk.org/project/dpdk/patch/20200903144942.671870-2-bruce.richardson@intel.com/\n---\n config/rte_config.h | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/config/rte_config.h b/config/rte_config.h\nindex cab4390a97..953216babd 100644\n--- a/config/rte_config.h\n+++ b/config/rte_config.h\n@@ -83,17 +83,17 @@\n \n /* ip_fragmentation defines */\n #define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8\n-#undef RTE_LIBRTE_IP_FRAG_TBL_STAT\n+// RTE_LIBRTE_IP_FRAG_TBL_STAT is not set\n \n /* rte_power defines */\n #define RTE_MAX_LCORE_FREQS 64\n \n /* rte_sched defines */\n-#undef RTE_SCHED_CMAN\n-#undef RTE_SCHED_COLLECT_STATS\n-#undef RTE_SCHED_SUBPORT_TC_OV\n+// RTE_SCHED_CMAN is not set\n+// RTE_SCHED_COLLECT_STATS is not set\n+// RTE_SCHED_SUBPORT_TC_OV is not set\n #define RTE_SCHED_PORT_N_GRINDERS 8\n-#undef RTE_SCHED_VECTOR\n+// RTE_SCHED_VECTOR is not set\n \n /* KNI defines */\n #define RTE_KNI_PREEMPT_DEFAULT 1\n@@ -127,7 +127,7 @@\n \n /* i40e defines */\n #define RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC 1\n-#undef RTE_LIBRTE_I40E_16BYTE_RX_DESC\n+// RTE_LIBRTE_I40E_16BYTE_RX_DESC is not set\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF 64\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4\n #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4\n@@ -140,6 +140,6 @@\n #define RTE_LIBRTE_QEDE_FW \"\"\n \n /* DLB2 defines */\n-#undef RTE_LIBRTE_PMD_DLB2_QUELL_STATS\n+// RTE_LIBRTE_PMD_DLB2_QUELL_STATS is not set\n \n #endif /* _RTE_CONFIG_H_ */\n", "prefixes": [] }