Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105154/?format=api
{ "id": 105154, "url": "http://patches.dpdk.org/api/patches/105154/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211215184859.1859870-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211215184859.1859870-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211215184859.1859870-1-ferruh.yigit@intel.com", "date": "2021-12-15T18:48:59", "name": "[dpdk-kmods] linux/igb_uio: fix build for switch fall through", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2794b3793ced7afa8226af92455af87603f66169", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211215184859.1859870-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 20949, "url": "http://patches.dpdk.org/api/series/20949/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20949", "date": "2021-12-15T18:48:59", "name": "[dpdk-kmods] linux/igb_uio: fix build for switch fall through", "version": 1, "mbox": "http://patches.dpdk.org/series/20949/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105154/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/105154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2F6C6A00C3;\n\tWed, 15 Dec 2021 19:49:19 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ED6D140688;\n\tWed, 15 Dec 2021 19:49:18 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 5007140041\n for <dev@dpdk.org>; Wed, 15 Dec 2021 19:49:16 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Dec 2021 10:49:02 -0800", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.27])\n by orsmga001.jf.intel.com with ESMTP; 15 Dec 2021 10:49:01 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1639594157; x=1671130157;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=dBDgascdiySxaSXEkVr29qOBjLWtzlzAjorUPKXie5k=;\n b=AMAB9YOr2ghQQoA5wjphc3/vwL5yyCyLUDKpkyS2hEgRceFyDkNNyUfV\n KP5hIbAVsSjb4EknoqyVb+JqU2Bts5H3HuBTrb68uAGKDGeTx6rIrhnh3\n Rf2SxAqNxyxDSjcXR6T5fZdMj7gGIZR1X1IMHPasmK4336loDuVYWGQl0\n qPuAz86IYUA26f8aE4WUGR44+wa9vKJAYBMoULCfuSGnIbhQuCZYtJxof\n SSeyjTa90oCKCCee/yvvvufWMK4Hag4ss1nZJdiP3mrqdHWzwg0DuxqfN\n sig/aCNA3coG3dPAoMo/8y0gnLeCtsbJE7hoR9o/J/MWJ+Px2i/dUuHpL A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10199\"; a=\"239531738\"", "E=Sophos;i=\"5.88,207,1635231600\"; d=\"scan'208\";a=\"239531738\"", "E=Sophos;i=\"5.88,207,1635231600\"; d=\"scan'208\";a=\"545682610\"" ], "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>", "Subject": "[dpdk-kmods] linux/igb_uio: fix build for switch fall through", "Date": "Wed, 15 Dec 2021 18:48:59 +0000", "Message-Id": "<20211215184859.1859870-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.33.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Linux is using '-Wimplicit-fallthrough=5' compiler option, which doesn't\ntake any fall through comments into account but only uses compiler\n'fallthrough' attribute to document fall through action is intended.\n\n\"falls through\" comment was used in the code which is causing a build\nerror now, this patch converts comment to the 'fallthrough' macro\ndefined in the Linux.\n\nTo cover the case where Linux version doesn't have the macro, defined it\nin the compatibility header too.\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n linux/igb_uio/compat.h | 4 ++++\n linux/igb_uio/igb_uio.c | 6 +++---\n 2 files changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/linux/igb_uio/compat.h b/linux/igb_uio/compat.h\nindex 8dbb896ae118..04ff7f60031f 100644\n--- a/linux/igb_uio/compat.h\n+++ b/linux/igb_uio/compat.h\n@@ -152,3 +152,7 @@ static inline bool igbuio_kernel_is_locked_down(void)\n \treturn false;\n #endif\n }\n+\n+#ifndef fallthrough\n+#define fallthrough\tdo {} while (0) /* fallthrough */\n+#endif\ndiff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c\nindex ea439d131de1..33e0e0286b69 100644\n--- a/linux/igb_uio/igb_uio.c\n+++ b/linux/igb_uio/igb_uio.c\n@@ -250,7 +250,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)\n \t\t}\n #endif\n \n-\t/* falls through - to MSI */\n+\tfallthrough;\n \tcase RTE_INTR_MODE_MSI:\n #ifndef HAVE_ALLOC_IRQ_VECTORS\n \t\tif (pci_enable_msi(udev->pdev) == 0) {\n@@ -269,7 +269,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)\n \t\t\tbreak;\n \t\t}\n #endif\n-\t/* falls through - to INTX */\n+\tfallthrough;\n \tcase RTE_INTR_MODE_LEGACY:\n \t\tif (pci_intx_mask_supported(udev->pdev)) {\n \t\t\tdev_dbg(&udev->pdev->dev, \"using INTX\");\n@@ -279,7 +279,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)\n \t\t\tbreak;\n \t\t}\n \t\tdev_notice(&udev->pdev->dev, \"PCI INTX mask not supported\\n\");\n-\t/* falls through - to no IRQ */\n+\tfallthrough;\n \tcase RTE_INTR_MODE_NONE:\n \t\tudev->mode = RTE_INTR_MODE_NONE;\n \t\tudev->info.irq = UIO_IRQ_NONE;\n", "prefixes": [ "dpdk-kmods" ] }