Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105149/?format=api
{ "id": 105149, "url": "http://patches.dpdk.org/api/patches/105149/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1639592401-56845-4-git-send-email-rsanford@akamai.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1639592401-56845-4-git-send-email-rsanford@akamai.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1639592401-56845-4-git-send-email-rsanford@akamai.com", "date": "2021-12-15T18:19:57", "name": "[3/7] net/bonding: change mbuf pool and ring allocation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7207f9657ee818f6cf64bd7c3186e4e292ffe9cc", "submitter": { "id": 7, "url": "http://patches.dpdk.org/api/people/7/?format=api", "name": "Robert Sanford", "email": "rsanford2@gmail.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1639592401-56845-4-git-send-email-rsanford@akamai.com/mbox/", "series": [ { "id": 20948, "url": "http://patches.dpdk.org/api/series/20948/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20948", "date": "2021-12-15T18:19:54", "name": "net/bonding: fixes and LACP short timeout", "version": 1, "mbox": "http://patches.dpdk.org/series/20948/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105149/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/105149/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6AD96A00C3;\n\tWed, 15 Dec 2021 19:20:46 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BC9B841158;\n\tWed, 15 Dec 2021 19:20:29 +0100 (CET)", "from mail-qk1-f174.google.com (mail-qk1-f174.google.com\n [209.85.222.174])\n by mails.dpdk.org (Postfix) with ESMTP id ABB3341147\n for <dev@dpdk.org>; Wed, 15 Dec 2021 19:20:27 +0100 (CET)", "by mail-qk1-f174.google.com with SMTP id m192so20928666qke.2\n for <dev@dpdk.org>; Wed, 15 Dec 2021 10:20:27 -0800 (PST)", "from ubuntu.localdomain\n (99-153-167-175.lightspeed.ftldfl.sbcglobal.net. [99.153.167.175])\n by smtp.gmail.com with ESMTPSA id 8sm2075978qtz.28.2021.12.15.10.20.26\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 15 Dec 2021 10:20:26 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=pXc71Yjkb1Baq56SEiQnuVV78bH0xh2zlKx/DgaqBRE=;\n b=YUjrKEtVgeMmNuuXvFkqjyqzP3aC++WJQ3Wqvfjp6FZToqDY3nSnWZMNFB7Gdi7FNz\n 0GJfJEn1VqPx7KASzCMZnr1cM2GpA534HhNvcwtNLbFuKJswrv38raD34HuQPd3qPSbD\n 4CXOEb5Nwm8VLXqAVYqN5f5Hb+cKOfr/1Pw6LbxvLEpZOgccKNSlSuA50+frU2e7gOvs\n OE8O5QmogIHf9jHqC1bJBCfX5rSkyi20y8MoUg5tGOe06WcgFUb1RrAdOBmGqfdcL4Vb\n P8943O3m7XYURiyq+PCujJlmhxKlUGqfwwz5VBk9hVug7VHrdaJiwBjeFkHj1Ypmb7Pq\n Ou1g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=pXc71Yjkb1Baq56SEiQnuVV78bH0xh2zlKx/DgaqBRE=;\n b=iRo/uoCfvahB08IO3qvMG3UqC39ue9e94wBx00TXsp8ruMKYP6+lDpEmlRWu8boXnV\n a7pbmvSDLUEsijusJhzGg8Ek3qOgj6AOttxWsvI0GE1BkL7eAWC5/xI5e5It1ZNTv6Qi\n dfOUItmqCvl/bmq51rE7MjmtVIaozqLXO2wegix4fm593AmmQzMDyl7kbD8p5mkfRVer\n C+m6fHYbOZPgWNftJlsjiU7fQc0KH2kHDx4r0uryTrgxHz1PBGHfh3IaYD0AElDGBk7j\n BfVB0Kd2C3sCUfCNrXc/s0gIkrYFd38sf9dL+9COmhew2RZ2LBWKAfCPsqgHOT4G1ZA8\n FiKQ==", "X-Gm-Message-State": "AOAM531pS2qqM9RudQ6WefN9Y5XxNhQPapNB0kSMRYsOvdf3C3oOoRZy\n ZTtokD/XDsh99NyirOus5+cnyOnVwgA=", "X-Google-Smtp-Source": "\n ABdhPJy+PTdZ5798lNcUqxqHYpc/jHJxdH7rdDO+oUl25BrMVoTLf/CKl3SpOYWpyimSxmwrI1kW3Q==", "X-Received": "by 2002:a37:de09:: with SMTP id h9mr9559969qkj.764.1639592427018;\n Wed, 15 Dec 2021 10:20:27 -0800 (PST)", "From": "Robert Sanford <rsanford2@gmail.com>", "X-Google-Original-From": "Robert Sanford <rsanford@akamai.com>", "To": "dev@dpdk.org", "Cc": "chas3@att.com,\n\thumin29@huawei.com", "Subject": "[PATCH 3/7] net/bonding: change mbuf pool and ring allocation", "Date": "Wed, 15 Dec 2021 13:19:57 -0500", "Message-Id": "<1639592401-56845-4-git-send-email-rsanford@akamai.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1639592401-56845-1-git-send-email-rsanford@akamai.com>", "References": "<1639592401-56845-1-git-send-email-rsanford@akamai.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Turn off mbuf pool caching to avoid mbufs lingering in pool caches.\n At most, we transmit one LACPDU per second, per port.\n- Fix calculation of ring sizes, taking into account that a ring of\n size N holds up to N-1 items.\n\nSigned-off-by: Robert Sanford <rsanford@akamai.com>\n---\n drivers/net/bonding/rte_eth_bond_8023ad.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\nindex 43231bc..83d3938 100644\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\n@@ -1101,9 +1101,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev,\n \t}\n \n \tsnprintf(mem_name, RTE_DIM(mem_name), \"slave_port%u_pool\", slave_id);\n-\tport->mbuf_pool = rte_pktmbuf_pool_create(mem_name, total_tx_desc,\n-\t\tRTE_MEMPOOL_CACHE_MAX_SIZE >= 32 ?\n-\t\t\t32 : RTE_MEMPOOL_CACHE_MAX_SIZE,\n+\tport->mbuf_pool = rte_pktmbuf_pool_create(mem_name, total_tx_desc, 0,\n \t\t0, element_size, socket_id);\n \n \t/* Any memory allocation failure in initialization is critical because\n@@ -1113,19 +1111,23 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev,\n \t\t\tslave_id, mem_name, rte_strerror(rte_errno));\n \t}\n \n+\t/* Add one extra because ring reserves one. */\n \tsnprintf(mem_name, RTE_DIM(mem_name), \"slave_%u_rx\", slave_id);\n \tport->rx_ring = rte_ring_create(mem_name,\n-\t\t\trte_align32pow2(BOND_MODE_8023AX_SLAVE_RX_PKTS), socket_id, 0);\n+\t\t\trte_align32pow2(BOND_MODE_8023AX_SLAVE_RX_PKTS + 1),\n+\t\t\tsocket_id, 0);\n \n \tif (port->rx_ring == NULL) {\n \t\trte_panic(\"Slave %u: Failed to create rx ring '%s': %s\\n\", slave_id,\n \t\t\tmem_name, rte_strerror(rte_errno));\n \t}\n \n-\t/* TX ring is at least one pkt longer to make room for marker packet. */\n+\t/* TX ring is at least one pkt longer to make room for marker packet.\n+\t * Add one extra because ring reserves one. */\n \tsnprintf(mem_name, RTE_DIM(mem_name), \"slave_%u_tx\", slave_id);\n \tport->tx_ring = rte_ring_create(mem_name,\n-\t\t\trte_align32pow2(BOND_MODE_8023AX_SLAVE_TX_PKTS + 1), socket_id, 0);\n+\t\t\trte_align32pow2(BOND_MODE_8023AX_SLAVE_TX_PKTS + 2),\n+\t\t\tsocket_id, 0);\n \n \tif (port->tx_ring == NULL) {\n \t\trte_panic(\"Slave %u: Failed to create tx ring '%s': %s\\n\", slave_id,\n", "prefixes": [ "3/7" ] }