Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105147/?format=api
{ "id": 105147, "url": "http://patches.dpdk.org/api/patches/105147/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1639592401-56845-2-git-send-email-rsanford@akamai.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1639592401-56845-2-git-send-email-rsanford@akamai.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1639592401-56845-2-git-send-email-rsanford@akamai.com", "date": "2021-12-15T18:19:55", "name": "[1/7] net/bonding: fix typos and whitespace", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9acde4abb6865bb4ee10890b2ae4c231b5a5d15f", "submitter": { "id": 7, "url": "http://patches.dpdk.org/api/people/7/?format=api", "name": "Robert Sanford", "email": "rsanford2@gmail.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1639592401-56845-2-git-send-email-rsanford@akamai.com/mbox/", "series": [ { "id": 20948, "url": "http://patches.dpdk.org/api/series/20948/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20948", "date": "2021-12-15T18:19:54", "name": "net/bonding: fixes and LACP short timeout", "version": 1, "mbox": "http://patches.dpdk.org/series/20948/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105147/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/105147/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 691DDA00C3;\n\tWed, 15 Dec 2021 19:20:33 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6A2CE41143;\n\tWed, 15 Dec 2021 19:20:27 +0100 (CET)", "from mail-qk1-f177.google.com (mail-qk1-f177.google.com\n [209.85.222.177])\n by mails.dpdk.org (Postfix) with ESMTP id 2AE1340041\n for <dev@dpdk.org>; Wed, 15 Dec 2021 19:20:26 +0100 (CET)", "by mail-qk1-f177.google.com with SMTP id t6so20957205qkg.1\n for <dev@dpdk.org>; Wed, 15 Dec 2021 10:20:26 -0800 (PST)", "from ubuntu.localdomain\n (99-153-167-175.lightspeed.ftldfl.sbcglobal.net. [99.153.167.175])\n by smtp.gmail.com with ESMTPSA id 8sm2075978qtz.28.2021.12.15.10.20.24\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 15 Dec 2021 10:20:24 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=xYSs9ULqYBCDoNIEvcCwDKXsXeMVHVUbtkfl+YY9mjk=;\n b=XE4tjn7iNVTmh8cuXgMV5+MkE88ZGlTO98S/RwLCQfPEu+XP8GDLC5MXE0k12N8BLv\n Xv5OrcHuF5r44s2u3uZztEAoZmd7nZCMDW5ivHCEAW42cvlDtfWmHpSaSLwhKoAiqE0Z\n fnq5rpx14fR/lrvs/tRFt7FNMX1rlYMGj3iYFLCCaJQWpzqoQpOUG1oUaa0TBXEBrqDO\n OfyFQs5MDgbtzhJU4YI+gmz/LK0UIpa34eI3bNTPduGYOx4Q4YWB00cNHQD4MtzryD75\n xn2uIaMVEGKmGjcTnnsCWGwhCj5b/As8Rvm6IcQMnCfhKqYcqHphLwQ+2LRlc81kbrQ6\n KJWA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=xYSs9ULqYBCDoNIEvcCwDKXsXeMVHVUbtkfl+YY9mjk=;\n b=uw5hNgPyW+a4eycW7eg9rrk9iNkuZEd/I5HUWFDkqSlc/tpPjfeAGwFmJRlPuRRwZN\n NgGU+jPUefVmooibR9YvcCVh6f0Gi3GrcCNjdlyPCE+Kp5n9hXRanXxc/5EYO1rPB8mb\n /hj6asGrC8TZRcwRFbbQDOVN/UdklE13lMF+PpdOBuuR6mBArX4IR7U4PGvNUfbAGzhm\n /z4F3gDp3HH88X3WhvrB0rhcscA0RZ+oCSXBPUEOnXb3bj/RTWewfGaRrrfXzA4sJZ/T\n Hsr3GfH99rqxBGvhjWC8nEJN97pASuNx070wEqt7qLR0brkLAUTQ5qeV2sfFrWC28vvS\n EAQg==", "X-Gm-Message-State": "AOAM5318imFVK/BwlxFjiDF+AYeJBh4u+aAjQVA2He5C02xhP8H3SQ3T\n t1DAvWPxQ+hPwkGxS7BOlv0wxrH/Vso=", "X-Google-Smtp-Source": "\n ABdhPJxkfmMkEAEwWNz1orkqm/ZGOk0182TfJuALwyPGrYBpTkRfH+D47rA3SkyDOns4aluUa9gS8w==", "X-Received": "by 2002:a05:620a:4251:: with SMTP id\n w17mr9807586qko.550.1639592425154;\n Wed, 15 Dec 2021 10:20:25 -0800 (PST)", "From": "Robert Sanford <rsanford2@gmail.com>", "X-Google-Original-From": "Robert Sanford <rsanford@akamai.com>", "To": "dev@dpdk.org", "Cc": "chas3@att.com,\n\thumin29@huawei.com", "Subject": "[PATCH 1/7] net/bonding: fix typos and whitespace", "Date": "Wed, 15 Dec 2021 13:19:55 -0500", "Message-Id": "<1639592401-56845-2-git-send-email-rsanford@akamai.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1639592401-56845-1-git-send-email-rsanford@akamai.com>", "References": "<1639592401-56845-1-git-send-email-rsanford@akamai.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Clean up minor typos in comments, strings, and private names.\n- Fix whitespace in log messages and function formatting (open brace\n after a new line).\n- Move closing C++ wrapper to the end of rte_eth_bond_8023ad.h.\n\nSigned-off-by: Robert Sanford <rsanford@akamai.com>\n---\n app/test-pmd/cmdline.c | 4 ++--\n app/test/test_link_bonding_mode4.c | 28 +++++++++++++--------------\n drivers/net/bonding/eth_bond_8023ad_private.h | 10 +++++-----\n drivers/net/bonding/rte_eth_bond_8023ad.c | 22 ++++++++++-----------\n drivers/net/bonding/rte_eth_bond_8023ad.h | 15 +++++++-------\n drivers/net/bonding/rte_eth_bond_pmd.c | 13 ++++++++-----\n 6 files changed, 48 insertions(+), 44 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 6e10afe..9fd2c2a 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -630,8 +630,8 @@ static void cmd_help_long_parsed(void *parsed_result,\n \t\t\t\"set bonding mac_addr (port_id) (address)\\n\"\n \t\t\t\"\tSet the MAC address of a bonded device.\\n\\n\"\n \n-\t\t\t\"set bonding mode IEEE802.3AD aggregator policy (port_id) (agg_name)\"\n-\t\t\t\"\tSet Aggregation mode for IEEE802.3AD (mode 4)\"\n+\t\t\t\"set bonding mode IEEE802.3AD aggregator policy (port_id) (agg_name)\\n\"\n+\t\t\t\"\tSet Aggregation mode for IEEE802.3AD (mode 4)\\n\\n\"\n \n \t\t\t\"set bonding balance_xmit_policy (port_id) (l2|l23|l34)\\n\"\n \t\t\t\"\tSet the transmit balance policy for bonded device running in balance mode.\\n\\n\"\ndiff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c\nindex 351129d..2be86d5 100644\n--- a/app/test/test_link_bonding_mode4.c\n+++ b/app/test/test_link_bonding_mode4.c\n@@ -58,11 +58,11 @@ static const struct rte_ether_addr slave_mac_default = {\n \t{ 0x00, 0xFF, 0x00, 0xFF, 0x00, 0x00 }\n };\n \n-static const struct rte_ether_addr parnter_mac_default = {\n+static const struct rte_ether_addr partner_mac_default = {\n \t{ 0x22, 0xBB, 0xFF, 0xBB, 0x00, 0x00 }\n };\n \n-static const struct rte_ether_addr parnter_system = {\n+static const struct rte_ether_addr partner_system = {\n \t{ 0x33, 0xFF, 0xBB, 0xFF, 0x00, 0x00 }\n };\n \n@@ -76,7 +76,7 @@ struct slave_conf {\n \tuint16_t port_id;\n \tuint8_t bonded : 1;\n \n-\tuint8_t lacp_parnter_state;\n+\tuint8_t lacp_partner_state;\n };\n \n struct ether_vlan_hdr {\n@@ -258,7 +258,7 @@ add_slave(struct slave_conf *slave, uint8_t start)\n \tTEST_ASSERT_EQUAL(rte_is_same_ether_addr(&addr, &addr_check), 1,\n \t\t\t\"Slave MAC address is not as expected\");\n \n-\tRTE_VERIFY(slave->lacp_parnter_state == 0);\n+\tRTE_VERIFY(slave->lacp_partner_state == 0);\n \treturn 0;\n }\n \n@@ -288,7 +288,7 @@ remove_slave(struct slave_conf *slave)\n \t\t\ttest_params.bonded_port_id);\n \n \tslave->bonded = 0;\n-\tslave->lacp_parnter_state = 0;\n+\tslave->lacp_partner_state = 0;\n \treturn 0;\n }\n \n@@ -501,20 +501,20 @@ make_lacp_reply(struct slave_conf *slave, struct rte_mbuf *pkt)\n \tslow_hdr = rte_pktmbuf_mtod(pkt, struct slow_protocol_frame *);\n \n \t/* Change source address to partner address */\n-\trte_ether_addr_copy(&parnter_mac_default, &slow_hdr->eth_hdr.src_addr);\n+\trte_ether_addr_copy(&partner_mac_default, &slow_hdr->eth_hdr.src_addr);\n \tslow_hdr->eth_hdr.src_addr.addr_bytes[RTE_ETHER_ADDR_LEN - 1] =\n \t\tslave->port_id;\n \n \tlacp = (struct lacpdu *) &slow_hdr->slow_protocol;\n \t/* Save last received state */\n-\tslave->lacp_parnter_state = lacp->actor.state;\n+\tslave->lacp_partner_state = lacp->actor.state;\n \t/* Change it into LACP replay by matching parameters. */\n \tmemcpy(&lacp->partner.port_params, &lacp->actor.port_params,\n \t\tsizeof(struct port_params));\n \n \tlacp->partner.state = lacp->actor.state;\n \n-\trte_ether_addr_copy(&parnter_system, &lacp->actor.port_params.system);\n+\trte_ether_addr_copy(&partner_system, &lacp->actor.port_params.system);\n \tlacp->actor.state = STATE_LACP_ACTIVE |\n \t\t\t\t\t\tSTATE_SYNCHRONIZATION |\n \t\t\t\t\t\tSTATE_AGGREGATION |\n@@ -580,7 +580,7 @@ bond_handshake_done(struct slave_conf *slave)\n \tconst uint8_t expected_state = STATE_LACP_ACTIVE | STATE_SYNCHRONIZATION |\n \t\t\tSTATE_AGGREGATION | STATE_COLLECTING | STATE_DISTRIBUTING;\n \n-\treturn slave->lacp_parnter_state == expected_state;\n+\treturn slave->lacp_partner_state == expected_state;\n }\n \n static unsigned\n@@ -1165,7 +1165,7 @@ init_marker(struct rte_mbuf *pkt, struct slave_conf *slave)\n \t\t\t&marker_hdr->eth_hdr.dst_addr);\n \n \t/* Init source address */\n-\trte_ether_addr_copy(&parnter_mac_default,\n+\trte_ether_addr_copy(&partner_mac_default,\n \t\t\t&marker_hdr->eth_hdr.src_addr);\n \tmarker_hdr->eth_hdr.src_addr.addr_bytes[RTE_ETHER_ADDR_LEN - 1] =\n \t\tslave->port_id;\n@@ -1353,7 +1353,7 @@ test_mode4_expired(void)\n \t/* After test only expected slave should be in EXPIRED state */\n \tFOR_EACH_SLAVE(i, slave) {\n \t\tif (slave == exp_slave)\n-\t\t\tTEST_ASSERT(slave->lacp_parnter_state & STATE_EXPIRED,\n+\t\t\tTEST_ASSERT(slave->lacp_partner_state & STATE_EXPIRED,\n \t\t\t\t\"Slave %u should be in expired.\", slave->port_id);\n \t\telse\n \t\t\tTEST_ASSERT_EQUAL(bond_handshake_done(slave), 1,\n@@ -1392,7 +1392,7 @@ test_mode4_ext_ctrl(void)\n \t\t},\n \t};\n \n-\trte_ether_addr_copy(&parnter_system, &src_mac);\n+\trte_ether_addr_copy(&partner_system, &src_mac);\n \trte_ether_addr_copy(&slow_protocol_mac_addr, &dst_mac);\n \n \tinitialize_eth_header(&lacpdu.eth_hdr, &src_mac, &dst_mac,\n@@ -1446,7 +1446,7 @@ test_mode4_ext_lacp(void)\n \t\t},\n \t};\n \n-\trte_ether_addr_copy(&parnter_system, &src_mac);\n+\trte_ether_addr_copy(&partner_system, &src_mac);\n \trte_ether_addr_copy(&slow_protocol_mac_addr, &dst_mac);\n \n \tinitialize_eth_header(&lacpdu.eth_hdr, &src_mac, &dst_mac,\n@@ -1535,7 +1535,7 @@ check_environment(void)\n \t\tif (port->bonded != 0)\n \t\t\tenv_state |= 0x04;\n \n-\t\tif (port->lacp_parnter_state != 0)\n+\t\tif (port->lacp_partner_state != 0)\n \t\t\tenv_state |= 0x08;\n \n \t\tif (env_state != 0)\ndiff --git a/drivers/net/bonding/eth_bond_8023ad_private.h b/drivers/net/bonding/eth_bond_8023ad_private.h\nindex 9b5738a..e415f2f 100644\n--- a/drivers/net/bonding/eth_bond_8023ad_private.h\n+++ b/drivers/net/bonding/eth_bond_8023ad_private.h\n@@ -20,7 +20,7 @@\n /** Maximum number of LACP packets from one slave queued in TX ring. */\n #define BOND_MODE_8023AX_SLAVE_TX_PKTS 1\n /**\n- * Timeouts deffinitions (5.4.4 in 802.1AX documentation).\n+ * Timeouts definitions (6.4.4 in 802.1AX documentation).\n */\n #define BOND_8023AD_FAST_PERIODIC_MS 900\n #define BOND_8023AD_SLOW_PERIODIC_MS 29000\n@@ -34,7 +34,7 @@\n /**\n * Interval of showing warning message from state machines. All messages will\n * be held (and gathered together) to prevent flooding.\n- * This is no parto of 802.1AX standard.\n+ * This is not part of 802.1AX standard.\n */\n #define BOND_8023AD_WARNINGS_PERIOD_MS 1000\n \n@@ -83,7 +83,7 @@\n #define PARTNER_STATE_SET(_p, _f) SET_FLAGS((_p)->partner_state, STATE_ ## _f)\n #define PARTNER_STATE_CLR(_p, _f) CLEAR_FLAGS((_p)->partner_state, STATE_ ## _f)\n \n-/** Variables associated with each port (5.4.7 in 802.1AX documentation). */\n+/** Variables associated with each port (6.4.7 in 802.1AX documentation). */\n struct port {\n \t/**\n \t * The operational values of the Actor's state parameters. Bitmask\n@@ -124,7 +124,7 @@ struct port {\n \tuint64_t wait_while_timer;\n \tuint64_t tx_machine_timer;\n \tuint64_t tx_marker_timer;\n-\t/* Agregator parameters */\n+\t/* Aggregator parameters */\n \t/** Used aggregator port ID */\n \tuint16_t aggregator_port_id;\n \n@@ -280,7 +280,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *dev, uint16_t port_id);\n /**\n * @internal\n *\n- * Denitializes and removes given slave from 802.1AX mode.\n+ * Deinitializes and removes given slave from 802.1AX mode.\n *\n * @param dev Bonded interface.\n * @param slave_num Position of slave in active_slaves array\ndiff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\nindex ca50583..43231bc 100644\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\n@@ -207,15 +207,15 @@ show_warnings(uint16_t slave_id)\n \tif (warnings & WRN_RX_QUEUE_FULL) {\n \t\tRTE_BOND_LOG(DEBUG,\n \t\t\t \"Slave %u: failed to enqueue LACP packet into RX ring.\\n\"\n-\t\t\t \"Receive and transmit functions must be invoked on bonded\"\n-\t\t\t \"interface at least 10 times per second or LACP will notwork correctly\",\n+\t\t\t \"Receive and transmit functions must be invoked on bonded\\n\"\n+\t\t\t \"interface at least 10 times per second or LACP will not work correctly\",\n \t\t\t slave_id);\n \t}\n \n \tif (warnings & WRN_TX_QUEUE_FULL) {\n \t\tRTE_BOND_LOG(DEBUG,\n \t\t\t \"Slave %u: failed to enqueue LACP packet into TX ring.\\n\"\n-\t\t\t \"Receive and transmit functions must be invoked on bonded\"\n+\t\t\t \"Receive and transmit functions must be invoked on bonded\\n\"\n \t\t\t \"interface at least 10 times per second or LACP will not work correctly\",\n \t\t\t slave_id);\n \t}\n@@ -250,7 +250,7 @@ record_default(struct port *port)\n \n /** Function handles rx state machine.\n *\n- * This function implements Receive State Machine from point 5.4.12 in\n+ * This function implements Receive State Machine from point 6.4.12 in\n * 802.1AX documentation. It should be called periodically.\n *\n * @param lacpdu\t\tLACPDU received.\n@@ -384,7 +384,7 @@ rx_machine(struct bond_dev_private *internals, uint16_t slave_id,\n /**\n * Function handles periodic tx state machine.\n *\n- * Function implements Periodic Transmission state machine from point 5.4.13\n+ * Function implements Periodic Transmission state machine from point 6.4.13\n * in 802.1AX documentation. It should be called periodically.\n *\n * @param port\t\t\tPort to handle state machine.\n@@ -446,7 +446,7 @@ periodic_machine(struct bond_dev_private *internals, uint16_t slave_id)\n /**\n * Function handles mux state machine.\n *\n- * Function implements Mux Machine from point 5.4.15 in 802.1AX documentation.\n+ * Function implements Mux Machine from point 6.4.15 in 802.1AX documentation.\n * It should be called periodically.\n *\n * @param port\t\t\tPort to handle state machine.\n@@ -549,7 +549,7 @@ mux_machine(struct bond_dev_private *internals, uint16_t slave_id)\n /**\n * Function handles transmit state machine.\n *\n- * Function implements Transmit Machine from point 5.4.16 in 802.1AX\n+ * Function implements Transmit Machine from point 6.4.16 in 802.1AX\n * documentation.\n *\n * @param port\n@@ -1051,14 +1051,14 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev,\n \tstruct bond_tx_queue *bd_tx_q;\n \tuint16_t q_id;\n \n-\t/* Given slave mus not be in active list */\n+\t/* Given slave must not be in active list. */\n \tRTE_ASSERT(find_slave_by_id(internals->active_slaves,\n \tinternals->active_slave_count, slave_id) == internals->active_slave_count);\n \tRTE_SET_USED(internals); /* used only for assert when enabled */\n \n \tmemcpy(&port->actor, &initial, sizeof(struct port_params));\n-\t/* Standard requires that port ID must be grater than 0.\n-\t * Add 1 do get corresponding port_number */\n+\t/* Standard requires that port ID must be greater than 0.\n+\t * Add 1 to get corresponding port_number. */\n \tport->actor.port_number = rte_cpu_to_be_16(slave_id + 1);\n \n \tmemcpy(&port->partner, &initial, sizeof(struct port_params));\n@@ -1069,7 +1069,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev,\n \tport->partner_state = STATE_LACP_ACTIVE | STATE_AGGREGATION;\n \tport->sm_flags = SM_FLAGS_BEGIN;\n \n-\t/* use this port as agregator */\n+\t/* Use this port as aggregator. */\n \tport->aggregator_port_id = slave_id;\n \n \tif (bond_mode_8023ad_register_lacp_mac(slave_id) < 0) {\ndiff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h b/drivers/net/bonding/rte_eth_bond_8023ad.h\nindex 11a71a5..7e9a018 100644\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.h\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.h\n@@ -68,7 +68,7 @@ struct port_params {\n \tstruct rte_ether_addr system;\n \t/**< System ID - Slave MAC address, same as bonding MAC address */\n \tuint16_t key;\n-\t/**< Speed information (implementation dependednt) and duplex. */\n+\t/**< Speed information (implementation dependent) and duplex. */\n \tuint16_t port_priority;\n \t/**< Priority of this (unused in current implementation) */\n \tuint16_t port_number;\n@@ -83,7 +83,7 @@ struct lacpdu_actor_partner_params {\n \tuint8_t reserved_3[3];\n } __rte_packed __rte_aligned(2);\n \n-/** LACPDU structure (5.4.2 in 802.1AX documentation). */\n+/** LACPDU structure (6.4.2 in 802.1AX documentation). */\n struct lacpdu {\n \tuint8_t subtype;\n \tuint8_t version_number;\n@@ -153,7 +153,7 @@ struct rte_eth_bond_8023ad_slave_info {\n /**\n * @internal\n *\n- * Function returns current configuration of 802.3AX mode.\n+ * Function returns current configuration of 802.1AX mode.\n *\n * @param port_id Bonding device id\n * @param conf\t\tPointer to timeout structure.\n@@ -197,10 +197,6 @@ int\n rte_eth_bond_8023ad_slave_info(uint16_t port_id, uint16_t slave_id,\n \t\tstruct rte_eth_bond_8023ad_slave_info *conf);\n \n-#ifdef __cplusplus\n-}\n-#endif\n-\n /**\n * Configure a slave port to start collecting.\n *\n@@ -331,4 +327,9 @@ rte_eth_bond_8023ad_agg_selection_get(uint16_t port_id);\n int\n rte_eth_bond_8023ad_agg_selection_set(uint16_t port_id,\n \t\tenum rte_bond_8023ad_agg_selection agg_selection);\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n #endif /* RTE_ETH_BOND_8023AD_H_ */\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 84f4900..f6003b0 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -158,7 +158,8 @@ const struct rte_flow_attr flow_attr_8023ad = {\n \n int\n bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,\n-\t\tuint16_t slave_port) {\n+\t\tuint16_t slave_port)\n+{\n \tstruct rte_eth_dev_info slave_info;\n \tstruct rte_flow_error error;\n \tstruct bond_dev_private *internals = bond_dev->data->dev_private;\n@@ -207,7 +208,8 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,\n }\n \n int\n-bond_8023ad_slow_pkt_hw_filter_supported(uint16_t port_id) {\n+bond_8023ad_slow_pkt_hw_filter_supported(uint16_t port_id)\n+{\n \tstruct rte_eth_dev *bond_dev = &rte_eth_devices[port_id];\n \tstruct bond_dev_private *internals = bond_dev->data->dev_private;\n \tstruct rte_eth_dev_info bond_info;\n@@ -240,8 +242,8 @@ bond_8023ad_slow_pkt_hw_filter_supported(uint16_t port_id) {\n }\n \n int\n-bond_ethdev_8023ad_flow_set(struct rte_eth_dev *bond_dev, uint16_t slave_port) {\n-\n+bond_ethdev_8023ad_flow_set(struct rte_eth_dev *bond_dev, uint16_t slave_port)\n+{\n \tstruct rte_flow_error error;\n \tstruct bond_dev_private *internals = bond_dev->data->dev_private;\n \tstruct rte_flow_action_queue lacp_queue_conf = {\n@@ -809,7 +811,8 @@ struct bwg_slave {\n };\n \n void\n-bond_tlb_activate_slave(struct bond_dev_private *internals) {\n+bond_tlb_activate_slave(struct bond_dev_private *internals)\n+{\n \tint i;\n \n \tfor (i = 0; i < internals->active_slave_count; i++) {\n", "prefixes": [ "1/7" ] }