Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 105134,
    "url": "http://patches.dpdk.org/api/patches/105134/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211214141242.3383831-5-ronan.randles@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20211214141242.3383831-5-ronan.randles@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20211214141242.3383831-5-ronan.randles@intel.com",
    "date": "2021-12-14T14:12:34",
    "name": "[04/12] gen: add basic Rx and Tx routines and tests",
    "commit_ref": null,
    "pull_url": null,
    "state": "not-applicable",
    "archived": true,
    "hash": "b4ab82946772e8a28f4278d9539c7d889a08a55a",
    "submitter": {
        "id": 2439,
        "url": "http://patches.dpdk.org/api/people/2439/?format=api",
        "name": "Ronan Randles",
        "email": "ronan.randles@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211214141242.3383831-5-ronan.randles@intel.com/mbox/",
    "series": [
        {
            "id": 20944,
            "url": "http://patches.dpdk.org/api/series/20944/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20944",
            "date": "2021-12-14T14:12:30",
            "name": "add packet generator library and example app",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/20944/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/105134/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/105134/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4FBF7A00C3;\n\tTue, 14 Dec 2021 15:13:17 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8FACD41159;\n\tTue, 14 Dec 2021 15:12:54 +0100 (CET)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id DA4D54114E\n for <dev@dpdk.org>; Tue, 14 Dec 2021 15:12:51 +0100 (CET)",
            "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Dec 2021 06:12:51 -0800",
            "from silpixa00401120.ir.intel.com ([10.55.129.95])\n by orsmga006.jf.intel.com with ESMTP; 14 Dec 2021 06:12:50 -0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1639491172; x=1671027172;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=WAsB5mXVwWeKQGOlTBvfEyGz03MD12da3+NZ+S40ePA=;\n b=AcB6eXtNnF/juefYnKgfVfk40CIu8Umiz0pru5NcqT/0ThzIIsQgOYoC\n 3fgXkZHFhpkRuxkJ60XrDmvIym8u0ldTMX3xGPQV5NP2cNsaf3QbuX9wn\n pTLnTXuUGScQwAHT3M/PSeWzTkVdFpJQcpzzsxG/gxUznYyWiVRUrWc+A\n KlXPSQdipoKb9KlWGyniE+adjBQA8HaMbyjZOvPyXRBcYr9HdcvYk3DDa\n AcpBj4HpjqqWwH0Ih2zLOP7zewioKTRmdpx4Q2fFKtTEkzAM7U/6F4cYg\n yZCuBIsXal5G5vEKNwVG411/OP1oPB2E+DXhD+4NI9SgA2o11Ex7f75vF Q==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6200,9189,10197\"; a=\"302362309\"",
            "E=Sophos;i=\"5.88,205,1635231600\"; d=\"scan'208\";a=\"302362309\"",
            "E=Sophos;i=\"5.88,205,1635231600\"; d=\"scan'208\";a=\"465104113\""
        ],
        "X-ExtLoop1": "1",
        "From": "Ronan Randles <ronan.randles@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "harry.van.haaren@intel.com,\n\tRonan Randles <ronan.randles@intel.com>",
        "Subject": "[PATCH 04/12] gen: add basic Rx and Tx routines and tests",
        "Date": "Tue, 14 Dec 2021 14:12:34 +0000",
        "Message-Id": "<20211214141242.3383831-5-ronan.randles@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20211214141242.3383831-1-ronan.randles@intel.com>",
        "References": "<20211214141242.3383831-1-ronan.randles@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Harry van Haaren <harry.van.haaren@intel.com>\n\nThis commit introduces functions for basic mbuf rx and tx.\nThis commit also contains a unit test that calls rte_gen_rx_burst\nand rte_gen_tx_burst to send bursts of 32 packets repeatedly in\norder to verify their functionality\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\nSigned-off-by: Ronan Randles <ronan.randles@intel.com>\n---\n app/test/test_gen.c | 46 ++++++++++++++++++++++++++++++++++++++++++\n lib/gen/meson.build |  1 +\n lib/gen/rte_gen.c   | 43 +++++++++++++++++++++++++++++++++++++++\n lib/gen/rte_gen.h   | 49 +++++++++++++++++++++++++++++++++++++++++++++\n lib/gen/version.map |  2 ++\n 5 files changed, 141 insertions(+)",
    "diff": "diff --git a/app/test/test_gen.c b/app/test/test_gen.c\nindex f53f4a6608..ceacd8c7c4 100644\n--- a/app/test/test_gen.c\n+++ b/app/test/test_gen.c\n@@ -8,6 +8,8 @@\n \n #include \"test.h\"\n \n+#define BURST_MAX 32\n+\n static struct rte_mempool *mp;\n \n static int\n@@ -36,12 +38,56 @@ test_gen_create(void)\n \treturn 0;\n }\n \n+static int\n+test_gen_basic_rxtx(void)\n+{\n+\tstruct rte_gen *gen = rte_gen_create(mp);\n+\tTEST_ASSERT_FAIL(gen, \"Expected valid pointer after create()\");\n+\n+\tstruct rte_mbuf *bufs[BURST_MAX];\n+\tuint16_t nb_rx = rte_gen_rx_burst(gen, bufs, BURST_MAX);\n+\tTEST_ASSERT_EQUAL(nb_rx, BURST_MAX, \"Expected rx packet burst.\");\n+\n+\tuint64_t latency[BURST_MAX];\n+\tuint16_t nb_tx = rte_gen_tx_burst(gen, bufs, latency, BURST_MAX);\n+\tTEST_ASSERT_EQUAL(nb_tx, BURST_MAX, \"Expected tx packet burst.\");\n+\n+\trte_gen_destroy(gen);\n+\treturn 0;\n+}\n+\n+static int\n+test_gen_loop_rxtx(void)\n+{\n+\tstruct rte_gen *gen = rte_gen_create(mp);\n+\tTEST_ASSERT_FAIL(gen, \"Expected valid pointer after create()\");\n+\n+\tuint32_t total_sent = 0;\n+\n+\twhile (total_sent < 1000000) {\n+\t\tstruct rte_mbuf *bufs[BURST_MAX];\n+\t\tuint16_t nb_rx = rte_gen_rx_burst(gen, bufs, BURST_MAX);\n+\t\tTEST_ASSERT_EQUAL(nb_rx, BURST_MAX, \"Expected rx packet burst.\");\n+\n+\t\tuint64_t latency[BURST_MAX];\n+\t\tuint16_t nb_tx = rte_gen_tx_burst(gen, bufs, latency, nb_rx);\n+\t\tTEST_ASSERT_EQUAL(nb_tx, BURST_MAX, \"Expected tx packet burst.\");\n+\n+\t\ttotal_sent += nb_tx;\n+\t}\n+\n+\trte_gen_destroy(gen);\n+\treturn 0;\n+}\n+\n static struct unit_test_suite gen_suite  = {\n \t.suite_name = \"gen: packet generator unit test suite\",\n \t.setup = testsuite_setup,\n \t.teardown = testsuite_teardown,\n \t.unit_test_cases = {\n \t\tTEST_CASE_ST(NULL, NULL, test_gen_create),\n+\t\tTEST_CASE_ST(NULL, NULL, test_gen_basic_rxtx),\n+\t\tTEST_CASE_ST(NULL, NULL, test_gen_loop_rxtx),\n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n };\ndiff --git a/lib/gen/meson.build b/lib/gen/meson.build\nindex 3c5d854645..753984cbba 100644\n--- a/lib/gen/meson.build\n+++ b/lib/gen/meson.build\n@@ -3,3 +3,4 @@\n \n sources = files('rte_gen.c')\n headers = files('rte_gen.h')\n+deps += ['mempool', 'mbuf']\ndiff --git a/lib/gen/rte_gen.c b/lib/gen/rte_gen.c\nindex d993772422..f0ad57fa81 100644\n--- a/lib/gen/rte_gen.c\n+++ b/lib/gen/rte_gen.c\n@@ -4,8 +4,11 @@\n \n #include \"rte_gen.h\"\n \n+#include <rte_mbuf.h>\n #include <rte_malloc.h>\n \n+#define GEN_MAX_BURST 32\n+\n /** Structure that represents a traffic generator. */\n struct rte_gen {\n \t/* Mempool that buffers are retrieved from. */\n@@ -31,3 +34,43 @@ rte_gen_destroy(struct rte_gen *gen)\n {\n \trte_free(gen);\n }\n+\n+uint16_t\n+rte_gen_rx_burst(struct rte_gen *gen,\n+\t\t struct rte_mbuf **rx_pkts,\n+\t\t const uint16_t nb_pkts)\n+{\n+\t/* Get a bulk of nb_pkts from the mempool. */\n+\tint err = rte_mempool_get_bulk(gen->mp, (void **)rx_pkts, nb_pkts);\n+\tif (err)\n+\t\treturn 0;\n+\n+\tconst uint32_t pkt_len = 64;\n+\n+\tuint32_t i;\n+\tfor (i = 0; i < nb_pkts; i++) {\n+\t\tstruct rte_mbuf *m = rx_pkts[i];\n+\t\tuint8_t *pkt_data = rte_pktmbuf_mtod(m, uint8_t *);\n+\n+\t\tmemset(pkt_data, 0, pkt_len);\n+\n+\t\tm->pkt_len  = pkt_len;\n+\t\tm->data_len = pkt_len;\n+\t}\n+\n+\treturn nb_pkts;\n+}\n+\n+uint16_t\n+rte_gen_tx_burst(struct rte_gen *gen,\n+\t\t struct rte_mbuf **tx_pkts,\n+\t\t uint64_t *pkt_latencies,\n+\t\t const uint16_t nb_pkts)\n+{\n+\tRTE_SET_USED(gen);\n+\tRTE_SET_USED(pkt_latencies);\n+\n+\trte_pktmbuf_free_bulk(tx_pkts, nb_pkts);\n+\n+\treturn nb_pkts;\n+}\ndiff --git a/lib/gen/rte_gen.h b/lib/gen/rte_gen.h\nindex 5b30430f9e..09ee1e8872 100644\n--- a/lib/gen/rte_gen.h\n+++ b/lib/gen/rte_gen.h\n@@ -25,6 +25,7 @@ extern \"C\" {\n struct rte_gen;\n \n /* Forward declarations for DPDK componeents. */\n+struct rte_mbuf;\n struct rte_mempool;\n \n /* Allocate and initialize a traffic generator instance. */\n@@ -37,6 +38,54 @@ __rte_experimental\n void\n rte_gen_destroy(struct rte_gen *gen);\n \n+/**\n+ * Call to receive a burst of generated packets\n+ *\n+ * @param gen\n+ *   Gen instance to be used.\n+ * @param rx_pkts\n+ *   mbuf where packets will be generated.\n+ * @param nb_pkts\n+ *   number of packets to be generated\n+ *\n+ * @retval nb_pkts\n+ *   On success the number of rx'ed packets will be returned\n+ * @retval 0\n+ *   Failure.\n+ */\n+__rte_experimental\n+uint16_t\n+rte_gen_rx_burst(struct rte_gen *gen,\n+\t\t struct rte_mbuf **rx_pkts,\n+\t\t const uint16_t nb_pkts);\n+\n+/** Call to transmit a burst of traffic back to the generator.\n+ * This allows the generator to calculate stats/properties of the stream.\n+ *\n+ * If the pkt_latencies parameter is not NULL, it is expected to be a pointer\n+ * to an array of uint64_t values that has nb_pkts in length. Each individual\n+ * packet latency will be stored to the array.\n+ *\n+ * @param gen\n+ *   Gen instance to be used.\n+ * @param tx_pkts\n+ *   mbuf to be used to tx packets\n+ * @param pkt_latencies\n+ *   Array to store latencies of sent packets\n+ * @param nb_pkts\n+ *   The number of packets to be tx'ed\n+ *\n+ * @retval nb_pkts\n+ *   On success the number of packets tx'ed is returned\n+ */\n+__rte_experimental\n+uint16_t\n+rte_gen_tx_burst(struct rte_gen *gen,\n+\t\t struct rte_mbuf **tx_pkts,\n+\t\t uint64_t *pkt_latencies,\n+\t\t const uint16_t nb_pkts);\n+\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/gen/version.map b/lib/gen/version.map\nindex d8a26eb53a..bdd25add6f 100644\n--- a/lib/gen/version.map\n+++ b/lib/gen/version.map\n@@ -3,4 +3,6 @@ EXPERIMENTAL {\n \n \trte_gen_create;\n \trte_gen_destroy;\n+\trte_gen_rx_burst;\n+\trte_gen_tx_burst;\n };\n",
    "prefixes": [
        "04/12"
    ]
}