Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105078/?format=api
{ "id": 105078, "url": "http://patches.dpdk.org/api/patches/105078/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1639369756-103116-1-git-send-email-andy.pei@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1639369756-103116-1-git-send-email-andy.pei@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1639369756-103116-1-git-send-email-andy.pei@intel.com", "date": "2021-12-13T04:29:16", "name": "[2/3] vdpa/ifc: check lm_cfg is not NULL before use lm_cfg", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "93d4af55b694bf17752567dff3a55eef66872694", "submitter": { "id": 1185, "url": "http://patches.dpdk.org/api/people/1185/?format=api", "name": "Pei, Andy", "email": "andy.pei@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1639369756-103116-1-git-send-email-andy.pei@intel.com/mbox/", "series": [ { "id": 20917, "url": "http://patches.dpdk.org/api/series/20917/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20917", "date": "2021-12-13T04:29:06", "name": "[1/3] vdpa/ifc: fix log info mismatch", "version": 1, "mbox": "http://patches.dpdk.org/series/20917/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105078/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105078/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E56D2A0032;\n\tMon, 13 Dec 2021 06:15:09 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0763C41104;\n\tMon, 13 Dec 2021 06:15:09 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id F32BA41101\n for <dev@dpdk.org>; Mon, 13 Dec 2021 06:15:06 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Dec 2021 21:15:06 -0800", "from dpdk-dipei.sh.intel.com ([10.67.111.91])\n by orsmga004.jf.intel.com with ESMTP; 12 Dec 2021 21:15:04 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1639372507; x=1670908507;\n h=from:to:cc:subject:date:message-id;\n bh=zHAeyJr7KjAOnoirBwwRuDZrWTw9M4iKMPuVIaadGc0=;\n b=IxeLYJ0CxFqNX0ZYlBl5u/5lbt7P5WmPe1hn/lJp1w7cqzT7rNh6q58S\n /uVNLmsOOqw0JPwVT885Zn4ENY6r0JIEKrNlpQath6hAP0N4F0E/t6vD9\n M3qRTlLUhxLG9DZp8Y3MElCTdDvgA155j3L4B9KJEhymA5Dc3tB3kntcB\n 6W63SXW495H70xvbadCULp4Eos47CEXRgz8X/ybOWeLZ3jnmCGTjQF2Dz\n 5yRXM1ojN3SO1OHjMJ2fzRAX8Cig5BayGBXkKYo0HJ2mCb4p9JBNfG48z\n CDcR0kY3bktsjIgib9+5DEevALjESMq5YcjHk2W2d8yOBG/QqOGiyK0ZA Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10196\"; a=\"262788026\"", "E=Sophos;i=\"5.88,201,1635231600\"; d=\"scan'208\";a=\"262788026\"", "E=Sophos;i=\"5.88,201,1635231600\"; d=\"scan'208\";a=\"613694155\"" ], "X-ExtLoop1": "1", "From": "Andy Pei <andy.pei@intel.com>", "To": "dev@dpdk.org", "Cc": "andy.pei@intel.com,\n\tchenbo.xia@intel.com,\n\txiao.w.wang@intel.com", "Subject": "[PATCH 2/3] vdpa/ifc: check lm_cfg is not NULL before use lm_cfg", "Date": "Mon, 13 Dec 2021 12:29:16 +0800", "Message-Id": "<1639369756-103116-1-git-send-email-andy.pei@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "check lm_cfg is not NULL before use lm_cfg.\nwhen init hardware, if lm_cfg is NULL, output some debug information.\n\nSigned-off-by: Andy Pei <andy.pei@intel.com>\n---\n drivers/vdpa/ifc/base/ifcvf.c | 32 ++++++++++++++++++++++++--------\n 1 file changed, 24 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c\nindex d10c1fd..b9b061f 100644\n--- a/drivers/vdpa/ifc/base/ifcvf.c\n+++ b/drivers/vdpa/ifc/base/ifcvf.c\n@@ -87,6 +87,8 @@\n \t}\n \n \thw->lm_cfg = hw->mem_resource[4].addr;\n+\tif (!hw->lm_cfg)\n+\t\tDEBUGOUT(\"HW mem_resource[4] is NULL, so lm_cfg is NULL.\\n\");\n \n \tif (hw->common_cfg == NULL || hw->notify_base == NULL ||\n \t\t\thw->isr == NULL || hw->dev_cfg == NULL) {\n@@ -218,10 +220,13 @@\n \t\t\t\t&cfg->queue_used_hi);\n \t\tIFCVF_WRITE_REG16(hw->vring[i].size, &cfg->queue_size);\n \n-\t\t*(u32 *)(lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n-\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE + (i % 2) * 4) =\n-\t\t\t(u32)hw->vring[i].last_avail_idx |\n-\t\t\t((u32)hw->vring[i].last_used_idx << 16);\n+\t\tif (lm_cfg != NULL) {\n+\t\t\t*(u32 *)(lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE +\n+\t\t\t\t\t(i % 2) * 4) =\n+\t\t\t\t(u32)hw->vring[i].last_avail_idx |\n+\t\t\t\t((u32)hw->vring[i].last_used_idx << 16);\n+\t\t}\n \n \t\tIFCVF_WRITE_REG16(i + 1, &cfg->queue_msix_vector);\n \t\tif (IFCVF_READ_REG16(&cfg->queue_msix_vector) ==\n@@ -254,10 +259,14 @@\n \t\tIFCVF_WRITE_REG16(i, &cfg->queue_select);\n \t\tIFCVF_WRITE_REG16(0, &cfg->queue_enable);\n \t\tIFCVF_WRITE_REG16(IFCVF_MSI_NO_VECTOR, &cfg->queue_msix_vector);\n-\t\tring_state = *(u32 *)(hw->lm_cfg + IFCVF_LM_RING_STATE_OFFSET +\n-\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE + (i % 2) * 4);\n-\t\thw->vring[i].last_avail_idx = (u16)(ring_state >> 16);\n-\t\thw->vring[i].last_used_idx = (u16)(ring_state >> 16);\n+\t\tif (hw->lm_cfg != NULL) {\n+\t\t\tring_state = *(u32 *)(hw->lm_cfg +\n+\t\t\t\t\tIFCVF_LM_RING_STATE_OFFSET +\n+\t\t\t\t\t(i / 2) * IFCVF_LM_CFG_SIZE +\n+\t\t\t\t\t(i % 2) * 4);\n+\t\t\thw->vring[i].last_avail_idx = (u16)(ring_state >> 16);\n+\t\t\thw->vring[i].last_used_idx = (u16)(ring_state >> 16);\n+\t\t}\n \t}\n }\n \n@@ -292,6 +301,9 @@\n \n \tlm_cfg = hw->lm_cfg;\n \n+\tif (lm_cfg == NULL)\n+\t\treturn;\n+\n \t*(u32 *)(lm_cfg + IFCVF_LM_BASE_ADDR_LOW) =\n \t\tlog_base & IFCVF_32_BIT_MASK;\n \n@@ -313,6 +325,10 @@\n \tu8 *lm_cfg;\n \n \tlm_cfg = hw->lm_cfg;\n+\n+\tif (lm_cfg == NULL)\n+\t\treturn;\n+\n \t*(u32 *)(lm_cfg + IFCVF_LM_LOGGING_CTRL) = IFCVF_LM_DISABLE;\n }\n \n", "prefixes": [ "2/3" ] }