Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105064/?format=api
{ "id": 105064, "url": "http://patches.dpdk.org/api/patches/105064/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211210140952.2907974-1-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211210140952.2907974-1-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211210140952.2907974-1-ciara.power@intel.com", "date": "2021-12-10T14:09:50", "name": "[1/3] crypto/ipsec_mb: fix qp setup null pointer dereference", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "85312859739903ce5628ab8f2c33ae79175d6e0d", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Ciara Power", "email": "ciara.power@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211210140952.2907974-1-ciara.power@intel.com/mbox/", "series": [ { "id": 20911, "url": "http://patches.dpdk.org/api/series/20911/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20911", "date": "2021-12-10T14:09:50", "name": "[1/3] crypto/ipsec_mb: fix qp setup null pointer dereference", "version": 1, "mbox": "http://patches.dpdk.org/series/20911/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/105064/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/105064/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1EAA2A0093;\n\tFri, 10 Dec 2021 15:10:10 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8D55B40685;\n\tFri, 10 Dec 2021 15:10:09 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 702FC40041;\n Fri, 10 Dec 2021 15:10:08 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Dec 2021 06:10:06 -0800", "from silpixa00400355.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.222.49])\n by orsmga004.jf.intel.com with ESMTP; 10 Dec 2021 06:10:04 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1639145408; x=1670681408;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=gH/RFh7s1/F8lKm0UpsOfaKbzr7Js/ZyJufZumg4mVw=;\n b=Pzsb8ApgCqZfFkdJa2P9wtYEFwa5tMJmJcLZlOZfehZhKhVsGN0iHmDX\n MNTQZHssNn+4/kXY/zT+hv/M6jq3QlnZx3kFIPdrrelSEOxUFjn3cbXKu\n uplLD0QknGZlIc8BgtuuZ10XdFeWp0XtoQWwCW20IZbJ1vJl2bXjyPRq3\n O6Z8VFNIlBElcT3f8rvH7EIQf18XvGbUpMUElNVTfTSqzpRc02nMTmHMw\n kEpM0kz8gPO00zr6R4v5C8kqdBk7evuOgf3v/j7A7AzZGek4ZvRwTUTVE\n UYPDvaFYgj3CbpSkCS0nf30T0TmMmf9QvlmtkJGUQschatdDm8uNo6l8v A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10193\"; a=\"324613220\"", "E=Sophos;i=\"5.88,195,1635231600\"; d=\"scan'208\";a=\"324613220\"", "E=Sophos;i=\"5.88,195,1635231600\"; d=\"scan'208\";a=\"612936980\"" ], "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, john.mcnamara@intel.com, roy.fan.zhang@intel.com,\n Ciara Power <ciara.power@intel.com>,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>", "Subject": "[PATCH 1/3] crypto/ipsec_mb: fix qp setup null pointer dereference", "Date": "Fri, 10 Dec 2021 14:09:50 +0000", "Message-Id": "<20211210140952.2907974-1-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When setting up a qp in a secondary process, the local qp pointer is set\nto the stored device qp, configured by the primary process for that\ndevice, but only if that device qp is not NULL.\nIf the device qp was not set up correctly by the primary process and has\na NULL value, the local qp variable stays at the default initialised\nvalue, NULL. This causes a NULL pointer dereference later in the\nfunction when using the qp value.\n\nThis is fixed by always setting the local qp to the value of the device\nqp stored, and then checking if qp is NULL, returning an error if it is.\n\nCoverity issue: 374382\nFixes: 72a169278a56 (\"crypto/ipsec_mb: support multi-process\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c\nindex 189262c4ad..6efa417d67 100644\n--- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c\n+++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c\n@@ -221,8 +221,11 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \t\t\t\tIMB_VERSION_STR, IMB_MP_REQ_VER_STR);\n \t\treturn -EINVAL;\n #endif\n-\t\tif (dev->data->queue_pairs[qp_id] != NULL)\n-\t\t\tqp = dev->data->queue_pairs[qp_id];\n+\t\tqp = dev->data->queue_pairs[qp_id];\n+\t\tif (qp == NULL) {\n+\t\t\tIPSEC_MB_LOG(ERR, \"Primary process hasn't configured device qp.\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t} else {\n \t\t/* Free memory prior to re-allocation if needed. */\n \t\tif (dev->data->queue_pairs[qp_id] != NULL)\n", "prefixes": [ "1/3" ] }