Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/10435/?format=api
{ "id": 10435, "url": "http://patches.dpdk.org/api/patches/10435/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1454942306-26154-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1454942306-26154-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1454942306-26154-1-git-send-email-thomas.monjalon@6wind.com", "date": "2016-02-08T14:38:26", "name": "[dpdk-dev] config: remove useless explicit includes of generated header", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "94787410b739e198e26fcfcbfdab82dc64d5d318", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1454942306-26154-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/10435/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/10435/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6F45E2E81;\n\tMon, 8 Feb 2016 15:39:55 +0100 (CET)", "from mail-wm0-f45.google.com (mail-wm0-f45.google.com\n\t[74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 547E91396\n\tfor <dev@dpdk.org>; Mon, 8 Feb 2016 15:39:54 +0100 (CET)", "by mail-wm0-f45.google.com with SMTP id 128so157788755wmz.1\n\tfor <dev@dpdk.org>; Mon, 08 Feb 2016 06:39:54 -0800 (PST)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by smtp.gmail.com with ESMTPSA id\n\thm9sm30052904wjb.34.2016.02.08.06.39.52\n\tfor <dev@dpdk.org> (version=TLSv1/SSLv3 cipher=OTHER);\n\tMon, 08 Feb 2016 06:39:53 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id;\n\tbh=w7bervca5EHZ/6wICW/l5wmm8PzPyvnjxmFXAys8Eho=;\n\tb=tk4qOyNBmaKk3QDAqrFEbuTli+DAonZXUv0WS5WRpjsHMUW870Ia0ZSfUpyJQxkwlt\n\tPSmpBCMU/hVi8BcCk8axoy8sVXco6RTNJMAjkFi6H4rNhKHatjKFe3qyrBCby79/DcEx\n\t7rr3e7IFgK+2Hx8Bo5aNZ6TZleqZ8gzOGhKNpkn7Z29uXIdOdXxyYbteUIaP7c22HhPJ\n\taaw9blLCop15Y1CNt9Oy1QXbuf8bO8EhvAh0aFTIFg+Dhc/QjXSDeg8XNWAHXm7TKf+k\n\t4Bk/DTr/7vvcAiwU71z/s15cb+p0FvhodarPEKPlOtJ8oH+T+D55wW9OG2D2GtdJI4cI\n\tV8mg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=w7bervca5EHZ/6wICW/l5wmm8PzPyvnjxmFXAys8Eho=;\n\tb=i3nujQxWsz9/28gDXJzrgMDNx92qS5EZ3xBF5mQ+Ofa1I118sqS3mwIKctrMf1AaFz\n\tN6LV5ddJMWEO5mgmRqkPymx5mSJG6tNK7JDhp9Mk4uSxXdEIHuB28Zq8lOG5K5FDtVmc\n\tR36u5WXQvSw5mU5Db2E2rESxLzJ87l+RHWwfKyZTESBcSSZsuwOkRjXkk6+KNnoM2ldn\n\tb7MGviLuLMdZiux1oN8baNkxh2LHY8QIZILmeERsLvobnAImHvUmgYMKtDU7Y+gO6gwf\n\tIjL92kSbhgKgK8h4YlGXxE9IoQCVaF33l41XMGCUyFZKiP6mMOz+z8mxjTqHysi//ucq\n\tYlMg==", "X-Gm-Message-State": "AG10YOQq1Z19afUcqix0iWHiewuOyLL8gU6UJLu5NcYbj603ynUH7V099UTqifHAWOKGqhp0", "X-Received": "by 10.28.146.145 with SMTP id u139mr30093978wmd.81.1454942394069;\n\tMon, 08 Feb 2016 06:39:54 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 8 Feb 2016 15:38:26 +0100", "Message-Id": "<1454942306-26154-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "Subject": "[dpdk-dev] [PATCH] config: remove useless explicit includes of\n\tgenerated header", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The file rte_config.h is automatically generated and included.\nNo need to #include it.\n\nThe example performance-thread needs a makefile fix to avoid\noverwriting the default cflags.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n app/proc_info/main.c | 1 -\n app/test/test_power_kvm_vm.c | 1 -\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 1 -\n drivers/net/mlx4/mlx4.c | 1 -\n examples/l2fwd-ivshmem/host/host.c | 1 -\n examples/performance-thread/common/lthread.c | 1 -\n examples/performance-thread/common/lthread_cond.c | 1 -\n examples/performance-thread/common/lthread_diag.c | 1 -\n examples/performance-thread/common/lthread_mutex.c | 1 -\n examples/performance-thread/common/lthread_sched.c | 1 -\n examples/performance-thread/common/lthread_tls.c | 1 -\n examples/performance-thread/pthread_shim/Makefile | 2 +-\n examples/performance-thread/pthread_shim/main.c | 1 -\n examples/performance-thread/pthread_shim/pthread_shim.c | 1 -\n examples/vm_power_manager/channel_manager.c | 1 -\n examples/vm_power_manager/channel_monitor.c | 1 -\n examples/vm_power_manager/guest_cli/main.c | 1 -\n examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 1 -\n examples/vm_power_manager/main.c | 1 -\n examples/vm_power_manager/power_manager.c | 1 -\n examples/vm_power_manager/vm_power_cli.c | 1 -\n lib/librte_eal/linuxapp/kni/kni_misc.c | 1 -\n lib/librte_eal/linuxapp/kni/kni_net.c | 1 -\n lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c | 1 -\n lib/librte_power/guest_channel.c | 1 -\n lib/librte_power/rte_power_kvm_vm.c | 1 -\n 26 files changed, 1 insertion(+), 26 deletions(-)", "diff": "diff --git a/app/proc_info/main.c b/app/proc_info/main.c\nindex 6448d7b..341176d 100644\n--- a/app/proc_info/main.c\n+++ b/app/proc_info/main.c\n@@ -42,7 +42,6 @@\n #include <getopt.h>\n \n #include <rte_eal.h>\n-#include <rte_config.h>\n #include <rte_common.h>\n #include <rte_debug.h>\n #include <rte_ethdev.h>\ndiff --git a/app/test/test_power_kvm_vm.c b/app/test/test_power_kvm_vm.c\nindex 6fdb344..ff468c1 100644\n--- a/app/test/test_power_kvm_vm.c\n+++ b/app/test/test_power_kvm_vm.c\n@@ -40,7 +40,6 @@\n #include \"test.h\"\n \n #include <rte_power.h>\n-#include <rte_config.h>\n \n #define TEST_POWER_VM_LCORE_ID 0U\n #define TEST_POWER_VM_LCORE_OUT_OF_BOUNDS (RTE_MAX_LCORE+1)\ndiff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\nindex d8ccf05..2ede7c1 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n@@ -31,7 +31,6 @@\n */\n \n #include <rte_common.h>\n-#include <rte_config.h>\n #include <rte_hexdump.h>\n #include <rte_cryptodev.h>\n #include <rte_cryptodev_pmd.h>\ndiff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c\nindex 207bfe2..ee00151 100644\n--- a/drivers/net/mlx4/mlx4.c\n+++ b/drivers/net/mlx4/mlx4.c\n@@ -73,7 +73,6 @@\n #ifdef PEDANTIC\n #pragma GCC diagnostic ignored \"-pedantic\"\n #endif\n-#include <rte_config.h>\n #include <rte_ether.h>\n #include <rte_ethdev.h>\n #include <rte_dev.h>\ndiff --git a/examples/l2fwd-ivshmem/host/host.c b/examples/l2fwd-ivshmem/host/host.c\nindex d923711..6e6ed5e 100644\n--- a/examples/l2fwd-ivshmem/host/host.c\n+++ b/examples/l2fwd-ivshmem/host/host.c\n@@ -41,7 +41,6 @@\n #include <signal.h>\n \n #include <rte_eal.h>\n-#include <rte_config.h>\n #include <rte_cycles.h>\n #include <rte_eal_memconfig.h>\n #include <rte_debug.h>\ndiff --git a/examples/performance-thread/common/lthread.c b/examples/performance-thread/common/lthread.c\nindex e8addb7..8fbff73 100644\n--- a/examples/performance-thread/common/lthread.c\n+++ b/examples/performance-thread/common/lthread.c\n@@ -74,7 +74,6 @@\n #include <sys/time.h>\n #include <sys/mman.h>\n \n-#include <rte_config.h>\n #include <rte_log.h>\n #include <ctx.h>\n \ndiff --git a/examples/performance-thread/common/lthread_cond.c b/examples/performance-thread/common/lthread_cond.c\nindex 8885a09..96fcce0 100644\n--- a/examples/performance-thread/common/lthread_cond.c\n+++ b/examples/performance-thread/common/lthread_cond.c\n@@ -73,7 +73,6 @@\n #include <sys/mman.h>\n #include <errno.h>\n \n-#include <rte_config.h>\n #include <rte_log.h>\n #include <rte_common.h>\n \ndiff --git a/examples/performance-thread/common/lthread_diag.c b/examples/performance-thread/common/lthread_diag.c\nindex 1913c25..bce1a0c 100644\n--- a/examples/performance-thread/common/lthread_diag.c\n+++ b/examples/performance-thread/common/lthread_diag.c\n@@ -31,7 +31,6 @@\n * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n */\n \n-#include <rte_config.h>\n #include <rte_log.h>\n #include <rte_common.h>\n \ndiff --git a/examples/performance-thread/common/lthread_mutex.c b/examples/performance-thread/common/lthread_mutex.c\nindex 074d066..af8b82d 100644\n--- a/examples/performance-thread/common/lthread_mutex.c\n+++ b/examples/performance-thread/common/lthread_mutex.c\n@@ -44,7 +44,6 @@\n #include <sys/time.h>\n #include <sys/mman.h>\n \n-#include <rte_config.h>\n #include <rte_per_lcore.h>\n #include <rte_log.h>\n #include <rte_spinlock.h>\ndiff --git a/examples/performance-thread/common/lthread_sched.c b/examples/performance-thread/common/lthread_sched.c\nindex 3fad768..ae698c4 100644\n--- a/examples/performance-thread/common/lthread_sched.c\n+++ b/examples/performance-thread/common/lthread_sched.c\n@@ -76,7 +76,6 @@\n #include <sys/mman.h>\n #include <sched.h>\n \n-#include <rte_config.h>\n #include <rte_prefetch.h>\n #include <rte_per_lcore.h>\n #include <rte_atomic.h>\ndiff --git a/examples/performance-thread/common/lthread_tls.c b/examples/performance-thread/common/lthread_tls.c\nindex 1c6cf11..43cda4f 100644\n--- a/examples/performance-thread/common/lthread_tls.c\n+++ b/examples/performance-thread/common/lthread_tls.c\n@@ -45,7 +45,6 @@\n #include <execinfo.h>\n #include <sched.h>\n \n-#include <rte_config.h>\n #include <rte_malloc.h>\n #include <rte_log.h>\n #include <rte_ring.h>\ndiff --git a/examples/performance-thread/pthread_shim/Makefile b/examples/performance-thread/pthread_shim/Makefile\nindex 9cf32e3..86ac657 100644\n--- a/examples/performance-thread/pthread_shim/Makefile\n+++ b/examples/performance-thread/pthread_shim/Makefile\n@@ -46,7 +46,7 @@ SRCS-y := main.c pthread_shim.c\n INCLUDES := -I$(RTE_SDK)/$(RTE_TARGET)/include -I$(SRCDIR)\n include $(RTE_SDK)/examples/performance-thread/common/common.mk\n \n-CFLAGS= -g -O3 $(USER_FLAGS) $(INCLUDES)\n+CFLAGS += -g -O3 $(USER_FLAGS) $(INCLUDES)\n CFLAGS += $(WERROR_FLAGS)\n \n LDFLAGS += -lpthread\ndiff --git a/examples/performance-thread/pthread_shim/main.c b/examples/performance-thread/pthread_shim/main.c\nindex dab379a..f035721 100644\n--- a/examples/performance-thread/pthread_shim/main.c\n+++ b/examples/performance-thread/pthread_shim/main.c\n@@ -47,7 +47,6 @@\n #include <sched.h>\n #include <pthread.h>\n \n-#include <rte_config.h>\n #include <rte_common.h>\n #include <rte_lcore.h>\n #include <rte_per_lcore.h>\ndiff --git a/examples/performance-thread/pthread_shim/pthread_shim.c b/examples/performance-thread/pthread_shim/pthread_shim.c\nindex 0fd36ba..93c3216 100644\n--- a/examples/performance-thread/pthread_shim/pthread_shim.c\n+++ b/examples/performance-thread/pthread_shim/pthread_shim.c\n@@ -39,7 +39,6 @@\n #include <sched.h>\n #include <dlfcn.h>\n \n-#include <rte_config.h>\n #include <rte_log.h>\n \n #include \"lthread_api.h\"\ndiff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c\nindex ceaf95d..22c2ddd 100644\n--- a/examples/vm_power_manager/channel_manager.c\n+++ b/examples/vm_power_manager/channel_manager.c\n@@ -45,7 +45,6 @@\n #include <sys/socket.h>\n #include <sys/select.h>\n \n-#include <rte_config.h>\n #include <rte_malloc.h>\n #include <rte_memory.h>\n #include <rte_mempool.h>\ndiff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c\nindex 7003ddf..e7f5cc4 100644\n--- a/examples/vm_power_manager/channel_monitor.c\n+++ b/examples/vm_power_manager/channel_monitor.c\n@@ -42,7 +42,6 @@\n #include <sys/epoll.h>\n #include <sys/queue.h>\n \n-#include <rte_config.h>\n #include <rte_log.h>\n #include <rte_memory.h>\n #include <rte_malloc.h>\ndiff --git a/examples/vm_power_manager/guest_cli/main.c b/examples/vm_power_manager/guest_cli/main.c\nindex 7ee2296..5ac98ed 100644\n--- a/examples/vm_power_manager/guest_cli/main.c\n+++ b/examples/vm_power_manager/guest_cli/main.c\n@@ -48,7 +48,6 @@\n #include <rte_lcore.h>\n #include <rte_power.h>\n #include <rte_debug.h>\n-#include <rte_config.h>\n \n #include \"vm_power_cli_guest.h\"\n \ndiff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c\nindex 75e544a..7931135 100644\n--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c\n+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c\n@@ -43,7 +43,6 @@\n #include <cmdline_parse_num.h>\n #include <cmdline_socket.h>\n #include <cmdline.h>\n-#include <rte_config.h>\n #include <rte_log.h>\n #include <rte_lcore.h>\n \ndiff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c\nindex dfca7b8..97178d1 100644\n--- a/examples/vm_power_manager/main.c\n+++ b/examples/vm_power_manager/main.c\n@@ -52,7 +52,6 @@\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\n #include <rte_debug.h>\n-#include <rte_config.h>\n \n #include \"channel_manager.h\"\n #include \"channel_monitor.h\"\ndiff --git a/examples/vm_power_manager/power_manager.c b/examples/vm_power_manager/power_manager.c\nindex 60da96c..2644fce 100644\n--- a/examples/vm_power_manager/power_manager.c\n+++ b/examples/vm_power_manager/power_manager.c\n@@ -43,7 +43,6 @@\n \n #include <sys/types.h>\n \n-#include <rte_config.h>\n #include <rte_log.h>\n #include <rte_power.h>\n #include <rte_spinlock.h>\ndiff --git a/examples/vm_power_manager/vm_power_cli.c b/examples/vm_power_manager/vm_power_cli.c\nindex 7690d14..c5e8d93 100644\n--- a/examples/vm_power_manager/vm_power_cli.c\n+++ b/examples/vm_power_manager/vm_power_cli.c\n@@ -45,7 +45,6 @@\n #include <cmdline_parse_num.h>\n #include <cmdline_socket.h>\n #include <cmdline.h>\n-#include <rte_config.h>\n \n #include \"vm_power_cli.h\"\n #include \"channel_manager.h\"\ndiff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c\nindex f5f18f0..ae8133f 100644\n--- a/lib/librte_eal/linuxapp/kni/kni_misc.c\n+++ b/lib/librte_eal/linuxapp/kni/kni_misc.c\n@@ -35,7 +35,6 @@\n \n #include <exec-env/rte_kni_common.h>\n #include \"kni_dev.h\"\n-#include <rte_config.h>\n \n MODULE_LICENSE(\"Dual BSD/GPL\");\n MODULE_AUTHOR(\"Intel Corporation\");\ndiff --git a/lib/librte_eal/linuxapp/kni/kni_net.c b/lib/librte_eal/linuxapp/kni/kni_net.c\nindex ab5add4..e02edcb 100644\n--- a/lib/librte_eal/linuxapp/kni/kni_net.c\n+++ b/lib/librte_eal/linuxapp/kni/kni_net.c\n@@ -36,7 +36,6 @@\n #include <linux/kthread.h>\n #include <linux/delay.h>\n \n-#include <rte_config.h>\n #include <exec-env/rte_kni_common.h>\n #include <kni_fifo.h>\n #include \"kni_dev.h\"\ndiff --git a/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c b/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c\nindex bfe0af8..79630ba 100644\n--- a/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c\n+++ b/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c\n@@ -71,7 +71,6 @@\n #include <xen/xen-ops.h>\n #include <xen/interface/memory.h>\n \n-#include <rte_config.h>\n #include <exec-env/rte_dom0_common.h>\n \n #include \"compat.h\"\ndiff --git a/lib/librte_power/guest_channel.c b/lib/librte_power/guest_channel.c\nindex 2295665..d6b6d0a 100644\n--- a/lib/librte_power/guest_channel.c\n+++ b/lib/librte_power/guest_channel.c\n@@ -42,7 +42,6 @@\n \n \n #include <rte_log.h>\n-#include <rte_config.h>\n \n #include \"guest_channel.h\"\n #include \"channel_commands.h\"\ndiff --git a/lib/librte_power/rte_power_kvm_vm.c b/lib/librte_power/rte_power_kvm_vm.c\nindex 11596c3..7bb2774 100644\n--- a/lib/librte_power/rte_power_kvm_vm.c\n+++ b/lib/librte_power/rte_power_kvm_vm.c\n@@ -34,7 +34,6 @@\n #include <string.h>\n \n #include <rte_log.h>\n-#include <rte_config.h>\n \n #include \"guest_channel.h\"\n #include \"channel_commands.h\"\n", "prefixes": [ "dpdk-dev" ] }