Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104259/?format=api
{ "id": 104259, "url": "http://patches.dpdk.org/api/patches/104259/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211112214826.333853-4-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211112214826.333853-4-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211112214826.333853-4-dmitry.kozliuk@gmail.com", "date": "2021-11-12T21:48:26", "name": "[3/3] config/x86: fix MinGW cross build with meson 0.49", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fd849d0ede034f7c707f378b64415f4146795bfe", "submitter": { "id": 1581, "url": "http://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211112214826.333853-4-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 20531, "url": "http://patches.dpdk.org/api/series/20531/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20531", "date": "2021-11-12T21:48:23", "name": "config/x86: improve AVX512 availability check", "version": 1, "mbox": "http://patches.dpdk.org/series/20531/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/104259/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/104259/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 368E4A0032;\n\tFri, 12 Nov 2021 22:48:58 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 072934114E;\n\tFri, 12 Nov 2021 22:48:43 +0100 (CET)", "from mail-lj1-f180.google.com (mail-lj1-f180.google.com\n [209.85.208.180])\n by mails.dpdk.org (Postfix) with ESMTP id 1556F4113C\n for <dev@dpdk.org>; Fri, 12 Nov 2021 22:48:40 +0100 (CET)", "by mail-lj1-f180.google.com with SMTP id d11so21091549ljg.8\n for <dev@dpdk.org>; Fri, 12 Nov 2021 13:48:40 -0800 (PST)", "from sovereign.. (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id l5sm647917ljh.66.2021.11.12.13.48.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 12 Nov 2021 13:48:39 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=OH362mBwPs28MBydeA/XRSUfYXRVQWbpIer4vfK2/LU=;\n b=HKw9Oq/oM2NEUOYa9gXMW7dXhJp4s9xpiszSH8lTc9OxOXKVEsvz/d7DA7JBe4qg9C\n voGkMm4oX1NHWfs58L53dyxQWaNaiGMXfjPbqEdrb5xcZ43HPCudVBhmiIYwE9PlzZNY\n rWoaBYOk7X8SdYhzLbPC2yzBX0UjXApLUVlfe262rkmQAlGAKZRfbIB9Mqkhr8oXwqnZ\n ESUtPFjWgLIcbk0zMicBylwbwMabKP62MlxBPX9FBvhyuHGozMQ1n75RQUCEzNWDEKFB\n xJmzndgkC/mdJdWJNPPkrOO/LkmWV1ArXhriXJZ/l1xFVQHOklIlmBD+4CvydsWeTDwX\n MxYg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=OH362mBwPs28MBydeA/XRSUfYXRVQWbpIer4vfK2/LU=;\n b=HEGTIHuwOIn+Uiv9xWeAHO7lCrEDcUL3/tBndW0R8nKKi5l7O+28BwQINu0KqZVj74\n 1KaJcc8KITxra85XcNjbCNtL5jLvLsu4uOKWMtsZ/j/ESyVPcXUQAS/UWb/rcvd+z7Am\n iiQ87AGrbnk38EguW405nrqIpIVpnYEQKJi+wjKer9bdqcWLSHB59AeMVQa6xVSlCC5V\n 534JD6czm/H2DXhJWXDtJ9HwWT4WnCe8w7YoTf7Ujz3I2V7mCOIFvaoCYZ0d7wIpI3+8\n gZ4K1xP0sP9MtMYH44H9INrbU2RKhHYo0BOf6lHAMhBx+e5m2ECRRXDcIaJEaPZfMZvf\n DRHA==", "X-Gm-Message-State": "AOAM531GmNc61QdHIkh7y9nopFteByOJPCH8kdBNrjuNb91awA/XwY9B\n SITINC4+dqqlGQlyBj1oxqetvUl8nIU=", "X-Google-Smtp-Source": "\n ABdhPJwZqU/XYUZwO5XowrQ79UVRfBsdKQsbxi++nVI9QcdyYEFDnMMOAXpuxmO8I0aiZulIH+XMHQ==", "X-Received": "by 2002:a2e:6e12:: with SMTP id\n j18mr16208220ljc.527.1636753719587;\n Fri, 12 Nov 2021 13:48:39 -0800 (PST)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, leyi.rong@intel.com,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Subject": "[PATCH 3/3] config/x86: fix MinGW cross build with meson 0.49", "Date": "Sat, 13 Nov 2021 00:48:26 +0300", "Message-Id": "<20211112214826.333853-4-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.29.3", "In-Reply-To": "<20211112214826.333853-1-dmitry.kozliuk@gmail.com>", "References": "<20211112214826.333853-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Cross build with MinGW was broken for the baseline meson 0.49.2.\nCause: in c_args = '-mno-avx512f' from config/x86/cross-mingw,\neach character was treated as a separate compiler option:\n\n meson.build:4:0: ERROR: Compiler x86_64-w64-mingw32-gcc can not compile programs.\n\nWith c_args = ['-mno-avx512f'] configuration passed, but build failed,\nbecause Meson placed -mno-avx512f after -mavx512f in CFLAGS:\n\n In file included from /usr/lib/gcc/x86_64-w64-mingw32/9.3-win32/include/immintrin.h:55,\n from /usr/lib/gcc/x86_64-w64-mingw32/9.3-win32/include/x86intrin.h:32,\n from ../dpdk/lib/net/net_crc_avx512.c:13:\n /usr/lib/gcc/x86_64-w64-mingw32/9.3-win32/include/avx512fintrin.h:1650:1:\n error: inlining failed in call to always_inline _mm512_ternarylogic_epi64:\n target specific option mismatch\n 1650 | _mm512_ternarylogic_epi64 (__m512i __A, __m512i __B, __m512i __C,\n | ^~~~~~~~~~~~~~~~~~~~~~~~~\n ../dpdk/lib/net/net_crc_avx512.c:59:9: note: called from here\n 59 | return _mm512_ternarylogic_epi64(tmp0, tmp1, data_block, 0x96);\n | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nAdditionally, -m[no-]avx512f flag is expected to be in machine_args\nby all the checks in meson.build files.\n\nCommit 419c6e9af69e (\"net/i40e: fix build for Windows MinGW\")\nfixed the errors cause by MinGW using AVX512F on Windows.\nThe binutils AVX512F bug check is now portable,\nso enable it for Windows to switch AVX512 support on and off\nwithout any special logic for MinGW.\n\nFixes: 549bfc83168f (\"config: disable AVX512 with MinGW\")\nCc: leyi.rong@intel.com\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n config/x86/cross-mingw | 4 +---\n config/x86/meson.build | 2 +-\n 2 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/config/x86/cross-mingw b/config/x86/cross-mingw\nindex 48a82b457e..09f7af0928 100644\n--- a/config/x86/cross-mingw\n+++ b/config/x86/cross-mingw\n@@ -5,12 +5,10 @@ ld = 'x86_64-w64-mingw32-ld'\n ar = 'x86_64-w64-mingw32-ar'\n strip = 'x86_64-w64-mingw32-strip'\n pkgconfig = 'x86_64-w64-mingw32-pkg-config'\n+objdump = 'x86_64-w64-mingw32-objdump'\n \n [host_machine]\n system = 'windows'\n cpu_family = 'x86_64'\n cpu = 'native'\n endian = 'little'\n-\n-[properties]\n-c_args = '-mno-avx512f'\ndiff --git a/config/x86/meson.build b/config/x86/meson.build\nindex 603359e55a..e25ed316f4 100644\n--- a/config/x86/meson.build\n+++ b/config/x86/meson.build\n@@ -3,7 +3,7 @@\n \n # get binutils version for the workaround of Bug 97\n binutils_ok = true\n-if not is_windows and (is_linux or cc.get_id() == 'gcc')\n+if is_linux or cc.get_id() == 'gcc'\n binutils_ok = run_command(binutils_avx512_check).returncode() == 0\n if not binutils_ok and cc.has_argument('-mno-avx512f')\n machine_args += '-mno-avx512f'\n", "prefixes": [ "3/3" ] }