Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 10373,
    "url": "http://patches.dpdk.org/api/patches/10373/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1454589920-801-1-git-send-email-shaopeng.he@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1454589920-801-1-git-send-email-shaopeng.he@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1454589920-801-1-git-send-email-shaopeng.he@intel.com",
    "date": "2016-02-04T12:45:20",
    "name": "[dpdk-dev,v2] fm10k: fix switch manager high CPU usage",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "20fbabd7d53a8cdf24b4dfc4a2932f3001533e29",
    "submitter": {
        "id": 226,
        "url": "http://patches.dpdk.org/api/people/226/?format=api",
        "name": "He, Shaopeng",
        "email": "shaopeng.he@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1454589920-801-1-git-send-email-shaopeng.he@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/10373/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/10373/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 5865995D8;\n\tThu,  4 Feb 2016 13:45:37 +0100 (CET)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id B56298D8B\n\tfor <dev@dpdk.org>; Thu,  4 Feb 2016 13:45:35 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga101.fm.intel.com with ESMTP; 04 Feb 2016 04:45:32 -0800",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 04 Feb 2016 04:45:27 -0800",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id u14CjPmm000523;\n\tThu, 4 Feb 2016 20:45:25 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid u14CjMil000837; Thu, 4 Feb 2016 20:45:24 +0800",
            "(from heshaope@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id u14CjMXk000833; \n\tThu, 4 Feb 2016 20:45:22 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.22,395,1449561600\"; d=\"scan'208\";a=\"876883532\"",
        "From": "Shaopeng He <shaopeng.he@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu,  4 Feb 2016 20:45:20 +0800",
        "Message-Id": "<1454589920-801-1-git-send-email-shaopeng.he@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1453960023-31402-1-git-send-email-shaopeng.he@intel.com>",
        "References": "<1453960023-31402-1-git-send-email-shaopeng.he@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2] fm10k: fix switch manager high CPU usage",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "fm10k switch core uses source MAC + VID + SGLORT to do\nlook up in MAC table. If no match, an exception interrupt\nwill be sent to the switch manager. Too much of this kind\nof exception interrupts cause switch manager side high CPU\nusage.\nTo reproduce this issue, one DPDK testpmd runs on a server\nwith one fm10k NIC, mac forwards test traffic from one of\nfm10k ports to another port. The CPU usage for the switch\nmanager will go up to about 20% for test traffic rate at\n10G bps, comparing to near 0% for no test traffic.\nThis patch fixes this issue. A default SGLORT is assigned\nto each TX queue. This default value works for non-VMDq mode\nand current VMDq example. For advanced VMDq usage, e.g.\ndifferent source MAC address for different TX queue, FTAG\nforwarding function could be used to change this default\nSGLORT value.\n\nSigned-off-by: Shaopeng He <shaopeng.he@intel.com>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 3 +++\n 1 file changed, 3 insertions(+)",
    "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex e4aed94..f6eb05d 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -675,6 +675,9 @@ fm10k_dev_tx_init(struct rte_eth_dev *dev)\n \t\tFM10K_WRITE_REG(hw, FM10K_TDBAH(i),\n \t\t\t\tbase_addr >> (CHAR_BIT * sizeof(uint32_t)));\n \t\tFM10K_WRITE_REG(hw, FM10K_TDLEN(i), size);\n+\n+\t\t/* assign default SGLORT for each TX queue */\n+\t\tFM10K_WRITE_REG(hw, FM10K_TX_SGLORT(i), hw->mac.dglort_map);\n \t}\n \n \t/* set up vector or scalar TX function as appropriate */\n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}