Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103056/?format=api
{ "id": 103056, "url": "http://patches.dpdk.org/api/patches/103056/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211027142213.556166-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211027142213.556166-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211027142213.556166-3-maxime.coquelin@redhat.com", "date": "2021-10-27T14:22:10", "name": "[v6,2/5] app/testpmd: fix RSS key length", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3977db547827bf6c1c479de957f9e1ffdb3dad27", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211027142213.556166-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 20057, "url": "http://patches.dpdk.org/api/series/20057/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=20057", "date": "2021-10-27T14:22:08", "name": "Virtio PMD RSS support & RSS fixes", "version": 6, "mbox": "http://patches.dpdk.org/series/20057/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/103056/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/103056/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 14CABA0C47;\n\tWed, 27 Oct 2021 16:24:00 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0627D41151;\n\tWed, 27 Oct 2021 16:24:00 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id B048540DDA\n for <dev@dpdk.org>; Wed, 27 Oct 2021 16:23:57 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-381-x-bdHO9iOeGeFKT3rEXe-A-1; Wed, 27 Oct 2021 10:23:54 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com\n [10.5.11.22])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8BB03180831A;\n Wed, 27 Oct 2021 14:23:52 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.21])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D4AA4100E12C;\n Wed, 27 Oct 2021 14:23:31 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1635344637;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=exjK/nYcxDNyQdQGRay0yFUFMPpckKP8NXEkfDBJFsE=;\n b=ImH4aFnynPWexP12h4btJZcYFFPdjtBmKha591skf6G69mnPnhtaZY2ZugPt7jZL5WZ19P\n mvZQ419eercPPS0q2gOo5tm90OReiX9HGuuI99VGE3hDGGULrRVbrpCinKByaHyUdDbQ/N\n 9lbl1dJE85Z8+6j3Z7RhCAFtrXhQU1U=", "X-MC-Unique": "x-bdHO9iOeGeFKT3rEXe-A-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com,\n david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru,\n ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com,\n xiaoyun.li@intel.com", "Cc": "nelio.laranjeiro@6wind.com, yvugenfi@redhat.com, ybendito@redhat.com,\n Maxime Coquelin <maxime.coquelin@redhat.com>, stable@dpdk.org", "Date": "Wed, 27 Oct 2021 16:22:10 +0200", "Message-Id": "<20211027142213.556166-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20211027142213.556166-1-maxime.coquelin@redhat.com>", "References": "<20211027142213.556166-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v6 2/5] app/testpmd: fix RSS key length", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "port_rss_hash_key_update() initializes rss_conf with the\nRSS key configuration provided by the user, but it calls\nrte_eth_dev_rss_hash_conf_get() before calling\nrte_eth_dev_rss_hash_update(), which overrides the parsed\nRSS config.\n\nWhile the RSS key value is set again after, this is not\nthe case of the key length. It could cause out of bounds\naccess if the key length parsed is smaller than the one\nread from rte_eth_dev_rss_hash_conf_get().\n\nThis patch restores the key length before the\nrte_eth_dev_rss_hash_update() call to ensure the RSS key\nvalue/length pair is consistent.\n\nFixes: 8205e241b2b0 (\"app/testpmd: add missing type to RSS hash commands\")\nCc: stable@dpdk.org\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nAcked-by: Xiaoyun Li <xiaoyun.li@intel.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n app/test-pmd/config.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex a18871d461..e5c58ceb37 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -3040,7 +3040,7 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key,\n \tunsigned int i;\n \n \trss_conf.rss_key = NULL;\n-\trss_conf.rss_key_len = hash_key_len;\n+\trss_conf.rss_key_len = 0;\n \trss_conf.rss_hf = 0;\n \tfor (i = 0; rss_type_table[i].str; i++) {\n \t\tif (!strcmp(rss_type_table[i].str, rss_type))\n@@ -3049,6 +3049,7 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key,\n \tdiag = rte_eth_dev_rss_hash_conf_get(port_id, &rss_conf);\n \tif (diag == 0) {\n \t\trss_conf.rss_key = hash_key;\n+\t\trss_conf.rss_key_len = hash_key_len;\n \t\tdiag = rte_eth_dev_rss_hash_update(port_id, &rss_conf);\n \t}\n \tif (diag == 0)\n", "prefixes": [ "v6", "2/5" ] }