Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102781/?format=api
{ "id": 102781, "url": "http://patches.dpdk.org/api/patches/102781/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211025133456.26850-8-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211025133456.26850-8-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211025133456.26850-8-david.marchand@redhat.com", "date": "2021-10-25T13:34:53", "name": "[v7,7/9] interrupts: make interrupt handle structure opaque", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c9a01ba1931b4e911b5bf8e28ffc0ca39de212f3", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211025133456.26850-8-david.marchand@redhat.com/mbox/", "series": [ { "id": 19958, "url": "http://patches.dpdk.org/api/series/19958/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19958", "date": "2021-10-25T13:34:46", "name": "make rte_intr_handle internal", "version": 7, "mbox": "http://patches.dpdk.org/series/19958/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102781/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/102781/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E661DA0C4C;\n\tMon, 25 Oct 2021 15:38:35 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D300840E3C;\n\tMon, 25 Oct 2021 15:38:35 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id 736F54003E\n for <dev@dpdk.org>; Mon, 25 Oct 2021 15:38:34 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-535-B6msBSw4MLiqamuAQDQiPA-1; Mon, 25 Oct 2021 09:38:32 -0400", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com\n [10.5.11.14])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 434979F92B;\n Mon, 25 Oct 2021 13:38:31 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.64])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8BB3218533;\n Mon, 25 Oct 2021 13:38:29 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1635169114;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=Z+WXFP8U8NW39vxQcpSXoehwqx4aTGPFAWfAT5XM3qg=;\n b=cjEpnBRkpqidgUgImx4x4HXlE5J/zvahsLDPzMFfxl7kBiMP/3dYQCnQNbFpHn83+Cubku\n ZgM1BHiAWHqrDXGpNMYwoAQM/x8z90XcqLjXHJOJ8EsjvKiuh0nPmb5IhfzhhvcRS1IS/T\n cV70FbjMPzzny+7OrNd3hAgtwv+PaPg=", "X-MC-Unique": "B6msBSw4MLiqamuAQDQiPA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "hkalra@marvell.com,\n\tdev@dpdk.org", "Cc": "dmitry.kozliuk@gmail.com,\n\trasland@nvidia.com,\n\tthomas@monjalon.net", "Date": "Mon, 25 Oct 2021 15:34:53 +0200", "Message-Id": "<20211025133456.26850-8-david.marchand@redhat.com>", "In-Reply-To": "<20211025133456.26850-1-david.marchand@redhat.com>", "References": "<20211022204934.132186-1-hkalra@marvell.com>\n <20211025133456.26850-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v7 7/9] interrupts: make interrupt handle\n structure opaque", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Harman Kalra <hkalra@marvell.com>\n\nMoving interrupt handle structure definition inside a EAL private\nheader to make its fields totally opaque to the outside world.\n\nSigned-off-by: Harman Kalra <hkalra@marvell.com>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\nChanges since v5:\n- let rte_intr_handle fields untouched:\n - split vfio / uio fd renames in a separate commit,\n - split event list update in a separate commit,\n- moved rte_intr_handle definition to a EAL private header,\n- preserved dumping all info in interrupt tracepoints,\n\n---\n lib/eal/common/eal_common_interrupts.c | 2 +\n lib/eal/common/eal_interrupts.h | 37 +++++++++++++\n lib/eal/include/meson.build | 1 -\n lib/eal/include/rte_eal_interrupts.h | 72 --------------------------\n lib/eal/include/rte_eal_trace.h | 2 +\n lib/eal/include/rte_interrupts.h | 24 ++++++++-\n 6 files changed, 63 insertions(+), 75 deletions(-)\n create mode 100644 lib/eal/common/eal_interrupts.h\n delete mode 100644 lib/eal/include/rte_eal_interrupts.h", "diff": "diff --git a/lib/eal/common/eal_common_interrupts.c b/lib/eal/common/eal_common_interrupts.c\nindex d6e6654fbb..1337c560e4 100644\n--- a/lib/eal/common/eal_common_interrupts.c\n+++ b/lib/eal/common/eal_common_interrupts.c\n@@ -10,6 +10,8 @@\n #include <rte_log.h>\n #include <rte_malloc.h>\n \n+#include \"eal_interrupts.h\"\n+\n /* Macros to check for valid interrupt handle */\n #define CHECK_VALID_INTR_HANDLE(intr_handle) do { \\\n \tif (intr_handle == NULL) { \\\ndiff --git a/lib/eal/common/eal_interrupts.h b/lib/eal/common/eal_interrupts.h\nnew file mode 100644\nindex 0000000000..beacc04b62\n--- /dev/null\n+++ b/lib/eal/common/eal_interrupts.h\n@@ -0,0 +1,37 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2010-2014 Intel Corporation\n+ */\n+\n+#ifndef EAL_INTERRUPTS_H\n+#define EAL_INTERRUPTS_H\n+\n+struct rte_intr_handle {\n+\tRTE_STD_C11\n+\tunion {\n+\t\tstruct {\n+\t\t\tRTE_STD_C11\n+\t\t\tunion {\n+\t\t\t\t/** VFIO device file descriptor */\n+\t\t\t\tint vfio_dev_fd;\n+\t\t\t\t/** UIO cfg file desc for uio_pci_generic */\n+\t\t\t\tint uio_cfg_fd;\n+\t\t\t};\n+\t\t\tint fd;\t/**< interrupt event file descriptor */\n+\t\t};\n+\t\tvoid *windows_handle; /**< device driver handle */\n+\t};\n+\tuint32_t alloc_flags;\t/**< flags passed at allocation */\n+\tenum rte_intr_handle_type type; /**< handle type */\n+\tuint32_t max_intr; /**< max interrupt requested */\n+\tuint32_t nb_efd; /**< number of available efd(event fd) */\n+\tuint8_t efd_counter_size; /**< size of efd counter, used for vdev */\n+\tuint16_t nb_intr;\n+\t\t/**< Max vector count, default RTE_MAX_RXTX_INTR_VEC_ID */\n+\tint efds[RTE_MAX_RXTX_INTR_VEC_ID]; /**< intr vectors/efds mapping */\n+\tstruct rte_epoll_event elist[RTE_MAX_RXTX_INTR_VEC_ID];\n+\t\t\t\t /**< intr vector epoll event */\n+\tuint16_t vec_list_size;\n+\tint *intr_vec; /**< intr vector number array */\n+};\n+\n+#endif /* EAL_INTERRUPTS_H */\ndiff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build\nindex 8e258607b8..86468d1a2b 100644\n--- a/lib/eal/include/meson.build\n+++ b/lib/eal/include/meson.build\n@@ -49,7 +49,6 @@ headers += files(\n 'rte_version.h',\n 'rte_vfio.h',\n )\n-indirect_headers += files('rte_eal_interrupts.h')\n \n # special case install the generic headers, since they go in a subdir\n generic_headers = files(\ndiff --git a/lib/eal/include/rte_eal_interrupts.h b/lib/eal/include/rte_eal_interrupts.h\ndeleted file mode 100644\nindex 60bb60ca59..0000000000\n--- a/lib/eal/include/rte_eal_interrupts.h\n+++ /dev/null\n@@ -1,72 +0,0 @@\n-/* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2010-2014 Intel Corporation\n- */\n-\n-#ifndef _RTE_INTERRUPTS_H_\n-#error \"don't include this file directly, please include generic <rte_interrupts.h>\"\n-#endif\n-\n-/**\n- * @file rte_eal_interrupts.h\n- * @internal\n- *\n- * Contains function prototypes exposed by the EAL for interrupt handling by\n- * drivers and other DPDK internal consumers.\n- */\n-\n-#ifndef _RTE_EAL_INTERRUPTS_H_\n-#define _RTE_EAL_INTERRUPTS_H_\n-\n-#define RTE_MAX_RXTX_INTR_VEC_ID 512\n-#define RTE_INTR_VEC_ZERO_OFFSET 0\n-#define RTE_INTR_VEC_RXTX_OFFSET 1\n-\n-/**\n- * The interrupt source type, e.g. UIO, VFIO, ALARM etc.\n- */\n-enum rte_intr_handle_type {\n-\tRTE_INTR_HANDLE_UNKNOWN = 0, /**< generic unknown handle */\n-\tRTE_INTR_HANDLE_UIO, /**< uio device handle */\n-\tRTE_INTR_HANDLE_UIO_INTX, /**< uio generic handle */\n-\tRTE_INTR_HANDLE_VFIO_LEGACY, /**< vfio device handle (legacy) */\n-\tRTE_INTR_HANDLE_VFIO_MSI, /**< vfio device handle (MSI) */\n-\tRTE_INTR_HANDLE_VFIO_MSIX, /**< vfio device handle (MSIX) */\n-\tRTE_INTR_HANDLE_ALARM, /**< alarm handle */\n-\tRTE_INTR_HANDLE_EXT, /**< external handler */\n-\tRTE_INTR_HANDLE_VDEV, /**< virtual device */\n-\tRTE_INTR_HANDLE_DEV_EVENT, /**< device event handle */\n-\tRTE_INTR_HANDLE_VFIO_REQ, /**< VFIO request handle */\n-\tRTE_INTR_HANDLE_MAX /**< count of elements */\n-};\n-\n-/** Handle for interrupts. */\n-struct rte_intr_handle {\n-\tRTE_STD_C11\n-\tunion {\n-\t\tstruct {\n-\t\t\tRTE_STD_C11\n-\t\t\tunion {\n-\t\t\t\t/** VFIO device file descriptor */\n-\t\t\t\tint vfio_dev_fd;\n-\t\t\t\t/** UIO cfg file desc for uio_pci_generic */\n-\t\t\t\tint uio_cfg_fd;\n-\t\t\t};\n-\t\t\tint fd;\t/**< interrupt event file descriptor */\n-\t\t};\n-\t\tvoid *windows_handle; /**< device driver handle */\n-\t};\n-\tuint32_t alloc_flags;\t/**< flags passed at allocation */\n-\tenum rte_intr_handle_type type; /**< handle type */\n-\tuint32_t max_intr; /**< max interrupt requested */\n-\tuint32_t nb_efd; /**< number of available efd(event fd) */\n-\tuint8_t efd_counter_size; /**< size of efd counter, used for vdev */\n-\tuint16_t nb_intr;\n-\t\t/**< Max vector count, default RTE_MAX_RXTX_INTR_VEC_ID */\n-\tint efds[RTE_MAX_RXTX_INTR_VEC_ID]; /**< intr vectors/efds mapping */\n-\tstruct rte_epoll_event elist[RTE_MAX_RXTX_INTR_VEC_ID];\n-\t\t\t\t /**< intr vector epoll event */\n-\tuint16_t vec_list_size;\n-\tint *intr_vec; /**< intr vector number array */\n-};\n-\n-#endif /* _RTE_EAL_INTERRUPTS_H_ */\ndiff --git a/lib/eal/include/rte_eal_trace.h b/lib/eal/include/rte_eal_trace.h\nindex 495ae1ee1d..af7b2d0bf0 100644\n--- a/lib/eal/include/rte_eal_trace.h\n+++ b/lib/eal/include/rte_eal_trace.h\n@@ -19,6 +19,8 @@ extern \"C\" {\n #include <rte_interrupts.h>\n #include <rte_trace_point.h>\n \n+#include \"eal_interrupts.h\"\n+\n /* Alarm */\n RTE_TRACE_POINT(\n \trte_eal_trace_alarm_set,\ndiff --git a/lib/eal/include/rte_interrupts.h b/lib/eal/include/rte_interrupts.h\nindex a515a8c073..edbf0faeef 100644\n--- a/lib/eal/include/rte_interrupts.h\n+++ b/lib/eal/include/rte_interrupts.h\n@@ -35,6 +35,28 @@ struct rte_intr_handle;\n /** Interrupt instance will be shared between primary and secondary processes. */\n #define RTE_INTR_INSTANCE_F_SHARED RTE_BIT32(0)\n \n+#define RTE_MAX_RXTX_INTR_VEC_ID 512\n+#define RTE_INTR_VEC_ZERO_OFFSET 0\n+#define RTE_INTR_VEC_RXTX_OFFSET 1\n+\n+/**\n+ * The interrupt source type, e.g. UIO, VFIO, ALARM etc.\n+ */\n+enum rte_intr_handle_type {\n+\tRTE_INTR_HANDLE_UNKNOWN = 0, /**< generic unknown handle */\n+\tRTE_INTR_HANDLE_UIO, /**< uio device handle */\n+\tRTE_INTR_HANDLE_UIO_INTX, /**< uio generic handle */\n+\tRTE_INTR_HANDLE_VFIO_LEGACY, /**< vfio device handle (legacy) */\n+\tRTE_INTR_HANDLE_VFIO_MSI, /**< vfio device handle (MSI) */\n+\tRTE_INTR_HANDLE_VFIO_MSIX, /**< vfio device handle (MSIX) */\n+\tRTE_INTR_HANDLE_ALARM, /**< alarm handle */\n+\tRTE_INTR_HANDLE_EXT, /**< external handler */\n+\tRTE_INTR_HANDLE_VDEV, /**< virtual device */\n+\tRTE_INTR_HANDLE_DEV_EVENT, /**< device event handle */\n+\tRTE_INTR_HANDLE_VFIO_REQ, /**< VFIO request handle */\n+\tRTE_INTR_HANDLE_MAX /**< count of elements */\n+};\n+\n /** Function to be registered for the specific interrupt */\n typedef void (*rte_intr_callback_fn)(void *cb_arg);\n \n@@ -45,8 +67,6 @@ typedef void (*rte_intr_callback_fn)(void *cb_arg);\n typedef void (*rte_intr_unregister_callback_fn)(struct rte_intr_handle *intr_handle,\n \t\t\t\t\t\tvoid *cb_arg);\n \n-#include \"rte_eal_interrupts.h\"\n-\n /**\n * It registers the callback for the specific interrupt. Multiple\n * callbacks can be registered at the same time.\n", "prefixes": [ "v7", "7/9" ] }