Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102703/?format=api
{ "id": 102703, "url": "http://patches.dpdk.org/api/patches/102703/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211022211407.315068-2-bingz@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211022211407.315068-2-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211022211407.315068-2-bingz@nvidia.com", "date": "2021-10-22T21:14:07", "name": "[2/2] ethdev: fix the race condition for fp ops reset", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "687230b13f093a134fc0d23f36bc08258f19b886", "submitter": { "id": 1976, "url": "http://patches.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211022211407.315068-2-bingz@nvidia.com/mbox/", "series": [ { "id": 19928, "url": "http://patches.dpdk.org/api/series/19928/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19928", "date": "2021-10-22T21:14:06", "name": "[1/2] ethdev: fix log level of Tx and Rx dummy functions", "version": 1, "mbox": "http://patches.dpdk.org/series/19928/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102703/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/102703/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DAA7DA0C43;\n\tFri, 22 Oct 2021 23:14:34 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4535B410EF;\n\tFri, 22 Oct 2021 23:14:33 +0200 (CEST)", "from NAM02-DM3-obe.outbound.protection.outlook.com\n (mail-dm3nam07on2071.outbound.protection.outlook.com [40.107.95.71])\n by mails.dpdk.org (Postfix) with ESMTP id D7243410EE\n for <dev@dpdk.org>; Fri, 22 Oct 2021 23:14:31 +0200 (CEST)", "from DM6PR02CA0058.namprd02.prod.outlook.com (2603:10b6:5:177::35)\n by MN2PR12MB4815.namprd12.prod.outlook.com (2603:10b6:208:1bf::22) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Fri, 22 Oct\n 2021 21:14:29 +0000", "from DM6NAM11FT004.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:177:cafe::2a) by DM6PR02CA0058.outlook.office365.com\n (2603:10b6:5:177::35) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend\n Transport; Fri, 22 Oct 2021 21:14:29 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT004.mail.protection.outlook.com (10.13.172.217) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4628.16 via Frontend Transport; Fri, 22 Oct 2021 21:14:29 +0000", "from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 22 Oct\n 2021 21:14:27 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=mfFhxNKxK2h+zYiidDEC0x9ymcXng7HJoZaqK6V5kozStil+uyGeBN4EEbbhlTOck+N+cQ+/SHMc2XFskd9zFrYEPLwFGcxnA1o2iX4jM81XouinRhNLQEOeeRPr3XaDv0Egl7JqGAmNW0QSNrILeWXcIWIXTw5vG/ZaWwNXYAF1fFHX9OxNmVBAmDjC4h2pk2CNAC4CQbTMtRRyuGp7pesDSXhpoje4+G2/fVhhzSHjrCceeirtNWOdM+j9VPIoboYQjB5eC3ZiEsbHOui/ZZVnDELqktLlGd79LD9ZTl0wBLrLy56yhMxaBtk9FazIorv68PUe4tWE2trVD3BO7Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=tTivB7WySVcB93Ki9ED9uIkRGP4ZsK8KwNs3KeEiJLE=;\n b=AKRsVBaEjgzQpfgVsvBzhh6M1AoM0hq9vU0PMeo5jqH9VS6yUAug/eHT5/6JjlV3db4Pexlf5Td6WuyGYWdotDYHF82VSa+PRILKhHnkTTQsYodS/bMiNItQW5lzTRxhcKCrpYvBc1ELt5GOgMhSXIOGE74YBBU+dZuiWVaYDnSB4tHFIL3A0XeXQkZH9lgiDdRQ9/r07BzGiXLDGuDgruNTBPF+1+ISFzKkCLWQDJTo4Q0N7mibKQOnVcGZrE23WH11y+Vo/kxFwqZLSjhSNrudm67+3aIRapGqQZVGhhvx305Kv/BODTRYA2cRhBDG5MzvCN6+RSw2iiqAghluaQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=tTivB7WySVcB93Ki9ED9uIkRGP4ZsK8KwNs3KeEiJLE=;\n b=OHtk7d60uvBQeq51hYbLDOW1Xrke2OZaO+D2HqbUpE7qfcguXv6zdZc3BU7iYJTFzyQmQB0iZGXE/OFFF8kz5TKb+n5nBx/eRbHCNxGNq3HiibT5geber2UZiu+nnHuUFMWwXR2Q/BVKnK5oOYr3vN/dIFO1qbekrRnwXGCFTkqNlxO5jsI/32LzP58qwkjUdvsG77OWlJwEyAxQYSlyLtfdDjDQvIEEC6jPji6/wk51sHbvDT3WZxop6XAqwq3hVZE6U0x1pHyJJzS51mncOZlJ1MLgWTctocVR9qEFNDVdFds1nipu/FC1H5tMNI7DuxToaL22EzHLAnM7cbSGzw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Bing Zhao <bingz@nvidia.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@intel.com>,\n <andrew.rybchenko@oktetlabs.ru>", "CC": "<dev@dpdk.org>, <konstantin.ananyev@intel.com>", "Date": "Sat, 23 Oct 2021 00:14:07 +0300", "Message-ID": "<20211022211407.315068-2-bingz@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20211022211407.315068-1-bingz@nvidia.com>", "References": "<20211022211407.315068-1-bingz@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "14a13237-6190-4b93-449b-08d995a0ef78", "X-MS-TrafficTypeDiagnostic": "MN2PR12MB4815:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <MN2PR12MB481505470ECE3A448D22B4AAD0809@MN2PR12MB4815.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:9508;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n bsgPGm9iAQi6XkbMRGxqFlOLLA8r/HntVf2bu4mLJJopcNN97zeYLXLXZTB+PZVq1unRuPWaA9BpJk221u8tikkW1/HP5VMdYJUMgpkGjIQTexUOvsG8kDC9q4JUXfVmnJSpfq/VlulmJW5J0xfTZUDioBUPW84yO9gxPgQXPVHZXo5WCtb7iv3bWEhm2EHkqoyuXu+psGPLJrnYnHcsHtYcKIzW0RrstQoCLwPXuU73S4H0jEyhN2FVnqLI+XMr73lvmJZI3ljegZI4qXRDM+KSYpuFWymBKNZt2okAMfyuXHGexFaw/7tkJi9+JyWhEQCxWsoPKxrIZk1wjcFUWVSuXOtID9qizBz8saW1ySJM+LR4zwcV72Ztjqsy2K7h2vO2gUJSsIWvNbnhb24EI7kwFHVuJ2DQ6k9/UgoSIga0g50UA9YIUtJPlOy2iJkx8Lm3/4eL+OipgpY9cd73hS9jZfUSgVVCngpv5GLe0Z2IJvDGTBxjPSSSCA5M13nfdJ03Ld5idp8N8GldyEp1NRTmXbWORqGgTYjXdQ0HwT+a+Dgzx3T+xrEEuJatbd9zkfPkfQN2e9RhMMr4oru82wk0XtHgGCFnqqKOiUiczRkrESpAv0EjCnrbM1ah4Xr/dIOEk4Fy2nVr0nmUHzr9GOeHPC8vWvasUXNaQvWN6k7TwxJ2OHrcNeQFHZqjrYzWGvtJYofwxuffbbjDEcEfjg==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(36840700001)(46966006)(356005)(8936002)(70586007)(2906002)(36906005)(83380400001)(508600001)(316002)(82310400003)(6666004)(110136005)(70206006)(54906003)(16526019)(8676002)(2616005)(26005)(5660300002)(7696005)(47076005)(7636003)(1076003)(86362001)(55016002)(336012)(426003)(36860700001)(36756003)(4326008)(6286002)(186003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Oct 2021 21:14:29.3408 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 14a13237-6190-4b93-449b-08d995a0ef78", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT004.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR12MB4815", "Subject": "[dpdk-dev] [PATCH 2/2] ethdev: fix the race condition for fp ops\n reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In the function \"eth_dev_fp_ops_reset\", a structure assignment\noperation is used to reset one queue's callback functions, etc., but\nit is not thread safe.\n\nThe structure assignment is not atomic, a lot of instructions will\nbe generated. Right now, since not all the fields are needed, the\nfields in the \"dummy_ops\" which is not set explicitly will be 0s\nbased on the specification and compiler behavior. In order to make\n\"fpo\" has the same content with \"dummy_ops\", some clearing to 0\noperation is needed.\n\nBy checking the object instructions (e.g. with GCC 4.8.5)\n 0x0000000000a58317 <+35>:\tmov %rsi,%rdi\n 0x0000000000a5831a <+38>:\tmov %rdx,%rcx\n=> 0x0000000000a5831d <+41>:\trep stos %rax,%es:(%rdi)\n 0x0000000000a58320 <+44>:\tmov -0x38(%rsp),%rax\n 0x0000000000a58325 <+49>:\tlea -0xe0(%rip),%rdx\n // # 0xa5824c <dummy_eth_rx_burst>\n\nIt shows that \"rep stos\" will clear the \"fpo\" structure before\nassigning new values.\n\nIn the other thread, if some data path Tx / Rx functions are still\nrunning, there is a risk to get 0 instead of the correct dummy\ncontent.\n 1. qd = p->rxq.data[queue_id]\n 2. (void **)&p->rxq.clbk[queue_id]\n\"data\" and \"clbk\" may be observed with NULL (0) in other threads.\nEven it is temporary, the accessing to a NULL pointer will cause a\ncrash. Using \"memcpy\" could get rid of this.\n\nFixes: c87d435a4d79 (\"ethdev: copy fast-path API into separate structure\")\nCc: konstantin.ananyev@intel.com\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\n---\n lib/ethdev/ethdev_private.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev/ethdev_private.c\nindex fbc3df91ad..cda9a6e228 100644\n--- a/lib/ethdev/ethdev_private.c\n+++ b/lib/ethdev/ethdev_private.c\n@@ -206,7 +206,7 @@ eth_dev_fp_ops_reset(struct rte_eth_fp_ops *fpo)\n \t\t.txq = {.data = dummy_data, .clbk = dummy_data,},\n \t};\n \n-\t*fpo = dummy_ops;\n+\trte_memcpy(fpo, &dummy_ops, sizeof(struct rte_eth_fp_ops));\n }\n \n void\n", "prefixes": [ "2/2" ] }