Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102693/?format=api
{ "id": 102693, "url": "http://patches.dpdk.org/api/patches/102693/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211022204934.132186-1-hkalra@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211022204934.132186-1-hkalra@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211022204934.132186-1-hkalra@marvell.com", "date": "2021-10-22T20:49:28", "name": "[v5,0/6] make rte_intr_handle internal", "commit_ref": null, "pull_url": null, "state": null, "archived": false, "hash": null, "submitter": { "id": 1182, "url": "http://patches.dpdk.org/api/people/1182/?format=api", "name": "Harman Kalra", "email": "hkalra@marvell.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211022204934.132186-1-hkalra@marvell.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/102693/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/102693/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9AB5BA0C43;\n\tFri, 22 Oct 2021 22:49:53 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 20A6D40150;\n\tFri, 22 Oct 2021 22:49:53 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 1B9E040150\n for <dev@dpdk.org>; Fri, 22 Oct 2021 22:49:50 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id\n 19MK5qJm011085;\n Fri, 22 Oct 2021 13:49:47 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 3buu23tby2-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 22 Oct 2021 13:49:47 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Fri, 22 Oct 2021 13:49:39 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Fri, 22 Oct 2021 13:49:39 -0700", "from localhost.marvell.com (unknown [10.29.52.211])\n by maili.marvell.com (Postfix) with ESMTP id 4C1B73F7058;\n Fri, 22 Oct 2021 13:49:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=I1mzvLJHp6ae7Qiq7QtdImoCEiPOLzSyZSAv7QO2kpQ=;\n b=R+V5r4lt188SKug4ByA7bsosU+DjI08aep+RjrkugRi55xeINgTKcRr0QgwVOC5PwPYI\n 5FzxfOuht9DAoTI8oWGMejeCSFbCvXv8j2eZXtGELPKplt7psTfKyjiWz7sIEaJDPDcu\n bYatVepVBEvZMuGeAZnVc5IJqwFOpS6foY+2QGTpmWzDc6MKNymulaPRFSfyzVKGXXR+\n 6UyCNlPkwcntDFp+qnHJ6Reo9ssyV+Q9A0ABIOHrqa2J+CHz2v4IQAhq69gDbxU3Xu7E\n T0P9/vzl71eAzfbcRi9XlB5Q6DB8sZblSdO+CotAKJQDQ2WqNHutUVOPeVSH0T8nP3qx OA==", "From": "Harman Kalra <hkalra@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<david.marchand@redhat.com>, <dmitry.kozliuk@gmail.com>, <mdr@ashroe.eu>,\n <thomas@monjalon.net>, Harman Kalra <hkalra@marvell.com>", "Date": "Sat, 23 Oct 2021 02:19:28 +0530", "Message-ID": "<20211022204934.132186-1-hkalra@marvell.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20210826145726.102081-1-hkalra@marvell.com>", "References": "<20210826145726.102081-1-hkalra@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "9m8xD7zoJLXdxpYVBQiI6XRYTEe8HFOC", "X-Proofpoint-ORIG-GUID": "9m8xD7zoJLXdxpYVBQiI6XRYTEe8HFOC", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-10-22_05,2021-10-22_01,2020-04-07_01", "Subject": "[dpdk-dev] [PATCH v5 0/6] make rte_intr_handle internal", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Moving struct rte_intr_handle as an internal structure to\navoid any ABI breakages in future. Since this structure defines\nsome static arrays and changing respective macros breaks the ABI.\nEg:\nCurrently RTE_MAX_RXTX_INTR_VEC_ID imposes a limit of maximum 512\nMSI-X interrupts that can be defined for a PCI device, while PCI\nspecification allows maximum 2048 MSI-X interrupts that can be used.\nIf some PCI device requires more than 512 vectors, either change the\nRTE_MAX_RXTX_INTR_VEC_ID limit or dynamically allocate based on\nPCI device MSI-X size on probe time. Either way its an ABI breakage.\n\nChange already included in 21.11 ABI improvement spreadsheet (item 42):\nhttps://urldefense.proofpoint.com/v2/url?u=https-3A__docs.google.com_s\npreadsheets_d_1betlC000ua5SsSiJIcC54mCCCJnW6voH5Dqv9UxeyfE_edit-23gid-\n3D0&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=5ESHPj7V-7JdkxT_Z_SU6RrS37ys4U\nXudBQ_rrS5LRo&m=7dl3OmXU7QHMmWYB6V1hYJtq1cUkjfhXUwze2Si_48c&s=lh6DEGhR\nBg1shODpAy3RQk-H-0uQx5icRfUBf9dtCp4&e=\n\nThis series makes struct rte_intr_handle totally opaque to the outside\nworld by wrapping it inside a .c file and providing get set wrapper APIs\nto read or manipulate its fields.. Any changes to be made to any of the\nfields should be done via these get set APIs.\nIntroduced a new eal_common_interrupts.c where all these APIs are defined\nand also hides struct rte_intr_handle definition.\n\nDetails on each patch of the series:\nPatch 1: eal/interrupts: implement get set APIs\nThis patch provides prototypes and implementation of all the new\nget set APIs. Alloc APIs are implemented to allocate memory for\ninterrupt handle instance. Currently most of the drivers defines\ninterrupt handle instance as static but now it cant be static as\nsize of rte_intr_handle is unknown to all the drivers. Drivers are\nexpected to allocate interrupt instances during initialization\nand free these instances during cleanup phase.\nThis patch also rearranges the headers related to interrupt\nframework. Epoll related definitions prototypes are moved into a\nnew header i.e. rte_epoll.h and APIs defined in rte_eal_interrupts.h\nwhich were driver specific are moved to rte_interrupts.h (as anyways\nit was accessible and used outside DPDK library. Later in the series\nrte_eal_interrupts.h is removed.\n\nPatch 2: eal/interrupts: avoid direct access to interrupt handle\nModifying the interrupt framework for linux and freebsd to use these\nget set alloc APIs as per requirement and avoid accessing the fields\ndirectly.\n\nPatch 3: test/interrupt: apply get set interrupt handle APIs\nUpdating interrupt test suite to use interrupt handle APIs.\n\nPatch 4: drivers: remove direct access to interrupt handle fields\nModifying all the drivers and libraries which are currently directly\naccessing the interrupt handle fields. Drivers are expected to\nallocated the interrupt instance, use get set APIs with the allocated\ninterrupt handle and free it on cleanup.\n\nPatch 5: eal/interrupts: make interrupt handle structure opaque\nIn this patch rte_eal_interrupt.h is removed, struct rte_intr_handle\ndefinition is moved to c file to make it completely opaque. As part of\ninterrupt handle allocation, array like efds and elist(which are currently\nstatic) are dynamically allocated with default size\n(RTE_MAX_RXTX_INTR_VEC_ID). Later these arrays can be reallocated as per\ndevice requirement using new API rte_intr_handle_event_list_update().\nEg, on PCI device probing MSIX size can be queried and these arrays can\nbe reallocated accordingly.\n\nPatch 6: eal/alarm: introduce alarm fini routine\nIntroducing alarm fini routine, as the memory allocated for alarm interrupt\ninstance can be freed in alarm fini.\n\nTesting performed:\n1. Validated the series by running interrupts and alarm test suite.\n2. Validate l3fwd power functionality with octeontx2 and i40e intel cards,\n where interrupts are expected on packet arrival.\n\nv1:\n* Fixed freebsd compilation failure\n* Fixed seg fault in case of memif\n\nv2:\n* Merged the prototype and implementation patch to 1.\n* Restricting allocation of single interrupt instance.\n* Removed base APIs, as they were exposing internally\nallocated memory information.\n* Fixed some memory leak issues.\n* Marked some library specific APIs as internal.\n\nv3:\n* Removed flag from instance alloc API, rather auto detect\nif memory should be allocated using glibc malloc APIs or\nrte_malloc*\n* Added APIs for get/set windows handle.\n* Defined macros for repeated checks.\n\nv4:\n* Rectified some typo in the APIs documentation.\n* Better names for some internal variables.\n\nv5:\n* Reverted back to passing flag to instance alloc API, as\nwith auto detect some multiprocess issues existing in the\nlibrary were causing tests failure.\n* Rebased to top of tree.\n\nHarman Kalra (6):\n eal/interrupts: implement get set APIs\n eal/interrupts: avoid direct access to interrupt handle\n test/interrupt: apply get set interrupt handle APIs\n drivers: remove direct access to interrupt handle\n eal/interrupts: make interrupt handle structure opaque\n eal/alarm: introduce alarm fini routine\n\n MAINTAINERS | 1 +\n app/test/test_interrupts.c | 163 +++--\n drivers/baseband/acc100/rte_acc100_pmd.c | 18 +-\n .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 21 +-\n drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 21 +-\n drivers/bus/auxiliary/auxiliary_common.c | 2 +\n drivers/bus/auxiliary/linux/auxiliary.c | 10 +\n drivers/bus/auxiliary/rte_bus_auxiliary.h | 2 +-\n drivers/bus/dpaa/dpaa_bus.c | 28 +-\n drivers/bus/dpaa/rte_dpaa_bus.h | 2 +-\n drivers/bus/fslmc/fslmc_bus.c | 16 +-\n drivers/bus/fslmc/fslmc_vfio.c | 32 +-\n drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 20 +-\n drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 +-\n drivers/bus/fslmc/rte_fslmc.h | 2 +-\n drivers/bus/ifpga/ifpga_bus.c | 15 +-\n drivers/bus/ifpga/rte_bus_ifpga.h | 2 +-\n drivers/bus/pci/bsd/pci.c | 21 +-\n drivers/bus/pci/linux/pci.c | 4 +-\n drivers/bus/pci/linux/pci_uio.c | 73 +-\n drivers/bus/pci/linux/pci_vfio.c | 115 ++-\n drivers/bus/pci/pci_common.c | 29 +-\n drivers/bus/pci/pci_common_uio.c | 21 +-\n drivers/bus/pci/rte_bus_pci.h | 4 +-\n drivers/bus/vmbus/linux/vmbus_bus.c | 6 +\n drivers/bus/vmbus/linux/vmbus_uio.c | 37 +-\n drivers/bus/vmbus/rte_bus_vmbus.h | 2 +-\n drivers/bus/vmbus/vmbus_common_uio.c | 24 +-\n drivers/common/cnxk/roc_cpt.c | 8 +-\n drivers/common/cnxk/roc_dev.c | 14 +-\n drivers/common/cnxk/roc_irq.c | 108 +--\n drivers/common/cnxk/roc_nix_inl_dev_irq.c | 8 +-\n drivers/common/cnxk/roc_nix_irq.c | 36 +-\n drivers/common/cnxk/roc_npa.c | 2 +-\n drivers/common/cnxk/roc_platform.h | 49 +-\n drivers/common/cnxk/roc_sso.c | 4 +-\n drivers/common/cnxk/roc_tim.c | 4 +-\n drivers/common/octeontx2/otx2_dev.c | 14 +-\n drivers/common/octeontx2/otx2_irq.c | 117 +--\n .../octeontx2/otx2_cryptodev_hw_access.c | 4 +-\n drivers/event/octeontx2/otx2_evdev_irq.c | 12 +-\n drivers/mempool/octeontx2/otx2_mempool.c | 2 +-\n drivers/net/atlantic/atl_ethdev.c | 20 +-\n drivers/net/avp/avp_ethdev.c | 8 +-\n drivers/net/axgbe/axgbe_ethdev.c | 12 +-\n drivers/net/axgbe/axgbe_mdio.c | 6 +-\n drivers/net/bnx2x/bnx2x_ethdev.c | 10 +-\n drivers/net/bnxt/bnxt_ethdev.c | 33 +-\n drivers/net/bnxt/bnxt_irq.c | 4 +-\n drivers/net/dpaa/dpaa_ethdev.c | 47 +-\n drivers/net/dpaa2/dpaa2_ethdev.c | 10 +-\n drivers/net/e1000/em_ethdev.c | 23 +-\n drivers/net/e1000/igb_ethdev.c | 79 +--\n drivers/net/ena/ena_ethdev.c | 35 +-\n drivers/net/enic/enic_main.c | 26 +-\n drivers/net/failsafe/failsafe.c | 23 +-\n drivers/net/failsafe/failsafe_intr.c | 43 +-\n drivers/net/failsafe/failsafe_ops.c | 19 +-\n drivers/net/failsafe/failsafe_private.h | 2 +-\n drivers/net/fm10k/fm10k_ethdev.c | 32 +-\n drivers/net/hinic/hinic_pmd_ethdev.c | 10 +-\n drivers/net/hns3/hns3_ethdev.c | 57 +-\n drivers/net/hns3/hns3_ethdev_vf.c | 64 +-\n drivers/net/hns3/hns3_rxtx.c | 2 +-\n drivers/net/i40e/i40e_ethdev.c | 53 +-\n drivers/net/iavf/iavf_ethdev.c | 42 +-\n drivers/net/iavf/iavf_vchnl.c | 4 +-\n drivers/net/ice/ice_dcf.c | 10 +-\n drivers/net/ice/ice_dcf_ethdev.c | 21 +-\n drivers/net/ice/ice_ethdev.c | 49 +-\n drivers/net/igc/igc_ethdev.c | 45 +-\n drivers/net/ionic/ionic_ethdev.c | 17 +-\n drivers/net/ixgbe/ixgbe_ethdev.c | 66 +-\n drivers/net/memif/memif_socket.c | 111 ++-\n drivers/net/memif/memif_socket.h | 4 +-\n drivers/net/memif/rte_eth_memif.c | 61 +-\n drivers/net/memif/rte_eth_memif.h | 2 +-\n drivers/net/mlx4/mlx4.c | 19 +-\n drivers/net/mlx4/mlx4.h | 2 +-\n drivers/net/mlx4/mlx4_intr.c | 47 +-\n drivers/net/mlx5/linux/mlx5_os.c | 53 +-\n drivers/net/mlx5/linux/mlx5_socket.c | 25 +-\n drivers/net/mlx5/mlx5.h | 6 +-\n drivers/net/mlx5/mlx5_rxq.c | 42 +-\n drivers/net/mlx5/mlx5_trigger.c | 4 +-\n drivers/net/mlx5/mlx5_txpp.c | 26 +-\n drivers/net/netvsc/hn_ethdev.c | 4 +-\n drivers/net/nfp/nfp_common.c | 34 +-\n drivers/net/nfp/nfp_ethdev.c | 13 +-\n drivers/net/nfp/nfp_ethdev_vf.c | 13 +-\n drivers/net/ngbe/ngbe_ethdev.c | 29 +-\n drivers/net/octeontx2/otx2_ethdev_irq.c | 35 +-\n drivers/net/qede/qede_ethdev.c | 16 +-\n drivers/net/sfc/sfc_intr.c | 30 +-\n drivers/net/tap/rte_eth_tap.c | 36 +-\n drivers/net/tap/rte_eth_tap.h | 2 +-\n drivers/net/tap/tap_intr.c | 32 +-\n drivers/net/thunderx/nicvf_ethdev.c | 12 +\n drivers/net/thunderx/nicvf_struct.h | 2 +-\n drivers/net/txgbe/txgbe_ethdev.c | 38 +-\n drivers/net/txgbe/txgbe_ethdev_vf.c | 33 +-\n drivers/net/vhost/rte_eth_vhost.c | 76 +-\n drivers/net/virtio/virtio_ethdev.c | 21 +-\n .../net/virtio/virtio_user/virtio_user_dev.c | 48 +-\n drivers/net/vmxnet3/vmxnet3_ethdev.c | 43 +-\n drivers/raw/ifpga/ifpga_rawdev.c | 62 +-\n drivers/raw/ntb/ntb.c | 9 +-\n .../regex/octeontx2/otx2_regexdev_hw_access.c | 4 +-\n drivers/vdpa/ifc/ifcvf_vdpa.c | 5 +-\n drivers/vdpa/mlx5/mlx5_vdpa.c | 10 +\n drivers/vdpa/mlx5/mlx5_vdpa.h | 4 +-\n drivers/vdpa/mlx5/mlx5_vdpa_event.c | 22 +-\n drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 45 +-\n lib/bbdev/rte_bbdev.c | 4 +-\n lib/eal/common/eal_common_interrupts.c | 588 +++++++++++++++\n lib/eal/common/eal_private.h | 11 +\n lib/eal/common/meson.build | 1 +\n lib/eal/freebsd/eal.c | 1 +\n lib/eal/freebsd/eal_alarm.c | 53 +-\n lib/eal/freebsd/eal_interrupts.c | 112 ++-\n lib/eal/include/meson.build | 2 +-\n lib/eal/include/rte_eal_interrupts.h | 269 -------\n lib/eal/include/rte_eal_trace.h | 24 +-\n lib/eal/include/rte_epoll.h | 118 ++++\n lib/eal/include/rte_interrupts.h | 668 +++++++++++++++++-\n lib/eal/linux/eal.c | 1 +\n lib/eal/linux/eal_alarm.c | 37 +-\n lib/eal/linux/eal_dev.c | 63 +-\n lib/eal/linux/eal_interrupts.c | 303 +++++---\n lib/eal/version.map | 46 +-\n lib/ethdev/ethdev_pci.h | 2 +-\n lib/ethdev/rte_ethdev.c | 14 +-\n 132 files changed, 3631 insertions(+), 1713 deletions(-)\n create mode 100644 lib/eal/common/eal_common_interrupts.c\n delete mode 100644 lib/eal/include/rte_eal_interrupts.h\n create mode 100644 lib/eal/include/rte_epoll.h", "diff": null, "prefixes": [ "v5", "0/6" ] }