Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102564/?format=api
{ "id": 102564, "url": "http://patches.dpdk.org/api/patches/102564/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211021095023.18288-21-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211021095023.18288-21-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211021095023.18288-21-jiawenwu@trustnetic.com", "date": "2021-10-21T09:50:17", "name": "[v2,20/26] net/ngbe: support device LED on and off", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "911d550ebd0aafcf84d18eec10ecfb7e0f199035", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211021095023.18288-21-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 19874, "url": "http://patches.dpdk.org/api/series/19874/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19874", "date": "2021-10-21T09:49:58", "name": "net/ngbe: add many features", "version": 2, "mbox": "http://patches.dpdk.org/series/19874/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102564/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/102564/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1555EA0547;\n\tThu, 21 Oct 2021 11:53:54 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CE25E41266;\n\tThu, 21 Oct 2021 11:51:16 +0200 (CEST)", "from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166])\n by mails.dpdk.org (Postfix) with ESMTP id 845EC41250\n for <dev@dpdk.org>; Thu, 21 Oct 2021 11:51:12 +0200 (CEST)", "from jiawenwu.trustnetic.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Thu, 21 Oct 2021 17:51:06 +0800 (CST)" ], "X-QQ-mid": "bizesmtp38t1634809867tdu999kg", "X-QQ-SSF": "01400000000000E0I000000A0000000", "X-QQ-FEAT": "YSwSv5UBo8ihXWU1VRUix6qoNuDlOXG5g99LgpZ1H0JJPxdLLRQT+/rJaGdHi\n lCRCu9b06A1tPJeMUimVuv2YN/l1PSU141g2LzMEi0LnkWlfeyTPoAbB1Us48FN5+fu+k6E\n 8y7fqTJdURrR/yJ7V0twkyLlpfCUp5jqWauCtgumk3ELb1dc9AwLDRVUjSV+GrHJ8GoP1qm\n r5TsMyvBpwKZEja6iaA9K4UImM1a2aE4tctCOmBxBc+VVg17EU/3v6uchO/wmQZdMa+ulbu\n j7yPpSP9wtKAZYexsuVAQd7G+N0PymjW9HBP/LG7Jbw95L4oHdGADx/fqvVWSNutcR7p1L7\n ZuX5VGuVBIj11oX6deGdEL0vq8CIA0mWoshtP27a6BFhopet4w=", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Thu, 21 Oct 2021 17:50:17 +0800", "Message-Id": "<20211021095023.18288-21-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20211021095023.18288-1-jiawenwu@trustnetic.com>", "References": "<20211021095023.18288-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign2", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 20/26] net/ngbe: support device LED on and off", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support device LED on and off.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/ngbe/base/ngbe_dummy.h | 10 +++++++\n drivers/net/ngbe/base/ngbe_hw.c | 48 ++++++++++++++++++++++++++++++\n drivers/net/ngbe/base/ngbe_hw.h | 3 ++\n drivers/net/ngbe/base/ngbe_type.h | 4 +++\n drivers/net/ngbe/ngbe_ethdev.c | 16 ++++++++++\n 5 files changed, 81 insertions(+)", "diff": "diff --git a/drivers/net/ngbe/base/ngbe_dummy.h b/drivers/net/ngbe/base/ngbe_dummy.h\nindex 0baabcbae7..9930a3a1d6 100644\n--- a/drivers/net/ngbe/base/ngbe_dummy.h\n+++ b/drivers/net/ngbe/base/ngbe_dummy.h\n@@ -104,6 +104,14 @@ static inline s32 ngbe_mac_get_link_capabilities_dummy(struct ngbe_hw *TUP0,\n {\n \treturn NGBE_ERR_OPS_DUMMY;\n }\n+static inline s32 ngbe_mac_led_on_dummy(struct ngbe_hw *TUP0, u32 TUP1)\n+{\n+\treturn NGBE_ERR_OPS_DUMMY;\n+}\n+static inline s32 ngbe_mac_led_off_dummy(struct ngbe_hw *TUP0, u32 TUP1)\n+{\n+\treturn NGBE_ERR_OPS_DUMMY;\n+}\n static inline s32 ngbe_mac_set_rar_dummy(struct ngbe_hw *TUP0, u32 TUP1,\n \t\t\t\t\tu8 *TUP2, u32 TUP3, u32 TUP4)\n {\n@@ -278,6 +286,8 @@ static inline void ngbe_init_ops_dummy(struct ngbe_hw *hw)\n \thw->mac.setup_link = ngbe_mac_setup_link_dummy;\n \thw->mac.check_link = ngbe_mac_check_link_dummy;\n \thw->mac.get_link_capabilities = ngbe_mac_get_link_capabilities_dummy;\n+\thw->mac.led_on = ngbe_mac_led_on_dummy;\n+\thw->mac.led_off = ngbe_mac_led_off_dummy;\n \thw->mac.set_rar = ngbe_mac_set_rar_dummy;\n \thw->mac.clear_rar = ngbe_mac_clear_rar_dummy;\n \thw->mac.set_vmdq = ngbe_mac_set_vmdq_dummy;\ndiff --git a/drivers/net/ngbe/base/ngbe_hw.c b/drivers/net/ngbe/base/ngbe_hw.c\nindex 8262e50a80..cd547eee6f 100644\n--- a/drivers/net/ngbe/base/ngbe_hw.c\n+++ b/drivers/net/ngbe/base/ngbe_hw.c\n@@ -390,6 +390,50 @@ s32 ngbe_stop_hw(struct ngbe_hw *hw)\n \treturn 0;\n }\n \n+/**\n+ * ngbe_led_on - Turns on the software controllable LEDs.\n+ * @hw: pointer to hardware structure\n+ * @index: led number to turn on\n+ **/\n+s32 ngbe_led_on(struct ngbe_hw *hw, u32 index)\n+{\n+\tu32 led_reg = rd32(hw, NGBE_LEDCTL);\n+\n+\tDEBUGFUNC(\"ngbe_led_on\");\n+\n+\tif (index > 3)\n+\t\treturn NGBE_ERR_PARAM;\n+\n+\t/* To turn on the LED, set mode to ON. */\n+\tled_reg |= NGBE_LEDCTL_100M;\n+\twr32(hw, NGBE_LEDCTL, led_reg);\n+\tngbe_flush(hw);\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * ngbe_led_off - Turns off the software controllable LEDs.\n+ * @hw: pointer to hardware structure\n+ * @index: led number to turn off\n+ **/\n+s32 ngbe_led_off(struct ngbe_hw *hw, u32 index)\n+{\n+\tu32 led_reg = rd32(hw, NGBE_LEDCTL);\n+\n+\tDEBUGFUNC(\"ngbe_led_off\");\n+\n+\tif (index > 3)\n+\t\treturn NGBE_ERR_PARAM;\n+\n+\t/* To turn off the LED, set mode to OFF. */\n+\tled_reg &= ~NGBE_LEDCTL_100M;\n+\twr32(hw, NGBE_LEDCTL, led_reg);\n+\tngbe_flush(hw);\n+\n+\treturn 0;\n+}\n+\n /**\n * ngbe_validate_mac_addr - Validate MAC address\n * @mac_addr: pointer to MAC address.\n@@ -1836,6 +1880,10 @@ s32 ngbe_init_ops_pf(struct ngbe_hw *hw)\n \tmac->disable_sec_rx_path = ngbe_disable_sec_rx_path;\n \tmac->enable_sec_rx_path = ngbe_enable_sec_rx_path;\n \n+\t/* LEDs */\n+\tmac->led_on = ngbe_led_on;\n+\tmac->led_off = ngbe_led_off;\n+\n \t/* RAR, VLAN, Multicast */\n \tmac->set_rar = ngbe_set_rar;\n \tmac->clear_rar = ngbe_clear_rar;\ndiff --git a/drivers/net/ngbe/base/ngbe_hw.h b/drivers/net/ngbe/base/ngbe_hw.h\nindex a84ddca6ac..ad7e8fc2d9 100644\n--- a/drivers/net/ngbe/base/ngbe_hw.h\n+++ b/drivers/net/ngbe/base/ngbe_hw.h\n@@ -32,6 +32,9 @@ s32 ngbe_setup_mac_link_em(struct ngbe_hw *hw,\n \t\t\t u32 speed,\n \t\t\t bool autoneg_wait_to_complete);\n \n+s32 ngbe_led_on(struct ngbe_hw *hw, u32 index);\n+s32 ngbe_led_off(struct ngbe_hw *hw, u32 index);\n+\n s32 ngbe_set_rar(struct ngbe_hw *hw, u32 index, u8 *addr, u32 vmdq,\n \t\t\t u32 enable_addr);\n s32 ngbe_clear_rar(struct ngbe_hw *hw, u32 index);\ndiff --git a/drivers/net/ngbe/base/ngbe_type.h b/drivers/net/ngbe/base/ngbe_type.h\nindex 310d32ecfa..886dffc0db 100644\n--- a/drivers/net/ngbe/base/ngbe_type.h\n+++ b/drivers/net/ngbe/base/ngbe_type.h\n@@ -265,6 +265,10 @@ struct ngbe_mac_info {\n \ts32 (*get_link_capabilities)(struct ngbe_hw *hw,\n \t\t\t\t u32 *speed, bool *autoneg);\n \n+\t/* LED */\n+\ts32 (*led_on)(struct ngbe_hw *hw, u32 index);\n+\ts32 (*led_off)(struct ngbe_hw *hw, u32 index);\n+\n \t/* RAR */\n \ts32 (*set_rar)(struct ngbe_hw *hw, u32 index, u8 *addr, u32 vmdq,\n \t\t\t u32 enable_addr);\ndiff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c\nindex 94d6de15f9..93072f5f34 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.c\n+++ b/drivers/net/ngbe/ngbe_ethdev.c\n@@ -2188,6 +2188,20 @@ ngbe_dev_interrupt_handler(void *param)\n \tngbe_dev_interrupt_action(dev);\n }\n \n+static int\n+ngbe_dev_led_on(struct rte_eth_dev *dev)\n+{\n+\tstruct ngbe_hw *hw = ngbe_dev_hw(dev);\n+\treturn hw->mac.led_on(hw, 0) == 0 ? 0 : -ENOTSUP;\n+}\n+\n+static int\n+ngbe_dev_led_off(struct rte_eth_dev *dev)\n+{\n+\tstruct ngbe_hw *hw = ngbe_dev_hw(dev);\n+\treturn hw->mac.led_off(hw, 0) == 0 ? 0 : -ENOTSUP;\n+}\n+\n static int\n ngbe_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)\n {\n@@ -2692,6 +2706,8 @@ static const struct eth_dev_ops ngbe_eth_dev_ops = {\n \t.rx_queue_release = ngbe_dev_rx_queue_release,\n \t.tx_queue_setup = ngbe_dev_tx_queue_setup,\n \t.tx_queue_release = ngbe_dev_tx_queue_release,\n+\t.dev_led_on = ngbe_dev_led_on,\n+\t.dev_led_off = ngbe_dev_led_off,\n \t.flow_ctrl_get = ngbe_flow_ctrl_get,\n \t.flow_ctrl_set = ngbe_flow_ctrl_set,\n \t.mac_addr_add = ngbe_add_rar,\n", "prefixes": [ "v2", "20/26" ] }