Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/102078/?format=api
{ "id": 102078, "url": "http://patches.dpdk.org/api/patches/102078/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211018170136.5189-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211018170136.5189-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211018170136.5189-1-david.marchand@redhat.com", "date": "2021-10-18T17:01:36", "name": "test: rely on EAL detection for core list", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4bd10949c91e1fc0cbf2c410bbfcb9bb307e4ec3", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211018170136.5189-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 19756, "url": "http://patches.dpdk.org/api/series/19756/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19756", "date": "2021-10-18T17:01:36", "name": "test: rely on EAL detection for core list", "version": 1, "mbox": "http://patches.dpdk.org/series/19756/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/102078/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/102078/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E2CFAA0C43;\n\tMon, 18 Oct 2021 19:02:59 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B0B2D40142;\n\tMon, 18 Oct 2021 19:02:59 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 0173840141\n for <dev@dpdk.org>; Mon, 18 Oct 2021 19:02:57 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-172-rIkqqRmuOY61TmE--pm-qA-1; Mon, 18 Oct 2021 13:02:53 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com\n [10.5.11.22])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E0F108066F0;\n Mon, 18 Oct 2021 17:02:52 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.193.101])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 5D70510016F4;\n Mon, 18 Oct 2021 17:02:51 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1634576577;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=4DIKNjSFY2qDEEVWvRK7piujX23lUNWPQdpvKDw48/k=;\n b=e5/yHvHSux0vB3LcYdw4emeOGSAnCNAziKClV2z2JdrLw3TEpYlAGEyRNAv5UKVIJH3FGc\n qIHxO+rdD1PLGnyXqCBU7H0dHGbIr+BRkUcrcY3YI4qN+NLHxaYN0loQfv/WFnafz5Pig+\n Guqr4s1RraXgt87W/SZwPP49BgYdL1M=", "X-MC-Unique": "rIkqqRmuOY61TmE--pm-qA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "aconole@redhat.com,\n\tblo@iol.unh.edu", "Date": "Mon, 18 Oct 2021 19:01:36 +0200", "Message-Id": "<20211018170136.5189-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH] test: rely on EAL detection for core list", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Cores count has a direct impact on the time needed to complete unit\ntests.\n\nCurrently, the core list used for unit test is enforced to \"all cores on\nthe system\" with no way for (CI) users to adapt it.\nOn the other hand, EAL default behavior (when no -c/-l option gets passed)\nis to start threads on as many cores available in the process cpu\naffinity.\n\nRemove logic from meson: users can then select where to run the tests by\neither running meson with a custom cpu affinity (using taskset/cpuset\ndepending on OS) or by passing a --test-args option to meson.\n\nExample:\n$ sudo meson test -C build --suite fast-tests -t 3 --test-args \"-l 0-3\"\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\nI wanted to post this as a RFC, but now, I wonder if all CI test RFC\npatches, so sending as a normal patch.\n\n---\n app/test/get-coremask.sh | 13 -------------\n app/test/meson.build | 10 +---------\n 2 files changed, 1 insertion(+), 22 deletions(-)\n delete mode 100755 app/test/get-coremask.sh", "diff": "diff --git a/app/test/get-coremask.sh b/app/test/get-coremask.sh\ndeleted file mode 100755\nindex bb8cf404d2..0000000000\n--- a/app/test/get-coremask.sh\n+++ /dev/null\n@@ -1,13 +0,0 @@\n-#! /bin/sh -e\n-# SPDX-License-Identifier: BSD-3-Clause\n-# Copyright(c) 2019 Intel Corporation\n-\n-if [ \"$(uname)\" = \"Linux\" ] ; then\n-\tcat /sys/devices/system/cpu/present\n-elif [ \"$(uname)\" = \"FreeBSD\" ] ; then\n-\tncpus=$(/sbin/sysctl -n hw.ncpu)\n-\techo 0-$(expr $ncpus - 1)\n-else\n-# fallback\n-\techo 0-3\n-fi\ndiff --git a/app/test/meson.build b/app/test/meson.build\nindex a16374b7a1..c7b377d52d 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -463,13 +463,8 @@ message('hugepage availability: @0@'.format(has_hugepage))\n timeout_seconds = 600\n timeout_seconds_fast = 10\n \n-get_coremask = find_program('get-coremask.sh')\n-num_cores_arg = '-l ' + run_command(get_coremask).stdout().strip()\n-\n-default_test_args = [num_cores_arg]\n-\n foreach arg : fast_tests\n- test_args = default_test_args\n+ test_args = []\n run_test = true\n if not has_hugepage\n if arg[1]\n@@ -502,7 +497,6 @@ endforeach\n foreach arg : perf_test_names\n test(arg, dpdk_test,\n env : ['DPDK_TEST=' + arg],\n- args : default_test_args,\n timeout : timeout_seconds,\n is_parallel : false,\n suite : 'perf-tests')\n@@ -511,7 +505,6 @@ endforeach\n foreach arg : driver_test_names\n test(arg, dpdk_test,\n env : ['DPDK_TEST=' + arg],\n- args : default_test_args,\n timeout : timeout_seconds,\n is_parallel : false,\n suite : 'driver-tests')\n@@ -520,7 +513,6 @@ endforeach\n foreach arg : dump_test_names\n test(arg, dpdk_test,\n env : ['DPDK_TEST=' + arg],\n- args : default_test_args,\n timeout : timeout_seconds,\n is_parallel : false,\n suite : 'debug-tests')\n", "prefixes": [] }