Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100946/?format=api
{ "id": 100946, "url": "http://patches.dpdk.org/api/patches/100946/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211010143930.4985-10-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211010143930.4985-10-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20211010143930.4985-10-ivan.malov@oktetlabs.ru", "date": "2021-10-10T14:39:27", "name": "[v3,09/12] net/enic: support meta flow actions to overrule destinations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4cbf32f9950cdd89a490a51b6c4970842f18419b", "submitter": { "id": 869, "url": "http://patches.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211010143930.4985-10-ivan.malov@oktetlabs.ru/mbox/", "series": [ { "id": 19490, "url": "http://patches.dpdk.org/api/series/19490/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19490", "date": "2021-10-10T14:39:18", "name": "ethdev: rework transfer flow API", "version": 3, "mbox": "http://patches.dpdk.org/series/19490/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/100946/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/100946/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8CDE1A0C43;\n\tSun, 10 Oct 2021 16:40:58 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 184144113F;\n\tSun, 10 Oct 2021 16:40:18 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 85E5740DF8\n for <dev@dpdk.org>; Sun, 10 Oct 2021 16:40:01 +0200 (CEST)", "from localhost.localdomain (unknown [5.144.123.197])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3464A7F6DB;\n Sun, 10 Oct 2021 17:40:01 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3464A7F6DB", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1633876801;\n bh=uCiNROpaS+TvBFonTXQ4IYGhlZqo6By8pj0+JsMyMO8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=RbWKpt83dwMcLIPMNJkQXeDrzHTxfk7gnfqgG0aGNTJYp+DwtDlAXAuC0X2/e0LQb\n JRIjR002UFApPr2iOEIODJODQMO+nGLILy2VNFy+CoLdWGN+gnMNzZs7OmeP8JzvqP\n vu3TgAPjlFPBk/HZxudlE4Lo9blVWcx+xKcHBbFs=", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Thomas Monjalon <thomas@monjalon.net>, Ori Kam <orika@nvidia.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n John Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>", "Date": "Sun, 10 Oct 2021 17:39:27 +0300", "Message-Id": "<20211010143930.4985-10-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20211010143930.4985-1-ivan.malov@oktetlabs.ru>", "References": "<20211001134716.1608857-1-andrew.rybchenko@oktetlabs.ru>\n <20211010143930.4985-1-ivan.malov@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 09/12] net/enic: support meta flow actions to\n overrule destinations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n\nAdd support for actions PORT_REPRESENTOR and REPRESENTED_PORT\nbased on the existing support for action PORT_ID.\n\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/net/enic/enic_fm_flow.c | 93 ++++++++++++++++++++++++++-------\n 1 file changed, 75 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c\nindex cd364ee16b..4092ff1f61 100644\n--- a/drivers/net/enic/enic_fm_flow.c\n+++ b/drivers/net/enic/enic_fm_flow.c\n@@ -1242,6 +1242,35 @@ vf_egress_port_id_action(struct enic_flowman *fm,\n \treturn 0;\n }\n \n+static int\n+enic_fm_check_transfer_dst(struct enic *enic, uint16_t dst_port_id,\n+\t\t\t struct rte_eth_dev **dst_dev,\n+\t\t\t struct rte_flow_error *error)\n+{\n+\tstruct rte_eth_dev *dev;\n+\n+\tENICPMD_LOG(DEBUG, \"port id %u\", dst_port_id);\n+\tif (!rte_eth_dev_is_valid_port(dst_port_id)) {\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\tNULL, \"invalid port_id\");\n+\t}\n+\tdev = &rte_eth_devices[dst_port_id];\n+\tif (!dev_is_enic(dev)) {\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\tNULL, \"port_id is not enic\");\n+\t}\n+\tif (enic->switch_domain_id != pmd_priv(dev)->switch_domain_id) {\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\tNULL, \"destination and source ports are not in the same switch domain\");\n+\t}\n+\n+\t*dst_dev = dev;\n+\treturn 0;\n+}\n+\n /* Translate flow actions to flowman TCAM entry actions */\n static int\n enic_fm_copy_action(struct enic_flowman *fm,\n@@ -1446,24 +1475,10 @@ enic_fm_copy_action(struct enic_flowman *fm,\n \t\t\t\tvnic_h = enic->fm_vnic_handle; /* This port */\n \t\t\t\tbreak;\n \t\t\t}\n-\t\t\tENICPMD_LOG(DEBUG, \"port id %u\", port->id);\n-\t\t\tif (!rte_eth_dev_is_valid_port(port->id)) {\n-\t\t\t\treturn rte_flow_error_set(error, EINVAL,\n-\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n-\t\t\t\t\tNULL, \"invalid port_id\");\n-\t\t\t}\n-\t\t\tdev = &rte_eth_devices[port->id];\n-\t\t\tif (!dev_is_enic(dev)) {\n-\t\t\t\treturn rte_flow_error_set(error, EINVAL,\n-\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n-\t\t\t\t\tNULL, \"port_id is not enic\");\n-\t\t\t}\n-\t\t\tif (enic->switch_domain_id !=\n-\t\t\t pmd_priv(dev)->switch_domain_id) {\n-\t\t\t\treturn rte_flow_error_set(error, EINVAL,\n-\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n-\t\t\t\t\tNULL, \"destination and source ports are not in the same switch domain\");\n-\t\t\t}\n+\t\t\tret = enic_fm_check_transfer_dst(enic, port->id, &dev,\n+\t\t\t\t\t\t\t error);\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n \t\t\tvnic_h = pmd_priv(dev)->fm_vnic_handle;\n \t\t\toverlap |= PORT_ID;\n \t\t\t/*\n@@ -1560,6 +1575,48 @@ enic_fm_copy_action(struct enic_flowman *fm,\n \t\t\tovlan |= rte_be_to_cpu_16(vid->vlan_vid);\n \t\t\tbreak;\n \t\t}\n+\t\tcase RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR: {\n+\t\t\tconst struct rte_flow_action_ethdev *ethdev;\n+\t\t\tstruct rte_eth_dev *dev;\n+\n+\t\t\tethdev = actions->conf;\n+\t\t\tret = enic_fm_check_transfer_dst(enic, ethdev->port_id,\n+\t\t\t\t\t\t\t &dev, error);\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n+\t\t\tvnic_h = pmd_priv(dev)->fm_vnic_handle;\n+\t\t\toverlap |= PORT_ID;\n+\t\t\t/*\n+\t\t\t * Action PORT_REPRESENTOR implies ingress destination.\n+\t\t\t * Noting to do. We add an implicit stree at the\n+\t\t\t * end if needed.\n+\t\t\t */\n+\t\t\tingress = 1;\n+\t\t\tbreak;\n+\t\t}\n+\t\tcase RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT: {\n+\t\t\tconst struct rte_flow_action_ethdev *ethdev;\n+\t\t\tstruct rte_eth_dev *dev;\n+\n+\t\t\tif (overlap & PORT_ID) {\n+\t\t\t\tENICPMD_LOG(DEBUG, \"cannot have multiple egress PORT_ID actions\");\n+\t\t\t\tgoto unsupported;\n+\t\t\t}\n+\t\t\tethdev = actions->conf;\n+\t\t\tret = enic_fm_check_transfer_dst(enic, ethdev->port_id,\n+\t\t\t\t\t\t\t &dev, error);\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n+\t\t\tvnic_h = pmd_priv(dev)->fm_vnic_handle;\n+\t\t\toverlap |= PORT_ID;\n+\t\t\t/* Action REPRESENTED_PORT: always egress destination */\n+\t\t\tingress = 0;\n+\t\t\tret = vf_egress_port_id_action(fm, dev, vnic_h, &fm_op,\n+\t\t\t\terror);\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n+\t\t\tbreak;\n+\t\t}\n \t\tdefault:\n \t\t\tgoto unsupported;\n \t\t}\n", "prefixes": [ "v3", "09/12" ] }