Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100905/?format=api
{ "id": 100905, "url": "http://patches.dpdk.org/api/patches/100905/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1633765318-28356-10-git-send-email-navasile@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1633765318-28356-10-git-send-email-navasile@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1633765318-28356-10-git-send-email-navasile@linux.microsoft.com", "date": "2021-10-09T07:41:58", "name": "[v16,9/9] Add unit tests for thread API", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9c23689ac8173d2fb298267635681c150871eaf8", "submitter": { "id": 1668, "url": "http://patches.dpdk.org/api/people/1668/?format=api", "name": "Narcisa Ana Maria Vasile", "email": "navasile@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1633765318-28356-10-git-send-email-navasile@linux.microsoft.com/mbox/", "series": [ { "id": 19478, "url": "http://patches.dpdk.org/api/series/19478/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19478", "date": "2021-10-09T07:41:49", "name": "eal: Add EAL API for threading", "version": 16, "mbox": "http://patches.dpdk.org/series/19478/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/100905/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/100905/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3B52AA0C41;\n\tSat, 9 Oct 2021 09:43:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 72C574113A;\n\tSat, 9 Oct 2021 09:42:18 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id A6FE74067A\n for <dev@dpdk.org>; Sat, 9 Oct 2021 09:42:07 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1059)\n id 3676120B8965; Sat, 9 Oct 2021 00:42:05 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 3676120B8965", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1633765326;\n bh=QOvlMZINHZvR4AuAmm5OSbsOU1Sy6BoLrVsQM/clu9k=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=H/JGyGGdA0ApL2BJ5VWMKlwWaLy6Hb37hd3Ec/lAHOadH9ZWSCpGlLprqGl1lm9gF\n bY4sQ9YiSQksGWP4SRToNJW4X5ZjU/yIND8QX6z+9RV1xD4woYuOps67+1yHN3wFDT\n S9E8zH/Yqr6UhtOSfsAlGkS8FvzCK5Oxr2gUFYJ0=", "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>", "To": "dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com,\n khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com,\n roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com", "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n pallavi.kadam@intel.com", "Date": "Sat, 9 Oct 2021 00:41:58 -0700", "Message-Id": "<1633765318-28356-10-git-send-email-navasile@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1633765318-28356-1-git-send-email-navasile@linux.microsoft.com>", "References": "<1633732841-17873-1-git-send-email-navasile@linux.microsoft.com>\n <1633765318-28356-1-git-send-email-navasile@linux.microsoft.com>", "Subject": "[dpdk-dev] [PATCH v16 9/9] Add unit tests for thread API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Narcisa Vasile <navasile@microsoft.com>\n\nAs a new API for threading is introduced,\na set of unit tests have been added to test the new interface.\nThe tests verify that:\n * mutexes and barriers behave as expected\n * thread properties are applied correctly\n * the thread id is retrieved correctly\n * thread creation/destruction works properly\n\nSigned-off-by: Narcisa Vasile <navasile@microsoft.com>\n---\n app/test/meson.build | 2 +\n app/test/test_threads.c | 372 ++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 374 insertions(+)\n create mode 100644 app/test/test_threads.c", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex f144d8b8ed..019c7e27d0 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -141,6 +141,7 @@ test_sources = files(\n 'test_table_tables.c',\n 'test_tailq.c',\n 'test_thash.c',\n+ 'test_threads.c',\n 'test_timer.c',\n 'test_timer_perf.c',\n 'test_timer_racecond.c',\n@@ -277,6 +278,7 @@ fast_tests = [\n ['reorder_autotest', true],\n ['service_autotest', true],\n ['thash_autotest', true],\n+ ['threads_autotest', true],\n ['trace_autotest', true],\n ]\n \ndiff --git a/app/test/test_threads.c b/app/test/test_threads.c\nnew file mode 100644\nindex 0000000000..d125a55b2e\n--- /dev/null\n+++ b/app/test/test_threads.c\n@@ -0,0 +1,372 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (c) 2021 Microsoft.\n+ */\n+\n+#include <rte_thread.h>\n+#include <rte_debug.h>\n+\n+#include \"test.h\"\n+\n+#define THREADS_COUNT 20\n+\n+RTE_LOG_REGISTER(threads_logtype_test, test.threads, INFO);\n+\n+static void *\n+thread_loop_self(void *arg)\n+{\n+\trte_thread_t *id = arg;\n+\n+\t*id = rte_thread_self();\n+\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_self(void)\n+{\n+\trte_thread_t threads_ids[THREADS_COUNT];\n+\trte_thread_t self_ids[THREADS_COUNT] = {};\n+\tint ret;\n+\tint i;\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tret = rte_thread_create(&threads_ids[i], NULL, thread_loop_self,\n+\t\t\t\t&self_ids[i]);\n+\t\tRTE_TEST_ASSERT(ret == 0, \"Failed to create threads!\");\n+\t}\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tRTE_TEST_ASSERT(rte_thread_join(threads_ids[i], NULL) == 0, \"Failed to join thread!\");\n+\t\tRTE_TEST_ASSERT_EQUAL(threads_ids[i].opaque_id,\n+\t\t\t\tself_ids[i].opaque_id, \"Unexpected thread id!\");\n+\t}\n+\n+\treturn 0;\n+}\n+\n+struct thread_context {\n+\trte_thread_barrier *barrier;\n+\tint barrier_result;\n+};\n+\n+static void *\n+thread_loop_barrier(void *arg)\n+{\n+\tstruct thread_context *ctx = arg;\n+\n+\tctx->barrier_result = rte_thread_barrier_wait(ctx->barrier);\n+\tif (ctx->barrier_result > 0)\n+\t\trte_log(RTE_LOG_DEBUG, threads_logtype_test, \"Failed to wait at barrier!\");\n+\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_barrier(void)\n+{\n+\trte_thread_t thread_id;\n+\tstruct thread_context ctx;\n+\trte_thread_barrier barrier;\n+\tint ret = 0;\n+\tint result = 0;\n+\n+\tret = rte_thread_barrier_init(&barrier, 2);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to initialize barrier!\");\n+\n+\tctx.barrier = &barrier;\n+\tret = rte_thread_create(&thread_id, NULL, thread_loop_barrier, &ctx);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to create thread!\");\n+\n+\tresult = rte_thread_barrier_wait(&barrier);\n+\tRTE_TEST_ASSERT(result <= 0, \"Failed to wait at the barrier!\");\n+\n+\tret = rte_thread_join(thread_id, NULL);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to join threads!\");\n+\n+\tret = rte_thread_barrier_destroy(&barrier);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to destroy barrier!\");\n+\n+\tRTE_TEST_ASSERT(ctx.barrier_result <= 0, \"Child thread failed to wait at the barrier!\");\n+\tRTE_TEST_ASSERT_NOT_EQUAL(ctx.barrier_result, result, \"Threads were not blocked at the barrier!\");\n+\n+\treturn 0;\n+}\n+\n+RTE_STATIC_MUTEX(static_mutex);\n+\n+struct mutex_loop_args {\n+\trte_thread_barrier *barrier;\n+\trte_thread_mutex *mutex;\n+\tunsigned long result_A;\n+\tunsigned long result_B;\n+};\n+\n+static void *\n+thread_loop_mutex_B(void *arg)\n+{\n+\tstruct mutex_loop_args *args = arg;\n+\n+\tif (rte_thread_mutex_try_lock(args->mutex) == 0) {\n+\t\trte_thread_barrier_wait(args->barrier);\n+\t\trte_thread_mutex_unlock(args->mutex);\n+\t\targs->result_B = 1;\n+\t} else {\n+\t\trte_thread_barrier_wait(args->barrier);\n+\t\targs->result_B = 2;\n+\t}\n+\n+\treturn NULL;\n+}\n+\n+static void *\n+thread_loop_mutex_A(void *arg)\n+{\n+\tstruct mutex_loop_args *args = arg;\n+\n+\tif (rte_thread_mutex_try_lock(args->mutex) != 0) {\n+\t\trte_thread_barrier_wait(args->barrier);\n+\t\targs->result_A = 2;\n+\t} else {\n+\t\trte_thread_barrier_wait(args->barrier);\n+\t\trte_thread_mutex_unlock(args->mutex);\n+\t\targs->result_A = 1;\n+\t}\n+\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_mutex(rte_thread_mutex *pmutex)\n+{\n+\trte_thread_t thread_A;\n+\trte_thread_t thread_B;\n+\trte_thread_mutex mutex;\n+\trte_thread_barrier barrier;\n+\tstruct mutex_loop_args args;\n+\tint ret = 0;\n+\n+\t/* If mutex is not statically initialized */\n+\tif (pmutex == NULL) {\n+\t\tret = rte_thread_mutex_init(&mutex);\n+\t\tRTE_TEST_ASSERT(ret == 0, \"Failed to initialize mutex!\");\n+\t} else\n+\t\tmutex = *pmutex;\n+\n+\tret = rte_thread_barrier_init(&barrier, 2);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to initialize barrier!\");\n+\n+\targs.mutex = &mutex;\n+\targs.barrier = &barrier;\n+\n+\tret = rte_thread_create(&thread_A, NULL, thread_loop_mutex_A, &args);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to create thread!\");\n+\n+\tret = rte_thread_create(&thread_B, NULL, thread_loop_mutex_B, &args);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to create thread!\");\n+\n+\tret = rte_thread_join(thread_A, NULL);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to join thread!\");\n+\n+\tret = rte_thread_join(thread_B, NULL);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to join thread!\");\n+\n+\tRTE_TEST_ASSERT(args.result_A != args.result_B, \"Mutex failed to be acquired or was acquired by both threads!\");\n+\n+\t/* Destroy if dynamically initialized */\n+\tif (pmutex == NULL) {\n+\t\tret = rte_thread_mutex_destroy(&mutex);\n+\t\tRTE_TEST_ASSERT(ret == 0, \"Failed to destroy mutex!\");\n+\t}\n+\n+\tret = rte_thread_barrier_destroy(&barrier);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to destroy barrier!\");\n+\n+\treturn ret;\n+}\n+\n+static int\n+test_thread_mutex_static(void)\n+{\n+\treturn test_thread_mutex(&static_mutex);\n+}\n+\n+static int\n+test_thread_mutex_dynamic(void)\n+{\n+\treturn test_thread_mutex(NULL);\n+}\n+\n+struct thread_affinity_ctx {\n+\trte_cpuset_t *cpuset;\n+\tunsigned int result;\n+};\n+\n+static void *\n+thread_loop_attributes_affinity(void *arg)\n+{\n+\tstruct thread_affinity_ctx *ctx = arg;\n+\trte_cpuset_t cpuset;\n+\tsize_t i;\n+\n+\tctx->result = 0;\n+\n+\tCPU_ZERO(&cpuset);\n+\tif (rte_thread_get_affinity_by_id(rte_thread_self(), &cpuset) != 0) {\n+\t\tctx->result = 1;\n+\t\trte_log(RTE_LOG_DEBUG, threads_logtype_test, \"Failed to get thread affinity!\");\n+\t\treturn NULL;\n+\t}\n+\n+\t/*\n+\t * Check that the thread is not running on CPUs which were not\n+\t * specified in the affinity mask. Note that the CPU mask\n+\t * retrieved above can be different than the original mask specified\n+\t * with rte_thread_attr_set_affinity(), since some CPUs may not be\n+\t * available on the system.\n+\t */\n+\tfor (i = 0; i < CPU_SETSIZE; ++i) {\n+\t\tif (!CPU_ISSET(i, ctx->cpuset) && CPU_ISSET(i, &cpuset)) {\n+\t\t\tctx->result = 1;\n+\t\t\trte_log(RTE_LOG_DEBUG, threads_logtype_test, \"CPU %zu should not be set for this thread!\\n\",\n+\t\t\t\t\ti);\n+\t\t\treturn NULL;\n+\t\t}\n+\t}\n+\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_attributes_affinity(void)\n+{\n+\trte_thread_t threads_ids[THREADS_COUNT];\n+\tstruct thread_affinity_ctx ctx[THREADS_COUNT] = {};\n+\trte_thread_attr_t attr;\n+\trte_cpuset_t cpuset;\n+\tsize_t i;\n+\tint ret = 0;\n+\n+\tret = rte_thread_attr_init(&attr);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to initialize thread attributes!\");\n+\n+\tCPU_ZERO(&cpuset);\n+\tret = rte_thread_get_affinity_by_id(rte_thread_self(), &cpuset);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to get main thread affinity!\");\n+\n+\tret = rte_thread_attr_set_affinity(&attr, &cpuset);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to set thread attributes!\");\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tctx[i].cpuset = &cpuset;\n+\t\tret = rte_thread_create(&threads_ids[i], &attr,\n+\t\t\t\tthread_loop_attributes_affinity, &ctx[i]);\n+\t\tRTE_TEST_ASSERT(ret == 0, \"Failed to create threads!\");\n+\t}\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tret = rte_thread_join(threads_ids[i], NULL);\n+\t\tRTE_TEST_ASSERT(ret == 0, \"Failed to join threads!\");\n+\n+\t\tRTE_TEST_ASSERT_EQUAL(ctx[i].result, 0, \"Unexpected thread affinity!\");\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static void *\n+thread_loop_priority(void *arg)\n+{\n+\tint ret;\n+\tenum rte_thread_priority priority;\n+\tint *result = arg;\n+\n+\t*result = 1;\n+\tret = rte_thread_get_priority(rte_thread_self(), &priority);\n+\tif (ret != 0 || priority != RTE_THREAD_PRIORITY_NORMAL)\n+\t\t*result = 2;\n+\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_attributes_priority(void)\n+{\n+\trte_thread_t threads_ids[THREADS_COUNT];\n+\trte_thread_attr_t attr;\n+\tsize_t i;\n+\tint ret = 0;\n+\tint results[THREADS_COUNT] = {};\n+\n+\tret = rte_thread_attr_init(&attr);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to initialize thread attributes!\");\n+\n+\tret = rte_thread_attr_set_priority(&attr, RTE_THREAD_PRIORITY_NORMAL);\n+\tRTE_TEST_ASSERT(ret == 0, \"Failed to set thread priority!\");\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tret = rte_thread_create(&threads_ids[i], &attr,\n+\t\t\t\tthread_loop_priority, &results[i]);\n+\t\tRTE_TEST_ASSERT(ret == 0, \"Failed to create threads!\");\n+\t}\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tret = rte_thread_join(threads_ids[i], NULL);\n+\t\tRTE_TEST_ASSERT(ret == 0, \"Failed to join threads!\");\n+\n+\t\tRTE_TEST_ASSERT_EQUAL(results[i], 1, \"Unexpected priority value!\");\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static void *\n+thread_loop_return(void *arg)\n+{\n+\tRTE_SET_USED(arg);\n+\treturn NULL;\n+}\n+\n+static int\n+test_thread_detach(void)\n+{\n+\trte_thread_t threads_ids[THREADS_COUNT];\n+\tsize_t i;\n+\tint ret = 0;\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tret = rte_thread_create(&threads_ids[i], NULL,\n+\t\t\t\tthread_loop_return, NULL);\n+\t\tRTE_TEST_ASSERT(ret == 0, \"Failed to create threads!\");\n+\t}\n+\n+\tfor (i = 0; i < THREADS_COUNT; ++i) {\n+\t\tret = rte_thread_detach(threads_ids[i]);\n+\t\tRTE_TEST_ASSERT(ret == 0, \"Failed to detach thread!\");\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static struct unit_test_suite threads_test_suite = {\n+\t.suite_name = \"threads autotest\",\n+\t.setup = NULL,\n+\t.teardown = NULL,\n+\t.unit_test_cases = {\n+\t\t\tTEST_CASE(test_thread_self),\n+\t\t\tTEST_CASE(test_thread_barrier),\n+\t\t\tTEST_CASE(test_thread_mutex_static),\n+\t\t\tTEST_CASE(test_thread_mutex_dynamic),\n+\t\t\tTEST_CASE(test_thread_attributes_affinity),\n+\t\t\tTEST_CASE(test_thread_attributes_priority),\n+\t\t\tTEST_CASE(test_thread_detach),\n+\t\t\tTEST_CASES_END()\n+\t}\n+};\n+\n+static int\n+test_threads(void)\n+{\n+\treturn unit_test_suite_runner(&threads_test_suite);\n+}\n+\n+REGISTER_TEST_COMMAND(threads_autotest, test_threads);\n", "prefixes": [ "v16", "9/9" ] }