Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100800/?format=api
{ "id": 100800, "url": "http://patches.dpdk.org/api/patches/100800/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20211007184350.73858-33-srikanth.k@oneconvergence.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211007184350.73858-33-srikanth.k@oneconvergence.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211007184350.73858-33-srikanth.k@oneconvergence.com", "date": "2021-10-07T18:43:41", "name": "[v2,32/41] net/mlx5: add multiprocess support", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "e57716e1d6feabbecd8c1aa3f78c3e9db3521af0", "submitter": { "id": 2368, "url": "http://patches.dpdk.org/api/people/2368/?format=api", "name": "Srikanth Kaka", "email": "srikanth.k@oneconvergence.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20211007184350.73858-33-srikanth.k@oneconvergence.com/mbox/", "series": [ { "id": 19455, "url": "http://patches.dpdk.org/api/series/19455/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=19455", "date": "2021-10-07T18:43:09", "name": "add MLX5 FreeBSD support", "version": 2, "mbox": "http://patches.dpdk.org/series/19455/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/100800/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/100800/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D4144A034F;\n\tFri, 8 Oct 2021 12:58:52 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 99632411EE;\n\tFri, 8 Oct 2021 12:56:33 +0200 (CEST)", "from mail-pg1-f173.google.com (mail-pg1-f173.google.com\n [209.85.215.173])\n by mails.dpdk.org (Postfix) with ESMTP id 8E4C541217\n for <dev@dpdk.org>; Thu, 7 Oct 2021 20:45:41 +0200 (CEST)", "by mail-pg1-f173.google.com with SMTP id r201so661571pgr.4\n for <dev@dpdk.org>; Thu, 07 Oct 2021 11:45:41 -0700 (PDT)", "from srikanth-ThinkPad-T450.domain.name ([136.185.113.102])\n by smtp.gmail.com with ESMTPSA id c11sm3311586pji.38.2021.10.07.11.45.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 Oct 2021 11:45:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oneconvergence.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=qG+azfxLlrWvx7/G3QPcbVDyIZB7jN6oFPxBd1aznH8=;\n b=ImKJ5ky21sBpcyD29yVyvJTC9Ni6uJOPgpdmlkVibWRwMFgDnViFz474LHYR44EH0+\n VhF+jcRJTm1rinOyS2iIekKRwca+A5hegdiOAf6PAG6Op8BdqDQnbTrZKGQDaTzb7WW3\n LCve8qkmvtLozjCHtjtIY/X3Mb84CFHTznGEU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=qG+azfxLlrWvx7/G3QPcbVDyIZB7jN6oFPxBd1aznH8=;\n b=pvg4RMITtgOKzsj1jy3XmHmYW8POhZkb2zIZ5Fa3Xh9WeFOEOn+6jRyYsP3f8OdVYk\n CsyXgOjHM5kiKQKpyJPOaOt1onXvr1oijgGFjCTrwBhXi6iRXjHsAQ7iJusbyHeqYalO\n yyN4DZjwGILkaiO2rVzAP3RhTudCPXdAuy93QZGBozXO6tfJuU/q/luoDx34jaB+RC8W\n DI15SIAglUJyrrCbYuZx4G2GnWmeeMAHlah5M/mmem9NZyT/Hsw7T5flmrdKFLY/aQtq\n MZtYjI4TrXLPR9KZzzL3sMEj/j7MpsoJ1n+Pe0siZJAK/qIfOD8CFvvDcIRuZmWREJ1n\n R5PQ==", "X-Gm-Message-State": "AOAM5318uneAbIHH6b954OCsE8UfKuv7sn4b2VmOxxWfdYl6enSU0Pp1\n 3silV3js5GCfA4AmmzOMjBaJgg==", "X-Google-Smtp-Source": "\n ABdhPJzCyPBNK5jYr6upWA1m+TsYLeWMiYsB7yryiAzWYZeI0chOrEGokzWq3woa+Q4jt8ruYivJTQ==", "X-Received": "by 2002:a05:6a00:238a:b0:44b:e2bb:e5ff with SMTP id\n f10-20020a056a00238a00b0044be2bbe5ffmr5807297pfc.14.1633632340738;\n Thu, 07 Oct 2021 11:45:40 -0700 (PDT)", "From": "Srikanth Kaka <srikanth.k@oneconvergence.com>", "To": "Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Cc": "dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>,\n Anand Thulasiram <avelu@juniper.net>,\n Srikanth Kaka <srikanth.k@oneconvergence.com>", "Date": "Fri, 8 Oct 2021 00:13:41 +0530", "Message-Id": "<20211007184350.73858-33-srikanth.k@oneconvergence.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20211007184350.73858-1-srikanth.k@oneconvergence.com>", "References": "<20211007184350.73858-1-srikanth.k@oneconvergence.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 08 Oct 2021 12:55:54 +0200", "Subject": "[dpdk-dev] [PATCH v2 32/41] net/mlx5: add multiprocess support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "These routines are equivalent to their Linux counterparts\n\nSigned-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>\nSigned-off-by: Vag Singh <vag.singh@oneconvergence.com>\nSigned-off-by: Anand Thulasiram <avelu@juniper.net>\n---\n drivers/net/mlx5/freebsd/mlx5_mp_os.c | 305 ++++++++++++++++++++++++++\n 1 file changed, 305 insertions(+)\n create mode 100644 drivers/net/mlx5/freebsd/mlx5_mp_os.c", "diff": "diff --git a/drivers/net/mlx5/freebsd/mlx5_mp_os.c b/drivers/net/mlx5/freebsd/mlx5_mp_os.c\nnew file mode 100644\nindex 0000000000..3a4aa766f8\n--- /dev/null\n+++ b/drivers/net/mlx5/freebsd/mlx5_mp_os.c\n@@ -0,0 +1,305 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright 2019 6WIND S.A.\n+ * Copyright 2019 Mellanox Technologies, Ltd\n+ */\n+\n+#include <stdio.h>\n+#include <time.h>\n+\n+#include <rte_eal.h>\n+#include <ethdev_driver.h>\n+#include <rte_string_fns.h>\n+\n+#include <mlx5_common_mp.h>\n+#include <mlx5_common_mr.h>\n+#include <mlx5_malloc.h>\n+\n+#include \"mlx5.h\"\n+#include \"mlx5_rxtx.h\"\n+#include \"mlx5_rx.h\"\n+#include \"mlx5_tx.h\"\n+#include \"mlx5_utils.h\"\n+\n+int\n+mlx5_mp_os_primary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n+{\n+\tstruct rte_mp_msg mp_res;\n+\tstruct mlx5_mp_param *res = (struct mlx5_mp_param *)mp_res.param;\n+\tconst struct mlx5_mp_param *param =\n+\t\t(const struct mlx5_mp_param *)mp_msg->param;\n+\tstruct rte_eth_dev *dev;\n+\tstruct mlx5_priv *priv;\n+\tstruct mr_cache_entry entry;\n+\tuint32_t lkey;\n+\tint ret;\n+\n+\tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);\n+\tif (!rte_eth_dev_is_valid_port(param->port_id)) {\n+\t\trte_errno = ENODEV;\n+\t\tDRV_LOG(ERR, \"port %u invalid port ID\", param->port_id);\n+\t\treturn -rte_errno;\n+\t}\n+\tdev = &rte_eth_devices[param->port_id];\n+\tpriv = dev->data->dev_private;\n+\tswitch (param->type) {\n+\tcase MLX5_MP_REQ_CREATE_MR:\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tlkey = mlx5_mr_create_primary(priv->sh->pd,\n+\t\t\t\t\t &priv->sh->share_cache,\n+\t\t\t\t\t &entry, param->args.addr,\n+\t\t\t\t\t priv->config.mr_ext_memseg_en);\n+\t\tif (lkey == UINT32_MAX)\n+\t\t\tres->result = -rte_errno;\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase MLX5_MP_REQ_VERBS_CMD_FD:\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tmp_res.num_fds = 1;\n+\t\tmp_res.fds[0] = ((struct ibv_context *)priv->sh->ctx)->cmd_fd;\n+\t\tres->result = 0;\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase MLX5_MP_REQ_QUEUE_STATE_MODIFY:\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tres->result = mlx5_queue_state_modify_primary\n+\t\t\t\t\t(dev, ¶m->args.state_modify);\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase MLX5_MP_REQ_QUEUE_RX_STOP:\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tres->result = mlx5_rx_queue_stop_primary\n+\t\t\t\t\t(dev, param->args.queue_id.queue_id);\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase MLX5_MP_REQ_QUEUE_RX_START:\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tres->result = mlx5_rx_queue_start_primary\n+\t\t\t\t\t(dev, param->args.queue_id.queue_id);\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase MLX5_MP_REQ_QUEUE_TX_STOP:\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tres->result = mlx5_tx_queue_stop_primary\n+\t\t\t\t\t(dev, param->args.queue_id.queue_id);\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase MLX5_MP_REQ_QUEUE_TX_START:\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tres->result = mlx5_tx_queue_start_primary\n+\t\t\t\t\t(dev, param->args.queue_id.queue_id);\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tdefault:\n+\t\trte_errno = EINVAL;\n+\t\tDRV_LOG(ERR, \"port %u invalid mp request type\",\n+\t\t\tdev->data->port_id);\n+\t\treturn -rte_errno;\n+\t}\n+\treturn ret;\n+}\n+\n+/**\n+ * IPC message handler of a secondary process.\n+ *\n+ * @param[in] dev\n+ * Pointer to Ethernet structure.\n+ * @param[in] peer\n+ * Pointer to the peer socket path.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_mp_os_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n+{\n+struct rte_mp_msg mp_res;\n+\tstruct mlx5_mp_param *res = (struct mlx5_mp_param *)mp_res.param;\n+\tconst struct mlx5_mp_param *param =\n+\t\t(const struct mlx5_mp_param *)mp_msg->param;\n+\tstruct rte_eth_dev *dev;\n+\tstruct mlx5_proc_priv *ppriv;\n+\tstruct mlx5_priv *priv;\n+\tint ret;\n+\n+\tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_SECONDARY);\n+\tif (!rte_eth_dev_is_valid_port(param->port_id)) {\n+\t\trte_errno = ENODEV;\n+\t\tDRV_LOG(ERR, \"port %u invalid port ID\", param->port_id);\n+\t\treturn -rte_errno;\n+\t}\n+\tdev = &rte_eth_devices[param->port_id];\n+\tpriv = dev->data->dev_private;\n+\tswitch (param->type) {\n+\tcase MLX5_MP_REQ_START_RXTX:\n+\t\tDRV_LOG(INFO, \"port %u starting datapath\", dev->data->port_id);\n+\t\tdev->rx_pkt_burst = mlx5_select_rx_function(dev);\n+\t\tdev->tx_pkt_burst = mlx5_select_tx_function(dev);\n+\t\tppriv = (struct mlx5_proc_priv *)dev->process_private;\n+\t\t/* If Tx queue number changes, re-initialize UAR. */\n+\t\tif (ppriv->uar_table_sz != priv->txqs_n) {\n+\t\t\tmlx5_tx_uar_uninit_secondary(dev);\n+\t\t\tmlx5_proc_priv_uninit(dev);\n+\t\t\tret = mlx5_proc_priv_init(dev);\n+\t\t\tif (ret)\n+\t\t\t\treturn -rte_errno;\n+\t\t\tret = mlx5_tx_uar_init_secondary(dev, mp_msg->fds[0]);\n+\t\t\tif (ret) {\n+\t\t\t\tmlx5_proc_priv_uninit(dev);\n+\t\t\t\treturn -rte_errno;\n+\t\t\t}\n+\t\t}\n+\t\trte_mb();\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tres->result = 0;\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase MLX5_MP_REQ_STOP_RXTX:\n+\t\tDRV_LOG(INFO, \"port %u stopping datapath\", dev->data->port_id);\n+\t\tdev->rx_pkt_burst = removed_rx_burst;\n+\t\tdev->tx_pkt_burst = removed_tx_burst;\n+\t\trte_mb();\n+\t\tmp_init_msg(&priv->mp_id, &mp_res, param->type);\n+\t\tres->result = 0;\n+\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tdefault:\n+\t\trte_errno = EINVAL;\n+\t\tDRV_LOG(ERR, \"port %u invalid mp request type\",\n+\t\t\tdev->data->port_id);\n+\t\treturn -rte_errno;\n+\t}\n+\treturn ret;\n+}\n+\n+/**\n+ * Broadcast request of stopping/starting data-path to secondary processes.\n+ *\n+ * @param[in] dev\n+ * Pointer to Ethernet structure.\n+ * @param[in] type\n+ * Request type.\n+ */\n+static void\n+mp_req_on_rxtx(struct rte_eth_dev *dev, enum mlx5_mp_req_type type)\n+{\n+\tstruct rte_mp_msg mp_req;\n+\tstruct rte_mp_msg *mp_res;\n+\tstruct rte_mp_reply mp_rep;\n+\tstruct mlx5_mp_param *res;\n+\tstruct timespec ts = {.tv_sec = MLX5_MP_REQ_TIMEOUT_SEC, .tv_nsec = 0};\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tint ret;\n+\tint i;\n+\n+\tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);\n+\tif (!mlx5_shared_data->secondary_cnt)\n+\t\treturn;\n+\tif (type != MLX5_MP_REQ_START_RXTX && type != MLX5_MP_REQ_STOP_RXTX) {\n+\t\tDRV_LOG(ERR, \"port %u unknown request (req_type %d)\",\n+\t\t\tdev->data->port_id, type);\n+\t\treturn;\n+\t}\n+\tmp_init_msg(&priv->mp_id, &mp_req, type);\n+\tif (type == MLX5_MP_REQ_START_RXTX) {\n+\t\tmp_req.num_fds = 1;\n+\t\tmp_req.fds[0] = ((struct ibv_context *)priv->sh->ctx)->cmd_fd;\n+\t}\n+\tret = rte_mp_request_sync(&mp_req, &mp_rep, &ts);\n+\tif (ret) {\n+\t\tif (rte_errno != ENOTSUP)\n+\t\t\tDRV_LOG(ERR, \"port %u failed to request stop/start Rx/Tx (%d)\",\n+\t\t\t\tdev->data->port_id, type);\n+\t\tgoto exit;\n+\t}\n+\tif (mp_rep.nb_sent != mp_rep.nb_received) {\n+\t\tDRV_LOG(ERR,\n+\t\t\t\"port %u not all secondaries responded (req_type %d)\",\n+\t\t\tdev->data->port_id, type);\n+\t\tgoto exit;\n+\t}\n+\tfor (i = 0; i < mp_rep.nb_received; i++) {\n+\t\tmp_res = &mp_rep.msgs[i];\n+\t\tres = (struct mlx5_mp_param *)mp_res->param;\n+\t\tif (res->result) {\n+\t\t\tDRV_LOG(ERR, \"port %u request failed on secondary #%d\",\n+\t\t\t\tdev->data->port_id, i);\n+\t\t\tgoto exit;\n+\t\t}\n+\t}\n+exit:\n+\tmlx5_free(mp_rep.msgs);\n+}\n+\n+/**\n+ * Broadcast request of starting data-path to secondary processes. The request\n+ * is synchronous.\n+ *\n+ * @param[in] dev\n+ * Pointer to Ethernet structure.\n+ */\n+void\n+mlx5_mp_os_req_start_rxtx(struct rte_eth_dev *dev)\n+{\n+\tmp_req_on_rxtx(dev, MLX5_MP_REQ_START_RXTX);\n+}\n+\n+/**\n+ * Broadcast request of stopping data-path to secondary processes. The request\n+ * is synchronous.\n+ *\n+ * @param[in] dev\n+ * Pointer to Ethernet structure.\n+ */\n+void\n+mlx5_mp_os_req_stop_rxtx(struct rte_eth_dev *dev)\n+{\n+\tmp_req_on_rxtx(dev, MLX5_MP_REQ_STOP_RXTX);\n+}\n+\n+/**\n+ * Request Verbs Rx/Tx queue stop or start to the primary process.\n+ *\n+ * @param[in] dev\n+ * Pointer to Ethernet structure.\n+ * @param queue_id\n+ * Queue ID to control.\n+ * @param req_type\n+ * request type\n+ * MLX5_MP_REQ_QUEUE_RX_START - start Rx queue\n+ * MLX5_MP_REQ_QUEUE_TX_START - stop Tx queue\n+ * MLX5_MP_REQ_QUEUE_RX_STOP - stop Rx queue\n+ * MLX5_MP_REQ_QUEUE_TX_STOP - stop Tx queue\n+ * @return\n+ * 0 on success, a negative errno value otherwise and\n+ * rte_errno is set.\n+ */\n+int\n+mlx5_mp_os_req_queue_control(struct rte_eth_dev *dev, uint16_t queue_id,\n+\t\t\t enum mlx5_mp_req_type req_type)\n+{\n+\tstruct rte_mp_msg mp_req;\n+\tstruct rte_mp_msg *mp_res;\n+\tstruct rte_mp_reply mp_rep;\n+\tstruct mlx5_mp_param *req = (struct mlx5_mp_param *)mp_req.param;\n+\tstruct mlx5_mp_param *res;\n+\tstruct timespec ts = {.tv_sec = MLX5_MP_REQ_TIMEOUT_SEC, .tv_nsec = 0};\n+\tstruct mlx5_priv *priv;\n+\tint ret;\n+\n+\tMLX5_ASSERT(rte_eal_process_type() == RTE_PROC_SECONDARY);\n+\tpriv = dev->data->dev_private;\n+\tmp_init_msg(&priv->mp_id, &mp_req, req_type);\n+\treq->args.queue_id.queue_id = queue_id;\n+\tret = rte_mp_request_sync(&mp_req, &mp_rep, &ts);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"port %u request to primary process failed\",\n+\t\t\tdev->data->port_id);\n+\t\treturn -rte_errno;\n+\t}\n+\tMLX5_ASSERT(mp_rep.nb_received == 1);\n+\tmp_res = &mp_rep.msgs[0];\n+\tres = (struct mlx5_mp_param *)mp_res->param;\n+\tret = res->result;\n+\tfree(mp_rep.msgs);\n+\treturn ret;\n+}\n", "prefixes": [ "v2", "32/41" ] }