Cover Detail
Show a cover letter.
GET /api/covers/862/?format=api
{ "id": 862, "url": "http://patches.dpdk.org/api/covers/862/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/1713201168-2233-1-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1713201168-2233-1-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1713201168-2233-1-git-send-email-roretzla@linux.microsoft.com", "date": "2024-04-15T17:12:46", "name": "[v5,0/2] build and install only one library type on Windows", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/1713201168-2233-1-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31744, "url": "http://patches.dpdk.org/api/series/31744/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31744", "date": "2024-04-15T17:12:48", "name": "build and install only one library type on Windows", "version": 5, "mbox": "http://patches.dpdk.org/series/31744/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/862/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 03C9C43E7C;\n\tMon, 15 Apr 2024 19:12:57 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 98AFE402C5;\n\tMon, 15 Apr 2024 19:12:52 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 5F0B04026C\n for <dev@dpdk.org>; Mon, 15 Apr 2024 19:12:50 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 802A920FC5F3; Mon, 15 Apr 2024 10:12:49 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 802A920FC5F3", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1713201169;\n bh=tQm56aPECQX0eoZi6TQUsAed2fMAwuSFKa1gwwoK3m0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=D3uslDhMejMBjS1U/diqUB1mRLS2G8+ZnxGrX+3oS6YUfdqFJdHuWzKQKkPiLKoOS\n N1w85TWQKJu69QrdOMsSgS0dQHH72Yx26r2mUkRr8Z2PNnZqA1q6lTPf7h0grcVAj7\n 6VIH/xqrAcsk+pvJQV6o3g6LevkUvXH4PcgYi7t0=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Harman Kalra <hkalra@marvell.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 0/2] build and install only one library type on Windows", "Date": "Mon, 15 Apr 2024 10:12:46 -0700", "Message-Id": "<1713201168-2233-1-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC is the only compiler that can produce usable shared libraries for\nDPDK on Windows because of the use of exported TLS variables.\n\nDisable building of shared libraries with LLVM and MinGW so that\nremaining __declspec macros needed for the functional libraries built by\nMSVC can be used without triggering errors in LLVM and MinGW builds.\n For Windows only install the default_library type to avoid confusion.\nWindows builds cannot build both shared and static in a single pass so\ninstall only the functional variant\n\nMSVC does not guarantee any kind of compatibility for static libraries so\nthey should not be packaged and instead they should be rebuilt along with\nthe application using the same version of the compiler & linker. Because\nof this we have chosen to build only one library type at a time instead of\ncompiling twice to produce both types in a single pass.\n\nthanks Bruce for all the discussion/feedback!\n\nv5: set RTE_BUILD_SHARED_LIB in a single location when building with msvc\n and is_shared_enabled instead of scattered over various meson.build files.\n\nv4:\n * use add_project_link_arguments() and move addition of linker and compiler\n arguments required only dynamic linking to block where it is determined\n is_shared_enabled=true and don't specify when is_shared_enabled=false.\n * unconditionally initialize shared_deps = {} and get rid of else leg of\n conditional evaluation in drivers/meson.build and lib/meson.build.\n * drop change to octeontx meson.build.\n\nv3:\n * condense library, target and toolchain type logic determining values for\n is_shared_enabled,install_{static,shared} values.\n * define empty shared_dep object to allow unconditional evaluation of shared\n variables even when is_shared_enabled is false.\n * use default_library() string to determine deps for chkincs.\n\nTyler Retzlaff (2):\n build: build only one library type on Windows\n buildtools: when building static library use static deps\n\n buildtools/chkincs/meson.build | 5 ++--\n config/meson.build | 24 +++++++++++++++\n drivers/meson.build | 59 ++++++++++++++++---------------------\n lib/meson.build | 67 ++++++++++++++++--------------------------\n 4 files changed, 78 insertions(+), 77 deletions(-)" }