Cover Detail
Show a cover letter.
GET /api/covers/79898/?format=api
{ "id": 79898, "url": "http://patches.dpdk.org/api/covers/79898/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/1602083215-22921-1-git-send-email-viacheslavo@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1602083215-22921-1-git-send-email-viacheslavo@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1602083215-22921-1-git-send-email-viacheslavo@nvidia.com", "date": "2020-10-07T15:06:46", "name": "[v2,0/9] ethdev: introduce Rx buffer split", "submitter": { "id": 1926, "url": "http://patches.dpdk.org/api/people/1926/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/1602083215-22921-1-git-send-email-viacheslavo@nvidia.com/mbox/", "series": [ { "id": 12756, "url": "http://patches.dpdk.org/api/series/12756/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=12756", "date": "2020-10-07T15:06:47", "name": "ethdev: introduce Rx buffer split", "version": 2, "mbox": "http://patches.dpdk.org/series/12756/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/79898/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5228DA04BA;\n\tWed, 7 Oct 2020 17:09:04 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 21B6E1BDBD;\n\tWed, 7 Oct 2020 17:07:11 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 945441BCD5\n for <dev@dpdk.org>; Wed, 7 Oct 2020 17:07:01 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n viacheslavo@nvidia.com) with SMTP; 7 Oct 2020 18:06:56 +0300", "from nvidia.com (pegasus12.mtr.labs.mlnx [10.210.17.40])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 097F6uPD010965;\n Wed, 7 Oct 2020 18:06:56 +0300" ], "From": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "To": "dev@dpdk.org", "Cc": "thomasm@monjalon.net, stephen@networkplumber.org, ferruh.yigit@intel.com,\n olivier.matz@6wind.com, jerinjacobk@gmail.com,\n maxime.coquelin@redhat.com, david.marchand@redhat.com,\n arybchenko@solarflare.com", "Date": "Wed, 7 Oct 2020 15:06:46 +0000", "Message-Id": "<1602083215-22921-1-git-send-email-viacheslavo@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "\n <MWHPR12MB136076E652230CEBD6EE6562DF5F0@MWHPR12MB1360.namprd12.prod.outlook.com>", "References": "\n <MWHPR12MB136076E652230CEBD6EE6562DF5F0@MWHPR12MB1360.namprd12.prod.outlook.com>", "Subject": "[dpdk-dev] [PATCH v2 0/9] ethdev: introduce Rx buffer split", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The DPDK datapath in the transmit direction is very flexible.\nAn application can build the multi-segment packet and manages\nalmost all data aspects - the memory pools where segments\nare allocated from, the segment lengths, the memory attributes\nlike external buffers, registered for DMA, etc.\n\nIn the receiving direction, the datapath is much less flexible,\nan application can only specify the memory pool to configure the\nreceiving queue and nothing more. In order to extend receiving\ndatapath capabilities it is proposed to add the way to provide\nextended information how to split the packets being received.\n\nThe following structure is introduced to specify the Rx packet\nsegment:\n\nstruct rte_eth_rxseg {\n struct rte_mempool *mp; /* memory pools to allocate segment from */\n uint16_t length; /* segment maximal data length */\n uint16_t offset; /* data offset from beginning of mbuf data buffer */\n uint32_t reserved; /* reserved field */\n};\n\nThe new routine rte_eth_rx_queue_setup_ex() is introduced to\nsetup the given Rx queue using the new extended Rx packet segment\ndescription:\n\nint\nrte_eth_rx_queue_setup_ex(uint16_t port_id, uint16_t rx_queue_id,\n uint16_t nb_rx_desc, unsigned int socket_id,\n const struct rte_eth_rxconf *rx_conf,\n const struct rte_eth_rxseg *rx_seg,\n uint16_t n_seg)\n\nThis routine presents the two new parameters:\n rx_seg - pointer the array of segment descriptions, each element\n describes the memory pool, maximal data length, initial\n data offset from the beginning of data buffer in mbuf\n n_seg - number of elements in the array\n\nThe new offload flag DEV_RX_OFFLOAD_BUFFER_SPLIT in device\ncapabilities is introduced to present the way for PMD to report to\napplication about supporting Rx packet split to configurable\nsegments. Prior invoking the rte_eth_rx_queue_setup_ex() routine\napplication should check DEV_RX_OFFLOAD_BUFFER_SPLIT flag.\n\nIf the Rx queue is configured with new routine the packets being\nreceived will be split into multiple segments pushed to the mbufs\nwith specified attributes. The PMD will allocate the first mbuf\nfrom the pool specified in the first segment descriptor and puts\nthe data staring at specified offset in the allocated mbuf data\nbuffer. If packet length exceeds the specified segment length\nthe next mbuf will be allocated according to the next segment\ndescriptor (if any) and data will be put in its data buffer at\nspecified offset and not exceeding specified length. If there is\nno next descriptor the next mbuf will be allocated and filled in the\nsame way (from the same pool and with the same buffer offset/length)\nas the current one.\n\nFor example, let's suppose we configured the Rx queue with the\nfollowing segments:\n seg0 - pool0, len0=14B, off0=RTE_PKTMBUF_HEADROOM\n seg1 - pool1, len1=20B, off1=0B\n seg2 - pool2, len2=20B, off2=0B\n seg3 - pool3, len3=512B, off3=0B\n\nThe packet 46 bytes long will look like the following:\n seg0 - 14B long @ RTE_PKTMBUF_HEADROOM in mbuf from pool0\n seg1 - 20B long @ 0 in mbuf from pool1\n seg2 - 12B long @ 0 in mbuf from pool2\n\nThe packet 1500 bytes long will look like the following:\n seg0 - 14B @ RTE_PKTMBUF_HEADROOM in mbuf from pool0\n seg1 - 20B @ 0 in mbuf from pool1\n seg2 - 20B @ 0 in mbuf from pool2\n seg3 - 512B @ 0 in mbuf from pool3\n seg4 - 512B @ 0 in mbuf from pool3\n seg5 - 422B @ 0 in mbuf from pool3\n\nThe offload DEV_RX_OFFLOAD_SCATTER must be present and\nconfigured to support new buffer split feature (if n_seg\nis greater than one).\n\nThe new approach would allow splitting the ingress packets into\nmultiple parts pushed to the memory with different attributes.\nFor example, the packet headers can be pushed to the embedded\ndata buffers within mbufs and the application data into\nthe external buffers attached to mbufs allocated from the\ndifferent memory pools. The memory attributes for the split\nparts may differ either - for example the application data\nmay be pushed into the external memory located on the dedicated\nphysical device, say GPU or NVMe. This would improve the DPDK\nreceiving datapath flexibility with preserving compatibility\nwith existing API.\n\nAlso, the proposed segment description might be used to specify\nRx packet split for some other features. For example, provide\nthe way to specify the extra memory pool for the Header Split\nfeature of some Intel PMD.\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n\n---\n[RFC]: http://patches.dpdk.org/patch/75582/\nRelated deprecation note (revoked): http://patches.dpdk.org/patch/75205/\n\nv1: http://patches.dpdk.org/patch/79594/\nv2: add feature supoport to mlx5 PMD\n\nViacheslav Ovsiienko (9):\n ethdev: introduce Rx buffer split\n app/testpmd: add multiple pools per core creation\n app/testpmd: add buffer split offload configuration\n app/testpmd: add rxpkts commands and parameters\n app/testpmd: add extended Rx queue setup\n net/mlx5: add extended Rx queue setup routine\n net/mlx5: configure Rx queue to support split\n net/mlx5: register multiple pool for Rx queue\n net/mlx5: update Rx datapath to support split\n\n app/test-pmd/bpf_cmd.c | 4 +-\n app/test-pmd/cmdline.c | 96 +++++++++++---\n app/test-pmd/config.c | 63 ++++++++-\n app/test-pmd/parameters.c | 39 +++++-\n app/test-pmd/testpmd.c | 108 +++++++++++-----\n app/test-pmd/testpmd.h | 41 +++++-\n doc/guides/nics/features.rst | 15 +++\n doc/guides/rel_notes/release_20_11.rst | 6 +\n doc/guides/testpmd_app_ug/run_app.rst | 16 ++-\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 21 ++-\n drivers/net/mlx5/linux/mlx5_os.c | 2 +\n drivers/net/mlx5/mlx5.h | 3 +\n drivers/net/mlx5/mlx5_mr.c | 3 +\n drivers/net/mlx5/mlx5_rxq.c | 194 +++++++++++++++++++++++-----\n drivers/net/mlx5/mlx5_rxtx.c | 3 +-\n drivers/net/mlx5/mlx5_rxtx.h | 10 +-\n drivers/net/mlx5/mlx5_trigger.c | 20 +--\n lib/librte_ethdev/rte_ethdev.c | 174 +++++++++++++++++++++++++\n lib/librte_ethdev/rte_ethdev.h | 16 +++\n lib/librte_ethdev/rte_ethdev_driver.h | 10 ++\n 20 files changed, 733 insertions(+), 111 deletions(-)" }