Cover Detail
Show a cover letter.
GET /api/covers/763/?format=api
{ "id": 763, "url": "http://patches.dpdk.org/api/covers/763/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/1710229908-31704-1-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1710229908-31704-1-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1710229908-31704-1-git-send-email-roretzla@linux.microsoft.com", "date": "2024-03-12T07:51:45", "name": "[0/3] RFC fix import/export MSVC data variables", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/1710229908-31704-1-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31470, "url": "http://patches.dpdk.org/api/series/31470/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=31470", "date": "2024-03-12T07:51:48", "name": "RFC fix import/export MSVC data variables", "version": 1, "mbox": "http://patches.dpdk.org/series/31470/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/763/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1274E43C8E;\n\tTue, 12 Mar 2024 08:51:57 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 43C6040C35;\n\tTue, 12 Mar 2024 08:51:53 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id C913D402EA\n for <dev@dpdk.org>; Tue, 12 Mar 2024 08:51:50 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id E361820B74C0; Tue, 12 Mar 2024 00:51:49 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com E361820B74C0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1710229909;\n bh=4LjbSHDhO22gFEuTD3B4+z+D7LR2/V75NoJDeUOBlcY=;\n h=From:To:Cc:Subject:Date:From;\n b=Duft44Y3937WtTLIKM3uM/C5rcNOtveIvDIeLs3iP52YBBJixCoEqnsci/Lf+kKZ8\n Ye2fHGUglLbLSRD2p1VvQZ/yei2jUNz4mqmUBJ9pkMRyFJwqOCXITgiNkHh6chij79\n HjUo13JAIBE5raLMpclRNg7wcnb9XEroa5U/dBRA=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Bruce Richardson <bruce.richardson@intel.com>,\n David Marchand <david.marchand@redhat.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH 0/3] RFC fix import/export MSVC data variables", "Date": "Tue, 12 Mar 2024 00:51:45 -0700", "Message-Id": "<1710229908-31704-1-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "MSVC requires that data variables within DPDK to be explicitly exported\nand when consumed by applications be explicitly imported. Further, MSVC\nand the Microsoft Linker need additional information when exporting\ndata variables that are thread local storage that cannot be conveyed\nthrough the version.map -> exports.def generation. The generation\nscript has been updated to allow data exports to be excluded during\na build with MSVC where the intent is to export them via the macros.\n\nThis RFC series proposes per-library macro that can be used to mark the\ndata variables for export so that when processed appropriate declaration\nof import or export is achieved either within the dpdk build or by a\nconsuming application.\n\nI have only supplied an example series that uses the macro on a handful\nof variables to demonstrate their use, after feedback on the RFC all\nlibs will have whatever method is arrived at applied to exported data\nvariables.\n\nThanks!\n\nTyler Retzlaff (3):\n buildtools: ignore exports for MSVC\n eal: import and export data variables for MSVC\n ethdev: import and export data variables for MSVC\n\n buildtools/map_to_win.py | 13 +++++++++----\n lib/eal/include/meson.build | 1 +\n lib/eal/include/rte_common.h | 8 ++++++++\n lib/eal/include/rte_eal.h | 2 ++\n lib/eal/include/rte_eal_export.h | 23 +++++++++++++++++++++++\n lib/eal/include/rte_errno.h | 2 ++\n lib/eal/version.map | 6 +++---\n lib/ethdev/meson.build | 1 +\n lib/ethdev/rte_ethdev_core.h | 3 +++\n lib/ethdev/rte_ethdev_export.h | 23 +++++++++++++++++++++++\n lib/ethdev/version.map | 2 +-\n lib/meson.build | 6 ++++--\n 12 files changed, 80 insertions(+), 10 deletions(-)\n create mode 100644 lib/eal/include/rte_eal_export.h\n create mode 100644 lib/ethdev/rte_ethdev_export.h" }