Cover Detail
Show a cover letter.
GET /api/covers/599/?format=api
{ "id": 599, "url": "http://patches.dpdk.org/api/covers/599/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/cover/20240131221308.2208815-1-joshwash@google.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240131221308.2208815-1-joshwash@google.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240131221308.2208815-1-joshwash@google.com", "date": "2024-01-31T22:13:03", "name": "[v5,0/5] net/gve: RSS Support for GVE Driver", "submitter": { "id": 2921, "url": "http://patches.dpdk.org/api/people/2921/?format=api", "name": "Joshua Washington", "email": "joshwash@google.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/cover/20240131221308.2208815-1-joshwash@google.com/mbox/", "series": [ { "id": 30957, "url": "http://patches.dpdk.org/api/series/30957/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30957", "date": "2024-01-31T22:13:03", "name": "net/gve: RSS Support for GVE Driver", "version": 5, "mbox": "http://patches.dpdk.org/series/30957/mbox/" } ], "comments": "http://patches.dpdk.org/api/covers/599/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B837143A26;\n\tWed, 31 Jan 2024 23:14:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 250404064A;\n\tWed, 31 Jan 2024 23:14:03 +0100 (CET)", "from mail-pg1-f201.google.com (mail-pg1-f201.google.com\n [209.85.215.201])\n by mails.dpdk.org (Postfix) with ESMTP id 3BF5A4026C\n for <dev@dpdk.org>; Wed, 31 Jan 2024 23:14:01 +0100 (CET)", "by mail-pg1-f201.google.com with SMTP id\n 41be03b00d2f7-5cdfd47de98so341097a12.1\n for <dev@dpdk.org>; Wed, 31 Jan 2024 14:14:01 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20230601; t=1706739240; x=1707344040; darn=dpdk.org;\n h=cc:from:subject:message-id:references:mime-version:in-reply-to:date\n :from:to:cc:subject:date:message-id:reply-to;\n bh=VifXbBnW+ZJ7e+xoFwjwdTJYS2vP0oxHLg6xwPiSKAc=;\n b=VIZekh4DKvs/Oe3whiJMn2WONnxyuVcSWbnMF9KM5LDBR3ivE8q/7ZNYBsLCUHseRD\n 8Qx0WzfxTa2GiVcuQ6uCEttM1YJnHHMi1FEsl++H53LkXoJUkiJxWbq1bd4RQT8IL57h\n lCotacXjH+7ay2+O95a5NJzw0wu4vr0NLRxhY82uBthtBY+Y4JVgxU5G56xRM9iE1gWC\n hBpfYxaRSuyT4FdlloW1pZ0xd9D7MGjnjYvG6oqxjl2Iruf4XRfZHSXB7gtrYQhwrNPc\n Ys4LSMFczH4x5lhwKGYvSX1NUgTtk/Khs/kbaAy20Vf5yYlVkmGUpTX0QQBfXhqbZeF7\n B2lw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1706739240; x=1707344040;\n h=cc:from:subject:message-id:references:mime-version:in-reply-to:date\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=VifXbBnW+ZJ7e+xoFwjwdTJYS2vP0oxHLg6xwPiSKAc=;\n b=A+rMGsHquUAd6bP0sU+BYoO7Qyu+KzVjUngSZqvXopqLXEZCxqPOjyCtcwhQms80xr\n kf0BgII55mmvPHUxHrQ1mxfVaC/XHSRRpPJqGI9Ieg92TunyuzHYrWYFnJWEfR/i1BXF\n XnLokFHKWaLUqQPCKdGcUqs28Eak//iVKrfr8H1smJlEng1z5UGKi8mD9nSYrnApcbPO\n DEnkFSLaLUh6Ia1xQiVLFyguUwZxq7KiMyOTV9566JwDyBtOfE2a95TMk8JZADiZ4j3u\n UqItTuUzd66m1evPCXsRES97oQ3b5THNPz3dJJl3xkOWEB+fr5+vu8Fo1CmzN5EFkyI0\n q8Jg==", "X-Gm-Message-State": "AOJu0YxO5wSPtInot4chJTqKnu97GlSEXLSRA04o7VZEuIhMNjIgqu31\n aIMxKhV6Zsc7jzXhBLmKpBQRRy7IYk94dEf+YISiArlCa5khlg1utynwncX9NXQblqdfHwNA+hJ\n cRYA7CfsX9Z42mF6AJG/gS88sUEAzQ7Zuvg/NkP7kIrpHCLi406DUz/1Cjl1YQi7YoLECAihaqE\n OJf4b04D8c1G0ykDXZGAyKNqBdABWtsw==", "X-Google-Smtp-Source": "\n AGHT+IGxtSl88iRvX44j9fjzuL+5k0kViJaokZ9UAVPyAbDdaL0mI5S5k2Y9XbX7SBIJyejSWGOWFict8nH+OQ==", "X-Received": "from joshwash.sea.corp.google.com\n ([2620:15c:11c:202:9a96:68e3:c6ee:7117])\n (user=joshwash job=sendgmr) by 2002:a65:624a:0:b0:5cf:c149:8dc with SMTP id\n q10-20020a65624a000000b005cfc14908dcmr688pgv.11.1706739239948; Wed, 31 Jan\n 2024 14:13:59 -0800 (PST)", "Date": "Wed, 31 Jan 2024 14:13:03 -0800", "In-Reply-To": "<20240126173317.2779230-2-joshwash@google.com>", "Mime-Version": "1.0", "References": "<20240126173317.2779230-2-joshwash@google.com>", "X-Mailer": "git-send-email 2.43.0.429.g432eaa2c6b-goog", "Message-ID": "<20240131221308.2208815-1-joshwash@google.com>", "Subject": "[PATCH v5 0/5] net/gve: RSS Support for GVE Driver", "From": "Joshua Washington <joshwash@google.com>", "Cc": "dev@dpdk.org, Ferruh Yigit <ferruh.yigit@amd.com>,\n Rushil Gupta <rushilg@google.com>, Joshua Washington <joshwash@google.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch series introduces RSS support for the GVE poll-mode driver.\nThis series includes implementations of the following eth_dev_ops:\n\n1) rss_hash_update\n2) rss_hash_conf_get\n3) reta_query\n4) reta_update\n\nIn rss_hash_update, the GVE driver supports the following RSS hash\ntypes:\n\n* RTE_ETH_RSS_IPV4\n* RTE_ETH_RSS_NONFRAG_IPV4_TCP\n* RTE_ETH_RSS_NONFRAG_IPV4_UDP\n* RTE_ETH_RSS_IPV6\n* RTE_ETH_RSS_IPV6_EX\n* RTE_ETH_RSS_NONFRAG_IPV6_TCP\n* RTE_ETH_RSS_NONFRAG_IPV6_UDP\n* RTE_ETH_RSS_IPV6_TCP_EX\n* RTE_ETH_RSS_IPV6_UDP_EX\n\nThe hash key is 40B, and the lookup table has 128 entries. These values\nare not configurable in this implementation.\n\nIn general, the DPDK driver expects the RSS hash configuration to be set\nwith a key before the redriection table is set up. When the RSS hash is\nconfigured, a default redirection table is generated based on the number\nof queues. When the device is re-configured, the redirection table is\nreset to the default value based on the queue count.\n\nAn important note is that the gVNIC device expects 32 bit integers for\nRSS redirection table entries, while the RTE API uses 16 bit integers.\nHowever, this is unlikely to be an issue, as these values represent\nreceive queues, and the gVNIC device does not support anywhere near 64K\nqueues.\n\nThis series also updates the corresponding feature matrix ertries and\ndocumentation as it pertains to RSS support in the GVE driver.\n\nv2:\nAdd commmit messages for patches with it missing, and other checkpatches\nfixes.\n\nNote: There is a warning about complex macros being parenthesized that\ndoes not seem to be well-founded.\n\nv3:\nFix build warnings that come up on certain distros.\n\nv4:\nFix formatting in gve_adminq.c\n\nv5:\nUpdate commit messages to comply with check-git-log.\nFold feature matrix and documentation updates into relevant commits.\n\nJoshua Washington (5):\n net/gve: expose RSS offload support in dev info\n net/gve: add RSS adminq command\n net/gve: add gve RSS library\n net/gve: add RSS configuration update support\n net/gve: add RSS redirection table update support\n\n doc/guides/nics/features/gve.ini | 2 +\n doc/guides/nics/gve.rst | 28 +++-\n drivers/net/gve/base/gve.h | 15 ++\n drivers/net/gve/base/gve_adminq.c | 58 ++++++++\n drivers/net/gve/base/gve_adminq.h | 21 +++\n drivers/net/gve/gve_ethdev.c | 231 +++++++++++++++++++++++++++++-\n drivers/net/gve/gve_ethdev.h | 17 +++\n drivers/net/gve/gve_rss.c | 206 ++++++++++++++++++++++++++\n drivers/net/gve/gve_rss.h | 107 ++++++++++++++\n drivers/net/gve/meson.build | 1 +\n 10 files changed, 677 insertions(+), 9 deletions(-)\n create mode 100644 drivers/net/gve/gve_rss.c\n create mode 100644 drivers/net/gve/gve_rss.h" }