Cover Comment List
List cover comments
GET /api/covers/53766/comments/?format=api
[ { "id": 96485, "web_url": "http://patches.dpdk.org/comment/96485/", "msgid": "<b9f807fb-73d2-31c8-c36c-c1d3c58d00e8@ashroe.eu>", "list_archive_url": "https://inbox.dpdk.org/dev/b9f807fb-73d2-31c8-c36c-c1d3c58d00e8@ashroe.eu", "date": "2019-05-28T14:01:27", "subject": "Re: [dpdk-dev] [PATCH 0/2] Add ABI Version Testing to app/test", "submitter": { "id": 1310, "url": "http://patches.dpdk.org/api/people/1310/?format=api", "name": "Ray Kinsella", "email": "mdr@ashroe.eu" }, "content": "Someone kindly approved it, and saved me sending it again from the right\nemail a/c, thank you.\n\nOn 28/05/2019 13:08, Bruce Richardson wrote:\n> On Tue, May 28, 2019 at 12:51:56PM +0100, Ray Kinsella wrote:\n>> This patchset adds ABI Version Testing functionality to the app/test unit\n>> test framework.\n>>\n>> The patchset is intended to address two issues previously raised during ML\n>> conversations on ABI Stability;\n>> 1. How do we unit test still supported previous ABI Versions.\n>> 2. How to we unit test inline functions from still supported previous ABI\n>> Versions.\n>>\n>> The more obvious way to achieve both of the above is to simply archive\n>> pre-built binaries compiled against previous versions of DPDK for use unit\n>> testing previous ABI Versions, and while this should still be done as an\n>> additional check, this approach does not scale well, must every DPDK\n>> developer have a local copy of these binaries to test with, before\n>> upstreaming changes?\n>>\n>> Instead starting with rte_lpm, I did the following:-\n>>\n>> * I reproduced mostly unmodified unit tests from previous ABI Versions,\n>> in this case v2.0 and v16.04\n>> * I reproduced the rte_lpm interface header from these previous ABI\n>> Versions,including the inline functions and remapping symbols to\n>> appropriate versions.\n>> * I added support for multiple abi versions to the app/test unit test\n>> framework to allow users to switch between abi versions (set_abi_version),\n>> without further polluting the already long list of unit tests available in\n>> app/test.\n>>\n>> The intention here is that, in future as developers need to depreciate\n>> APIs, their associated unit tests may move into the ABI Version testing\n>> mechanism of the app/test instead of being replaced by the latest set of\n>> unit tests as would be the case today.\n>>\n>> ToDo:\n>> * Refactor the v2.0 and v16.04 unit tests to separate functional and\n>> performance test cases.\n>> * Add support for trigger ABI Version unit tests from the app/test command\n>> line.\n>>\n> While I admire the goal, given the amount of code that seems to be involved\n> here, I'm not sure if the \"test\" binary is the place to put this. I think\n> it might be better as a separate ABI compatiblity test app.\n\nI did think about that also - the test binary, similar to testpmd is\nvery busy. I sought to mitigate that with set_abi_version command,\nmitigating unit test name collisions etc.\n\nI would have a huge concern about putting it into a separate binary, as\nthese tcs would quickly become forgotten about.\n\n> \n> A separate question is whether this is really necessary to ensure ABI\n> compatibility? \n\nI would argue that we currently have no idea if ABI versioned functions\nactually work? Why offer backward compatibility, if we don't test it?\n\n> Do other projects do this? \n\nThe C++ stdlib is many ways similar to DPDK, ABI compatibility is a well\nunderstood problem over there. See the following presentation Slide 20.\n\nhttps://accu.org/content/conf2015/JonathanWakely-What%20Is%20An%20ABI%20And%20Why%20Is%20It%20So%20Complicated.pdf\n\nThey have a small corpus of TC's for this\n\nhttps://github.com/gcc-mirror/gcc/tree/master/libstdc%2B%2B-v3/testsuite/[backward,abi]\n\n> Is the info from the abi\n> compatiblity checker script already in DPDK, or from other\n> already-available tools not sufficient?\n\nWell this just tells you that you ABI has changed. We don't have\nanything at the moment that tells us that the ABI compatible functions\nactually work ... ?\n\n> \n> /Bruce\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C24674C99;\n\tTue, 28 May 2019 16:01:38 +0200 (CEST)", "from qrelay125.mxroute.com (qrelay125.mxroute.com [172.82.139.125])\n\tby dpdk.org (Postfix) with ESMTP id E23ED2E8F\n\tfor <dev@dpdk.org>; Tue, 28 May 2019 16:01:37 +0200 (CEST)", "from filter002.mxroute.com (unknown [94.130.183.33])\n\tby qrelay125.mxroute.com (Postfix) with ESMTP id 4115A12093C;\n\tTue, 28 May 2019 10:01:37 -0400 (EDT)", "from localhost (unknown [23.92.70.113])\n\tby filter002.mxroute.com (Postfix) with ESMTPS id 6E7993F025;\n\tTue, 28 May 2019 14:01:31 +0000 (UTC)", "from fmdmzpr04-ext.fm.intel.com ([192.55.54.39])\n\tby localhost with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)\n\t(Exim 4.91) (envelope-from <mdr@ashroe.eu>)\n\tid 1hVcgE-0003cO-K4; Tue, 28 May 2019 10:02:18 -0400" ], "To": "Bruce Richardson <bruce.richardson@intel.com>,\n\tRay Kinsella <ray.kinsella@intel.com>", "Cc": "vladimir.medvedkin@intel.com, dev@dpdk.org", "References": "<20190528115158.73245-1-ray.kinsella@intel.com>\n\t<20190528120804.GA1095@bricha3-MOBL.ger.corp.intel.com>", "From": "Ray Kinsella <mdr@ashroe.eu>", "Openpgp": "preference=signencrypt", "Autocrypt": "addr=mdr@ashroe.eu; keydata=\n\tmQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6\n\tASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s\n\tJtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j\n\tHV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr\n\tS51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS\n\tuxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++\n\tYICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux\n\tTpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH\n\tbKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5\n\t0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs\n\tbGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8\n\tB3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE\n\tmsa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn\n\tB3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f\n\tVRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a\n\t04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7\n\tJLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt\n\tTcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1\n\t+nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD\n\tdT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL\n\t92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC\n\tVqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5\n\txJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC\n\thf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5\n\tpt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S\n\tOhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v\n\tccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1\n\tpWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt\n\t07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj\n\ttkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y\n\tyfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u\n\tAjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ\n\tCWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf\n\tu+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17\n\tc+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA\n\tthNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK\n\t+d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8\n\tpcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2\n\tGpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75\n\tQO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l\n\tBGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ\n\twzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg==", "Message-ID": "<b9f807fb-73d2-31c8-c36c-c1d3c58d00e8@ashroe.eu>", "Date": "Tue, 28 May 2019 15:01:27 +0100", "User-Agent": "Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101\n\tThunderbird/60.6.1", "MIME-Version": "1.0", "In-Reply-To": "<20190528120804.GA1095@bricha3-MOBL.ger.corp.intel.com>", "Content-Type": "text/plain; charset=utf-8", "Content-Language": "en-US", "Content-Transfer-Encoding": "8bit", "X-AuthUser": "mdr@ashroe.eu", "Subject": "Re: [dpdk-dev] [PATCH 0/2] Add ABI Version Testing to app/test", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]